Hi,
I pushed update-buildsystem-docs to my clone. Generally, I want to make sure
that the links one hop away from the primary new manuals are properly marked
up as rst for the release.
I need a style guide for that, so I wrote one as a starting point for
discussion.
Style
-
1)
On 02/02/2014 03:49 PM, Stephen Kelly wrote:
Should this topic set the CPACK_PROJECT_VERSION variable? Or should cpack
first try to read PROJECT_VERSION, and only use CPACK_PROJECT_VERSION as a
fallback?
I think it should read CPACK_PROJECT_VERSION and if that is not set
then try
On 01/30/2014 01:32 PM, Eran Ifrah wrote:
I found and fixed a minor bug in CodeLite IDE generator:
Thanks. The fix is now in 'master' and will be in 3.0.
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
On 01/31/2014 06:11 PM, Nils Gladitz wrote:
I created gcc-ipo to replace gcc-binutil-wrappers.
It implements the INTERPROCEDURAL_OPTIMIZATION target properties for gcc
following the example of the existing implementation for the intel compiler.
master itself is closed for new features.
I
Currently, feature_summary() prints out all the transitive dependencies
of a package (those found with find_dependency() in a Config.cmake file)
in addition to the explicit dependencies looked for in a CMakeLists.txt.
This makes feature_summary() much less useful, because it is difficult
to see
Hi,
It's generally preferable to write an email and attach the patch.
Alex Merry wrote:
-# informative diagnostic message if the dependency could not be found.
+# informative diagnostic message if the dependency could not be found,
and +# marks the package as a TRANSITIVE_DEPENDENCY for
+#
On 02/02/2014 04:12 PM, Stephen Kelly wrote:
I was investigating the fact that target_compile_options accepts a BEFORE
keyword. The keyword is ignored, by the command implementation, but could be
used by cmTarget. Should it be? Is the bug in target_compile_options
accepting the option, or
On 02/02/2014 04:01 PM, Stephen Kelly wrote:
source_group.rst contains this:
.. code-block:: cmake
source_group(name [FILES src...] [REGULAR_EXPRESSION regex])
That block of code is not cmake code, but it is marked as such in the rst.
That seems inappropriate. I suggest removing
Brad King wrote:
On 02/02/2014 04:12 PM, Stephen Kelly wrote:
I was investigating the fact that target_compile_options accepts a BEFORE
keyword. The keyword is ignored, by the command implementation, but could
be used by cmTarget. Should it be? Is the bug in target_compile_options
accepting
On 02/03/2014 02:37 PM, Stephen Kelly wrote:
That's if it makes sense to handle it. I suppose there may be some flag for
which
target_compile_options(tgt -flag)
# ... elsewhere:
target_compile_options(tgt BEFORE -otherflag)
makes sense? I don't think it makes sense with -O2, -O3
Brad King wrote:
On 02/02/2014 04:01 PM, Stephen Kelly wrote:
source_group.rst contains this:
.. code-block:: cmake
source_group(name [FILES src...] [REGULAR_EXPRESSION regex])
That block of code is not cmake code, but it is marked as such in the
rst. That seems inappropriate. I
Hi,
This is a followup to this issue [0] and this pull request [1], relating to
finding Java and JNI on Mac.
After the commits noted here [2], I have found several issues:
* FindJava.cmake *
CMAKE_FIND_FRAMEWORK=FIRST|ONLY is ignored; only finds framework's
executable if JAVA_HOME is defined.
On 02/03/2014 02:44 PM, Stephen Kelly wrote:
Additionally, sphinx is not the only tool processing the rst.
[snip]
Additionally, it is not actually valid cmake code.
Fair enough. We can just go with normal literal blocks.
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source
On 02/03/2014 03:01 PM, Larry Shaffer wrote:
After the commits noted here [2], I have found several issues:
I've put as much time into this problem as I can spare now.
Are you interested in becoming the maintainer for these modules?
On 02/03/2014 08:32 AM, Stephen Kelly wrote:
1)
Command signatures should not be marked up as cmake code.
More specifically, they should be plain literal blocks.
2)
Signatures are introduced in prose after their appearance.
I've never been happy with this style. The literal block with
On 2014-02-03 14:44, Stephen Kelly wrote:
Additionally, sphinx is not the only tool processing the rst. The kate
editor also does syntax highlighting of the blocks. It should (but currently
does not) highlight the 'invalid' cmake code as invalid.
I guess you mean that in a '..code-block::
On 03/02/14 19:27, Stephen Kelly wrote:
It's generally preferable to write an email and attach the patch.
Noted.
Alex Merry wrote:
+set_package_properties(${dep} PROPERTIES TRANSITIVE_DEPENDENCY)
I prefer not to create public API in set_package_properties for something
that doesn't
Matthew Woehlke wrote:
I guess you mean that in a '..code-block:: cmake' block, kate should
apply the CMake HL rules? (What about other languages; I guess the same
argument would apply to e.g. C++, Python, etc?)
Kate already does that, since my recent patches to the cmake rst
highlighting
The automoc documentation
(http://www.cmake.org/cmake/help/v2.8.12/cmake.html#prop_tgt:AUTOMOC)
states that all header files are considered for automoc, which is not
true for any sensible definition of all header files.
Only header files with certain names are considered: specifically, if
you
Brad King wrote:
2)
Signatures are introduced in prose after their appearance.
I've never been happy with this style. The literal block with
a signature does not stand out as the beginning of a section
and looks more like the end. It works cleanly only when there
is just one
I have applied all the suggestions and re-pushed LinkOptionsCommand (after
rebasing) to stage.
Thanks,
SteveW
On Feb 2, 2014, at 2:44 AM, Stephen Kelly steve...@gmail.com wrote:
Steve Wilson wrote:
I have just pushed the LinkOptionsCommand topic branch to stage. This
topic branch
Sounds good. I will get this work prepared and submitted as soon as I can.
SteveW
On Feb 3, 2014, at 12:43 PM, Brad King brad.k...@kitware.com wrote:
On 01/29/2014 05:54 PM, Steve Wilson wrote:
Is there a need for the add_custom_command() version with CONFIG?
Yes. Petr's example of
Hi everyone,
Greetings
I am using CMake for cross compiler, freescale.
I've written a toolchain file for it but it does not detect the linker.
It is important to note here is linker can be invoked through the command line
tool by invoking the exe 'mwldeppc'.
When I check the CMakeCache.txt I
23 matches
Mail list logo
