Re: [cmake-developers] Empty ERROR_VARIABLE in execute_process

2016-05-23 Thread Roman Wüger
Ok, thanks Brad. Hello Qt Mailing list, First i thought this is a bug in CMake but it has appeared that it seems to be a bug in qmllint: Here the original question: when I run qmllint from the command line to test an error I get: C:\Tests>C:\Qt\5.6\msvc2015\bin\qmllint.exe test.qml

Re: [cmake-developers] the default value in CMake 3.5.2 for CMAKE_OSX_DEPLOYMENT_TARGET is too low for Xcode6

2016-05-23 Thread James Burgess
Hi Brad, Apologies, I didn’t look closely enough/didn’t understand that the discovery modules would be under influence of CMAKE_OSX_DEPLOYMENT_TARGET set from the CMakeFiles.txt, makes total sense now that you said that. This is the doxygen project, I just did a git clone of their latest.

Re: [cmake-developers] Custom commands with Ninja on Windows

2016-05-23 Thread Brad King
On 05/23/2016 10:24 AM, Brad King wrote: > Please use cmGeneratedFileStream. Also please place the script files in the > CMakeFiles/ directory. See cmake::GetCMakeFilesDirectoryPostSlash callers > for examples. [snip] > Please also update the call sites for PRE_BUILD, PRE_LINK, and POST_BUILD >

Re: [cmake-developers] Empty ERROR_VARIABLE in execute_process

2016-05-23 Thread Brad King
On 05/23/2016 11:34 AM, Roman Wüger wrote: > I tried it with CMake 3.5.1 and 3.5.2 and now with the master with > the same result. I've attached an example which won't work. I was able to reproduce it with that, but I also tried this: add_custom_target(${PROJECT_NAME}-c2 COMMAND

Re: [cmake-developers] [PATCH] CPackIFW Updates

2016-05-23 Thread Brad King
On 05/23/2016 12:21 PM, Konstantin Podsvirov wrote: > commit 06ca7795f4c0a7503d98e856384f986a0047f811 > > CPackIFW: Command cpack_ifw_configure_component learned ESSENTIAL option > > commit 222fa595cd6106cb6a4948eedeb55b0314338dff > > CPackIFW: Doc decoration Thanks. I've merged this topic

Re: [cmake-developers] Very minor doc update

2016-05-23 Thread Brad King
On 05/23/2016 01:24 PM, Harry Mallon wrote: > Defaults to UDZO. Thanks, applied: CPackDMG: Document CPACK_DMG_FORMAT default https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=239367f0 -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at:

[cmake-developers] Very minor doc update

2016-05-23 Thread Harry Mallon
A quick one, CPACK_DMG_FORMAT¶ The disk image format. Common values are UDRO (UDIF read-only), UDZO (UDIF zlib-compressed) or UDBZ (UDIF bzip2-compressed). Refer to hdiutil(1) for more information on other

[cmake-developers] [PATCH] CPackIFW Updates

2016-05-23 Thread Konstantin Podsvirov
Hi again Brad! Sorry for my tardiness, and work in small pieces, but please accept my changes to CPack IFW generator (2 of the latest commit): commit 06ca7795f4c0a7503d98e856384f986a0047f811 CPackIFW: Command cpack_ifw_configure_component learned ESSENTIAL option commit

Re: [cmake-developers] CMake 3.5.2 conflates OSX SDK version with target deployment

2016-05-23 Thread Gregor Jasny via cmake-developers
I'm away from keyboard until June 8th. everything written is from the top of my head. AFAIR the warning goes away if you properly set the OSX SYSROOT. Setting it to macosx without version number should be sufficient (maybe you have to insert a xcrun --showsdk-path there). As far as I see the

Re: [cmake-developers] Empty ERROR_VARIABLE in execute_process

2016-05-23 Thread Brad King
On 05/23/2016 03:25 AM, Roman Wüger wrote: > The output is: > > 1> _resVar: -1 > 1> _outVar: > 1> _errVar: > > It seems that the error pipe isn’t read correctly, because _errVar is empty. I cannot reproduce that. With an empty test.qml file I get: _resVar: -1 _outVar: _errVar:

Re: [cmake-developers] Developer tasks - Refactoring

2016-05-23 Thread Brad King
On 05/19/2016 06:06 PM, Daniel Pfeifer wrote: >>> 1) Make cmLocalGenerator not inherit cmOutputConverter >>> * Change enums like cmLocalGenerator::START_OUTPUT with sed. See > Revised patch attached. Please ignore the previous one. > This one also fully qualifies the enums that were used

Re: [cmake-developers] Custom commands with Ninja on Windows

2016-05-23 Thread Brad King
On 05/23/2016 06:48 AM, Martin Ankerl wrote: > Here is an updated patch Thanks! > +#include This looks unnecessary. > +const std::string cmdFile = hasher.HashString(cmd.str()) + ".cmd"; > + > +// TODO fail if can't open file > +std::ofstream fout(cmdFile); Please use

Re: [cmake-developers] the default value in CMake 3.5.2 for CMAKE_OSX_DEPLOYMENT_TARGET is too low for Xcode6

2016-05-23 Thread Brad King
On 05/22/2016 01:27 AM, James Burgess wrote: > If you don’t set this you get 10.5. On any mac with Xcode 6 (7 is the latest) CMake's default value for CMAKE_OSX_DEPLOYMENT_TARGET is empty, which results in either no -mmacosx-version-min flag being used or in the host OS X version, depending on

Re: [cmake-developers] CMake 3.5.2 conflates OSX SDK version with target deployment

2016-05-23 Thread Brad King
On 05/22/2016 01:50 AM, James Burgess wrote: > $ cmake -D CMAKE_OSX_DEPLOYMENT_TARGET=10.8 . > CMAKE_OSX_DEPLOYMENT_TARGET is '10.8' but the matching SDK does not exist > at: > > > "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk" > >

[cmake-developers] Using CPack to package things not built using CMake

2016-05-23 Thread Bruce Stephens
Suppose I have a build which uses a number of external projects (perhaps built using ExternalProject_Add) but which use a variety of build systems. And I want to package the result (so I arrange for the external projects to build expecting themselves to be installed under /opt/foo). What are

Re: [cmake-developers] [CMake] Empty ERROR_VARIABLE in execute_process

2016-05-23 Thread Roman Wüger
As an addition: If I run "C:\Qt\5.6\msvc2015\bin\qmllint.exe test.qml 1> stdout.txt 2> stderr.txt" Then the error is written to stderr.txt. Regards Roman > Am 23.05.2016 um 09:25 schrieb Roman Wüger : > > Hello, > > when I run qmllint from the command line to test an

Re: [cmake-developers] Custom commands with Ninja on Windows

2016-05-23 Thread Martin Ankerl
Thanks for the feedback! Here is an updated patch that uses a hash as filename, .cmd as extension, boolean argument, and some error checks. Martin On Fri, May 20, 2016 at 3:40 PM Brad King wrote: > On 05/20/2016 03:41 AM, Martin Ankerl wrote: > > From what I have

[cmake-developers] Empty ERROR_VARIABLE in execute_process

2016-05-23 Thread Roman Wüger
Hello, when I run qmllint from the command line to test an error I get: C:\Tests>C:\Qt\5.6\msvc2015\bin\qmllint.exe test.qml test.qml:1 : Syntax error C:\Tests>echo %ERRORLEVEL% -1 C:\Tests> If I call this from a CMake script execute_process(COMMAND C:/Qt/5.6/msvc2015/bin/qmllint.exe