Re: [Cocci] Moving exception handling code to the end of a function implementation with SmPL?

2019-10-31 Thread Markus Elfring
>>> Unfortunately, I stumble on the error message “replacement: already >>> tagged token: >>> C code context” then. > > This is what I would expect. I came along different application imaginations. > You could use one rule with an exists to put a position variable in the place > where you

Re: [Cocci] Moving exception handling code to the end of a function implementation with SmPL?

2019-10-31 Thread Julia Lawall
On Thu, 31 Oct 2019, Markus Elfring wrote: > > Unfortunately, I stumble on the error message “replacement: already > > tagged token: > > C code context” then. This is what I would expect. You could use one rule with an exists to put a position variable in the place where you want to put

Re: [Cocci] Moving exception handling code to the end of a function implementation with SmPL?

2019-10-31 Thread Markus Elfring
> Unfortunately, I stumble on the error message “replacement: already tagged > token: > C code context” then. It might be that the transformation approach was too generic for the implementation of the function “megasas_mgmt_ioctl_fw”.

Re: [Cocci] Moving exception handling code to the end of a function implementation with SmPL?

2019-06-27 Thread Markus Elfring
>> Where did the Coccinelle software get the impression that anything >> would be added too often at the end of such a function implementation? > > Without the semantic patch and the C source code, You have access to data from both files already. > I can't answer the question. Is it more

Re: [Cocci] Moving exception handling code to the end of a function implementation with SmPL?

2019-06-27 Thread Julia Lawall
On Thu, 27 Jun 2019, Markus Elfring wrote: > >> replacement: already tagged token: > > > > You try to add two things one one token, which is not allowed. > > How do you think about to clarify why a source file adjustment > like the following can let my SmPL script succeed in a test

Re: [Cocci] Moving exception handling code to the end of a function implementation with SmPL?

2019-06-27 Thread Markus Elfring
>> replacement: already tagged token: > > You try to add two things one one token, which is not allowed. How do you think about to clarify why a source file adjustment like the following can let my SmPL script succeed in a test configuration? elfring@Sonne:~/Projekte/Coccinelle/Probe> diff -u

Re: [Cocci] Moving exception handling code to the end of a function implementation with SmPL?

2019-06-27 Thread Markus Elfring
>>> You can try with the option --debug. >>> Or if that doesn't help with the option --verbose-ctl-engine. >> >> How can these parameters help to clarify undesirable run time >> characteristics? > > How about actually looking at the results yourself? I did that. - I do not find these extra data

Re: [Cocci] Moving exception handling code to the end of a function implementation with SmPL?

2019-06-27 Thread Markus Elfring
> Maybe there are too many metavariable bindings. Under which circumstances would such a situation really occur? How do you think about my SmPL script example for the shown use case? > You can try with the option --debug. > Or if that doesn't help with the option --verbose-ctl-engine. How can

Re: [Cocci] Moving exception handling code to the end of a function implementation with SmPL?

2019-06-27 Thread Julia Lawall
On Thu, 27 Jun 2019, Markus Elfring wrote: > > * The complete source file seems to be very challenging for testing > > the run time characteristics. > > How are the chances to clarify the different test results for this source code > transformation approach with the software combination

Re: [Cocci] Moving exception handling code to the end of a function implementation with SmPL?

2019-06-27 Thread Markus Elfring
> * The complete source file seems to be very challenging for testing > the run time characteristics. How are the chances to clarify the different test results for this source code transformation approach with the software combination “Coccinelle 1.0.7-00211-geaa13d59-dirty (OCaml 4.07.1)”?

[Cocci] Moving exception handling code to the end of a function implementation with SmPL?

2019-06-21 Thread Markus Elfring
Hello, I became interested in another source code transformation again. I would like to move a bit of common code to the end of a function implementation with the help of the following script for the semantic patch language. @replacement@ expression info, result; identifier target, work; type