[GitHub] incubator-trafodion pull request #1267: [TRAFODION-2775] Insert does not rai...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafodion/pull/1267


---

[GitHub] incubator-trafodion pull request #1267: [TRAFODION-2775] Insert does not rai...

[sureshsubbiah]

Github user sureshsubbiah commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1267#discussion_r145482847
  
--- Diff: core/sql/exp/ExpHbaseInterface.cpp ---
@@ -842,7 +842,9 @@ Lng32 ExpHbaseInterface_JNI::insertRow(
 transID = getTransactionIDFromContext();
   retCode_ = client_->insertRow((NAHeap *)heap_, tblName.val, hbs_,
 useTRex_, transID, rowID, row, timestamp, 
-checkAndPut, asyncOperation, useRegionXn, 
);
+checkAndPut, asyncOperation, useRegionXn, 
+   0, // checkAndPut is false, so colIndexToCheck 
is not used
--- End diff --

The java code in HTableClient::putRow has this line of code which will 
ensure that the number passed in for colIndexToCheck is meaningless when 
checkAndPut is FALSE. -1 would have been easier to read. I can make that change 
later, if you agree.

if (checkAndPut && colIndex == colIndexToCheck) {




---

[GitHub] incubator-trafodion pull request #1267: [TRAFODION-2775] Insert does not rai...

[DaveBirdsall]

Github user DaveBirdsall commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1267#discussion_r145479903
  
--- Diff: core/sql/exp/ExpHbaseInterface.cpp ---
@@ -842,7 +842,9 @@ Lng32 ExpHbaseInterface_JNI::insertRow(
 transID = getTransactionIDFromContext();
   retCode_ = client_->insertRow((NAHeap *)heap_, tblName.val, hbs_,
 useTRex_, transID, rowID, row, timestamp, 
-checkAndPut, asyncOperation, useRegionXn, 
);
+checkAndPut, asyncOperation, useRegionXn, 
+   0, // checkAndPut is false, so colIndexToCheck 
is not used
--- End diff --

How will the insertRow method distinguish between the "not used" case and a 
column index of zero? (Elsewhere I saw a comment that the column index is 
0-based.)


---

[GitHub] incubator-trafodion pull request #1267: [TRAFODION-2775] Insert does not rai...

[sureshsubbiah]

GitHub user sureshsubbiah opened a pull request:

https://github.com/apache/incubator-trafodion/pull/1267

[TRAFODION-2775] Insert does not raise duplicate row error for hbase …

…format table with defaulted first column

There was a problem with column being checked during CheckAndPut call for 
such tables. We were always checking the first column in the row, which may not 
have existed in the previous version of this rowid. Please see JIRA for a 
complete explanation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sureshsubbiah/incubator-trafodion misc3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/1267.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1267


commit 921c0a5840a7f6f233166b1d745a4a7f65f49118
Author: Suresh Subbiah 
Date:   2017-10-18T14:51:34Z

[TRAFODION-2775] Insert does not raise duplicate row error for hbase format 
table with defaulted first column

There was a problem with column being checked during CheckAndPut call for 
such tables. We were always checking the first column in the row, which may not 
have existed in the previous version of this rowid. Please see JIRA for a 
complete explanation.




---