[GitHub] trafodion pull request #1562: [TRAFODION-2821] Trafodion core code base need...

2018-05-13 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1562#discussion_r187841031 --- Diff: core/sqf/src/tm/tmtransaction.cpp --- @@ -797,7 +797,7 @@ short TM_Transaction::status(short *pp_status) return

[GitHub] trafodion pull request #1562: [TRAFODION-2821] Trafodion core code base need...

2018-05-12 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1562#discussion_r187753748 --- Diff: core/sqf/src/tm/tmlib.cpp --- @@ -2817,35 +2833,44 @@ void TMLIB::initialize() // This call has been changed so that the node

[GitHub] trafodion pull request #1562: [TRAFODION-2821] Trafodion core code base need...

2018-05-12 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1562#discussion_r187754295 --- Diff: core/sqf/src/tm/tmtransaction.cpp --- @@ -797,7 +797,7 @@ short TM_Transaction::status(short *pp_status) return

[GitHub] trafodion pull request #1562: [TRAFODION-2821] Trafodion core code base need...

2018-05-12 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1562#discussion_r187753028 --- Diff: core/sqf/src/tm/tmlib.cpp --- @@ -2817,35 +2833,44 @@ void TMLIB::initialize() // This call has been changed so that the node

[GitHub] trafodion pull request #1562: [TRAFODION-2821] Trafodion core code base need...

2018-05-12 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1562#discussion_r187752369 --- Diff: core/sqf/src/tm/tmlib.cpp --- @@ -2470,7 +2482,7 @@ int16 TMWAIT() TMlibTrace(("TMLIB_TRACE : TMWAIT ENTRY\n

[GitHub] trafodion pull request #1534: [TRAFODION-3039] SendEventMsg is used in a wro...

2018-05-28 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1534#discussion_r186468687 --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp --- @@ -6533,6 +6533,8 @@ odbc_SQLSrvr_ExtractLob_sme_( if (retcode

[GitHub] trafodion pull request #1582: [TRAFODION-3039] SendEventMsg is used in a wro...

2018-05-28 Thread xiaozhongwang
GitHub user xiaozhongwang opened a pull request: https://github.com/apache/trafodion/pull/1582 [TRAFODION-3039] SendEventMsg is used in a wrong way SendEventMsg use dynamic parameter. And there is a parameter control the total, all of dynamic parameters are string data type

[GitHub] trafodion pull request #1534: [TRAFODION-3039] SendEventMsg is used in a wro...

2018-05-28 Thread xiaozhongwang
Github user xiaozhongwang closed the pull request at: https://github.com/apache/trafodion/pull/1534 ---

[GitHub] trafodion pull request #1582: [TRAFODION-3039] SendEventMsg is used in a wro...

2018-05-28 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1582#discussion_r191290915 --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp --- @@ -6533,6 +6535,8 @@ odbc_SQLSrvr_ExtractLob_sme_( if (retcode

[GitHub] trafodion pull request #1382: [TRAFODION-2893] fix the logic Critical error ...

2018-01-09 Thread xiaozhongwang
GitHub user xiaozhongwang opened a pull request: https://github.com/apache/trafodion/pull/1382 [TRAFODION-2893] fix the logic Critical error checked by TScanCode. The count of parameters mismatches the format string in sprintf You can merge this pull request into a Git repository

[GitHub] trafodion pull request #1379: remove code about SP_EXPORT_LIB

2018-01-08 Thread xiaozhongwang
GitHub user xiaozhongwang opened a pull request: https://github.com/apache/trafodion/pull/1379 remove code about SP_EXPORT_LIB Because the SP_EXPORT_LIB is empty. make a build error, as: mkdir -p##(SEAMONSTER) mkdir: 缺少操作数 ##(SEAMONSTER) 请å

[GitHub] trafodion pull request #1380: [TRAFODION-2886] fix the nullpointer error sca...

2018-01-11 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1380#discussion_r160870920 --- Diff: core/sql/executor/cluster.cpp --- @@ -2395,7 +2395,7 @@ NABoolean Cluster::checkAndSplit(ExeErrorCode * rc

[GitHub] trafodion pull request #1394: [TRAFODION-2891] fix the bufoverrun Critical e...

2018-01-16 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1394#discussion_r161910390 --- Diff: core/conn/odb/src/odb.c --- @@ -5313,7 +5313,7 @@ static void etabadd(char type, char *run, int id

[GitHub] trafodion pull request #1394: [TRAFODION-2891] fix the bufoverrun Critical e...

2018-01-16 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1394#discussion_r161911063 --- Diff: core/sqf/src/seatrans/tm/hbasetmlib2/hbasetm.h --- @@ -139,9 +139,9 @@ class CHbaseTM : public JavaObjectInterfaceTM

[GitHub] trafodion pull request #1413: [TRAFODION-2802 ] source the .bashrc before ac...

2018-01-25 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1413#discussion_r164020994 --- Diff: install/traf_checkset_env.sh --- @@ -244,11 +244,14 @@ if [ ! -d ${javapath} ]; then exit 1 fi +source $HOME

[GitHub] trafodion pull request #1440: [TRAFODION-2893] make this error when fixed th...

2018-02-05 Thread xiaozhongwang
GitHub user xiaozhongwang opened a pull request: https://github.com/apache/trafodion/pull/1440 [TRAFODION-2893] make this error when fixed the error checked by TScanCode You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] trafodion pull request #1421: [TRAFODION-2936] nullpointer error where serve...

2018-01-29 Thread xiaozhongwang
GitHub user xiaozhongwang opened a pull request: https://github.com/apache/trafodion/pull/1421 [TRAFODION-2936] nullpointer error where server return without value we met a bug, when the server return without value, will make a null point error. You can merge this pull request

[GitHub] trafodion pull request #1671: [TRAFODION-3710] odb don't report error messag...

2018-07-31 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1671#discussion_r206444234 --- Diff: core/conn/odb/src/odb.c --- @@ -40,6 +40,7 @@ char *odbauth = "Trafodion Dev "; #define MAX_ARGS11 /* Max

[GitHub] trafodion pull request #1413: [TRAFODION-2802 ] source the .bashrc before ac...

2018-01-23 Thread xiaozhongwang
GitHub user xiaozhongwang opened a pull request: https://github.com/apache/trafodion/pull/1413 [TRAFODION-2802 ] source the .bashrc before access JAVA_HOME modify for running on a new server You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] trafodion pull request #:

2018-04-22 Thread xiaozhongwang
Github user xiaozhongwang commented on the pull request: https://github.com/apache/trafodion/commit/a3971a2365d23f66303c0a33d36b70cb47fb6c21#commitcomment-28689713 +1 looks good for me ---

[GitHub] trafodion pull request #1534: [TRAFODION-3039] SendEventMsg is used in a wro...

2018-04-23 Thread xiaozhongwang
GitHub user xiaozhongwang opened a pull request: https://github.com/apache/trafodion/pull/1534 [TRAFODION-3039] SendEventMsg is used in a wrong way SendEventMsg use dynamic parameter. And there is a parameter control the total, all of dynamic parameters are string data type

[GitHub] trafodion pull request #1501: [TRAFODION-3016] Windows ODBC do not support o...

2018-03-28 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1501#discussion_r177751339 --- Diff: win-odbc64/odbcclient/drvr35/cstmt.cpp --- @@ -1063,7 +1063,20 @@ SQLRETURN CStmt::SendSQLCommand(BOOL SkipProcess, SQLCHAR

[GitHub] trafodion pull request #1499: [TRAFODION-3003]Trafodion keepalive support

2018-03-28 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1499#discussion_r177483293 --- Diff: core/conn/odbc/src/odbc/Common/Global.h --- @@ -935,7 +941,10 @@ typedef struct _SRVR_GLOBAL_Def bzero(m_ProcName,sizeof

[GitHub] trafodion pull request #1499: [TRAFODION-3003]Trafodion keepalive support

2018-03-28 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1499#discussion_r177489126 --- Diff: dcs/src/main/java/org/trafodion/dcs/Constants.java --- @@ -112,6 +112,29 @@ /** Default value for DCS server user program exit

[GitHub] trafodion pull request #1499: [TRAFODION-3003]Trafodion keepalive support

2018-03-28 Thread xiaozhongwang
Github user xiaozhongwang commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1499#discussion_r177485881 --- Diff: core/conn/odbc/src/odbc/Common/Global.h --- @@ -139,10 +139,16 @@ class ODBCMXTraceMsg; #define DEFAULT_REFRESH_RATE_SECS