Re: [collectd] write_graphite documentation out of date?

2018-11-13 Thread Pavel
On Tue, 13 Nov 2018 10:33:01 -0800 Matt Simmons wrote: Hi! I use write_graphite to send my collectd metrics to carbon/graphite, and I've been going by the documentation for this plugin here: https://collectd.org/wiki/index.php/Plugin:Write_Graphite Collectd has documentation distributed wit

[collectd] write_graphite documentation out of date?

2018-11-13 Thread Matt Simmons
Hi! I use write_graphite to send my collectd metrics to carbon/graphite, and I've been going by the documentation for this plugin here: https://collectd.org/wiki/index.php/Plugin:Write_Graphite When I look at the source code itself, though, I see that it seems to support the UseTags configuratio

Re: [collectd] [Libguestfs] collectd leaks SIGCHLD == SIG_IGN into plugins

2018-11-13 Thread Richard W.M. Jones
On Tue, Nov 13, 2018 at 03:17:33PM +0200, Peter Dimitrov wrote: > I was extending the virt plugin. > It already collects similar data (about VMs) using Libvirt's API, but lacks > disk usage information. > > I went through some hoops to link libguestfs correctly to collectd. > Is it okay to just in

Re: [collectd] [Libguestfs] collectd leaks SIGCHLD == SIG_IGN into plugins

2018-11-13 Thread Sven Trenkel
On 2018-11-13 12:25, Richard W.M. Jones wrote: The problem with all of this is that all the different plugins that expect different SIGCHLD behaviour are running in the same process and you can only have one behaviour for all of them. I encountered that with the Python plugin years ago, docume

Re: [collectd] [Libguestfs] collectd leaks SIGCHLD == SIG_IGN into plugins

2018-11-13 Thread Richard W.M. Jones
On Tue, Nov 13, 2018 at 12:00:19PM +0100, Florian Forster wrote: > Hi, > > thank you very much for reporting this! Sounds like a bug in the exec plugin – > it never ceases to amaze me how many issues a single plugin can have ;) > > > > > This means that any plugin that does the usual pattern of:

Re: [collectd] [Libguestfs] collectd leaks SIGCHLD == SIG_IGN into plugins

2018-11-13 Thread Richard W.M. Jones
On Tue, Nov 13, 2018 at 12:07:23PM +0100, Florian Forster wrote: > A quick glance shows that the exec plugin actually is clearing the signal > mask: > https://github.com/collectd/collectd/blob/master/src/exec.c#L526 The problem is the SIGCHLD handler being set to SIG_IGN, which is different from

Re: [collectd] [Libguestfs] collectd leaks SIGCHLD == SIG_IGN into plugins

2018-11-13 Thread Florian Forster
A quick glance shows that the exec plugin actually is clearing the signal mask: https://github.com/collectd/collectd/blob/master/src/exec.c#L526 Can you give some more context when this problem comes up? Ideally in a Github issue (hint, hint ;). -- Florian octo Forster Hacker in training GnuPG: 0

Re: [collectd] [Libguestfs] collectd leaks SIGCHLD == SIG_IGN into plugins

2018-11-13 Thread Florian Forster
Hi, thank you very much for reporting this! Sounds like a bug in the exec plugin – it never ceases to amaze me how many issues a single plugin can have ;) > > > This means that any plugin that does the usual pattern of: > > > > > > pid = fork (); Note that the exec plugin is the *only* plugin

Re: [collectd] [Libguestfs] collectd leaks SIGCHLD == SIG_IGN into plugins

2018-11-13 Thread Richard W.M. Jones
On Tue, Nov 13, 2018 at 10:04:33AM +, Daniel P. Berrangé wrote: > On Fri, Nov 09, 2018 at 12:19:30PM +, Richard W.M. Jones wrote: > > Peter Dimitrov and myself were debugging a very peculiar bug when > > libguestfs is run as a plugin from collectd: > > > > https://www.redhat.com/archives

Re: [collectd] collectd leaks SIGCHLD == SIG_IGN into plugins

2018-11-13 Thread Richard W.M. Jones
On Tue, Nov 13, 2018 at 09:19:40AM +0100, Ruben Kerkhof wrote: > Hi Rich, > > On Fri, Nov 9, 2018 at 1:19 PM, Richard W.M. Jones wrote: > > Peter Dimitrov and myself were debugging a very peculiar bug when > > libguestfs is run as a plugin from collectd: > > > > https://www.redhat.com/archives/

Re: [collectd] collectd leaks SIGCHLD == SIG_IGN into plugins

2018-11-13 Thread Ruben Kerkhof
Hi Rich, On Fri, Nov 9, 2018 at 1:19 PM, Richard W.M. Jones wrote: > Peter Dimitrov and myself were debugging a very peculiar bug when > libguestfs is run as a plugin from collectd: > > https://www.redhat.com/archives/libguestfs/2018-November/thread.html#00023 > > The long story short is that c