[GitHub] [airflow] codecov-io edited a comment on issue #6379: [AIRFLOW-5708] Optionally check task pools when parsing dags.

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #6379: [AIRFLOW-5708] Optionally check task pools when parsing dags. URL: https://github.com/apache/airflow/pull/6379#issuecomment-603646789 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #6379: [AIRFLOW-5708] Optionally check task pools when parsing dags.

2020-03-24 Thread GitBox
codecov-io commented on issue #6379: [AIRFLOW-5708] Optionally check task pools when parsing dags. URL: https://github.com/apache/airflow/pull/6379#issuecomment-603646789 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=h1) Report > Merging

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397603531 ## File path: scripts/ci/docker-compose/base.yml ## @@ -59,6 +59,8 @@ services: - DB_RESET -

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397603326 ## File path: scripts/ci/_utils.sh ## @@ -530,7 +531,7 @@ function confirm_image_rebuild() { #

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397603139 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397603010 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397602871 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397602779 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397602652 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397602189 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397602286 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397601566 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397601489 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397601320 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
potiuk commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397601090 ## File path: .travis.yml ## @@ -41,24 +41,24 @@ jobs: stage: pre-test script:

[jira] [Commented] (AIRFLOW-6912) Airflow unable to run concurrent ssh tasks (up to 27) in a single dag

2020-03-24 Thread Nguyen Lam Phuc (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066365#comment-17066365 ] Nguyen Lam Phuc commented on AIRFLOW-6912: -- [~ash] Is there a way for us to share the dag with

[GitHub] [airflow] codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation URL: https://github.com/apache/airflow/pull/7464#issuecomment-603575203 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation URL: https://github.com/apache/airflow/pull/7464#issuecomment-603575203 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation URL: https://github.com/apache/airflow/pull/7464#issuecomment-603575203 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=h1) Report > Merging

[GitHub] [airflow] mik-laj opened a new pull request #7863: Improve authorization in GCP system tests

2020-03-24 Thread GitBox
mik-laj opened a new pull request #7863: Improve authorization in GCP system tests URL: https://github.com/apache/airflow/pull/7863 --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark the boxes below before creating PR:

[GitHub] [airflow] mik-laj opened a new pull request #7862: Improve setUp/tearDown in Cloud Firestore system test

2020-03-24 Thread GitBox
mik-laj opened a new pull request #7862: Improve setUp/tearDown in Cloud Firestore system test URL: https://github.com/apache/airflow/pull/7862 --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark the boxes below before

[GitHub] [airflow] kaxil commented on issue #7786: Restore DaskExecutor tests

2020-03-24 Thread GitBox
kaxil commented on issue #7786: Restore DaskExecutor tests URL: https://github.com/apache/airflow/pull/7786#issuecomment-603610022 https://github.com/apache/airflow/pull/7786/commits/d652062b19f0820a0ba5636ec2c4ff94f8aef9b3 should fix another 2 tests. ```

[GitHub] [airflow] kuromt commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

2020-03-24 Thread GitBox
kuromt commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator URL: https://github.com/apache/airflow/pull/7365#issuecomment-603606530 > @ashb as the config rewrite is down the road I'm good to merge this. Thanks! `pod_generator.py` is updated after

[jira] [Commented] (AIRFLOW-4453) none_failed trigger rule cascading skipped state to downstream tasks

2020-03-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066328#comment-17066328 ] ASF GitHub Bot commented on AIRFLOW-4453: - yuqian90 commented on pull request #7464:

[jira] [Commented] (AIRFLOW-4453) none_failed trigger rule cascading skipped state to downstream tasks

2020-03-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066329#comment-17066329 ] ASF GitHub Bot commented on AIRFLOW-4453: - yuqian90 commented on pull request #7464:

[GitHub] [airflow] yuqian90 opened a new pull request #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

2020-03-24 Thread GitBox
yuqian90 opened a new pull request #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation URL: https://github.com/apache/airflow/pull/7464 This is to pick up the work started in https://github.com/apache/airflow/pull/7098. I discussed with @TV4Fun and opened

[GitHub] [airflow] yuqian90 closed pull request #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

2020-03-24 Thread GitBox
yuqian90 closed pull request #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation URL: https://github.com/apache/airflow/pull/7464 This is an automated message from the Apache Git Service. To

[GitHub] [airflow] codecov-io commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix

2020-03-24 Thread GitBox
codecov-io commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix URL: https://github.com/apache/airflow/pull/7861#issuecomment-603603258 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7861?src=pr=h1) Report > Merging

[GitHub] [airflow] zhongjiajie removed a comment on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix

2020-03-24 Thread GitBox
zhongjiajie removed a comment on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix URL: https://github.com/apache/airflow/pull/7861#issuecomment-603600912 Should we add `[WIP]` in PR title avoid incorrect merge?

[GitHub] [airflow] zhongjiajie commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix

2020-03-24 Thread GitBox
zhongjiajie commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix URL: https://github.com/apache/airflow/pull/7861#issuecomment-603600912 Should we add `[WIP]` in PR title avoid incorrect merge?

[GitHub] [airflow] zhongjiajie commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix

2020-03-24 Thread GitBox
zhongjiajie commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix URL: https://github.com/apache/airflow/pull/7861#issuecomment-603600903 Should we add `[WIP]` in PR title avoid incorrect merge?

[GitHub] [airflow] xinbinhuang edited a comment on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
xinbinhuang edited a comment on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603593164 > Options: > > 1. `connections_path_prefix` > 2. `connections_prefix` > 3. `connections_path` > > What do others

[GitHub] [airflow] xinbinhuang commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
xinbinhuang commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603593164 > Options: > > 1. `connections_path_prefix` > 2. `connections_prefix` > 3. `connections_path` > > What do others think

[GitHub] [airflow] xinbinhuang commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix

2020-03-24 Thread GitBox
xinbinhuang commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix URL: https://github.com/apache/airflow/pull/7861#issuecomment-603591925 Need to rebase after https://github.com/apache/airflow/pull/7861 is merged

[jira] [Commented] (AIRFLOW-7108) Fix CloudSecretsManagerBackend invalid connections_prefix

2020-03-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066308#comment-17066308 ] ASF GitHub Bot commented on AIRFLOW-7108: - xinbinhuang commented on pull request #7861:

[jira] [Created] (AIRFLOW-7108) Fix CloudSecretsManagerBackend invalid connections_prefix

2020-03-24 Thread Xinbin Huang (Jira)
Xinbin Huang created AIRFLOW-7108: - Summary: Fix CloudSecretsManagerBackend invalid connections_prefix Key: AIRFLOW-7108 URL: https://issues.apache.org/jira/browse/AIRFLOW-7108 Project: Apache Airflow

[GitHub] [airflow] xinbinhuang opened a new pull request #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix

2020-03-24 Thread GitBox
xinbinhuang opened a new pull request #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix URL: https://github.com/apache/airflow/pull/7861 --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark

[GitHub] [airflow] j-y-matsubara commented on issue #7854: Add not solved items to pylint_todo.txt

2020-03-24 Thread GitBox
j-y-matsubara commented on issue #7854: Add not solved items to pylint_todo.txt URL: https://github.com/apache/airflow/pull/7854#issuecomment-603579735 @potiuk OK, I understand. I will try it. The reason I sent this pull request is because when I ran

[GitHub] [airflow] codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest URL: https://github.com/apache/airflow/pull/7860#issuecomment-603573823 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation URL: https://github.com/apache/airflow/pull/7464#issuecomment-603575203 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation URL: https://github.com/apache/airflow/pull/7464#issuecomment-603575203 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation URL: https://github.com/apache/airflow/pull/7464#issuecomment-603575203 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest URL: https://github.com/apache/airflow/pull/7860#issuecomment-603573823 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

2020-03-24 Thread GitBox
codecov-io commented on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation URL: https://github.com/apache/airflow/pull/7464#issuecomment-603575203 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest URL: https://github.com/apache/airflow/pull/7860#issuecomment-603573823 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest URL: https://github.com/apache/airflow/pull/7860#issuecomment-603573823 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest

2020-03-24 Thread GitBox
codecov-io commented on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest URL: https://github.com/apache/airflow/pull/7860#issuecomment-603573823 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397541486 ## File path: scripts/ci/docker-compose/base.yml ## @@ -59,6 +59,8 @@ services: - DB_RESET -

[GitHub] [airflow] codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397540533 ## File path: scripts/ci/_utils.sh ## @@ -530,7 +531,7 @@ function confirm_image_rebuild() { # Make

[GitHub] [airflow] mik-laj commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
mik-laj commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397540234 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] codecov-io commented on issue #7859: BugFix: Show task_id in the Graph View tooltip

2020-03-24 Thread GitBox
codecov-io commented on issue #7859: BugFix: Show task_id in the Graph View tooltip URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397539382 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397539036 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397539315 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397539204 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397539097 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397538762 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397538872 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397538375 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397538596 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397538375 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397538278 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397538133 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397538278 ## File path: CONTRIBUTING.rst ## @@ -341,31 +341,59 @@ be open to allow several different libraries with

[GitHub] [airflow] mik-laj commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
mik-laj commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397538396 ## File path: .travis.yml ## @@ -41,24 +41,24 @@ jobs: stage: pre-test script:

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

2020-03-24 Thread GitBox
kaxil commented on a change in pull request #7841: Requirements now depend on python version URL: https://github.com/apache/airflow/pull/7841#discussion_r397537666 ## File path: .travis.yml ## @@ -41,24 +41,24 @@ jobs: stage: pre-test script:

[GitHub] [airflow] mik-laj opened a new pull request #7860: Improve setUp/tearDown in PrestoToGCSSystemTest

2020-03-24 Thread GitBox
mik-laj opened a new pull request #7860: Improve setUp/tearDown in PrestoToGCSSystemTest URL: https://github.com/apache/airflow/pull/7860 --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark the boxes below before creating

[GitHub] [airflow] kaxil opened a new pull request #7859: BugFix: Show task_id in the Graph View tooltip

2020-03-24 Thread GitBox
kaxil opened a new pull request #7859: BugFix: Show task_id in the Graph View tooltip URL: https://github.com/apache/airflow/pull/7859 I am not sure how to add a test for this as the Tooltip is generated using jQuery Make sure to mark the boxes below before creating PR: [x]

[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603557518 > For some context, this is a snapshot of the `parameter store` service. So I feel like better to still have the `ParameterStore` part > >

[GitHub] [airflow] xinbinhuang commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
xinbinhuang commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603553216 For some context, this is a snapshot of the `parameter store` service. So I feel like better to still have the `ParameterStore` part

[GitHub] [airflow] kaxil edited a comment on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
kaxil edited a comment on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603547473 `SystemsManagerParametersBackend` stripping AWS as we don't use GCP or Hashicorp in their respective backends too.

[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603547473 `SystemManagerParametersBackend` stripping AWS as we don't use GCP or Hashicorp in their respective backends too.

[GitHub] [airflow] sharmaTanmay opened a new issue #7858: ShortCircuitOperator Ignoring Trigger Rules for Downstream Task and Skipping all Tasks

2020-03-24 Thread GitBox
sharmaTanmay opened a new issue #7858: ShortCircuitOperator Ignoring Trigger Rules for Downstream Task and Skipping all Tasks URL: https://github.com/apache/airflow/issues/7858 **Apache Airflow version**: 1.10.3 **What happened**: I'm trying to use a

[GitHub] [airflow] ashb commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
ashb commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603546886 I think the "Store" part is not needed, so AwsSMParametersBackend, AwsSystemManagerParametersBackend or soemthing like that, or perhaps

[GitHub] [airflow] ashb commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
ashb commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603546227 https://docs.aws.amazon.com/systems-manager/latest/userguide/what-is-systems-manager.html > *Systems Manager Service Name History* > >

[GitHub] [airflow] kaxil edited a comment on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
kaxil edited a comment on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603545674 `AwsSystemsManagerParameterStoreBackend` wow that name would be huge `SystemsManagerParameterStoreBackend` ? We can remove `aws` as it

[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603545674 `AwsSystemsManagerParameterStoreBackend` wow that name would be huge `AwsSMParameterStoreBackend` ?

[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603545387 > I think SecretsManager may be something else. Go AWS! 臘‍♂ I am confused. WTH!

[GitHub] [airflow] ashb commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
ashb commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603545231 I think SecretsManager may be something else. Go AWS! This is an automated message

[GitHub] [airflow] ashb commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
ashb commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603544999 In fact it seems that "SSM" is the "Systems Manager Agent" https://docs.aws.amazon.com/systems-manager/latest/userguide/ssm-agent.html. The

[GitHub] [airflow] kaxil edited a comment on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
kaxil edited a comment on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603544562 > Aws SSM How about `AwsSecretsManager`? (Based on https://docs.aws.amazon.com/secretsmanager/latest/userguide/intro.html)

[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603544562 > Aws SSM How about `AwdSecretsManager`? (Based on https://docs.aws.amazon.com/secretsmanager/latest/userguide/intro.html)

[GitHub] [airflow] ashb commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
ashb commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603543950 Aws SSM is a suite of tools/products so calling it AwsSSMBackend is too generic. AwsSSMParameterStoreBackend (though it's too long a name)

[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names

2020-03-24 Thread GitBox
kaxil commented on issue #7846: Standardize SecretBackend class names URL: https://github.com/apache/airflow/pull/7846#issuecomment-603543023 Options: 1. `connections_path_prefix` 2. `connections_prefix` 3. `connections_path` What do others think @potiuk @ashb

[GitHub] [airflow] kaxil merged pull request #7851: Bump Boto3 to >=1.12

2020-03-24 Thread GitBox
kaxil merged pull request #7851: Bump Boto3 to >=1.12 URL: https://github.com/apache/airflow/pull/7851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] codecov-io edited a comment on issue #7405: [AIRFLOW-6780] Add option to use args instead of command in K8s pod spec

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7405: [AIRFLOW-6780] Add option to use args instead of command in K8s pod spec URL: https://github.com/apache/airflow/pull/7405#issuecomment-603534537 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7401: [AIRFLOW-6778] Add a configurable DAGs volume mount path for Kubernetes

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7401: [AIRFLOW-6778] Add a configurable DAGs volume mount path for Kubernetes URL: https://github.com/apache/airflow/pull/7401#issuecomment-603533965 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7405: [AIRFLOW-6780] Add option to use args instead of command in K8s pod spec

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7405: [AIRFLOW-6780] Add option to use args instead of command in K8s pod spec URL: https://github.com/apache/airflow/pull/7405#issuecomment-603534537 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7405: [AIRFLOW-6780] Add option to use args instead of command in K8s pod spec

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7405: [AIRFLOW-6780] Add option to use args instead of command in K8s pod spec URL: https://github.com/apache/airflow/pull/7405#issuecomment-603534537 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7401: [AIRFLOW-6778] Add a configurable DAGs volume mount path for Kubernetes

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7401: [AIRFLOW-6778] Add a configurable DAGs volume mount path for Kubernetes URL: https://github.com/apache/airflow/pull/7401#issuecomment-603533965 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes URL: https://github.com/apache/airflow/pull/7423#issuecomment-586568480 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes URL: https://github.com/apache/airflow/pull/7423#issuecomment-586568480 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes

2020-03-24 Thread GitBox
codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes URL: https://github.com/apache/airflow/pull/7423#issuecomment-586568480 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=h1) Report > Merging

  1   2   >