varundhussa commented on pull request #10673:
URL: https://github.com/apache/airflow/pull/10673#issuecomment-687554661
Thanks @jaketf and @turbaszek
This is an automated message from the Apache Git Service.
To respond to
ryanyuan opened a new pull request #10744:
URL: https://github.com/apache/airflow/pull/10744
In CONTRIBUTING.rst, we have brew install node --without-npm for installing
node in macOS. The --without-npm flag is outdated and running this command will
throw Error: invalid option:
ryanyuan opened a new issue #10743:
URL: https://github.com/apache/airflow/issues/10743
**Environment**:
- **OS** (e.g. from /etc/os-release): macOS 10.15.6
- **Install tools**: brew
**What happened**:
In CONTRIBUTING.rst, we have `brew install node --without-npm`
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to tag nightly-master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
*** WARNING: tag nightly-master was modified! ***
from 4e09cb5 (commit)
to 079d7b5 (commit)
from
yuqian90 commented on issue #10725:
URL: https://github.com/apache/airflow/issues/10725#issuecomment-687530055
@kaxil will do
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mik-laj commented on issue #9708:
URL: https://github.com/apache/airflow/issues/9708#issuecomment-68751
@turbaszek We still have many suppliers with coverage below 75 percent.
```
0.00 dingding
0.00 opsgenie
0.00 presto
0.00 qubole
0.00 samba
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 079d7b5 Enable more checks for pydocstyle
kaxil merged pull request #10741:
URL: https://github.com/apache/airflow/pull/10741
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kaxil commented on pull request #10741:
URL: https://github.com/apache/airflow/pull/10741#issuecomment-687506821
> Have you thought about creating a ticket about changes in documentation
along with the label goodfirstissue? we have a large community willing to help
if they know what to
mik-laj commented on pull request #10741:
URL: https://github.com/apache/airflow/pull/10741#issuecomment-687505217
Have you thought about creating a ticket about changes in documentation
along with the label goodfirstissue? we have a large community willing to help
if they know what to
kaxil opened a new issue #10742:
URL: https://github.com/apache/airflow/issues/10742
We use [PyDocStyle](https://github.com/PyCQA/pydocstyle) in pre-commit to
enforce docstring style:
mik-laj commented on pull request #10594:
URL: https://github.com/apache/airflow/pull/10594#issuecomment-687503868
Alternatively, you can add the tables to the documentation and that will be
enough for me too.
**
for more
potiuk commented on pull request #10733:
URL: https://github.com/apache/airflow/pull/10733#issuecomment-687454263
cc: @OmairK
This is an automated message from the Apache Git Service.
To respond to the message, please log
potiuk opened a new pull request #10733:
URL: https://github.com/apache/airflow/pull/10733
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
for more
potiuk commented on pull request #10708:
URL: https://github.com/apache/airflow/pull/10708#issuecomment-687450981
Rebased to the latest asserts and added unit tests for breeze-complete.
This is an automated message from the
mik-laj commented on a change in pull request #10162:
URL: https://github.com/apache/airflow/pull/10162#discussion_r483872791
##
File path: airflow/config_templates/config.yml
##
@@ -1080,6 +1080,13 @@
type: string
example: ~
default: "30"
+- name:
dimon222 commented on issue #10722:
URL: https://github.com/apache/airflow/issues/10722#issuecomment-687447007
I've previously encountered this issue and can confirm that it takes place.
My solution was to not use xcom with KubernetesPodOperator, but obviously
that's not a cure, but
mik-laj commented on pull request #5:
URL: https://github.com/apache/airflow-client-go/pull/5#issuecomment-687442219
Have you tested how the client is generated for Google OpenID or Kerberos?
This is an automated message
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 6e3d7b6 Add masterConfig parameter to
MLEngineStartTrainingJobOperator (#10578)
add 8cb4fc1 Add
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 6e3d7b6 Add masterConfig parameter to
MLEngineStartTrainingJobOperator (#10578)
add 8cb4fc1 Add
mik-laj merged pull request #10652:
URL: https://github.com/apache/airflow/pull/10652
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mik-laj commented on a change in pull request #10652:
URL: https://github.com/apache/airflow/pull/10652#discussion_r483865385
##
File path: docs/conf.py
##
@@ -553,6 +553,7 @@ def _get_rst_filepath_from_path(filepath: str):
'spec': OPENAPI_FILE,
'opts': {
jhtimmins commented on a change in pull request #10652:
URL: https://github.com/apache/airflow/pull/10652#discussion_r483864689
##
File path: docs/conf.py
##
@@ -553,6 +553,7 @@ def _get_rst_filepath_from_path(filepath: str):
'spec': OPENAPI_FILE,
'opts': {
potiuk commented on pull request #10731:
URL: https://github.com/apache/airflow/pull/10731#issuecomment-687415943
That one has just quarantined tests failed.
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from e4de728 Switches to better BATS asserts (#10718)
add 6e3d7b6 Add masterConfig parameter to
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 6e3d7b6 Add masterConfig parameter to
mik-laj merged pull request #10578:
URL: https://github.com/apache/airflow/pull/10578
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
boring-cyborg[bot] commented on pull request #10578:
URL: https://github.com/apache/airflow/pull/10578#issuecomment-687413011
Awesome work, congrats on your first merged pull request!
This is an automated message from
kaxil commented on a change in pull request #9467:
URL: https://github.com/apache/airflow/pull/9467#discussion_r483854376
##
File path: airflow/bin/cli.py
##
@@ -2151,6 +2153,19 @@ def info(args):
print(info)
+def upgrade_check(args):
+if args.save:
+
mik-laj commented on issue #10549:
URL: https://github.com/apache/airflow/issues/10549#issuecomment-687402016
@jpmarques66 I assigned you to this ticket
This is an automated message from the Apache Git Service.
To respond
mik-laj commented on pull request #9467:
URL: https://github.com/apache/airflow/pull/9467#issuecomment-687401568
We want to build this tool together with the community. When this change is
merged, we will create several tickets for other contributors. It will also be
a good time to add a
mik-laj commented on a change in pull request #10728:
URL: https://github.com/apache/airflow/pull/10728#discussion_r483852840
##
File path: docs/howto/connection/gcp.rst
##
@@ -32,7 +32,13 @@ There are three ways to connect to Google Cloud using
Airflow.
1. Use
kaxil commented on issue #10686:
URL: https://github.com/apache/airflow/issues/10686#issuecomment-687396470
cc @yuqian90
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mik-laj commented on issue #8061:
URL: https://github.com/apache/airflow/issues/8061#issuecomment-687396161
@aragaorenan I did not see any active contributions related to it. This is
also not a big problem if you are using containers/Docker or other [mount
ashb commented on pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#issuecomment-687393784
I need to extend the unit tests to check that it correctly tests the new
functionality (not sure how I missed that) -- namely that TIs from a
SchedulerJob that has
kaxil commented on issue #10725:
URL: https://github.com/apache/airflow/issues/10725#issuecomment-687393402
@yuqian90 Looks like more people rely on this feature, would you be able to
make a PR that restores this behavior to allow empty branch please
dimberman commented on pull request #10732:
URL: https://github.com/apache/airflow/pull/10732#issuecomment-687393242
It turns out that the script needed to migrate users to a pod_template_file
was WAY easier than I had expected! We should add this to 1.10.13.
dimberman opened a new pull request #10732:
URL: https://github.com/apache/airflow/pull/10732
Create a script to migrate KubernetesExecutor airflow.cfg configs to
pod_template_file
---
**^ Add meaningful description above**
Read the **[Pull Request
jhtimmins commented on a change in pull request #10594:
URL: https://github.com/apache/airflow/pull/10594#discussion_r483844302
##
File path: airflow/www/security.py
##
@@ -151,10 +152,12 @@ class AirflowSecurityManager(SecurityManager,
LoggingMixin):
WRITE_DAG_PERMS =
XD-DENG commented on pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#issuecomment-687370386
> Looks like this breaks on SQLite --- will need to take a look.
Should be due to SQLite dialect doesn’t support multiple-table criteria
within UPDATE (log line
dimon222 commented on issue #10725:
URL: https://github.com/apache/airflow/issues/10725#issuecomment-687370279
Okay, I thought I'm alone, but then saw #10686 and now this, I start to
think that its a regression.
I'm also affected, what is the proposed way around this? Adding dummy
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 90c1505 Make grace_period_seconds option on K8sPodOperator (#10727)
add e4de728 Switches to better BATS
ashb commented on pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#issuecomment-687365654
Looks like this breaks on SQLite --- will need to take a look.
This is an automated message from the Apache Git
potiuk commented on pull request #10718:
URL: https://github.com/apache/airflow/pull/10718#issuecomment-687365311
Thanks @kaxil!
This is an automated message from the Apache Git Service.
To respond to the message, please
potiuk merged pull request #10718:
URL: https://github.com/apache/airflow/pull/10718
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ashb commented on a change in pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#discussion_r483829702
##
File path: airflow/jobs/scheduler_job.py
##
@@ -1759,3 +1759,46 @@ def _emit_pool_metrics(self, session: Session = None) ->
None:
XD-DENG commented on a change in pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#discussion_r483827767
##
File path: airflow/jobs/scheduler_job.py
##
@@ -1759,3 +1759,46 @@ def _emit_pool_metrics(self, session: Session = None) ->
None:
potiuk opened a new pull request #10731:
URL: https://github.com/apache/airflow/pull/10731
The docker(), helm(), kubectl() functions replace the real tools
to get verbose behaviour (we can print the exact command being
executed for those. But when 'set +e' was set before the command
jaketf commented on a change in pull request #10673:
URL: https://github.com/apache/airflow/pull/10673#discussion_r483811344
##
File path: airflow/providers/google/cloud/sensors/dataproc.py
##
@@ -0,0 +1,83 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+#
XD-DENG commented on a change in pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#discussion_r483806158
##
File path: tests/jobs/test_backfill_job.py
##
@@ -1441,3 +1441,97 @@ def test_backfill_run_backwards(self):
dag.clear()
jaketf commented on a change in pull request #10673:
URL: https://github.com/apache/airflow/pull/10673#discussion_r483810223
##
File path: airflow/providers/google/cloud/sensors/dataproc.py
##
@@ -0,0 +1,83 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+#
jaketf commented on a change in pull request #10673:
URL: https://github.com/apache/airflow/pull/10673#discussion_r483809033
##
File path: airflow/providers/google/cloud/sensors/dataproc.py
##
@@ -0,0 +1,83 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+#
HenryLinTw commented on issue #10725:
URL: https://github.com/apache/airflow/issues/10725#issuecomment-687337266
Just want to bring this up because we also encountered this.
If what mentioned above is eventually finalized, the example in the doc
here:
ashb commented on a change in pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#discussion_r483799618
##
File path: airflow/jobs/base_job.py
##
@@ -73,6 +72,17 @@ class BaseJob(Base, LoggingMixin):
Index('idx_job_state_heartbeat', state,
millertracy closed pull request #10591:
URL: https://github.com/apache/airflow/pull/10591
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
dimberman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 3f7831c Relax requirement to allow latest version of flask-login
(#9990)
add 90c1505 Make
This is an automated email from the ASF dual-hosted git repository.
dimberman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 3f7831c Relax requirement to allow latest version of flask-login
(#9990)
add 90c1505 Make
dimberman merged pull request #10727:
URL: https://github.com/apache/airflow/pull/10727
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kaxil commented on a change in pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#discussion_r483783889
##
File path: airflow/jobs/scheduler_job.py
##
@@ -1759,3 +1759,46 @@ def _emit_pool_metrics(self, session: Session = None) ->
None:
ashb commented on a change in pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#discussion_r483781796
##
File path: airflow/models/taskinstance.py
##
@@ -1871,3 +1872,14 @@ def construct_task_instance(self, session=None,
lock_for_update=False) -> TaskIn
ashb commented on a change in pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#discussion_r483781427
##
File path: airflow/jobs/scheduler_job.py
##
@@ -1759,3 +1759,46 @@ def _emit_pool_metrics(self, session: Session = None) ->
None:
kaxil commented on a change in pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#discussion_r483775657
##
File path: airflow/jobs/scheduler_job.py
##
@@ -1759,3 +1759,46 @@ def _emit_pool_metrics(self, session: Session = None) ->
None:
kaxil commented on a change in pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#discussion_r483775410
##
File path: airflow/jobs/scheduler_job.py
##
@@ -1759,3 +1759,46 @@ def _emit_pool_metrics(self, session: Session = None) ->
None:
kaxil commented on a change in pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#discussion_r483774892
##
File path: airflow/jobs/base_job.py
##
@@ -73,6 +72,17 @@ class BaseJob(Base, LoggingMixin):
Index('idx_job_state_heartbeat', state,
potiuk commented on issue #10730:
URL: https://github.com/apache/airflow/issues/10730#issuecomment-687299266
Or maybe ypu can simply add a PR with that @enriqueayala -> happy to review
it and merge :)
This is an automated
potiuk commented on issue #10730:
URL: https://github.com/apache/airflow/issues/10730#issuecomment-687298766
Nice thing to add indeed. There are a couple of similar requests so I will
address them in one go soon.
This is an
kaxil commented on a change in pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#discussion_r483774432
##
File path: airflow/models/taskinstance.py
##
@@ -1871,3 +1872,14 @@ def construct_task_instance(self, session=None,
lock_for_update=False) -> TaskIn
kaxil commented on a change in pull request #10729:
URL: https://github.com/apache/airflow/pull/10729#discussion_r483774046
##
File path:
airflow/migrations/versions/b247b1e3d1ed_add_queued_by_job_id_to_ti.py
##
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software
kaxil commented on a change in pull request #10727:
URL: https://github.com/apache/airflow/pull/10727#discussion_r483770896
##
File path: kubernetes_tests/test_kubernetes_pod_operator.py
##
@@ -903,7 +904,6 @@ def test_on_kill(self,
self.assertEqual(pod.status.phase,
dimberman commented on a change in pull request #10727:
URL: https://github.com/apache/airflow/pull/10727#discussion_r483770449
##
File path: kubernetes_tests/test_kubernetes_pod_operator.py
##
@@ -903,7 +904,6 @@ def test_on_kill(self,
boring-cyborg[bot] commented on issue #10730:
URL: https://github.com/apache/airflow/issues/10730#issuecomment-687293892
Thanks for opening your first issue here! Be sure to follow the issue
template!
This is an
enriqueayala opened a new issue #10730:
URL: https://github.com/apache/airflow/issues/10730
**Description**
Allow build of airflow docker image behind a corporate firewall.
**Use case / motivation**
I would like to manually build an image by specifying the
kaxil commented on a change in pull request #10727:
URL: https://github.com/apache/airflow/pull/10727#discussion_r483769070
##
File path: kubernetes_tests/test_kubernetes_pod_operator.py
##
@@ -903,7 +904,6 @@ def test_on_kill(self,
self.assertEqual(pod.status.phase,
potiuk commented on pull request #10718:
URL: https://github.com/apache/airflow/pull/10718#issuecomment-687293173
Would love to get that in, so I can add more unit tests while adding the
"Google Shell guidelines" compatibility :)
ashb opened a new pull request #10729:
URL: https://github.com/apache/airflow/pull/10729
Once HA mode for scheduler lands, we can no longer reset orphaned
task by looking at the tasks in (the memory of) the current executor.
This changes it to keep track of which (Scheduler)Job
medb commented on pull request #10714:
URL: https://github.com/apache/airflow/pull/10714#issuecomment-687290335
Thank you for clarification, in this case I will close this PR because it's
already possible to use `DataprocCreateCluster` operator to specify secondary
workers preemptibility.
aragaorenan commented on issue #8061:
URL: https://github.com/apache/airflow/issues/8061#issuecomment-687290298
Hello everyone, any update about this issue?
This is an automated message from the Apache Git Service.
To
medb closed pull request #10714:
URL: https://github.com/apache/airflow/pull/10714
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kaxil commented on a change in pull request #10727:
URL: https://github.com/apache/airflow/pull/10727#discussion_r483763836
##
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##
@@ -146,6 +146,9 @@ class KubernetesPodOperator(BaseOperator): # pylint:
ashb commented on a change in pull request #10594:
URL: https://github.com/apache/airflow/pull/10594#discussion_r483762556
##
File path: airflow/api_connexion/security.py
##
@@ -16,25 +16,63 @@
# under the License.
from functools import wraps
-from typing import Callable,
jaketf opened a new pull request #10728:
URL: https://github.com/apache/airflow/pull/10728
Workload Identity is the recommended way of managing authorization to GCP
services from GKE.
While it is notably not used by Cloud Composer, I think a note like this
could be useful for those who
1 - 100 of 177 matches
Mail list logo
