[GitHub] [airflow] henryzhangsta commented on issue #17014: Changes to BaseOperatorMeta breaks __init_subclass__

2021-07-14 Thread GitBox
henryzhangsta commented on issue #17014: URL: https://github.com/apache/airflow/issues/17014#issuecomment-880418148 @uranusjr Yes, I'll get that going -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] uranusjr commented on issue #16986: Retrying a task from inside task instance view

2021-07-14 Thread GitBox
uranusjr commented on issue #16986: URL: https://github.com/apache/airflow/issues/16986#issuecomment-880418133 If you already know some Flask, what you need to do is to add a form in the UI that POST to a new view. That view should take the current task instance’s id, select it out, set

[GitHub] [airflow] potiuk commented on issue #15303: 1.10.14 Webserver : webserver launch crash without failling

2021-07-14 Thread GitBox
potiuk commented on issue #15303: URL: https://github.com/apache/airflow/issues/15303#issuecomment-880414696 Duplicate of #13470 indeed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] uranusjr closed issue #16836: WebUI broke when enable_xcom_pickling Airflow2.1

2021-07-14 Thread GitBox
uranusjr closed issue #16836: URL: https://github.com/apache/airflow/issues/16836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on issue #17014: Changes to BaseOperatorMeta breaks __init_subclass__

2021-07-14 Thread GitBox
uranusjr commented on issue #17014: URL: https://github.com/apache/airflow/issues/17014#issuecomment-880412245 Hi! Would you be interested in submitting a pull request for the fix? (And a test to prevent future regression.) -- This is an automated message from the Apache Git Service. To

[airflow] branch main updated: Drop support for Airflow 1.10 in entrypoint_prod.sh and improve MSSQL compatibility (#17011)

2021-07-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new cc33d7e Drop support for Airflow 1.10 in

[GitHub] [airflow] potiuk merged pull request #17011: Drop support for Airflow 1.10 in entrypoint_prod.sh and improve MSSQL compatibility

2021-07-14 Thread GitBox
potiuk merged pull request #17011: URL: https://github.com/apache/airflow/pull/17011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #17011: Drop support for Airflow 1.10 in entrypoint_prod.sh and improve MSSQL compatibility

2021-07-14 Thread GitBox
potiuk commented on pull request #17011: URL: https://github.com/apache/airflow/pull/17011#issuecomment-880410452 Ah yeah! Let's rip 1.10 out completely :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] github-actions[bot] commented on pull request #17011: Drop support for Airflow 1.10 in entrypoint_prod.sh and improve MSSQL compatibility

2021-07-14 Thread GitBox
github-actions[bot] commented on pull request #17011: URL: https://github.com/apache/airflow/pull/17011#issuecomment-880409897 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] uranusjr commented on a change in pull request #16954: PythonVritualenvOperator - Feature: Add support for private pypi repo packages in requirements

2021-07-14 Thread GitBox
uranusjr commented on a change in pull request #16954: URL: https://github.com/apache/airflow/pull/16954#discussion_r670146636 ## File path: airflow/utils/python_virtualenv.py ## @@ -35,12 +38,44 @@ def _generate_virtualenv_cmd(tmp_dir: str, python_bin: str,

[airflow] branch main updated (c164c5c -> 469d1cf)

2021-07-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from c164c5c Chart: Update the default Airflow version to ``2.1.2`` (#17013) add 469d1cf Update Airflow version

[GitHub] [airflow] potiuk commented on a change in pull request #16954: PythonVritualenvOperator - Feature: Add support for private pypi repo packages in requirements

2021-07-14 Thread GitBox
potiuk commented on a change in pull request #16954: URL: https://github.com/apache/airflow/pull/16954#discussion_r670145902 ## File path: airflow/utils/python_virtualenv.py ## @@ -88,12 +124,15 @@ def prepare_virtualenv( :type system_site_packages: bool :param

[GitHub] [airflow] kaxil merged pull request #17009: Update Airflow version in ``README.md``

2021-07-14 Thread GitBox
kaxil merged pull request #17009: URL: https://github.com/apache/airflow/pull/17009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on a change in pull request #16954: PythonVritualenvOperator - Feature: Add support for private pypi repo packages in requirements

2021-07-14 Thread GitBox
uranusjr commented on a change in pull request #16954: URL: https://github.com/apache/airflow/pull/16954#discussion_r670145370 ## File path: airflow/utils/python_virtualenv.py ## @@ -88,12 +124,15 @@ def prepare_virtualenv( :type system_site_packages: bool :param

[GitHub] [airflow] uranusjr commented on a change in pull request #16508: Fixes #16507 Subdags are now created with pause status based on their parent.

2021-07-14 Thread GitBox
uranusjr commented on a change in pull request #16508: URL: https://github.com/apache/airflow/pull/16508#discussion_r670144247 ## File path: airflow/models/dag.py ## @@ -1847,7 +1847,10 @@ def bulk_write_to_db(cls, dags: Collection["DAG"], session=None): for

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17014: Changes to BaseOperatorMeta breaks __init_subclass__

2021-07-14 Thread GitBox
boring-cyborg[bot] commented on issue #17014: URL: https://github.com/apache/airflow/issues/17014#issuecomment-880406773 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] henryzhangsta opened a new issue #17014: Changes to BaseOperatorMeta breaks __init_subclass__

2021-07-14 Thread GitBox
henryzhangsta opened a new issue #17014: URL: https://github.com/apache/airflow/issues/17014 **Apache Airflow version**: 2.1.2 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): 1.19.8 **Environment**: - **Cloud provider or hardware

[GitHub] [airflow] ferruzzi commented on a change in pull request #16571: Implemented Basic EKS Integration

2021-07-14 Thread GitBox
ferruzzi commented on a change in pull request #16571: URL: https://github.com/apache/airflow/pull/16571#discussion_r670141477 ## File path: airflow/providers/amazon/aws/hooks/eks.py ## @@ -0,0 +1,452 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] ferruzzi commented on a change in pull request #16571: Implemented Basic EKS Integration

2021-07-14 Thread GitBox
ferruzzi commented on a change in pull request #16571: URL: https://github.com/apache/airflow/pull/16571#discussion_r670140497 ## File path: tests/providers/amazon/aws/utils/eks_test_constants.py ## @@ -0,0 +1,256 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] ferruzzi commented on a change in pull request #16571: Implemented Basic EKS Integration

2021-07-14 Thread GitBox
ferruzzi commented on a change in pull request #16571: URL: https://github.com/apache/airflow/pull/16571#discussion_r670140426 ## File path: tests/providers/amazon/aws/utils/eks_test_constants.py ## @@ -0,0 +1,256 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] potiuk commented on pull request #16311: Prevent running `airflow db init` migrations and setup in parallel.

2021-07-14 Thread GitBox
potiuk commented on pull request #16311: URL: https://github.com/apache/airflow/pull/16311#issuecomment-880396282 Example failure here: https://github.com/apache/airflow/runs/3072403518?check_suite_focus=true -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk commented on pull request #16311: Prevent running `airflow db init` migrations and setup in parallel.

2021-07-14 Thread GitBox
potiuk commented on pull request #16311: URL: https://github.com/apache/airflow/pull/16311#issuecomment-880395808 Happy to take a look as well but the Summit has taken quite a lot of my time this week. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk commented on pull request #16311: Prevent running `airflow db init` migrations and setup in parallel.

2021-07-14 Thread GitBox
potiuk commented on pull request #16311: URL: https://github.com/apache/airflow/pull/16311#issuecomment-880395529 Hmm. Somehow, I think (even if it succeeded), it causes failure in mssql in main @aneesh-joseph @anitakar -> maybe you can join the forces and fix it :) -- This is an

[GitHub] [airflow] potiuk commented on pull request #16932: Adds option to disable mounting temporary folder in DockerOperator

2021-07-14 Thread GitBox
potiuk commented on pull request #16932: URL: https://github.com/apache/airflow/pull/16932#issuecomment-880393717 > I prefer to keep the operator KISS, so it should not retry in case of bad configuration. I thought about it, and I think I prefer to have this retry mechanism for at

[GitHub] [airflow] potiuk closed pull request #17002: Parse JSON template files by default

2021-07-14 Thread GitBox
potiuk closed pull request #17002: URL: https://github.com/apache/airflow/pull/17002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #17002: Parse JSON template files by default

2021-07-14 Thread GitBox
potiuk commented on pull request #17002: URL: https://github.com/apache/airflow/pull/17002#issuecomment-880389530 Closing (unless there will be some good argument to re-open it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk commented on pull request #17002: Parse JSON template files by default

2021-07-14 Thread GitBox
potiuk commented on pull request #17002: URL: https://github.com/apache/airflow/pull/17002#issuecomment-880389374 Agree with @uranusjr - this is backwards-incompatible change. If anything we might want to make it an optional feature that you can enable if you want, but if we would like to

[airflow] branch main updated: Chart: Update the default Airflow version to ``2.1.2`` (#17013)

2021-07-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c164c5c Chart: Update the default Airflow version

[GitHub] [airflow] potiuk merged pull request #17013: Chart: Update the default Airflow version to ``2.1.2``

2021-07-14 Thread GitBox
potiuk merged pull request #17013: URL: https://github.com/apache/airflow/pull/17013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #17008: FIX changelog provider docker 2.0.0

2021-07-14 Thread GitBox
potiuk commented on pull request #17008: URL: https://github.com/apache/airflow/pull/17008#issuecomment-880384940 This will be implemented as bugfix in 2.1.0 that willl follow. The description is also wrong. It will only fail when you have Docker-in-Docker or Remote engine, So it does not

[GitHub] [airflow] potiuk closed pull request #17008: FIX changelog provider docker 2.0.0

2021-07-14 Thread GitBox
potiuk closed pull request #17008: URL: https://github.com/apache/airflow/pull/17008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (fc0250f -> bc00415)

2021-07-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from fc0250f Allow attaching to previously launched task in ECSOperator (#16685) add bc00415 Adds option to

[GitHub] [airflow] potiuk merged pull request #16932: Adds option to disable mounting temporary folder in DockerOperator

2021-07-14 Thread GitBox
potiuk merged pull request #16932: URL: https://github.com/apache/airflow/pull/16932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed issue #16803: DockerOperator not working from containerized Airflow not recognizing `/var/run/docker.sock`

2021-07-14 Thread GitBox
potiuk closed issue #16803: URL: https://github.com/apache/airflow/issues/16803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed issue #16806: Error mounting /tmp/airflowtmp... with remote docker

2021-07-14 Thread GitBox
potiuk closed issue #16806: URL: https://github.com/apache/airflow/issues/16806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #16932: Adds option to disable mounting temporary folder in DockerOperator

2021-07-14 Thread GitBox
potiuk commented on pull request #16932: URL: https://github.com/apache/airflow/pull/16932#issuecomment-880384155 > The cause to the failure is that old `binds` thing _automatically create an empty directory_ if the host path does not exist; the new `mounts` thing does not do that, but

[GitHub] [airflow] mariotaddeucci commented on a change in pull request #16915: Added generic tableau operator

2021-07-14 Thread GitBox
mariotaddeucci commented on a change in pull request #16915: URL: https://github.com/apache/airflow/pull/16915#discussion_r670125675 ## File path: airflow/providers/tableau/operators/tableau.py ## @@ -0,0 +1,144 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] ferruzzi commented on a change in pull request #16571: Implemented Basic EKS Integration

2021-07-14 Thread GitBox
ferruzzi commented on a change in pull request #16571: URL: https://github.com/apache/airflow/pull/16571#discussion_r670125459 ## File path: tests/providers/amazon/aws/operators/test_eks.py ## @@ -0,0 +1,299 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] ferruzzi commented on a change in pull request #16571: Implemented Basic EKS Integration

2021-07-14 Thread GitBox
ferruzzi commented on a change in pull request #16571: URL: https://github.com/apache/airflow/pull/16571#discussion_r670125356 ## File path: tests/providers/amazon/aws/operators/test_eks.py ## @@ -0,0 +1,299 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] potiuk commented on pull request #16932: Adds option to disable mounting temporary folder in DockerOperator

2021-07-14 Thread GitBox
potiuk commented on pull request #16932: URL: https://github.com/apache/airflow/pull/16932#issuecomment-880382561 > Change is good as-is, the changelog addition can be done either here or in another PR. Yep. I will add the changelog when preparing provider's release. -- This is

[GitHub] [airflow] uranusjr commented on pull request #16956: Update spark_kubernetes.py

2021-07-14 Thread GitBox
uranusjr commented on pull request #16956: URL: https://github.com/apache/airflow/pull/16956#issuecomment-880380845 This can be seen with `BashOperator`’s `bash_command` argument. If you search [this documentation

[GitHub] [airflow] edwardwang888 commented on a change in pull request #17003: WIP Fix `retry_exponential_backoff` divide by zero error when retry delay is zero

2021-07-14 Thread GitBox
edwardwang888 commented on a change in pull request #17003: URL: https://github.com/apache/airflow/pull/17003#discussion_r670115567 ## File path: airflow/models/taskinstance.py ## @@ -939,9 +939,9 @@ def next_retry_datetime(self): delay = self.task.retry_delay

[GitHub] [airflow] edwardwang888 commented on a change in pull request #17003: WIP Fix `retry_exponential_backoff` divide by zero error when retry delay is zero

2021-07-14 Thread GitBox
edwardwang888 commented on a change in pull request #17003: URL: https://github.com/apache/airflow/pull/17003#discussion_r670115567 ## File path: airflow/models/taskinstance.py ## @@ -939,9 +939,9 @@ def next_retry_datetime(self): delay = self.task.retry_delay

[GitHub] [airflow] edwardwang888 commented on a change in pull request #17003: WIP Fix `retry_exponential_backoff` divide by zero error when retry delay is zero

2021-07-14 Thread GitBox
edwardwang888 commented on a change in pull request #17003: URL: https://github.com/apache/airflow/pull/17003#discussion_r670115567 ## File path: airflow/models/taskinstance.py ## @@ -939,9 +939,9 @@ def next_retry_datetime(self): delay = self.task.retry_delay

[GitHub] [airflow] uranusjr commented on a change in pull request #17003: WIP Fix `retry_exponential_backoff` divide by zero error when retry delay is zero

2021-07-14 Thread GitBox
uranusjr commented on a change in pull request #17003: URL: https://github.com/apache/airflow/pull/17003#discussion_r670116981 ## File path: airflow/models/taskinstance.py ## @@ -939,9 +939,9 @@ def next_retry_datetime(self): delay = self.task.retry_delay if

[GitHub] [airflow] edwardwang888 commented on a change in pull request #17003: WIP Fix `retry_exponential_backoff` divide by zero error when retry delay is zero

2021-07-14 Thread GitBox
edwardwang888 commented on a change in pull request #17003: URL: https://github.com/apache/airflow/pull/17003#discussion_r670115567 ## File path: airflow/models/taskinstance.py ## @@ -939,9 +939,9 @@ def next_retry_datetime(self): delay = self.task.retry_delay

[GitHub] [airflow] edwardwang888 commented on a change in pull request #17003: WIP Fix `retry_exponential_backoff` divide by zero error when retry delay is zero

2021-07-14 Thread GitBox
edwardwang888 commented on a change in pull request #17003: URL: https://github.com/apache/airflow/pull/17003#discussion_r670115567 ## File path: airflow/models/taskinstance.py ## @@ -939,9 +939,9 @@ def next_retry_datetime(self): delay = self.task.retry_delay

[GitHub] [airflow] edwardwang888 commented on a change in pull request #17003: WIP Fix `retry_exponential_backoff` divide by zero error when retry delay is zero

2021-07-14 Thread GitBox
edwardwang888 commented on a change in pull request #17003: URL: https://github.com/apache/airflow/pull/17003#discussion_r670115567 ## File path: airflow/models/taskinstance.py ## @@ -939,9 +939,9 @@ def next_retry_datetime(self): delay = self.task.retry_delay

[GitHub] [airflow] uranusjr commented on pull request #17002: Parse JSON template files by default

2021-07-14 Thread GitBox
uranusjr commented on pull request #17002: URL: https://github.com/apache/airflow/pull/17002#issuecomment-880371855 > Some operators handle it, but I think it will be good to make this behavior by default But some operators *want* the un-parsed JSON string, so this will only create

[GitHub] [airflow] uranusjr commented on a change in pull request #17003: WIP Fix `retry_exponential_backoff` divide by zero error when retry delay is zero

2021-07-14 Thread GitBox
uranusjr commented on a change in pull request #17003: URL: https://github.com/apache/airflow/pull/17003#discussion_r670107222 ## File path: airflow/models/taskinstance.py ## @@ -939,9 +939,9 @@ def next_retry_datetime(self): delay = self.task.retry_delay if

[GitHub] [airflow] uranusjr commented on a change in pull request #17003: WIP Fix `retry_exponential_backoff` divide by zero error when retry delay is zero

2021-07-14 Thread GitBox
uranusjr commented on a change in pull request #17003: URL: https://github.com/apache/airflow/pull/17003#discussion_r670107222 ## File path: airflow/models/taskinstance.py ## @@ -939,9 +939,9 @@ def next_retry_datetime(self): delay = self.task.retry_delay if

[GitHub] [airflow] github-actions[bot] commented on pull request #16932: Adds option to disable mounting temporary folder in DockerOperator

2021-07-14 Thread GitBox
github-actions[bot] commented on pull request #16932: URL: https://github.com/apache/airflow/pull/16932#issuecomment-880361861 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] uranusjr edited a comment on pull request #16932: Adds option to disable mounting temporary folder in DockerOperator

2021-07-14 Thread GitBox
uranusjr edited a comment on pull request #16932: URL: https://github.com/apache/airflow/pull/16932#issuecomment-880360742 The cause to the failure is that old `binds` thing *automatically create an empty directory* if the host path does not exist; the new `mounts` thing does not do that,

[GitHub] [airflow] uranusjr edited a comment on pull request #16932: Adds option to disable mounting temporary folder in DockerOperator

2021-07-14 Thread GitBox
uranusjr edited a comment on pull request #16932: URL: https://github.com/apache/airflow/pull/16932#issuecomment-880360742 The cause to the failure is that old `binds` thing *automatically create an empty directory* if the host path does not exist; the new `mounts` thing does not do that,

[GitHub] [airflow] uranusjr commented on pull request #16932: Adds option to disable mounting temporary folder in DockerOperator

2021-07-14 Thread GitBox
uranusjr commented on pull request #16932: URL: https://github.com/apache/airflow/pull/16932#issuecomment-880360742 The cause to the failure is that old `binds` thing *automatically create an empty directory* if the host path does not exist; the new `mounts` thing does not do that. So the

[GitHub] [airflow] uranusjr commented on a change in pull request #16932: Adds option to disable mounting temporary folder in DockerOperator

2021-07-14 Thread GitBox
uranusjr commented on a change in pull request #16932: URL: https://github.com/apache/airflow/pull/16932#discussion_r670099878 ## File path: airflow/providers/docker/operators/docker.py ## @@ -227,66 +240,66 @@ def get_hook(self) -> DockerHook: def _run_image(self) ->

[GitHub] [airflow] github-actions[bot] commented on pull request #17009: Update Airflow version in ``README.md``

2021-07-14 Thread GitBox
github-actions[bot] commented on pull request #17009: URL: https://github.com/apache/airflow/pull/17009#issuecomment-880349192 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] uranusjr commented on issue #16983: `on_failure_callback` is not executed

2021-07-14 Thread GitBox
uranusjr commented on issue #16983: URL: https://github.com/apache/airflow/issues/16983#issuecomment-880348627 @trucnguyenlam Callback execution is disabled here, but that disabled callback is returned as the second value here (`callback_to_run`). That callback is then passed on for

[GitHub] [airflow] raphaelauv commented on issue #15303: 1.10.14 Webserver : webserver launch crash without failling

2021-07-14 Thread GitBox
raphaelauv commented on issue #15303: URL: https://github.com/apache/airflow/issues/15303#issuecomment-880323051 https://github.com/apache/airflow/pull/13470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] houqp commented on pull request #16636: Added dashes to pod naming

2021-07-14 Thread GitBox
houqp commented on pull request #16636: URL: https://github.com/apache/airflow/pull/16636#issuecomment-880313628 @SimonOsipov i think you need to write code to check and remove trailing `-` after the truncation so when we concat them with `.`, it won't result in invalid pod name in k8s.

[airflow] branch main updated (16c55f1 -> fc0250f)

2021-07-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 16c55f1 Move docs about masking to a new page (#17007) add fc0250f Allow attaching to previously launched

[GitHub] [airflow] kaxil merged pull request #16685: Allow attaching to previously launched task in ECSOperator

2021-07-14 Thread GitBox
kaxil merged pull request #16685: URL: https://github.com/apache/airflow/pull/16685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16685: Allow attaching to previously launched task in ECSOperator

2021-07-14 Thread GitBox
boring-cyborg[bot] commented on pull request #16685: URL: https://github.com/apache/airflow/pull/16685#issuecomment-880312980 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] kaxil commented on a change in pull request #17011: Drop support for Airflow 1.10 in entrypoint_prod.sh and improve MSSQL compatibility

2021-07-14 Thread GitBox
kaxil commented on a change in pull request #17011: URL: https://github.com/apache/airflow/pull/17011#discussion_r670053767 ## File path: scripts/in_container/prod/entrypoint_prod.sh ## @@ -193,30 +186,13 @@ function set_pythonpath_for_root_user() { } function

[GitHub] [airflow] vikramkoka commented on issue #14906: SimpleHttpOperator takes lambda to transform response before doing XCom push

2021-07-14 Thread GitBox
vikramkoka commented on issue #14906: URL: https://github.com/apache/airflow/issues/14906#issuecomment-880306538 > No worries, I'll pick this one up then! Great, assigned it to you @Naraujo13 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] kaxil opened a new pull request #17013: Chart: Update the default Airflow version to ``2.1.2``

2021-07-14 Thread GitBox
kaxil opened a new pull request #17013: URL: https://github.com/apache/airflow/pull/17013 Updates default Airflow version to 2.1.2 as it has been released. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] github-actions[bot] commented on issue #15793: Airflow Scheduler does not take Queued Slots in Pools into consideration

2021-07-14 Thread GitBox
github-actions[bot] commented on issue #15793: URL: https://github.com/apache/airflow/issues/15793#issuecomment-880288906 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] github-actions[bot] commented on issue #16313: cryptography.fernet.InvalidToken when attempting to access connections

2021-07-14 Thread GitBox
github-actions[bot] commented on issue #16313: URL: https://github.com/apache/airflow/issues/16313#issuecomment-880288890 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] pmalafosse commented on a change in pull request #16685: Allow attaching to previously launched task in ECSOperator

2021-07-14 Thread GitBox
pmalafosse commented on a change in pull request #16685: URL: https://github.com/apache/airflow/pull/16685#discussion_r670031677 ## File path: tests/providers/amazon/aws/operators/test_ecs.py ## @@ -349,6 +349,111 @@ def test_reattach_successful(self, launch_type, tags,

[GitHub] [airflow] kaxil commented on a change in pull request #16404: Secrets backend failover

2021-07-14 Thread GitBox
kaxil commented on a change in pull request #16404: URL: https://github.com/apache/airflow/pull/16404#discussion_r670028958 ## File path: airflow/models/variable.py ## @@ -201,7 +201,13 @@ def get_variable_from_secrets(key: str) -> Optional[str]: :return: Variable

[GitHub] [airflow] kaxil commented on a change in pull request #16404: Secrets backend failover

2021-07-14 Thread GitBox
kaxil commented on a change in pull request #16404: URL: https://github.com/apache/airflow/pull/16404#discussion_r670028958 ## File path: airflow/models/variable.py ## @@ -201,7 +201,13 @@ def get_variable_from_secrets(key: str) -> Optional[str]: :return: Variable

[GitHub] [airflow] kaxil commented on a change in pull request #16685: Allow attaching to previously launched task in ECSOperator

2021-07-14 Thread GitBox
kaxil commented on a change in pull request #16685: URL: https://github.com/apache/airflow/pull/16685#discussion_r670027434 ## File path: tests/providers/amazon/aws/operators/test_ecs.py ## @@ -349,6 +349,111 @@ def test_reattach_successful(self, launch_type, tags,

[GitHub] [airflow] kaxil edited a comment on issue #16952: Secrets Backend Search Path Ordering/Priority

2021-07-14 Thread GitBox
kaxil edited a comment on issue #16952: URL: https://github.com/apache/airflow/issues/16952#issuecomment-880281931 I think the priority is correct and will cause confusion if changed later on. And with customer Secrets Backend, you can mix and match however you like. We intentionally did

[GitHub] [airflow] kaxil commented on issue #16952: Secrets Backend Search Path Ordering/Priority

2021-07-14 Thread GitBox
kaxil commented on issue #16952: URL: https://github.com/apache/airflow/issues/16952#issuecomment-880281931 I think the priority is correct and will cause confusion if changed later on. And with customer Secrets Backend, you can mix and match however you like. We intentionally did this

[GitHub] [airflow] SangwanP commented on issue #17010: Add a trigger rule to support all_done_and_one_success

2021-07-14 Thread GitBox
SangwanP commented on issue #17010: URL: https://github.com/apache/airflow/issues/17010#issuecomment-880274651 Having the ability to define a custom trigger rule would be nice. The difference between triggering with 2+ successes compared to 1+ success(es) is that the latter is more

[GitHub] [airflow] raphaelauv edited a comment on issue #17010: Add a trigger rule to support all_done_and_one_success

2021-07-14 Thread GitBox
raphaelauv edited a comment on issue #17010: URL: https://github.com/apache/airflow/issues/17010#issuecomment-880267979 Problem what to do about the person that need all_done_and_X_success where X could be 2 and not one Look like airflow is missing an expressive pattern to let

[GitHub] [airflow] raphaelauv commented on issue #17010: Add a trigger rule to support all_done_and_one_success

2021-07-14 Thread GitBox
raphaelauv commented on issue #17010: URL: https://github.com/apache/airflow/issues/17010#issuecomment-880267979 Problem what to do about the person that need all_done_and_X_success where X could be 2 and not one Look like airflow is missing an expressive pattern to let the

[GitHub] [airflow] gh4n removed a comment on issue #16983: `on_failure_callback` is not executed

2021-07-14 Thread GitBox
gh4n removed a comment on issue #16983: URL: https://github.com/apache/airflow/issues/16983#issuecomment-880263158 @ephraimbuddy Is your PR https://github.com/apache/airflow/pull/15172 released with 2.1.2 related to this issue? -- This is an automated message from the Apache Git

[GitHub] [airflow] raphaelauv opened a new issue #17012: NONE_FAILED_OR_SKIPPED and NONE_FAILED do the same

2021-07-14 Thread GitBox
raphaelauv opened a new issue #17012: URL: https://github.com/apache/airflow/issues/17012 **Apache Airflow version**: 2.1.2 **What happened**: https://github.com/apache/airflow/blob/16c55f100374df8cb17a85d06396aa42785fed0e/airflow/ti_deps/deps/trigger_rule_dep.py#L206

[GitHub] [airflow] gh4n edited a comment on issue #16983: `on_failure_callback` is not executed

2021-07-14 Thread GitBox
gh4n edited a comment on issue #16983: URL: https://github.com/apache/airflow/issues/16983#issuecomment-880263158 @ephraimbuddy Is your PR https://github.com/apache/airflow/pull/15172 released with 2.1.2 related to this issue? -- This is an automated message from the Apache Git

[GitHub] [airflow] gh4n commented on issue #16983: `on_failure_callback` is not executed

2021-07-14 Thread GitBox
gh4n commented on issue #16983: URL: https://github.com/apache/airflow/issues/16983#issuecomment-880263158 @ephraimbuddy Will your PR https://github.com/apache/airflow/pull/15172 released with 2.1.2 fix this issue? -- This is an automated message from the Apache Git Service. To respond

[airflow] branch main updated (a5d7f9b -> 16c55f1)

2021-07-14 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from a5d7f9b Fix static checks after pre-commit upgrades (#17006) add 16c55f1 Move docs about masking to a

[GitHub] [airflow] mik-laj merged pull request #17007: Move docs about masking to a new page

2021-07-14 Thread GitBox
mik-laj merged pull request #17007: URL: https://github.com/apache/airflow/pull/17007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] mik-laj commented on pull request #17011: Drop support for Airflow 1.10 in entrypoint_prod.sh and improve MSSQL compatibility

2021-07-14 Thread GitBox
mik-laj commented on pull request #17011: URL: https://github.com/apache/airflow/pull/17011#issuecomment-880261527 CC: @aneesh-joseph -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] mik-laj opened a new pull request #17011: Drop support for Airflow 1.10 in entrypoint_prod.sh and improve MSSQL compatibility

2021-07-14 Thread GitBox
mik-laj opened a new pull request #17011: URL: https://github.com/apache/airflow/pull/17011 The 1.10 series reached end of life, so the Dockerfile on main can drop support it. Additionally, this solves one problem that the user reported. We used CLI check for Airflow 1.10 to check

[GitHub] [airflow] magler commented on issue #16952: Secrets Backend Search Path Ordering/Priority

2021-07-14 Thread GitBox
magler commented on issue #16952: URL: https://github.com/apache/airflow/issues/16952#issuecomment-880259029 > > > @kaxil WDYT? II like this idea, but I wonder if there was any assumption on the basis of which you chose the current order. The Secrets backend docs mention a

[GitHub] [airflow] pmalafosse commented on pull request #16937: New Tableau operator: TableauRefreshDatasourceOperator

2021-07-14 Thread GitBox
pmalafosse commented on pull request #16937: URL: https://github.com/apache/airflow/pull/16937#issuecomment-880255509 Nice new operator! There is this issue about TableauRefreshWorkbookOperator operator FYI https://github.com/apache/airflow/issues/16669 @ciancolo -- This is an

[GitHub] [airflow] SangwanP opened a new issue #17010: Add a trigger rule to support all_done_and_one_success

2021-07-14 Thread GitBox
SangwanP opened a new issue #17010: URL: https://github.com/apache/airflow/issues/17010 **Description** I would like to have a trigger rule that triggers a task if all the upstream tasks have executed (_all_done_) and there is atleast one successful upstream task. This would be like

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17010: Add a trigger rule to support all_done_and_one_success

2021-07-14 Thread GitBox
boring-cyborg[bot] commented on issue #17010: URL: https://github.com/apache/airflow/issues/17010#issuecomment-880254564 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] kaxil opened a new pull request #17009: Update Airflow version in ``README.md``

2021-07-14 Thread GitBox
kaxil opened a new pull request #17009: URL: https://github.com/apache/airflow/pull/17009 This commit/PR also updates the release date in CHANGELOG.txt --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] raphaelauv edited a comment on pull request #17008: FIX changelog provider docker 2.0.0

2021-07-14 Thread GitBox
raphaelauv edited a comment on pull request #17008: URL: https://github.com/apache/airflow/pull/17008#issuecomment-880252375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] raphaelauv commented on pull request #17008: FIX changelog provider docker 2.0.0

2021-07-14 Thread GitBox
raphaelauv commented on pull request #17008: URL: https://github.com/apache/airflow/pull/17008#issuecomment-880252375 Should I change the base branch to make this commit appear on https://airflow.apache.org/docs/apache-airflow-providers-docker/2.0.0/index.htmll -- This is an automated

[GitHub] [airflow] raphaelauv opened a new pull request #17008: FIX changelog provider docker 2.0.0

2021-07-14 Thread GitBox
raphaelauv opened a new pull request #17008: URL: https://github.com/apache/airflow/pull/17008 Since there is a regression in version 2.0.0 , the changelog that is directly show by the documentation ( and so the airflow website ) should let know people about. -- This is an automated

[GitHub] [airflow] mik-laj commented on issue #16952: Secrets Backend Search Path Ordering/Priority

2021-07-14 Thread GitBox
mik-laj commented on issue #16952: URL: https://github.com/apache/airflow/issues/16952#issuecomment-880246050 @kaxil WDYT? II like this idea, but I wonder if there was any assumption on the basis of which you chose the current order. -- This is an automated message from the Apache Git

[GitHub] [airflow] mik-laj commented on issue #16996: Private Image for KubernetesPodOperator XCOM Sidecar Container

2021-07-14 Thread GitBox
mik-laj commented on issue #16996: URL: https://github.com/apache/airflow/issues/16996#issuecomment-880245073 Duplicate: https://github.com/apache/airflow/issues/10605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] mik-laj closed issue #16996: Private Image for KubernetesPodOperator XCOM Sidecar Container

2021-07-14 Thread GitBox
mik-laj closed issue #16996: URL: https://github.com/apache/airflow/issues/16996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #16685: Allow attaching to previously launched task in ECSOperator

2021-07-14 Thread GitBox
github-actions[bot] commented on pull request #16685: URL: https://github.com/apache/airflow/pull/16685#issuecomment-880242336 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] raphaelauv edited a comment on pull request #16932: Adds option to disable mounting temporary folder in DockerOperator

2021-07-14 Thread GitBox
raphaelauv edited a comment on pull request #16932: URL: https://github.com/apache/airflow/pull/16932#issuecomment-880238711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] raphaelauv commented on pull request #16932: Adds option to disable mounting temporary folder in DockerOperator

2021-07-14 Thread GitBox
raphaelauv commented on pull request #16932: URL: https://github.com/apache/airflow/pull/16932#issuecomment-880238711 Since it's from 2.0.0 let's consider the mount of the tmp folder the default pattern and simply add an option to disable it in case of docker in docker I prefer to

[GitHub] [airflow] pmalafosse commented on pull request #16685: Allow attaching to previously launched task in ECSOperator

2021-07-14 Thread GitBox
pmalafosse commented on pull request #16685: URL: https://github.com/apache/airflow/pull/16685#issuecomment-880238325 Sorry there were some conflicts after the rebase that I hadn't fixed completely, fixed now (I ran pytest locally and it passed) @kaxil . -- This is an automated message

  1   2   3   4   >