[GitHub] [airflow] pritampbonde commented on issue #18091: Possible PyJWT dependency upgrade?

2021-09-21 Thread GitBox
pritampbonde commented on issue #18091: URL: https://github.com/apache/airflow/issues/18091#issuecomment-924581725 @potiuk : As per suggestion given have raise a new request but I found there is already one request one on similar lines

[GitHub] [airflow] r-richmond edited a comment on issue #18051: Airflow scheduling only 1 dag at a time leaving other dags in a queued state

2021-09-21 Thread GitBox
r-richmond edited a comment on issue #18051: URL: https://github.com/apache/airflow/issues/18051#issuecomment-924580052 Going to close this out since I assume #18061 tackled it and I'm on 2.1.4. now. If this issue presents itself again I'll re-open. Thanks again @ephraimbuddy

[GitHub] [airflow] r-richmond closed issue #18051: Airflow scheduling only 1 dag at a time leaving other dags in a queued state

2021-09-21 Thread GitBox
r-richmond closed issue #18051: URL: https://github.com/apache/airflow/issues/18051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] r-richmond commented on issue #18051: Airflow scheduling only 1 dag at a time leaving other dags in a queued state

2021-09-21 Thread GitBox
r-richmond commented on issue #18051: URL: https://github.com/apache/airflow/issues/18051#issuecomment-924580052 Going to close this out since I assume #18061 tackled it and I'm on 2.1.4. now. If this issue presents itself again I'll re-open. Thanks again @ephraimbuddy -- This

[GitHub] [airflow] uranusjr commented on a change in pull request #18226: Add start date to trigger_dagrun operator

2021-09-21 Thread GitBox
uranusjr commented on a change in pull request #18226: URL: https://github.com/apache/airflow/pull/18226#discussion_r713582288 ## File path: tests/operators/test_trigger_dagrun.py ## @@ -250,8 +250,36 @@ def test_trigger_dagrun_with_wait_for_completion_true_fail(self):

[GitHub] [airflow] uranusjr commented on pull request #18226: Add start date to trigger_dagrun operator

2021-09-21 Thread GitBox
uranusjr commented on pull request #18226: URL: https://github.com/apache/airflow/pull/18226#issuecomment-924573995 Failure seems unrelated ``` _ test_external_task_marker_exception __ dag_bag_ext = def

[GitHub] [airflow] uranusjr commented on a change in pull request #18309: task logs for dummy operators

2021-09-21 Thread GitBox
uranusjr commented on a change in pull request #18309: URL: https://github.com/apache/airflow/pull/18309#discussion_r713580537 ## File path: tests/utils/log/test_log_reader.py ## @@ -79,29 +81,66 @@ def configure_loggers(self, log_dir, settings_folder):

[GitHub] [airflow] uranusjr commented on pull request #18425: Installation Page

2021-09-21 Thread GitBox
uranusjr commented on pull request #18425: URL: https://github.com/apache/airflow/pull/18425#issuecomment-924564644 Your change does not match your PR description at all. Is there something wrong? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18425: Installation Page

2021-09-21 Thread GitBox
boring-cyborg[bot] commented on pull request #18425: URL: https://github.com/apache/airflow/pull/18425#issuecomment-924562811 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] DeathGun01 opened a new pull request #18425: Installation Page

2021-09-21 Thread GitBox
DeathGun01 opened a new pull request #18425: URL: https://github.com/apache/airflow/pull/18425 Briefly defining the installation options to be easily understood before the user dives in on any of them. Along with it, the documentation could use a lot more flowcharts or something

[GitHub] [airflow] uranusjr commented on pull request #18424: Delete extra space in adding connections doc

2021-09-21 Thread GitBox
uranusjr commented on pull request #18424: URL: https://github.com/apache/airflow/pull/18424#issuecomment-924561752 It’s probably better to change the entire block to indent by four spaces (it’s currently indented by three). This makes future changes easier. -- This is an automated

[GitHub] [airflow] uranusjr commented on a change in pull request #18042: Fixing ses email backend

2021-09-21 Thread GitBox
uranusjr commented on a change in pull request #18042: URL: https://github.com/apache/airflow/pull/18042#discussion_r713571942 ## File path: airflow/utils/email.py ## @@ -87,8 +91,10 @@ def send_email_smtp( """ smtp_mail_from = conf.get('smtp', 'SMTP_MAIL_FROM') +

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18424: Delete extra space in adding connections doc

2021-09-21 Thread GitBox
boring-cyborg[bot] commented on pull request #18424: URL: https://github.com/apache/airflow/pull/18424#issuecomment-924561121 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] GonzaloUlla opened a new pull request #18424: Delete extra space in adding connections doc

2021-09-21 Thread GitBox
GonzaloUlla opened a new pull request #18424: URL: https://github.com/apache/airflow/pull/18424 Extra space in secret keys was causing an error while parsing values.yaml Before this change, copying and pasting the example from the docs was causing: ```bash Error: failed to

[GitHub] [airflow] fredthomsen opened a new pull request #18423: Add Opus Interactive to INTHEWILD

2021-09-21 Thread GitBox
fredthomsen opened a new pull request #18423: URL: https://github.com/apache/airflow/pull/18423 Adds Opus Interactive to list of companies using Airflow. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] uranusjr commented on issue #18398: When clearing a successful Subdag, child tasks are not ran

2021-09-21 Thread GitBox
uranusjr commented on issue #18398: URL: https://github.com/apache/airflow/issues/18398#issuecomment-924545967 cc @ephraimbuddy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] uranusjr closed issue #18102: Snowflake provider not accepting private_key_file in extras

2021-09-21 Thread GitBox
uranusjr closed issue #18102: URL: https://github.com/apache/airflow/issues/18102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] yuanke7 opened a new issue #18422: No response from request api(longer than 30min) while using SimpleHttpOperator

2021-09-21 Thread GitBox
yuanke7 opened a new issue #18422: URL: https://github.com/apache/airflow/issues/18422 ### Apache Airflow version 2.1.2 ### Operating System CentOS Linux 7 ### Versions of Apache Airflow Providers apache-airflow-providers-amazon==2.0.0

[GitHub] [airflow] uranusjr commented on a change in pull request #18370: Properly fix dagrun update state endpoint

2021-09-21 Thread GitBox
uranusjr commented on a change in pull request #18370: URL: https://github.com/apache/airflow/pull/18370#discussion_r713535348 ## File path: tests/api_connexion/endpoints/test_dag_run_endpoint.py ## @@ -1162,16 +1162,19 @@ def test_should_raises_403_unauthorized(self):

[GitHub] [airflow] uranusjr commented on a change in pull request #18421: Correctly select DagRun.execution_date from db

2021-09-21 Thread GitBox
uranusjr commented on a change in pull request #18421: URL: https://github.com/apache/airflow/pull/18421#discussion_r713525205 ## File path: airflow/models/dag.py ## @@ -1269,8 +1269,8 @@ def get_task_instances_before( ``base_date``, or more if there are manual task

[GitHub] [airflow] uranusjr opened a new pull request #18421: Correctly select DagRun.execution_date from db

2021-09-21 Thread GitBox
uranusjr opened a new pull request #18421: URL: https://github.com/apache/airflow/pull/18421 Fix #3413. The importance of test coverage and type annotations… -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] uranusjr commented on a change in pull request #18418: Fix task instance url in webserver utils

2021-09-21 Thread GitBox
uranusjr commented on a change in pull request #18418: URL: https://github.com/apache/airflow/pull/18418#discussion_r713520604 ## File path: airflow/www/utils.py ## @@ -228,7 +228,7 @@ def task_instance_link(attr): dag_id = attr.get('dag_id') task_id =

[GitHub] [airflow] github-actions[bot] commented on pull request #18419: Fix ``docker-stack`` docs build

2021-09-21 Thread GitBox
github-actions[bot] commented on pull request #18419: URL: https://github.com/apache/airflow/pull/18419#issuecomment-924498839 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] jedcunningham closed pull request #18306: Chart: warn when webserver secret key isn't set

2021-09-21 Thread GitBox
jedcunningham closed pull request #18306: URL: https://github.com/apache/airflow/pull/18306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on a change in pull request #18420: Custom timetable must return aware datetimes

2021-09-21 Thread GitBox
uranusjr commented on a change in pull request #18420: URL: https://github.com/apache/airflow/pull/18420#discussion_r713508561 ## File path: airflow/utils/timezone.py ## @@ -176,11 +176,11 @@ def parse(string: str, timezone=None) -> DateTime: def coerce_datetime(v:

[GitHub] [airflow] uranusjr opened a new pull request #18420: Custom timetable must return aware datetimes

2021-09-21 Thread GitBox
uranusjr opened a new pull request #18420: URL: https://github.com/apache/airflow/pull/18420 The example included in the recent AIP-39 documentation change had a bug that returns naive datetime for runs scheduled after a Friday. This also fixes a bug in `coerce_datetime` that may

[GitHub] [airflow] alex-astronomer commented on issue #18217: Audit Logging for Variables, Connections, Pools

2021-09-21 Thread GitBox
alex-astronomer commented on issue #18217: URL: https://github.com/apache/airflow/issues/18217#issuecomment-924485066 Upon further consideration, I'd like to not use a SQLAlchemy event to make this happen. The way that we handle audit logging right now happens (from what I've seen)

[GitHub] [airflow] kazanzhy closed pull request #18394: Add hook_params in SqlSensor

2021-09-21 Thread GitBox
kazanzhy closed pull request #18394: URL: https://github.com/apache/airflow/pull/18394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch constraints-2-2 updated (17cff54 -> 60412d5)

2021-09-21 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch constraints-2-2 in repository https://gitbox.apache.org/repos/asf/airflow.git. from 17cff54 Update to latest source/no providers add 520291e Switch main to patched version of

[airflow] 01/01: Bump version to 2.2.0b2

2021-09-21 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 63b1c270cb09ff897702dafda28c59559f9e6080 Author: Jed Cunningham

[airflow] branch v2-2-test updated (e994d36 -> 63b1c27)

2021-09-21 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git. omit e994d36 Add 2.2.0b1 changelog omit faff793 Bump version to `2.2.0b1` add 4ee8f82 Allow users

[airflow] branch main updated (f74d0ab -> a5afd1b)

2021-09-21 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from f74d0ab Require can_edit on DAG privileges to modify TaskInstances and DagRuns (#16634) add a5afd1b

[GitHub] [airflow] jedcunningham merged pull request #18417: Update 2.2.0 changelog for b2

2021-09-21 Thread GitBox
jedcunningham merged pull request #18417: URL: https://github.com/apache/airflow/pull/18417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on pull request #18417: Update 2.2.0 changelog for b2

2021-09-21 Thread GitBox
jedcunningham commented on pull request #18417: URL: https://github.com/apache/airflow/pull/18417#issuecomment-924481855 Docs build failure is unrelated and will be fixed by #18419. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] jedcunningham opened a new pull request #18419: Fix ``docker-stack`` docs build

2021-09-21 Thread GitBox
jedcunningham opened a new pull request #18419: URL: https://github.com/apache/airflow/pull/18419 Missing newlines in the new pre-commit hook is causing the `docker-stack` docs build to fail: e.g: https://github.com/apache/airflow/pull/18417/checks?check_run_id=3669346986 ```

[GitHub] [airflow] github-actions[bot] commented on pull request #16498: gitpodify Apache Airflow - online development workspace

2021-09-21 Thread GitBox
github-actions[bot] commented on pull request #16498: URL: https://github.com/apache/airflow/pull/16498#issuecomment-924475513 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] commented on pull request #17354: Add Docker Sensor

2021-09-21 Thread GitBox
github-actions[bot] commented on pull request #17354: URL: https://github.com/apache/airflow/pull/17354#issuecomment-924475476 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] jedcunningham closed pull request #18417: Update 2.2.0 changelog for b2

2021-09-21 Thread GitBox
jedcunningham closed pull request #18417: URL: https://github.com/apache/airflow/pull/18417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ephraimbuddy opened a new pull request #18418: Fix task instance url in webserver utils

2021-09-21 Thread GitBox
ephraimbuddy opened a new pull request #18418: URL: https://github.com/apache/airflow/pull/18418 `execution_date` was omitted when generating the task instance URL. This PR fixes it --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] github-actions[bot] commented on pull request #18417: Update 2.2.0 changelog for b2

2021-09-21 Thread GitBox
github-actions[bot] commented on pull request #18417: URL: https://github.com/apache/airflow/pull/18417#issuecomment-924434477 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] jedcunningham commented on a change in pull request #18417: Update 2.2.0 changelog for b2

2021-09-21 Thread GitBox
jedcunningham commented on a change in pull request #18417: URL: https://github.com/apache/airflow/pull/18417#discussion_r713460021 ## File path: CHANGELOG.txt ## @@ -1,13 +1,20 @@ -Airflow 2.2.0b1, TBD +Airflow 2.2.0b2, TBD - New Features

[GitHub] [airflow] kaxil commented on a change in pull request #18417: Update 2.2.0 changelog for b2

2021-09-21 Thread GitBox
kaxil commented on a change in pull request #18417: URL: https://github.com/apache/airflow/pull/18417#discussion_r713457018 ## File path: CHANGELOG.txt ## @@ -119,6 +133,33 @@ Improvements Bug Fixes " +- Properly handle ti state difference between executor and

[GitHub] [airflow] maxcountryman commented on issue #13542: Task stuck in "scheduled" or "queued" state, pool has all slots queued, nothing is executing

2021-09-21 Thread GitBox
maxcountryman commented on issue #13542: URL: https://github.com/apache/airflow/issues/13542#issuecomment-924426797 @Jorricks thanks for your note--we'll do both 1. and 2. when this happens next. We're actually using the Celery executor with Redis; I don't see any weird resource

[GitHub] [airflow] andrewgodwin commented on issue #18392: TriggerEvent fires, and then defers a second time (doesn't fire a second time though).

2021-09-21 Thread GitBox
andrewgodwin commented on issue #18392: URL: https://github.com/apache/airflow/issues/18392#issuecomment-924416527 Yup, @MatrixManAtYrService and I discussed this yesterday. It's not a bad bug - triggers are designed to be re-entrant, and it won't resume the task twice - just something

[GitHub] [airflow] potiuk edited a comment on pull request #18382: Production-level support for MSSQL

2021-09-21 Thread GitBox
potiuk edited a comment on pull request #18382: URL: https://github.com/apache/airflow/pull/18382#issuecomment-924410641 > How much does this add to the docker images size btw? It increases the size of the image by 4MB - from 972 MB to 976 MB (~ 0.5%) See the discussion here:

[GitHub] [airflow] kazanzhy commented on a change in pull request #17592: Support for passing arguments to SqlSensor underlying hooks

2021-09-21 Thread GitBox
kazanzhy commented on a change in pull request #17592: URL: https://github.com/apache/airflow/pull/17592#discussion_r712553155 ## File path: tests/sensors/test_sql_sensor.py ## @@ -242,6 +242,22 @@ def test_sql_sensor_postgres_poke_invalid_success(self, mock_hook):

[GitHub] [airflow] potiuk commented on pull request #18382: Production-level support for MSSQL

2021-09-21 Thread GitBox
potiuk commented on pull request #18382: URL: https://github.com/apache/airflow/pull/18382#issuecomment-924410641 > How much does this add to the docker images size btw? It increases the size of the image by 4MB - from 972 to 976. See the discussion here:

[GitHub] [airflow] SamWheating commented on a change in pull request #18370: Properly fix dagrun update state endpoint

2021-09-21 Thread GitBox
SamWheating commented on a change in pull request #18370: URL: https://github.com/apache/airflow/pull/18370#discussion_r713422834 ## File path: airflow/api_connexion/endpoints/dag_run_endpoint.py ## @@ -302,6 +306,10 @@ def update_dag_run_state(dag_id: str, dag_run_id: str,

[GitHub] [airflow] SamWheating commented on a change in pull request #18370: Properly fix dagrun update state endpoint

2021-09-21 Thread GitBox
SamWheating commented on a change in pull request #18370: URL: https://github.com/apache/airflow/pull/18370#discussion_r713422834 ## File path: airflow/api_connexion/endpoints/dag_run_endpoint.py ## @@ -302,6 +306,10 @@ def update_dag_run_state(dag_id: str, dag_run_id: str,

[airflow] branch main updated: Require can_edit on DAG privileges to modify TaskInstances and DagRuns (#16634)

2021-09-21 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f74d0ab Require can_edit on DAG privileges

[GitHub] [airflow] jedcunningham merged pull request #16634: Require can_edit on DAG privileges to modify TaskInstances and DagRuns

2021-09-21 Thread GitBox
jedcunningham merged pull request #16634: URL: https://github.com/apache/airflow/pull/16634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] weiminmei commented on issue #18102: Snowflake provider not accepting private_key_file in extras

2021-09-21 Thread GitBox
weiminmei commented on issue #18102: URL: https://github.com/apache/airflow/issues/18102#issuecomment-924381869 Hi, On version 2.2.0b1, looks like this is addressed. ![Screen Shot 2021-09-21 at 4 02 55

[GitHub] [airflow] kimyen commented on issue #18317: Better Backfill User Experience

2021-09-21 Thread GitBox
kimyen commented on issue #18317: URL: https://github.com/apache/airflow/issues/18317#issuecomment-924377251 > What I'm after is a way to insert multiple dag-runs for historical dates in bulk from the UI, possibly with some tasks already marked as complete/skipped, as well as clearing

[GitHub] [airflow] Jorricks edited a comment on issue #13542: Task stuck in "scheduled" or "queued" state, pool has all slots queued, nothing is executing

2021-09-21 Thread GitBox
Jorricks edited a comment on issue #13542: URL: https://github.com/apache/airflow/issues/13542#issuecomment-924363913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] Jorricks commented on issue #13542: Task stuck in "scheduled" or "queued" state, pool has all slots queued, nothing is executing

2021-09-21 Thread GitBox
Jorricks commented on issue #13542: URL: https://github.com/apache/airflow/issues/13542#issuecomment-924363913 > We're continuing to see an issue in `2.1.3` where DAG tasks appear to be running for many hours, even days, but are making no visible progress. This situation persists through

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18370: Properly fix dagrun update state endpoint

2021-09-21 Thread GitBox
ephraimbuddy commented on a change in pull request #18370: URL: https://github.com/apache/airflow/pull/18370#discussion_r713396773 ## File path: airflow/api_connexion/endpoints/dag_run_endpoint.py ## @@ -302,6 +306,10 @@ def update_dag_run_state(dag_id: str, dag_run_id: str,

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18370: Properly fix dagrun update state endpoint

2021-09-21 Thread GitBox
ephraimbuddy commented on a change in pull request #18370: URL: https://github.com/apache/airflow/pull/18370#discussion_r713395912 ## File path: airflow/api_connexion/endpoints/dag_run_endpoint.py ## @@ -302,6 +306,10 @@ def update_dag_run_state(dag_id: str, dag_run_id: str,

[GitHub] [airflow] eladkal commented on a change in pull request #18413: Add/Update Snowflake SQL Operators

2021-09-21 Thread GitBox
eladkal commented on a change in pull request #18413: URL: https://github.com/apache/airflow/pull/18413#discussion_r713395104 ## File path: airflow/providers/snowflake/operators/snowflake.py ## @@ -409,3 +430,175 @@ def __init__( def get_db_hook(self) -> SnowflakeHook:

[GitHub] [airflow] eladkal commented on a change in pull request #18413: Add/Update Snowflake SQL Operators

2021-09-21 Thread GitBox
eladkal commented on a change in pull request #18413: URL: https://github.com/apache/airflow/pull/18413#discussion_r713395104 ## File path: airflow/providers/snowflake/operators/snowflake.py ## @@ -409,3 +430,175 @@ def __init__( def get_db_hook(self) -> SnowflakeHook:

[airflow] branch main updated (7808be7 -> eed2ef6)

2021-09-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 7808be7 Make Kubernetes job description fit on one log line (#18377) add eed2ef6 Explain scheduler fine-tuning

[GitHub] [airflow] potiuk merged pull request #18356: Explain scheduler fine-tuning better

2021-09-21 Thread GitBox
potiuk merged pull request #18356: URL: https://github.com/apache/airflow/pull/18356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] Jorricks commented on a change in pull request #16634: Require can_edit on DAG privileges to modify TaskInstances and DagRuns

2021-09-21 Thread GitBox
Jorricks commented on a change in pull request #16634: URL: https://github.com/apache/airflow/pull/16634#discussion_r713392948 ## File path: airflow/www/views.py ## @@ -3145,6 +3156,65 @@ class AirflowModelView(ModelView): CustomSQLAInterface =

[GitHub] [airflow] Jorricks commented on a change in pull request #16634: Require can_edit on DAG privileges to modify TaskInstances and DagRuns

2021-09-21 Thread GitBox
Jorricks commented on a change in pull request #16634: URL: https://github.com/apache/airflow/pull/16634#discussion_r713391890 ## File path: airflow/www/security.py ## @@ -520,6 +520,17 @@ def _has_perm(self, action_name, resource_name): self._get_and_cache_perms()

[airflow] branch main updated: Make Kubernetes job description fit on one log line (#18377)

2021-09-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7808be7 Make Kubernetes job description fit on

[GitHub] [airflow] kaxil merged pull request #18377: Make Kubernetes job description fit on one log line

2021-09-21 Thread GitBox
kaxil merged pull request #18377: URL: https://github.com/apache/airflow/pull/18377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil commented on pull request #17819: Properly handle ti state difference between executor and scheduler

2021-09-21 Thread GitBox
kaxil commented on pull request #17819: URL: https://github.com/apache/airflow/pull/17819#issuecomment-924351634 Well done @ephraimbuddy  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] branch main updated: Properly handle ti state difference between executor and scheduler (#17819)

2021-09-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 44f601e Properly handle ti state difference

[GitHub] [airflow] kaxil closed issue #16625: Task is not retried when worker pod fails to start

2021-09-21 Thread GitBox
kaxil closed issue #16625: URL: https://github.com/apache/airflow/issues/16625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil merged pull request #17819: Properly handle ti state difference between executor and scheduler

2021-09-21 Thread GitBox
kaxil merged pull request #17819: URL: https://github.com/apache/airflow/pull/17819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #17819: Properly handle ti state difference between executor and scheduler

2021-09-21 Thread GitBox
github-actions[bot] commented on pull request #17819: URL: https://github.com/apache/airflow/pull/17819#issuecomment-924334170 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] kaxil edited a comment on pull request #17819: Properly handle ti state difference between executor and scheduler

2021-09-21 Thread GitBox
kaxil edited a comment on pull request #17819: URL: https://github.com/apache/airflow/pull/17819#issuecomment-924333229 All the reviews have been addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] kaxil commented on pull request #17819: Properly handle ti state difference between executor and scheduler

2021-09-21 Thread GitBox
kaxil commented on pull request #17819: URL: https://github.com/apache/airflow/pull/17819#issuecomment-924333229 Addressed all the reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] branch main updated: Update boto3 to <1.19 (#18389)

2021-09-21 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5f07675 Update boto3 to <1.19 (#18389)

[GitHub] [airflow] mik-laj merged pull request #18389: update boto to latest version

2021-09-21 Thread GitBox
mik-laj merged pull request #18389: URL: https://github.com/apache/airflow/pull/18389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #18389: update boto to latest version

2021-09-21 Thread GitBox
github-actions[bot] commented on pull request #18389: URL: https://github.com/apache/airflow/pull/18389#issuecomment-924331435 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[airflow] branch main updated (a91d9a7 -> d4662ab)

2021-09-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from a91d9a7 Labels on job templates (#18403) add d4662ab Add ODBC extra for the production image (#18407) No new

[GitHub] [airflow] kaxil commented on a change in pull request #17819: Properly handle ti state difference between executor and scheduler

2021-09-21 Thread GitBox
kaxil commented on a change in pull request #17819: URL: https://github.com/apache/airflow/pull/17819#discussion_r713361445 ## File path: airflow/jobs/scheduler_job.py ## @@ -521,14 +521,24 @@ def _process_executor_events(self, session: Session = None) -> int:

[GitHub] [airflow] collinmcnulty opened a new pull request #18414: Change the color for deferred status to blueviolet

2021-09-21 Thread GitBox
collinmcnulty opened a new pull request #18414: URL: https://github.com/apache/airflow/pull/18414 Changes the color for the deferred status to something more distinct, blueviolet.

[GitHub] [airflow] potiuk merged pull request #18407: Add ODBC extra for the production image

2021-09-21 Thread GitBox
potiuk merged pull request #18407: URL: https://github.com/apache/airflow/pull/18407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] bbovenzi commented on a change in pull request #18405: Move tags filter cookie to frontend

2021-09-21 Thread GitBox
bbovenzi commented on a change in pull request #18405: URL: https://github.com/apache/airflow/pull/18405#discussion_r713348938 ## File path: airflow/www/static/js/dags.js ## @@ -37,6 +37,20 @@ const lastDagRunsUrl = getMetaValue('last_dag_runs_url'); const dagStatsUrl =

[GitHub] [airflow] bbovenzi commented on a change in pull request #18405: Move tags filter cookie to frontend

2021-09-21 Thread GitBox
bbovenzi commented on a change in pull request #18405: URL: https://github.com/apache/airflow/pull/18405#discussion_r713348938 ## File path: airflow/www/static/js/dags.js ## @@ -37,6 +37,20 @@ const lastDagRunsUrl = getMetaValue('last_dag_runs_url'); const dagStatsUrl =

[GitHub] [airflow] potiuk closed pull request #18104: Adding corresponding labels to pods created by jobs

2021-09-21 Thread GitBox
potiuk closed pull request #18104: URL: https://github.com/apache/airflow/pull/18104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #18104: Adding corresponding labels to pods created by jobs

2021-09-21 Thread GitBox
potiuk commented on pull request #18104: URL: https://github.com/apache/airflow/pull/18104#issuecomment-924272795 Closing this one as it was implemented in #18403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[airflow] branch main updated: Labels on job templates (#18403)

2021-09-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new a91d9a7 Labels on job templates (#18403) a91d9a7

[GitHub] [airflow] potiuk closed issue #18103: Helm Chart Jobs (apache-airflow-test-run-airflow-migrations) does not Pass Labels to Pod

2021-09-21 Thread GitBox
potiuk closed issue #18103: URL: https://github.com/apache/airflow/issues/18103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk merged pull request #18403: Labels on job templates

2021-09-21 Thread GitBox
potiuk merged pull request #18403: URL: https://github.com/apache/airflow/pull/18403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] collinmcnulty commented on issue #17559: Dag Import Error Hidden for existing dags leading to nondescriptive UI errors

2021-09-21 Thread GitBox
collinmcnulty commented on issue #17559: URL: https://github.com/apache/airflow/issues/17559#issuecomment-924259267 @ephraimbuddy Confirmed. Tested this on main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] potiuk closed issue #18253: Allow to write to task log from task policy

2021-09-21 Thread GitBox
potiuk closed issue #18253: URL: https://github.com/apache/airflow/issues/18253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] denimalpaca opened a new pull request #18413: Add/Update Snowflake SQL Operators

2021-09-21 Thread GitBox
denimalpaca opened a new pull request #18413: URL: https://github.com/apache/airflow/pull/18413 Add `SnowflakeThresholdOperator` and `BranchSnowflakeOperator` Two new operators are added for Snowflake to match the full suite of SQL Operators doing checks and branches. Slight updates

[GitHub] [airflow] potiuk commented on issue #18253: Allow to write to task log from task policy

2021-09-21 Thread GitBox
potiuk commented on issue #18253: URL: https://github.com/apache/airflow/issues/18253#issuecomment-924255102 As explained in #18402 I think in most cases you should not change values of the parameter but you should simply fail the Task if you see that it runs without the right parameter

[GitHub] [airflow] potiuk closed issue #18402: Allow to set execution_timeout default value in airflow.cfg

2021-09-21 Thread GitBox
potiuk closed issue #18402: URL: https://github.com/apache/airflow/issues/18402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #18402: Allow to set execution_timeout default value in airflow.cfg

2021-09-21 Thread GitBox
potiuk commented on issue #18402: URL: https://github.com/apache/airflow/issues/18402#issuecomment-924252379 This would be a backwards incompatible-change, and it is completely needed and one that could be easily might be overridden by default_args of the DAG - which I believe should be

[GitHub] [airflow] kurtqq commented on pull request #18389: update boto to latest version

2021-09-21 Thread GitBox
kurtqq commented on pull request #18389: URL: https://github.com/apache/airflow/pull/18389#issuecomment-924249506 @potiuk @mik-laj is something else needed for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] felipeangelimvieira commented on issue #17507: Task processes killed with WARNING - Recorded pid does not match the current pid

2021-09-21 Thread GitBox
felipeangelimvieira commented on issue #17507: URL: https://github.com/apache/airflow/issues/17507#issuecomment-924240160 @nmehraein I've updated to 2.1.4 but the problem still appears. This issue is related to #18041. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] eladkal commented on issue #18410: AirflowClusterPolicyViolation Overhaul - Pause DAG, Make it so that DAG cannot be unpaused, still shows in DAG list view but has tooltip saying wh

2021-09-21 Thread GitBox
eladkal commented on issue #18410: URL: https://github.com/apache/airflow/issues/18410#issuecomment-924235182 > I believe that a DAG should not be able to be run unless it adheres to the cluster policy. I agree but it seems a bit odd to me to mix paused/active to this. Say I

[GitHub] [airflow] mik-laj commented on a change in pull request #18407: Add ODBC extra for the production image

2021-09-21 Thread GitBox
mik-laj commented on a change in pull request #18407: URL: https://github.com/apache/airflow/pull/18407#discussion_r713293939 ## File path: scripts/ci/pre_commit/pre_commit_check_order_dockerfile_extras.py ## @@ -0,0 +1,73 @@ +#!/usr/bin/env python +# +# Licensed to the Apache

[GitHub] [airflow] potiuk commented on pull request #18407: Add ODBC extra for the production image

2021-09-21 Thread GitBox
potiuk commented on pull request #18407: URL: https://github.com/apache/airflow/pull/18407#issuecomment-924229754 Added extras to the docs :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on a change in pull request #18407: Add ODBC extra for the production image

2021-09-21 Thread GitBox
potiuk commented on a change in pull request #18407: URL: https://github.com/apache/airflow/pull/18407#discussion_r713290521 ## File path: scripts/ci/pre_commit/pre_commit_check_order_dockerfile_extras.py ## @@ -0,0 +1,73 @@ +#!/usr/bin/env python +# +# Licensed to the Apache

[GitHub] [airflow] mik-laj commented on a change in pull request #18407: Add ODBC extra for the production image

2021-09-21 Thread GitBox
mik-laj commented on a change in pull request #18407: URL: https://github.com/apache/airflow/pull/18407#discussion_r713287040 ## File path: scripts/ci/pre_commit/pre_commit_check_order_dockerfile_extras.py ## @@ -0,0 +1,73 @@ +#!/usr/bin/env python +# +# Licensed to the Apache

[GitHub] [airflow] mik-laj commented on a change in pull request #18407: Add ODBC extra for the production image

2021-09-21 Thread GitBox
mik-laj commented on a change in pull request #18407: URL: https://github.com/apache/airflow/pull/18407#discussion_r713287040 ## File path: scripts/ci/pre_commit/pre_commit_check_order_dockerfile_extras.py ## @@ -0,0 +1,73 @@ +#!/usr/bin/env python +# +# Licensed to the Apache

  1   2   3   >