[GitHub] [airflow] eladkal commented on issue #18921: Add query timeout as an argument in CassandraToGCSOperator

2021-10-12 Thread GitBox
eladkal commented on issue #18921: URL: https://github.com/apache/airflow/issues/18921#issuecomment-941947902 We probably need also to add support for timeout in the hook itself (for users who build custom operators on top of the hook)? -- This is an automated message from the Apache

[GitHub] [airflow] zkan opened a new pull request #18931: Add clear task menu on task instance view

2021-10-12 Thread GitBox
zkan opened a new pull request #18931: URL: https://github.com/apache/airflow/pull/18931 Related: #16986 Changes proposed in this PR: * Add a clear task menu on task instance view to save a few clicks --- **^ Add meaningful description above** Read

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18930: pinot operators guide #8194

2021-10-12 Thread GitBox
boring-cyborg[bot] commented on pull request #18930: URL: https://github.com/apache/airflow/pull/18930#issuecomment-941921101 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] sharon2719 opened a new pull request #18930: pinot operators guide #8194

2021-10-12 Thread GitBox
sharon2719 opened a new pull request #18930: URL: https://github.com/apache/airflow/pull/18930 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] dstandish opened a new pull request #18929: Do not require all extra params in salesforce hook

2021-10-12 Thread GitBox
dstandish opened a new pull request #18929: URL: https://github.com/apache/airflow/pull/18929 This is a small fixup for the salesforce hook. Previously, code used `extras["blah"] or None` instead of simply `extras.get("blah")`, which forces users to add each of these optional params

[GitHub] [airflow] jameslamb opened a new pull request #18928: Add more type hints to PodLauncher

2021-10-12 Thread GitBox
jameslamb opened a new pull request #18928: URL: https://github.com/apache/airflow/pull/18928 This PR proposes adding additional type hints on arguments and return values for methods in `airflow.providers.cncf.kubernetes.utils.PodLauncher` which currently don't have them. I hope

[GitHub] [airflow] asaf400 edited a comment on issue #18874: DockerOperator xcom is broken

2021-10-12 Thread GitBox
asaf400 edited a comment on issue #18874: URL: https://github.com/apache/airflow/issues/18874#issuecomment-941906832 I have confirmed the fix I suggested works in airflow 2.0.2, For my own use, I just overrode the 'DockerOperator' class, and it's '_run_image' function I'll now

[GitHub] [airflow] asaf400 edited a comment on issue #18874: DockerOperator xcom is broken

2021-10-12 Thread GitBox
asaf400 edited a comment on issue #18874: URL: https://github.com/apache/airflow/issues/18874#issuecomment-941906832 I have confirmed the fix I suggested works in airflow 2.0.2, For my own use, I just overrode the 'DockerOperator' class, and it's '_run_image' function I'll now

[GitHub] [airflow] asaf400 edited a comment on issue #18874: DockerOperator xcom is broken

2021-10-12 Thread GitBox
asaf400 edited a comment on issue #18874: URL: https://github.com/apache/airflow/issues/18874#issuecomment-941906832 I have confirmed the fix I suggested works in airflow 2.0.2, For my own use, I just overrode the 'DockerOperator' class, and it's '_run_image' function I'll now

[GitHub] [airflow] asaf400 edited a comment on issue #18874: DockerOperator xcom is broken

2021-10-12 Thread GitBox
asaf400 edited a comment on issue #18874: URL: https://github.com/apache/airflow/issues/18874#issuecomment-941906832 I have confirmed the fix I suggested works in airflow 2.0.2, For my own use, I just overrode the 'DockerOperator' class, and it's '_run_image' function I'll now

[GitHub] [airflow] asaf400 edited a comment on issue #18874: DockerOperator xcom is broken

2021-10-12 Thread GitBox
asaf400 edited a comment on issue #18874: URL: https://github.com/apache/airflow/issues/18874#issuecomment-941906832 I have confirmed the fix I suggested works in airflow 2.0.2, For my own use, I just overrode the 'DockerOperator' class, and it's '_run_image' function I'll now

[GitHub] [airflow] asaf400 commented on issue #18874: DockerOperator xcom is broken

2021-10-12 Thread GitBox
asaf400 commented on issue #18874: URL: https://github.com/apache/airflow/issues/18874#issuecomment-941906832 I have confirmed the fix I suggested works in airflow 2.0.2, For my own use, I just overrode the 'DockerOperator' class, and it's '_run_image' function I'll now start to

[airflow] branch main updated: Bump chart version to `1.3.0-dev` (#18919)

2021-10-12 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c4f5233 Bump chart version to `1.3.0-dev`

[GitHub] [airflow] jedcunningham merged pull request #18919: Bump chart version to `1.3.0-dev`

2021-10-12 Thread GitBox
jedcunningham merged pull request #18919: URL: https://github.com/apache/airflow/pull/18919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on a change in pull request #18926: Check python version before starting triggerer

2021-10-12 Thread GitBox
jedcunningham commented on a change in pull request #18926: URL: https://github.com/apache/airflow/pull/18926#discussion_r727685785 ## File path: airflow/cli/cli_parser.py ## @@ -73,6 +73,12 @@ def _check_value(self, action, value): "To do it, run: pip

[GitHub] [airflow] josh-fell commented on pull request #18562: Updating core example DAGs to use TaskFlow API where applicable

2021-10-12 Thread GitBox
josh-fell commented on pull request #18562: URL: https://github.com/apache/airflow/pull/18562#issuecomment-941845645 Rebasing. Looks like #18853 fixes the failing `tests/sensors/test_external_task_sensor.py` test for Postgres13, Py3.8. -- This is an automated message from the Apache

[GitHub] [airflow] edwardwang888 commented on pull request #18866: Display current date and seconds in the UI clock

2021-10-12 Thread GitBox
edwardwang888 commented on pull request #18866: URL: https://github.com/apache/airflow/pull/18866#issuecomment-941797477 Thanks for the feedback. On further thought, I think the timestamp is based on local computer time, so having the seconds isn't all that accurate anyways. I would

[GitHub] [airflow] xuan616 commented on pull request #18927: Support query timeout as an argument in CassandraToGCSOperator

2021-10-12 Thread GitBox
xuan616 commented on pull request #18927: URL: https://github.com/apache/airflow/pull/18927#issuecomment-941793980 thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] xuan616 commented on a change in pull request #18927: Support query timeout as an argument in CassandraToGCSOperator

2021-10-12 Thread GitBox
xuan616 commented on a change in pull request #18927: URL: https://github.com/apache/airflow/pull/18927#discussion_r727608247 ## File path: airflow/providers/google/cloud/transfers/cassandra_to_gcs.py ## @@ -84,6 +87,10 @@ class CassandraToGCSOperator(BaseOperator):

[GitHub] [airflow] uranusjr commented on a change in pull request #18927: Support query timeout as an argument in CassandraToGCSOperator

2021-10-12 Thread GitBox
uranusjr commented on a change in pull request #18927: URL: https://github.com/apache/airflow/pull/18927#discussion_r727590968 ## File path: airflow/providers/google/cloud/transfers/cassandra_to_gcs.py ## @@ -110,6 +117,7 @@ def __init__( google_cloud_storage_conn_id:

[GitHub] [airflow] xuan616 opened a new pull request #18927: Support query timeout as an argument in CassandraToGCSOperator

2021-10-12 Thread GitBox
xuan616 opened a new pull request #18927: URL: https://github.com/apache/airflow/pull/18927 Related issue: #18921 - Add query_timeout as an argument in CassandraToGCSOperator constructor - Support query execution with a timeout parameter --- **^ Add meaningful

[GitHub] [airflow] mik-laj commented on issue #18925: Add template_ext = ('.json') to databricks operators

2021-10-12 Thread GitBox
mik-laj commented on issue #18925: URL: https://github.com/apache/airflow/issues/18925#issuecomment-941739050 > If you create pull-request, you don't have to create an issue first, but if you want, you can do it. Creating an issue will allow you to collect feedback or share plans with

[GitHub] [airflow] mik-laj commented on a change in pull request #18926: Check python version before starting triggerer

2021-10-12 Thread GitBox
mik-laj commented on a change in pull request #18926: URL: https://github.com/apache/airflow/pull/18926#discussion_r727578230 ## File path: airflow/cli/cli_parser.py ## @@ -73,6 +73,12 @@ def _check_value(self, action, value): "To do it, run: pip install

[GitHub] [airflow] mik-laj commented on a change in pull request #18926: Check python version before starting triggerer

2021-10-12 Thread GitBox
mik-laj commented on a change in pull request #18926: URL: https://github.com/apache/airflow/pull/18926#discussion_r727578230 ## File path: airflow/cli/cli_parser.py ## @@ -73,6 +73,12 @@ def _check_value(self, action, value): "To do it, run: pip install

[GitHub] [airflow] andrewgodwin commented on pull request #18926: Check python version before starting triggerer

2021-10-12 Thread GitBox
andrewgodwin commented on pull request #18926: URL: https://github.com/apache/airflow/pull/18926#issuecomment-941736300 I thought our import error in `utils.asyncio` errored out early enough, but this *is* nicer :) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] uranusjr commented on pull request #18875: Add explicit session parameter in PoolSlotsAvailableDep

2021-10-12 Thread GitBox
uranusjr commented on pull request #18875: URL: https://github.com/apache/airflow/pull/18875#issuecomment-941732893 If you're just curious, try changing the expected query count in the test against main and see what `assert_queries_count` reports  But less query is always good so that

[GitHub] [airflow] SamWheating commented on pull request #18924: Adding search parameter to the /dags endpoint

2021-10-12 Thread GitBox
SamWheating commented on pull request #18924: URL: https://github.com/apache/airflow/pull/18924#issuecomment-941718102 Since the search term is passed directly into `ilike()` it can use wildcards, so maybe we should call it something like `dag_id_pattern` or `search_pattern`? -- This

[GitHub] [airflow] jedcunningham opened a new pull request #18926: Check python version before starting triggerer

2021-10-12 Thread GitBox
jedcunningham opened a new pull request #18926: URL: https://github.com/apache/airflow/pull/18926 The triggerer requires Python 3.7+. cc: @andrewgodwin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] uranusjr commented on pull request #18924: Adding search parameter to the /dags endpoint

2021-10-12 Thread GitBox
uranusjr commented on pull request #18924: URL: https://github.com/apache/airflow/pull/18924#issuecomment-941710663 My Django root tells me to choose `dag_id__contains` but I understand it's not a universally loved approash :p -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] SamWheating edited a comment on pull request #18924: Adding search parameter to the /dags endpoint

2021-10-12 Thread GitBox
SamWheating edited a comment on pull request #18924: URL: https://github.com/apache/airflow/pull/18924#issuecomment-941706608 > what's wrong with fetching the entire list and filter yourself This is totally possible (and what we're doing currently), but it feels pretty inefficient

[GitHub] [airflow] SamWheating edited a comment on pull request #18924: Adding search parameter to the /dags endpoint

2021-10-12 Thread GitBox
SamWheating edited a comment on pull request #18924: URL: https://github.com/apache/airflow/pull/18924#issuecomment-941706608 > what's wrong with fetching the entire list and filter yourself This is totally possible (and what we're doing currently), but it feels pretty inefficient

[GitHub] [airflow] SamWheating commented on pull request #18924: Adding search parameter to the /dags endpoint

2021-10-12 Thread GitBox
SamWheating commented on pull request #18924: URL: https://github.com/apache/airflow/pull/18924#issuecomment-941706608 > what's wrong with fetching the entire list and filter yourself This is totally possible (and what we're doing currently), but it feels pretty inefficient when we

[GitHub] [airflow] uranusjr commented on issue #18925: Add template_ext = ('.json') to databricks operators

2021-10-12 Thread GitBox
uranusjr commented on issue #18925: URL: https://github.com/apache/airflow/issues/18925#issuecomment-941703559 Go ahead  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] celoibarros opened a new issue #18925: Add template_ext = ('.json') to databricks operators

2021-10-12 Thread GitBox
celoibarros opened a new issue #18925: URL: https://github.com/apache/airflow/issues/18925 ### Description Add template_ext = ('.json') in databricks operators. I will improve the debug and the way to organize parameters. ### Use case/motivation Bigger parameters on

[GitHub] [airflow] boring-cyborg[bot] commented on issue #18925: Add template_ext = ('.json') to databricks operators

2021-10-12 Thread GitBox
boring-cyborg[bot] commented on issue #18925: URL: https://github.com/apache/airflow/issues/18925#issuecomment-941695216 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] uranusjr commented on pull request #18924: Adding search parameter to the /dags endpoint

2021-10-12 Thread GitBox
uranusjr commented on pull request #18924: URL: https://github.com/apache/airflow/pull/18924#issuecomment-941688196 Not objecting to the idea (although what's wrong with fetching the entire list and filter yourself?) but I feel `search` is not a particularly good name for this. -- This

[GitHub] [airflow] josh-fell opened a new pull request #18562: Updating core example DAGs to use TaskFlow API where applicable

2021-10-12 Thread GitBox
josh-fell opened a new pull request #18562: URL: https://github.com/apache/airflow/pull/18562 Related: #9415 This PR aims to replace the use of `PythonOperator` and `PythonVirtualEnvOperator` tasks for the TaskFlow API in several core example DAGs. Additionally, there are

[GitHub] [airflow] uranusjr closed pull request #18562: Updating core example DAGs to use TaskFlow API where applicable

2021-10-12 Thread GitBox
uranusjr closed pull request #18562: URL: https://github.com/apache/airflow/pull/18562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] SamWheating commented on a change in pull request #18924: Adding search parameter to the /dags endpoint

2021-10-12 Thread GitBox
SamWheating commented on a change in pull request #18924: URL: https://github.com/apache/airflow/pull/18924#discussion_r727556838 ## File path: airflow/api_connexion/endpoints/dag_endpoint.py ## @@ -60,13 +60,16 @@ def get_dag_details(dag_id):

[GitHub] [airflow] SamWheating opened a new pull request #18924: Adding search parameter to the /dags endpoint

2021-10-12 Thread GitBox
SamWheating opened a new pull request #18924: URL: https://github.com/apache/airflow/pull/18924 One of the issues we run into when developing tools on top of the Airflow API is wanting to get just a subset of DAGs (typically all of the jobs relating to a particular service or data

[GitHub] [airflow] coinzerge commented on pull request #18622: Use seconds for schedule_delay metric

2021-10-12 Thread GitBox
coinzerge commented on pull request #18622: URL: https://github.com/apache/airflow/pull/18622#issuecomment-941660710 what's not right? total_seconds returns a float. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] uranusjr edited a comment on issue #17689: Set up multiple Airflow instances under the same domain with different sessions

2021-10-12 Thread GitBox
uranusjr edited a comment on issue #17689: URL: https://github.com/apache/airflow/issues/17689#issuecomment-940908158 The cookies are natively separated by domain, so this is the natural behaviour for sites configured like this. It is theoratically possible to manually prefix all the

[GitHub] [airflow] uranusjr edited a comment on issue #17689: Set up multiple Airflow instances under the same domain with different sessions

2021-10-12 Thread GitBox
uranusjr edited a comment on issue #17689: URL: https://github.com/apache/airflow/issues/17689#issuecomment-940908158 The cookies are natively separated by domain, so this is the natural behaviour for sites configured like this. It is theoratically possible to manually prefix all the

[GitHub] [airflow] uranusjr commented on issue #17413: Clicking the "Update" button in the "Tree View" of the DAG deletes the DAG runs from UI

2021-10-12 Thread GitBox
uranusjr commented on issue #17413: URL: https://github.com/apache/airflow/issues/17413#issuecomment-941641096 I wonder why that's the case. `get_latest_execution_date` simply fetches the `execution_date` from the database, which *should* match the value in the dropdown... Do we do

[GitHub] [airflow] uranusjr commented on pull request #18755: MySQLToS3Operator add support for parquet format

2021-10-12 Thread GitBox
uranusjr commented on pull request #18755: URL: https://github.com/apache/airflow/pull/18755#issuecomment-941635373 You can import it from `typing_extensions` instead. Try searching the code base, I think there are a couple of examples in other providers available. -- This is an

[GitHub] [airflow] uranusjr edited a comment on issue #18894: Migrate from 2.1.4 to 2.2.0

2021-10-12 Thread GitBox
uranusjr edited a comment on issue #18894: URL: https://github.com/apache/airflow/issues/18894#issuecomment-941632056 Also I'd be interested if you have ever deleted any DAG runs from the web UI (or if you can identify any of the `execution_date` values in `task_instance` and `task_fail`

[GitHub] [airflow] uranusjr commented on issue #18894: Migrate from 2.1.4 to 2.2.0

2021-10-12 Thread GitBox
uranusjr commented on issue #18894: URL: https://github.com/apache/airflow/issues/18894#issuecomment-941632056 Also I'd be interested if you have ever deleted any DAG runs from the web UI (or if you can identify any of the `execution_date` values in `task_instance` correspond to those DAG

[GitHub] [airflow] uranusjr commented on a change in pull request #18675: New Tree View

2021-10-12 Thread GitBox
uranusjr commented on a change in pull request #18675: URL: https://github.com/apache/airflow/pull/18675#discussion_r727534778 ## File path: airflow/www/static/js/tree/useTreeData.js ## @@ -0,0 +1,79 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [airflow] uranusjr commented on a change in pull request #18675: New Tree View

2021-10-12 Thread GitBox
uranusjr commented on a change in pull request #18675: URL: https://github.com/apache/airflow/pull/18675#discussion_r727529032 ## File path: airflow/www/views.py ## @@ -219,6 +219,82 @@ def get_date_time_num_runs_dag_runs_form_data(www_request, session, dag): } +def

[GitHub] [airflow] potiuk closed pull request #18922: Switch default version of Python to 3.7

2021-10-12 Thread GitBox
potiuk closed pull request #18922: URL: https://github.com/apache/airflow/pull/18922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (c8b86e6 -> a59775b)

2021-10-12 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from c8b86e6 Add more information to PodLauncher timeout error (#17953) add a59775b Revert "Fix --github-image-id

[GitHub] [airflow] potiuk closed pull request #18914: documentation grammar check - remove a word

2021-10-12 Thread GitBox
potiuk closed pull request #18914: URL: https://github.com/apache/airflow/pull/18914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk merged pull request #18923: Revert "Fix --github-image-id flag for Breeze (#18882)"

2021-10-12 Thread GitBox
potiuk merged pull request #18923: URL: https://github.com/apache/airflow/pull/18923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk opened a new pull request #18923: Revert "Fix --github-image-id flag for Breeze (#18882)"

2021-10-12 Thread GitBox
potiuk opened a new pull request #18923: URL: https://github.com/apache/airflow/pull/18923 This reverts commit ce0b64e895a247fde9d177a044ba16b1b99a9596. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] potiuk commented on pull request #18920: Chart: Use python 3.7 by default; support disabling triggerer

2021-10-12 Thread GitBox
potiuk commented on pull request #18920: URL: https://github.com/apache/airflow/pull/18920#issuecomment-941593301 Counterpart here : https://github.com/apache/airflow/pull/18922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk opened a new pull request #18922: Switch default version of Python to 3.7

2021-10-12 Thread GitBox
potiuk opened a new pull request #18922: URL: https://github.com/apache/airflow/pull/18922 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] uranusjr commented on a change in pull request #18915: Add custom entrypoint documentation

2021-10-12 Thread GitBox
uranusjr commented on a change in pull request #18915: URL: https://github.com/apache/airflow/pull/18915#discussion_r727516599 ## File path: docs/docker-stack/entrypoint.rst ## @@ -194,6 +194,27 @@ If there are any other arguments - they are simply passed to the "airflow"

[GitHub] [airflow] uranusjr commented on issue #18921: Add query timeout as an argument in CassandraToGCSOperator

2021-10-12 Thread GitBox
uranusjr commented on issue #18921: URL: https://github.com/apache/airflow/issues/18921#issuecomment-941589700 Assigned. Feel free to submit the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] xuan616 opened a new issue #18921: Add query timeout as an argument in CassandraToGCSOperator

2021-10-12 Thread GitBox
xuan616 opened a new issue #18921: URL: https://github.com/apache/airflow/issues/18921 ### Description In the current [CassandraToGCSOperator](https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/transfers/cassandra_to_gcs.py#L40),

[GitHub] [airflow] uranusjr commented on a change in pull request #18916: Add role export/import to cli tools

2021-10-12 Thread GitBox
uranusjr commented on a change in pull request #18916: URL: https://github.com/apache/airflow/pull/18916#discussion_r727511440 ## File path: airflow/cli/commands/role_command.py ## @@ -42,3 +44,43 @@ def roles_create(args): for role_name in args.role:

[GitHub] [airflow] jedcunningham commented on pull request #17953: add more information to PodLauncher timeout error

2021-10-12 Thread GitBox
jedcunningham commented on pull request #17953: URL: https://github.com/apache/airflow/pull/17953#issuecomment-941582292 Thanks @jameslamb, congrats on your second commit  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[airflow] branch main updated: Add more information to PodLauncher timeout error (#17953)

2021-10-12 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c8b86e6 Add more information to

[GitHub] [airflow] jedcunningham merged pull request #17953: add more information to PodLauncher timeout error

2021-10-12 Thread GitBox
jedcunningham merged pull request #17953: URL: https://github.com/apache/airflow/pull/17953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #18920: Chart: Use python 3.7 by default; support disabling triggerer

2021-10-12 Thread GitBox
github-actions[bot] commented on pull request #18920: URL: https://github.com/apache/airflow/pull/18920#issuecomment-941572093 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] jedcunningham opened a new pull request #18920: Chart: Use python 3.7 by default; support disabling triggerer

2021-10-12 Thread GitBox
jedcunningham opened a new pull request #18920: URL: https://github.com/apache/airflow/pull/18920 The triggerer is only supported in Python 3.7, so use that as the default image. For users who do not want to update Python versions, allow the triggerer component to be disabled. --

[GitHub] [airflow] Acehaidrey closed pull request #18916: Add role export/import to cli tools

2021-10-12 Thread GitBox
Acehaidrey closed pull request #18916: URL: https://github.com/apache/airflow/pull/18916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Add information about keepalives for managed Postgres (#18850)

2021-10-12 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f22c834 Add information about keepalives for

[GitHub] [airflow] potiuk merged pull request #18850: Add information about keepalives for managed Postgres

2021-10-12 Thread GitBox
potiuk merged pull request #18850: URL: https://github.com/apache/airflow/pull/18850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed pull request #18916: Add role export/import to cli tools

2021-10-12 Thread GitBox
potiuk closed pull request #18916: URL: https://github.com/apache/airflow/pull/18916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #18850: Add information about keepalives for managed Postgres

2021-10-12 Thread GitBox
github-actions[bot] commented on pull request #18850: URL: https://github.com/apache/airflow/pull/18850#issuecomment-941531993 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] potiuk closed pull request #18635: Forces log lines to be printed as single-line logs by default

2021-10-12 Thread GitBox
potiuk closed pull request #18635: URL: https://github.com/apache/airflow/pull/18635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #18850: Add information about keepalives for managed Postgres

2021-10-12 Thread GitBox
potiuk commented on pull request #18850: URL: https://github.com/apache/airflow/pull/18850#issuecomment-941499940 Shall we merge :) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk closed pull request #18915: Add custom entrypoint documentation

2021-10-12 Thread GitBox
potiuk closed pull request #18915: URL: https://github.com/apache/airflow/pull/18915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] leonsmith edited a comment on issue #18894: Migrate from 2.1.4 to 2.2.0

2021-10-12 Thread GitBox
leonsmith edited a comment on issue #18894: URL: https://github.com/apache/airflow/issues/18894#issuecomment-941325572 SQL we used from our deployment playbook to clean up these tables Obviously a disclaimer on running this blindly. Validate its rows you can safely remove first by

[GitHub] [airflow] potiuk commented on a change in pull request #18915: Add custom entrypoint documentation

2021-10-12 Thread GitBox
potiuk commented on a change in pull request #18915: URL: https://github.com/apache/airflow/pull/18915#discussion_r727480731 ## File path: docs/docker-stack/entrypoint.rst ## @@ -194,6 +194,27 @@ If there are any other arguments - they are simply passed to the "airflow" comma

[GitHub] [airflow] avkirilishin commented on pull request #18875: Add explicit session parameter in PoolSlotsAvailableDep

2021-10-12 Thread GitBox
avkirilishin commented on pull request #18875: URL: https://github.com/apache/airflow/pull/18875#issuecomment-941491678 I reduced the number of queries in the test. Why are two excluded instead of one? First - implicit COMMIT (expected). Second - SELECT in new session (`SELECT ...

[GitHub] [airflow] mik-laj commented on a change in pull request #18915: Add custom entrypoint documentation

2021-10-12 Thread GitBox
mik-laj commented on a change in pull request #18915: URL: https://github.com/apache/airflow/pull/18915#discussion_r727476558 ## File path: docs/docker-stack/entrypoint.rst ## @@ -194,6 +194,27 @@ If there are any other arguments - they are simply passed to the "airflow"

[GitHub] [airflow] mik-laj commented on a change in pull request #18915: Add custom entrypoint documentation

2021-10-12 Thread GitBox
mik-laj commented on a change in pull request #18915: URL: https://github.com/apache/airflow/pull/18915#discussion_r727475627 ## File path: docs/docker-stack/entrypoint.rst ## @@ -194,6 +194,27 @@ If there are any other arguments - they are simply passed to the "airflow"

[GitHub] [airflow] github-actions[bot] commented on pull request #18919: Bump chart version to `1.3.0-dev`

2021-10-12 Thread GitBox
github-actions[bot] commented on pull request #18919: URL: https://github.com/apache/airflow/pull/18919#issuecomment-941470907 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] jedcunningham opened a new pull request #18919: Bump chart version to `1.3.0-dev`

2021-10-12 Thread GitBox
jedcunningham opened a new pull request #18919: URL: https://github.com/apache/airflow/pull/18919 Now that `1.2.0` has been released, time to bump the chart version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] jedcunningham commented on issue #18894: Migrate from 2.1.4 to 2.2.0

2021-10-12 Thread GitBox
jedcunningham commented on issue #18894: URL: https://github.com/apache/airflow/issues/18894#issuecomment-941446073 @sbialkowski-pixel @RenGeng, thanks! Would either of you happen to have an example `execution_date` from one of those task_instance rows (or better yet a couple)? Mostly

[GitHub] [airflow] gigatexal closed pull request #18800: Make the salesforce connection initiation more robust

2021-10-12 Thread GitBox
gigatexal closed pull request #18800: URL: https://github.com/apache/airflow/pull/18800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] RenGeng commented on issue #18894: Migrate from 2.1.4 to 2.2.0

2021-10-12 Thread GitBox
RenGeng commented on issue #18894: URL: https://github.com/apache/airflow/issues/18894#issuecomment-941387303 We've started using airflow one year ago with 1.10 and then updated to every new version when there is a release -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] sbialkowski-pixel commented on issue #18894: Migrate from 2.1.4 to 2.2.0

2021-10-12 Thread GitBox
sbialkowski-pixel commented on issue #18894: URL: https://github.com/apache/airflow/issues/18894#issuecomment-941369344 I've started from 2.1.2 Then upgrade to 2.1.4 and now 2.2.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] potiuk commented on issue #18894: Migrate from 2.1.4 to 2.2.0

2021-10-12 Thread GitBox
potiuk commented on issue #18894: URL: https://github.com/apache/airflow/issues/18894#issuecomment-941360717 How old your databases were @RenGeng @sbialkowski-pixel ? Did you upgrade to Airflow 2 from 1.10 before ? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] leonsmith edited a comment on issue #18894: Migrate from 2.1.4 to 2.2.0

2021-10-12 Thread GitBox
leonsmith edited a comment on issue #18894: URL: https://github.com/apache/airflow/issues/18894#issuecomment-941325572 SQL we used from our deployment playbook to clean up these tables Obviously a disclaimer on running this blindly. Validate its rows you can safely remove first by

[GitHub] [airflow] leonsmith edited a comment on issue #18894: Migrate from 2.1.4 to 2.2.0

2021-10-12 Thread GitBox
leonsmith edited a comment on issue #18894: URL: https://github.com/apache/airflow/issues/18894#issuecomment-941325572 SQL we used from our deployment playbook to clean up these tables Obviously a disclaimer on running this blindly. Validate its rows you can safely remove first by

[GitHub] [airflow] uranusjr edited a comment on issue #18894: Migrate from 2.1.4 to 2.2.0

2021-10-12 Thread GitBox
uranusjr edited a comment on issue #18894: URL: https://github.com/apache/airflow/issues/18894#issuecomment-941336577 Might also want to remove DAG runs with NULL execution date, I think 2.2 also started enforcing those (and I think their existence might mess up some clauses in the SQL

[GitHub] [airflow] uranusjr commented on issue #18894: Migrate from 2.1.4 to 2.2.0

2021-10-12 Thread GitBox
uranusjr commented on issue #18894: URL: https://github.com/apache/airflow/issues/18894#issuecomment-941336577 Might also want to remove DAG runs with NULL and execution date, I think 2.2 also started enforcing those (and I think their existence might mess up some clauses in the SQL

[GitHub] [airflow] MatrixManAtYrService opened a new issue #18918: Manual execution of future dated dag succeeds, but none of the tasks actually run

2021-10-12 Thread GitBox
MatrixManAtYrService opened a new issue #18918: URL: https://github.com/apache/airflow/issues/18918 ### Apache Airflow version 2.2.0 (latest released) ### Operating System Debian Buster (in docker) ### Versions of Apache Airflow Providers n/a ###

[GitHub] [airflow] leonsmith edited a comment on issue #18894: Migrate from 2.1.4 to 2.2.0

2021-10-12 Thread GitBox
leonsmith edited a comment on issue #18894: URL: https://github.com/apache/airflow/issues/18894#issuecomment-941325572 SQL we used from our deployment playbook to clean up these tables Obviously a disclaimer on running this blindly. Validate its rows you can safely remove first by

[GitHub] [airflow] leonsmith commented on issue #18894: Migrate from 2.1.4 to 2.2.0

2021-10-12 Thread GitBox
leonsmith commented on issue #18894: URL: https://github.com/apache/airflow/issues/18894#issuecomment-941325572 SQL we used from our deployment playbook to clean up these tables ```sql BEGIN; -- Remove dag runs without a valid run_id DELETE FROM dag_run WHERE run_id is

[GitHub] [airflow] dimon222 edited a comment on issue #8212: Can't read S3 remote logs when using gevent/eventlent webserver workers.

2021-10-12 Thread GitBox
dimon222 edited a comment on issue #8212: URL: https://github.com/apache/airflow/issues/8212#issuecomment-914353201 If anyone pops on this issue, I wanted to mention that as of 2.1.3 the issue is still present, and solution that still works is prepending this: ```python from gevent

[GitHub] [airflow] mik-laj commented on issue #18913: Better "recipe" for image with gcloud

2021-10-12 Thread GitBox
mik-laj commented on issue #18913: URL: https://github.com/apache/airflow/issues/18913#issuecomment-941317784 We can still delete a few unnecessary files. ``` && rm -rf "/root/.config/gcloud/logs/" \ && find "$(python -c 'import sys; print(sys.prefix);')" -regex

[GitHub] [airflow] potiuk commented on issue #18917: Document xcom clearing behaviour on task retries

2021-10-12 Thread GitBox
potiuk commented on issue #18917: URL: https://github.com/apache/airflow/issues/18917#issuecomment-941316313 > I'm going to re-open this as a "we should document the behaviour". Yep. Completely right! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ashb commented on issue #18917: `xcom_pull` in task retry doesn't see value pushed during initial try

2021-10-12 Thread GitBox
ashb commented on issue #18917: URL: https://github.com/apache/airflow/issues/18917#issuecomment-941306984 I have memories of another issue about this (making it an option or something like that) but I can't find it right now. I'm going to re-open this as a "we should document the

[GitHub] [airflow] potiuk edited a comment on issue #18917: `xcom_pull` in task retry doesn't see value pushed during initial try

2021-10-12 Thread GitBox
potiuk edited a comment on issue #18917: URL: https://github.com/apache/airflow/issues/18917#issuecomment-941304995 This is expected behaviour. When task is retried, XCom is cleaned (just before retry is executed) in order to maintain "idempotent" behaviour. If you want to keep "state"

[GitHub] [airflow] potiuk commented on issue #18917: `xcom_pull` in task retry doesn't see value pushed during initial try

2021-10-12 Thread GitBox
potiuk commented on issue #18917: URL: https://github.com/apache/airflow/issues/18917#issuecomment-941304995 This is expected behaviour. When task is retried, XCom is cleaned in order to maintain "idempotent" behaviour. If you want to keep "state" from the first try you need to keep it

[GitHub] [airflow] potiuk closed issue #18917: `xcom_pull` in task retry doesn't see value pushed during initial try

2021-10-12 Thread GitBox
potiuk closed issue #18917: URL: https://github.com/apache/airflow/issues/18917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] MatrixManAtYrService opened a new issue #18917: `xcom_pull` in task retry doesn't see value pushed during initial try

2021-10-12 Thread GitBox
MatrixManAtYrService opened a new issue #18917: URL: https://github.com/apache/airflow/issues/18917 ### Apache Airflow version 2.2.0 (latest released) ### Operating System Debian Buster (in Docker) ### Versions of Apache Airflow Providers n/a ###

  1   2   3   >