[GitHub] [airflow] harishkrao commented on issue #20032: Snowflake Provider - Hook's support for not providing a region is broken when using SQLAlchemy

2021-12-07 Thread GitBox
harishkrao commented on issue #20032: URL: https://github.com/apache/airflow/issues/20032#issuecomment-988575520 @mik-laj I have made the change, I have a question on the unit tests. They are failing because the connection sends the region name. Do you have a suggestion on how to test

[GitHub] [airflow] Bowrna commented on pull request #20066: Rewrite Breeze setup autocomplete

2021-12-07 Thread GitBox
Bowrna commented on pull request #20066: URL: https://github.com/apache/airflow/pull/20066#issuecomment-988574897 I face static check issues in shell check. But the shell files I have committed is the autogenerated one by python click. How could this issue be handled? -- This is an

[GitHub] [airflow] huxuan opened a new issue #20127: WARNING - Access is Denied for: can_read on: CustomUserOAuthModelView

2021-12-07 Thread GitBox
huxuan opened a new issue #20127: URL: https://github.com/apache/airflow/issues/20127 ### Apache Airflow version 2.2.2 (latest released) ### What happened After configuring `AUTH_OAUTH`, everything looks good except that Role `User` and `Viewer` can not access "Your

[GitHub] [airflow] uranusjr commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability

2021-12-07 Thread GitBox
uranusjr commented on pull request #20112: URL: https://github.com/apache/airflow/pull/20112#issuecomment-988570543 Need to fix many errors in linters and tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] github-actions[bot] commented on pull request #20126: Update a link in the Google provider documentation

2021-12-07 Thread GitBox
github-actions[bot] commented on pull request #20126: URL: https://github.com/apache/airflow/pull/20126#issuecomment-988569847 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] uranusjr commented on a change in pull request #18724: Use `DagRun.run_id` instead of `execution_date` when updating state of TIs(UI & REST API)

2021-12-07 Thread GitBox
uranusjr commented on a change in pull request #18724: URL: https://github.com/apache/airflow/pull/18724#discussion_r764611325 ## File path: airflow/api_connexion/endpoints/task_instance_endpoint.py ## @@ -297,15 +296,34 @@ def post_set_task_instances_state(dag_id, session):

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #20126: Update a link in the Google provider documentation

2021-12-07 Thread GitBox
boring-cyborg[bot] commented on pull request #20126: URL: https://github.com/apache/airflow/pull/20126#issuecomment-988568327 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] holadepo opened a new pull request #20126: Update a link in the Google provider documentation

2021-12-07 Thread GitBox
holadepo opened a new pull request #20126: URL: https://github.com/apache/airflow/pull/20126 Replace a Poland specific link to Google Workplace with a more general link in apache-airflow-providers-google documentation --- **^ Add meaningful description above** Read

[GitHub] [airflow] wsmolak commented on issue #20100: google providers > dataproc > ClusterGenerator does not implement all parameters of Dataproc ClusterConfig object

2021-12-07 Thread GitBox
wsmolak commented on issue #20100: URL: https://github.com/apache/airflow/issues/20100#issuecomment-988563395 Thanks @mik-laj! What is the recommended way to build a cluster config? Usage of ClusterGenerator simplifies running a DataProc pipelines form Composer. -- This is an

[GitHub] [airflow] uranusjr commented on issue #20110: CORS access_control_allow_origin header never returned

2021-12-07 Thread GitBox
uranusjr commented on issue #20110: URL: https://github.com/apache/airflow/issues/20110#issuecomment-988562945 Looks like the logic does not handle wildcard expansion:

[GitHub] [airflow] plockaby edited a comment on pull request #20114: fixing #19028 by moving chown to use sudo

2021-12-07 Thread GitBox
plockaby edited a comment on pull request #20114: URL: https://github.com/apache/airflow/pull/20114#issuecomment-988555042 Oh and I may add that the use case you put forth -- people using impersonation without sudo configured or installed -- does not exist. The current code uses a

[GitHub] [airflow] uranusjr commented on issue #18967: Airflow 2.2.0 : Connection Type Oracle returns "ORA-00923: FROM keyword not found where expected" as the result of pressing the "new" button "Tes

2021-12-07 Thread GitBox
uranusjr commented on issue #18967: URL: https://github.com/apache/airflow/issues/18967#issuecomment-988558407 ORA-00923 is *FROM keyword not found where expected*. Currently we are testing a database connection with `select 1`, but it seems like Oracle does not support this. [From this

[GitHub] [airflow] casra-developers commented on pull request #16110: Added windows extensions

2021-12-07 Thread GitBox
casra-developers commented on pull request #16110: URL: https://github.com/apache/airflow/pull/16110#issuecomment-988555675 @potiuk any news on the failing tests? I see that there are some conflicts again. I can resolve those but seeing how this would be about the 4th iteration it would

[GitHub] [airflow] plockaby commented on pull request #20114: fixing #19028 by moving chown to use sudo

2021-12-07 Thread GitBox
plockaby commented on pull request #20114: URL: https://github.com/apache/airflow/pull/20114#issuecomment-988555042 Oh and I may add that the use case you put forth -- people using impersonation without sudo configured or installed -- does not exist. The current code uses a combination of

[GitHub] [airflow] github-actions[bot] commented on pull request #20121: Fix log link in gantt view

2021-12-07 Thread GitBox
github-actions[bot] commented on pull request #20121: URL: https://github.com/apache/airflow/pull/20121#issuecomment-988554510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] uranusjr commented on a change in pull request #20121: Fix log link in gantt view

2021-12-07 Thread GitBox
uranusjr commented on a change in pull request #20121: URL: https://github.com/apache/airflow/pull/20121#discussion_r764597161 ## File path: airflow/www/views.py ## @@ -2889,7 +2889,7 @@ def gantt(self, session=None): task_dict['end_date'] = task_dict['end_date']

[GitHub] [airflow] plockaby commented on pull request #20114: fixing #19028 by moving chown to use sudo

2021-12-07 Thread GitBox
plockaby commented on pull request #20114: URL: https://github.com/apache/airflow/pull/20114#issuecomment-988550520 I mean the docs are very clear that when using impersonation you have to configure sudo and even tell you how to configure sudo. I'm trying to touch as little code as

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #20096: Fix mypy issues in www/views.py

2021-12-07 Thread GitBox
ephraimbuddy commented on a change in pull request #20096: URL: https://github.com/apache/airflow/pull/20096#discussion_r764593128 ## File path: airflow/www/views.py ## @@ -543,7 +543,7 @@ class AirflowBaseView(BaseView): } if not conf.getboolean('core',

[GitHub] [airflow] yrj opened a new issue #20125: Airflow Tree and Gantt View are improper

2021-12-07 Thread GitBox
yrj opened a new issue #20125: URL: https://github.com/apache/airflow/issues/20125 ### Apache Airflow version 2.2.2 (latest released) ### What happened Airflow Task and Gantt view doesnt display the task names properly in Airflow UI. Anything more than 30 characters

[GitHub] [airflow] boring-cyborg[bot] commented on issue #20125: Airflow Tree and Gantt View are improper

2021-12-07 Thread GitBox
boring-cyborg[bot] commented on issue #20125: URL: https://github.com/apache/airflow/issues/20125#issuecomment-988548918 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] uranusjr edited a comment on pull request #20114: fixing #19028 by moving chown to use sudo

2021-12-07 Thread GitBox
uranusjr edited a comment on pull request #20114: URL: https://github.com/apache/airflow/pull/20114#issuecomment-988547402 The problem is that you’re prioritising your use case over others, and potentially breaking other people’s environments to make your environment work correctly.

[GitHub] [airflow] uranusjr commented on pull request #20114: fixing #19028 by moving chown to use sudo

2021-12-07 Thread GitBox
uranusjr commented on pull request #20114: URL: https://github.com/apache/airflow/pull/20114#issuecomment-988547402 The problem with is that you’re prioritising your use case over others, and potentially breaking other people’s environments to make your environment work correctly. That’s

[GitHub] [airflow] uranusjr commented on a change in pull request #20096: Fix mypy issues in www/views.py

2021-12-07 Thread GitBox
uranusjr commented on a change in pull request #20096: URL: https://github.com/apache/airflow/pull/20096#discussion_r764589818 ## File path: airflow/www/views.py ## @@ -543,7 +543,7 @@ class AirflowBaseView(BaseView): } if not conf.getboolean('core',

[GitHub] [airflow] uranusjr commented on a change in pull request #20096: Fix mypy issues in www/views.py

2021-12-07 Thread GitBox
uranusjr commented on a change in pull request #20096: URL: https://github.com/apache/airflow/pull/20096#discussion_r764589818 ## File path: airflow/www/views.py ## @@ -543,7 +543,7 @@ class AirflowBaseView(BaseView): } if not conf.getboolean('core',

[airflow] branch constraints-main updated: Updating constraints. Build id:1552663087

2021-12-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new bb48bc3 Updating

[GitHub] [airflow] plockaby commented on pull request #20114: fixing #19028 by moving chown to use sudo

2021-12-07 Thread GitBox
plockaby commented on pull request #20114: URL: https://github.com/apache/airflow/pull/20114#issuecomment-988539843 One thing that I do notice when I run my patch on my own system is this error: ``` [2021-12-08 06:31:05,703: ERROR/ForkPoolWorker-31] Failed to execute task [Errno

[GitHub] [airflow] plockaby edited a comment on pull request #20114: fixing #19028 by moving chown to use sudo

2021-12-07 Thread GitBox
plockaby edited a comment on pull request #20114: URL: https://github.com/apache/airflow/pull/20114#issuecomment-988534329 You're right, @uranusjr , that there are improvements that could be made to this. My first priority is addressing the regression quickly by getting it back to the

[GitHub] [airflow] plockaby commented on pull request #20114: fixing #19028 by moving chown to use sudo

2021-12-07 Thread GitBox
plockaby commented on pull request #20114: URL: https://github.com/apache/airflow/pull/20114#issuecomment-988534329 You're right, @uranusjr , that there are improvements that could be made to this. My first priority is addressing the regression quickly by getting it back to the previous

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #20096: Fix mypy issues in www/views.py

2021-12-07 Thread GitBox
ephraimbuddy commented on a change in pull request #20096: URL: https://github.com/apache/airflow/pull/20096#discussion_r764577876 ## File path: airflow/settings.py ## @@ -80,7 +80,7 @@ DAGS_FOLDER: str = os.path.expanduser(conf.get('core', 'DAGS_FOLDER')) engine:

[GitHub] [airflow] uranusjr commented on pull request #20114: fixing #19028 by moving chown to use sudo

2021-12-07 Thread GitBox
uranusjr commented on pull request #20114: URL: https://github.com/apache/airflow/pull/20114#issuecomment-988532609 One downside to this change is it requires `sudo` to exist (it is not guaranteed), which is unnecessary if the Airflow’s runtime user _does_ have permission to chown. Maybe

[GitHub] [airflow] alexott commented on issue #20097: Status of testing Providers that were prepared on December 07, 2021

2021-12-07 Thread GitBox
alexott commented on issue #20097: URL: https://github.com/apache/airflow/issues/20097#issuecomment-988531446 Thank you Jarek -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] uranusjr commented on a change in pull request #20120: Fix various MyPy issues in airflow/www folder (part 1)

2021-12-07 Thread GitBox
uranusjr commented on a change in pull request #20120: URL: https://github.com/apache/airflow/pull/20120#discussion_r764571216 ## File path: airflow/www/extensions/init_appbuilder.py ## @@ -560,7 +561,7 @@ def security_converge(self, dry=False) -> Dict: :param dry: If

[GitHub] [airflow] uranusjr commented on a change in pull request #20096: Fix mypy issues in www/views.py

2021-12-07 Thread GitBox
uranusjr commented on a change in pull request #20096: URL: https://github.com/apache/airflow/pull/20096#discussion_r764571983 ## File path: airflow/settings.py ## @@ -80,7 +80,7 @@ DAGS_FOLDER: str = os.path.expanduser(conf.get('core', 'DAGS_FOLDER')) engine:

[GitHub] [airflow] uranusjr commented on a change in pull request #20106: Support insecure mode in SnowflakeHook

2021-12-07 Thread GitBox
uranusjr commented on a change in pull request #20106: URL: https://github.com/apache/airflow/pull/20106#discussion_r764570799 ## File path: airflow/providers/snowflake/hooks/snowflake.py ## @@ -25,10 +25,22 @@ from snowflake import connector from snowflake.connector import

[GitHub] [airflow] uranusjr commented on a change in pull request #20106: Support insecure mode in SnowflakeHook

2021-12-07 Thread GitBox
uranusjr commented on a change in pull request #20106: URL: https://github.com/apache/airflow/pull/20106#discussion_r764570006 ## File path: airflow/providers/snowflake/hooks/snowflake.py ## @@ -25,10 +25,22 @@ from snowflake import connector from snowflake.connector import

[GitHub] [airflow] mik-laj commented on a change in pull request #20106: Support insecure mode in SnowflakeHook

2021-12-07 Thread GitBox
mik-laj commented on a change in pull request #20106: URL: https://github.com/apache/airflow/pull/20106#discussion_r764567672 ## File path: airflow/providers/snowflake/hooks/snowflake.py ## @@ -25,10 +25,22 @@ from snowflake import connector from snowflake.connector import

[GitHub] [airflow] uranusjr commented on pull request #17329: Split sql statements in DbApi run

2021-12-07 Thread GitBox
uranusjr commented on pull request #17329: URL: https://github.com/apache/airflow/pull/17329#issuecomment-988513575 @flolas Do you intend to pick this back up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[airflow] branch main updated (7fb301b -> b0eecc3)

2021-12-07 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 7fb301b Remove unused code in SnowflakeHook (#20107) add b0eecc3 Remove legacy hack for TaskInstance without

[GitHub] [airflow] uranusjr merged pull request #20108: Remove legacy hack for TaskInstance without DagRun

2021-12-07 Thread GitBox
uranusjr merged pull request #20108: URL: https://github.com/apache/airflow/pull/20108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on issue #20116: BaseOperator.get_task_instances is broken due to order by TaskInstance.execution_date

2021-12-07 Thread GitBox
uranusjr commented on issue #20116: URL: https://github.com/apache/airflow/issues/20116#issuecomment-988511457 > This is *meant* to be a backwards compatibility shim Not really, the function has not been touched (except to apply Black) in three years, and is not used at all in the

[GitHub] [airflow] mik-laj commented on a change in pull request #20124: Added function in AWSAthenaHook to get s3 output query results file URI

2021-12-07 Thread GitBox
mik-laj commented on a change in pull request #20124: URL: https://github.com/apache/airflow/pull/20124#discussion_r764543794 ## File path: airflow/providers/amazon/aws/hooks/athena.py ## @@ -227,6 +227,29 @@ def poll_query_status(self, query_execution_id: str, max_tries:

[GitHub] [airflow] mik-laj commented on a change in pull request #20124: Added function in AWSAthenaHook to get s3 output query results file URI

2021-12-07 Thread GitBox
mik-laj commented on a change in pull request #20124: URL: https://github.com/apache/airflow/pull/20124#discussion_r764543412 ## File path: airflow/providers/amazon/aws/hooks/athena.py ## @@ -227,6 +227,29 @@ def poll_query_status(self, query_execution_id: str, max_tries:

[airflow] branch main updated (bcacc51 -> 7fb301b)

2021-12-07 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from bcacc51 Lift off upper bound for MarkupSafe (#20113) add 7fb301b Remove unused code in SnowflakeHook

[GitHub] [airflow] mik-laj merged pull request #20107: Remove unused code in SnowflakeHook

2021-12-07 Thread GitBox
mik-laj merged pull request #20107: URL: https://github.com/apache/airflow/pull/20107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] PrincipalsOffice commented on issue #20116: BaseOperator.get_task_instances is broken due to order by TaskInstance.execution_date

2021-12-07 Thread GitBox
PrincipalsOffice commented on issue #20116: URL: https://github.com/apache/airflow/issues/20116#issuecomment-988487760 @ashb I have updated the "How to reproduce" section with a reproducible snippet. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mik-laj commented on a change in pull request #20106: Support insecure mode in SnowflakeHook

2021-12-07 Thread GitBox
mik-laj commented on a change in pull request #20106: URL: https://github.com/apache/airflow/pull/20106#discussion_r764538586 ## File path: airflow/providers/snowflake/hooks/snowflake.py ## @@ -25,10 +25,22 @@ from snowflake import connector from snowflake.connector import

[GitHub] [airflow] manuzhang commented on issue #14459: Misleading terminology in UI: "Active" or "Unpaused"

2021-12-07 Thread GitBox
manuzhang commented on issue #14459: URL: https://github.com/apache/airflow/issues/14459#issuecomment-988476934 I don't thinks this is minor now when I'm trying to get DAGs from this tab from the `/dags` endpoint with `only_active` parameter. Meanwhile, is there a way to get all unpaused

[GitHub] [airflow] subkanthi opened a new pull request #20124: Added function in AWSAthenaHook to get s3 output query results file URI

2021-12-07 Thread GitBox
subkanthi opened a new pull request #20124: URL: https://github.com/apache/airflow/pull/20124 Added function in AWSAthenaHook to get s3 output query results file URI --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] EricGao888 commented on pull request #19471: Add cli command for 'airflow dags reserialize`

2021-12-07 Thread GitBox
EricGao888 commented on pull request #19471: URL: https://github.com/apache/airflow/pull/19471#issuecomment-988457294 > > > Did I miss any important information? > > I think you missed the information that Airlfow 1.10 (not even 1.10.12 but any 1.10 version) reached

[GitHub] [airflow] potiuk commented on pull request #19471: Add cli command for 'airflow dags reserialize`

2021-12-07 Thread GitBox
potiuk commented on pull request #19471: URL: https://github.com/apache/airflow/pull/19471#issuecomment-988444636 > Did I miss any important information? I think you missed the information that Airlfow 1.10 (not even 1.10.12 but any 1.10 version) reached end of life in June 2021 and

[GitHub] [airflow] EricGao888 commented on pull request #19471: Add cli command for 'airflow dags reserialize`

2021-12-07 Thread GitBox
EricGao888 commented on pull request #19471: URL: https://github.com/apache/airflow/pull/19471#issuecomment-988441211 > Workers don’t need DAG information, only the scheduler does. Thanks for the reply. Another question is will the python script `from airflow.models.serialized_dag

[GitHub] [airflow] potiuk commented on issue #19205: Grouping of connections

2021-12-07 Thread GitBox
potiuk commented on issue #19205: URL: https://github.com/apache/airflow/issues/19205#issuecomment-988433544 We have now Multi-tenancy effort in progress which I am leading. And while the first two AIPs that are very draft (but will soon be updated) do not address this final granularity

[GitHub] [airflow] potiuk commented on issue #19226: DAG permission setting per owner and/or per tag

2021-12-07 Thread GitBox
potiuk commented on issue #19226: URL: https://github.com/apache/airflow/issues/19226#issuecomment-988432370 Or actually let me re-open it and add multi-tenancy label to group similar stuff together and refer to it when we will be implementing it. -- This is an automated message from

[GitHub] [airflow] mandicLuka opened a new issue #19226: DAG permission setting per owner and/or per tag

2021-12-07 Thread GitBox
mandicLuka opened a new issue #19226: URL: https://github.com/apache/airflow/issues/19226 ### Description Access Control feature where one can limit a DAG permissions (read, write, etc.) for a group of DAGs, namely, the ones where owner is set or the tag is set to the desired

[GitHub] [airflow] potiuk commented on issue #9342: RBAC access rights filtering by dag tags

2021-12-07 Thread GitBox
potiuk commented on issue #9342: URL: https://github.com/apache/airflow/issues/9342#issuecomment-988431647 We have now Multi-tenancy effort in progress which I am leading. And while the first two AIPs that are very draft (but will soon be updated) do not address this final granularity

[GitHub] [airflow] potiuk commented on issue #19226: DAG permission setting per owner and/or per tag

2021-12-07 Thread GitBox
potiuk commented on issue #19226: URL: https://github.com/apache/airflow/issues/19226#issuecomment-988429690 Note that we have now Multi-tenancy effort in progress which I am leading. And while the first two AIPs that are very draft (but will soon be updated) do not address this final

[GitHub] [airflow] potiuk edited a comment on issue #19226: DAG permission setting per owner and/or per tag

2021-12-07 Thread GitBox
potiuk edited a comment on issue #19226: URL: https://github.com/apache/airflow/issues/19226#issuecomment-988429690 Note that we have now Multi-tenancy effort in progress which I am leading. And while the first two AIPs that are very draft (but will soon be updated) do not address this

[GitHub] [airflow] potiuk closed issue #19226: DAG permission setting per owner and/or per tag

2021-12-07 Thread GitBox
potiuk closed issue #19226: URL: https://github.com/apache/airflow/issues/19226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #19891: Re-enable MyPy

2021-12-07 Thread GitBox
potiuk commented on issue #19891: URL: https://github.com/apache/airflow/issues/19891#issuecomment-988425025 cool. I will refresh the list from scratch tomorrow :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] potiuk edited a comment on pull request #20113: Lift off upper bound for MarkupSafe

2021-12-07 Thread GitBox
potiuk edited a comment on pull request #20113: URL: https://github.com/apache/airflow/pull/20113#issuecomment-988424025 But if you want to start using it for your own builds, you will need to wait for new release unfortunately as this is released airlfow package dependency (`MarkupSafe <

[GitHub] [airflow] potiuk commented on pull request #20113: Lift off upper bound for MarkupSafe

2021-12-07 Thread GitBox
potiuk commented on pull request #20113: URL: https://github.com/apache/airflow/pull/20113#issuecomment-988424025 But if you want to start using it for your own builds, you will need to wait for new release unfortunately as this is released airlfow package dependency (`MarkupSafe <

[GitHub] [airflow] smartnewsdingli opened a new issue #20123: Multi scheduler caused random worker pods crash

2021-12-07 Thread GitBox
smartnewsdingli opened a new issue #20123: URL: https://github.com/apache/airflow/issues/20123 ### Apache Airflow version 2.2.2 (latest released) ### What happened We have multi schedulers setup with kubernetesExecutor. We find of all 14000 tasks run daily, there are

[GitHub] [airflow] potiuk commented on pull request #20113: Lift off upper bound for MarkupSafe

2021-12-07 Thread GitBox
potiuk commented on pull request #20113: URL: https://github.com/apache/airflow/pull/20113#issuecomment-988419189 Hey @tsingh2k15 - all looks good. In the "Build Images" job you can find that this build actually used 2.0.1 version:

[GitHub] [airflow] sunny760408 commented on issue #10026: Duplicate tasks invoked for a single task_id when manually invoked task details modal.

2021-12-07 Thread GitBox
sunny760408 commented on issue #10026: URL: https://github.com/apache/airflow/issues/10026#issuecomment-988412621 > Hi @gcristian , What is worker's heartbeats name? Do you mean `job_heartbeat_sec`? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] dstandish commented on a change in pull request #19729: Local kubernetes executor

2021-12-07 Thread GitBox
dstandish commented on a change in pull request #19729: URL: https://github.com/apache/airflow/pull/19729#discussion_r764477823 ## File path: airflow/executors/local_kubernetes_executor.py ## @@ -0,0 +1,204 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[airflow] branch main updated (139be53 -> bcacc51)

2021-12-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 139be53 Fix mypy tests providers part 2 (#20111) add bcacc51 Lift off upper bound for MarkupSafe (#20113) No

[GitHub] [airflow] potiuk merged pull request #20113: Lift off upper bound for MarkupSafe

2021-12-07 Thread GitBox
potiuk merged pull request #20113: URL: https://github.com/apache/airflow/pull/20113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk edited a comment on issue #12611: Switch from Email to general/extensible Notifiers

2021-12-07 Thread GitBox
potiuk edited a comment on issue #12611: URL: https://github.com/apache/airflow/issues/12611#issuecomment-988403817 Yeah. I also think it's not really AIP-worthy. But this is very good point with the multi-tenancy interaction I am performing an inventory of stuff that will

[GitHub] [airflow] potiuk edited a comment on issue #12611: Switch from Email to general/extensible Notifiers

2021-12-07 Thread GitBox
potiuk edited a comment on issue #12611: URL: https://github.com/apache/airflow/issues/12611#issuecomment-988403817 Yeah. I also think it's not really AIP-worthy. But this is very good point with the multi-tenancy interaction I am performing an inventory of stuff that will

[GitHub] [airflow] potiuk commented on issue #12611: Switch from Email to general/extensible Notifiers

2021-12-07 Thread GitBox
potiuk commented on issue #12611: URL: https://github.com/apache/airflow/issues/12611#issuecomment-988403817 Yeah. I also think it's not really AIP-worthy. But this is very good point with the multi-tenancy interaction I am performing an inventory of stuff that will be

[GitHub] [airflow] jedcunningham commented on issue #19199: WebUI: Action on multiple selection in dag run list yields an error

2021-12-07 Thread GitBox
jedcunningham commented on issue #19199: URL: https://github.com/apache/airflow/issues/19199#issuecomment-988361250 Hmm, I couldn't even reproduce this in 2.1.3 路‍♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] github-actions[bot] commented on pull request #19157: fix "mismatch process ids" issue for the "run as user" case

2021-12-07 Thread GitBox
github-actions[bot] commented on pull request #19157: URL: https://github.com/apache/airflow/pull/19157#issuecomment-988360953 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] closed pull request #19039: Allow the user to use dag timezone to create dag_run_id

2021-12-07 Thread GitBox
github-actions[bot] closed pull request #19039: URL: https://github.com/apache/airflow/pull/19039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] closed pull request #19051: Add process state framework and watermark operator

2021-12-07 Thread GitBox
github-actions[bot] closed pull request #19051: URL: https://github.com/apache/airflow/pull/19051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] closed pull request #17329: Split sql statements in DbApi run

2021-12-07 Thread GitBox
github-actions[bot] closed pull request #17329: URL: https://github.com/apache/airflow/pull/17329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] dstandish commented on a change in pull request #19665: Add two operators in AWS Providers: RedshiftResumeClusterOperator and RedshiftPauseClusterOperator

2021-12-07 Thread GitBox
dstandish commented on a change in pull request #19665: URL: https://github.com/apache/airflow/pull/19665#discussion_r764429805 ## File path: tests/providers/amazon/aws/operators/test_redshift.py ## @@ -42,3 +47,69 @@ def test_redshift_operator(self, test_autocommit,

[GitHub] [airflow] potiuk merged pull request #20111: Fix mypy tests providers part 2

2021-12-07 Thread GitBox
potiuk merged pull request #20111: URL: https://github.com/apache/airflow/pull/20111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on issue #19199: WebUI: Action on multiple selection in dag run list yields an error

2021-12-07 Thread GitBox
jedcunningham commented on issue #19199: URL: https://github.com/apache/airflow/issues/19199#issuecomment-988354751 @parisni, can you try with 2.2.2? I'm unable to reproduce this with 2.2.2 or main. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] github-actions[bot] commented on pull request #19825: Deprecate passing execution_date to XCom methods

2021-12-07 Thread GitBox
github-actions[bot] commented on pull request #19825: URL: https://github.com/apache/airflow/pull/19825#issuecomment-988353130 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk closed issue #17800: BigQueryCreateExternalTableOperator from providers package fails to get schema from GCS object

2021-12-07 Thread GitBox
potiuk closed issue #17800: URL: https://github.com/apache/airflow/issues/17800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk merged pull request #20091: Remove deprecated method call (blob.download_as_string)

2021-12-07 Thread GitBox
potiuk merged pull request #20091: URL: https://github.com/apache/airflow/pull/20091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #19729: Local kubernetes executor

2021-12-07 Thread GitBox
github-actions[bot] commented on pull request #19729: URL: https://github.com/apache/airflow/pull/19729#issuecomment-988351445 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] kaxil commented on pull request #19729: Local kubernetes executor

2021-12-07 Thread GitBox
kaxil commented on pull request #19729: URL: https://github.com/apache/airflow/pull/19729#issuecomment-988351165 cc @potiuk @dstandish for a second review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] euccas opened a new pull request #20122: Allow users to input reasons when manually mark states.

2021-12-07 Thread GitBox
euccas opened a new pull request #20122: URL: https://github.com/apache/airflow/pull/20122 This PR is a change that allows users to input reasons on the UI when they manually mark state (clear, success, failed) of a DAG run or task instances. Recording users' comments associated with such

[GitHub] [airflow] jedcunningham commented on issue #19613: Can't open task log from Gantt view

2021-12-07 Thread GitBox
jedcunningham commented on issue #19613: URL: https://github.com/apache/airflow/issues/19613#issuecomment-988345779 Ah! #19258 populated `execution_date` in 2.2.2. Mystery solved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] hkjang commented on issue #18967: Airflow 2.2.0 : Connection Type Oracle returns "ORA-00923: FROM keyword not found where expected" as the result of pressing the "new" button "Test"

2021-12-07 Thread GitBox
hkjang commented on issue #18967: URL: https://github.com/apache/airflow/issues/18967#issuecomment-988344799 first thanks. also i got that error message ORA-00923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] jedcunningham commented on issue #19613: Can't open task log from Gantt view

2021-12-07 Thread GitBox
jedcunningham commented on issue #19613: URL: https://github.com/apache/airflow/issues/19613#issuecomment-988344210 I wasn't able to reproduce the original error, but the log link was broken and should be fixed in #20121. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] jedcunningham opened a new pull request #20121: Fix log link in gantt view

2021-12-07 Thread GitBox
jedcunningham opened a new pull request #20121: URL: https://github.com/apache/airflow/pull/20121 The link to the log in the gantt view modal was a broken link as the execution_date wasn't isoformatted. Closes #19613 -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] github-actions[bot] commented on pull request #20108: Remove legacy hack for TaskInstance without DagRun

2021-12-07 Thread GitBox
github-actions[bot] commented on pull request #20108: URL: https://github.com/apache/airflow/pull/20108#issuecomment-988335064 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] khalidmammadov opened a new pull request #20120: Fix various MyPy issues in airflow/www folder (part 1)

2021-12-07 Thread GitBox
khalidmammadov opened a new pull request #20120: URL: https://github.com/apache/airflow/pull/20120 Part of https://github.com/apache/airflow/issues/19891 Fixes various typing issues in airflow/www subfolder --- **^ Add meaningful description above** Read the **[Pull

[GitHub] [airflow] github-actions[bot] commented on pull request #20118: Log only when Zombies exists

2021-12-07 Thread GitBox
github-actions[bot] commented on pull request #20118: URL: https://github.com/apache/airflow/pull/20118#issuecomment-988330008 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk edited a comment on issue #20097: Status of testing Providers that were prepared on December 07, 2021

2021-12-07 Thread GitBox
potiuk edited a comment on issue #20097: URL: https://github.com/apache/airflow/issues/20097#issuecomment-988327727 > P.S. #19443 is missing from the changelog Ah yeah. Good point - I have mistakenly hidden it in the changelog - it is in the hidden section among refactoring (my

[GitHub] [airflow] potiuk commented on issue #20097: Status of testing Providers that were prepared on December 07, 2021

2021-12-07 Thread GitBox
potiuk commented on issue #20097: URL: https://github.com/apache/airflow/issues/20097#issuecomment-988327727 > P.S. #19443 is missing from the changelog Ah yeah. Good point - I have mistakenly hidden it in the changelog - it is in the hidden section among refactoring (my bad) - see

[GitHub] [airflow] isaac-florence edited a comment on issue #19226: DAG permission setting per owner and/or per tag

2021-12-07 Thread GitBox
isaac-florence edited a comment on issue #19226: URL: https://github.com/apache/airflow/issues/19226#issuecomment-988324455 Agreeing with @potiuk's comment on #9342, airflow can't do multi-tenancy at the moment. However we have setup an instance which only uses the kubernetesPodOperator,

[GitHub] [airflow] isaac-florence commented on issue #19226: DAG permission setting per owner and/or per tag

2021-12-07 Thread GitBox
isaac-florence commented on issue #19226: URL: https://github.com/apache/airflow/issues/19226#issuecomment-988324455 Agreeing with @potiuk's comment on #9342, airflow can't do multi-tenancy at the moment. However we have setup an instance which only uses the kubernetesPodOperator, and so

[GitHub] [airflow] kazanzhy commented on issue #10288: gcs_to_bigquery using deprecated methods

2021-12-07 Thread GitBox
kazanzhy commented on issue #10288: URL: https://github.com/apache/airflow/issues/10288#issuecomment-988323907 Hi all. I've tried to remove warnings during GCSToBigQueryOperator as in PR #20119 But as a result, I copied almost all code from `bq_hook.create_external_table` and

[GitHub] [airflow] kazanzhy opened a new pull request #20119: Remove deprecated method call of BigQueryHook cursor from GCSToBigQueryOperator

2021-12-07 Thread GitBox
kazanzhy opened a new pull request #20119: URL: https://github.com/apache/airflow/pull/20119 closes: #10288 I've tried to remove warnings during `GCSToBigQueryOperator` as in issue #10288. But as a result, I copied almost all code from `bq_hook.create_external_table` and

[GitHub] [airflow] kaxil opened a new pull request #20118: Log only when Zombies exists

2021-12-07 Thread GitBox
kaxil opened a new pull request #20118: URL: https://github.com/apache/airflow/pull/20118 The following feels like there were non-zero jobs that were zombies while there weren't ``` [2021-12-07 20:54:35,502] {manager.py:1051} INFO - Finding 'running' jobs without a recent heartbeat

[GitHub] [airflow] dbarrundiag commented on a change in pull request #19665: Add two operators in AWS Providers: RedshiftResumeClusterOperator and RedshiftPauseClusterOperator

2021-12-07 Thread GitBox
dbarrundiag commented on a change in pull request #19665: URL: https://github.com/apache/airflow/pull/19665#discussion_r764419580 ## File path: tests/providers/amazon/aws/operators/test_redshift.py ## @@ -42,3 +47,69 @@ def test_redshift_operator(self, test_autocommit,

[GitHub] [airflow] plockaby commented on pull request #20114: fixing #19028 by moving chown to use sudo

2021-12-07 Thread GitBox
plockaby commented on pull request #20114: URL: https://github.com/apache/airflow/pull/20114#issuecomment-988316722 I answered your message and stepped out to a meeting and then you fixed my whole PR.  Looks good to me! Thanks for your help! -- This is an automated message from

  1   2   3   4   >