[GitHub] [airflow] bhavaniravi commented on issue #20139: Restructure Amazon provider operators files

2021-12-08 Thread GitBox
bhavaniravi commented on issue #20139: URL: https://github.com/apache/airflow/issues/20139#issuecomment-989599852 Let me start with DMS, then. Quick question. Should we add the deprecated warning like the following on existing modules, or is this auto-generated? ``` import

[GitHub] [airflow] KennyRich commented on issue #20139: Restructure Amazon provider operators files

2021-12-08 Thread GitBox
KennyRich commented on issue #20139: URL: https://github.com/apache/airflow/issues/20139#issuecomment-989598237 > @eladkal Please kindly link your PR here so I can easily see and learn from it. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] KennyRich removed a comment on issue #20139: Restructure Amazon provider operators files

2021-12-08 Thread GitBox
KennyRich removed a comment on issue #20139: URL: https://github.com/apache/airflow/issues/20139#issuecomment-989597773 > Please kindly link your PR here so I can easily see and learn from it. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] KennyRich commented on issue #20139: Restructure Amazon provider operators files

2021-12-08 Thread GitBox
KennyRich commented on issue #20139: URL: https://github.com/apache/airflow/issues/20139#issuecomment-989597773 > Please kindly link your PR here so I can easily see and learn from it. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] eladkal commented on issue #20139: Restructure Amazon provider operators files

2021-12-08 Thread GitBox
eladkal commented on issue #20139: URL: https://github.com/apache/airflow/issues/20139#issuecomment-989596066 > I can take up a few of them since @KennyRich wants to do S3. I'll start with EC2 Already started EC2 as mentioned earlier.. I'll PR shortly... There is plenty to pick

[GitHub] [airflow] harishkrao commented on issue #20032: Snowflake Provider - Hook's support for not providing a region is broken when using SQLAlchemy

2021-12-08 Thread GitBox
harishkrao commented on issue #20032: URL: https://github.com/apache/airflow/issues/20032#issuecomment-989595540 @mik-laj Made the below changes, running pytests pending, will let you know after running them tomorrow:

[GitHub] [airflow] bhavaniravi edited a comment on issue #20139: Restructure Amazon provider operators files

2021-12-08 Thread GitBox
bhavaniravi edited a comment on issue #20139: URL: https://github.com/apache/airflow/issues/20139#issuecomment-989594428 I can take up a few of them since @KennyRich wants to do S3. I'll start with EC2 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] alexakra edited a comment on issue #19901: No scheduling when max_active_runs is 1

2021-12-08 Thread GitBox
alexakra edited a comment on issue #19901: URL: https://github.com/apache/airflow/issues/19901#issuecomment-989593193 > What do you mean by no scheduling? Is it that dagruns are not created at all? There is a record in the "dag" table in which `next_dagrun_create_after` remains

[GitHub] [airflow] bhavaniravi commented on issue #20139: Restructure Amazon provider operators files

2021-12-08 Thread GitBox
bhavaniravi commented on issue #20139: URL: https://github.com/apache/airflow/issues/20139#issuecomment-989594428 I can take up a few of them since @KennyRich wants to do S3. I'll start with ECS -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] alexakra commented on issue #19901: No scheduling when max_active_runs is 1

2021-12-08 Thread GitBox
alexakra commented on issue #19901: URL: https://github.com/apache/airflow/issues/19901#issuecomment-989593193 > What do you mean by no scheduling? Is it that dagruns are not created at all? There is a record in the "dag" table in which `next_dagrun_create_after` remains `null`.

[GitHub] [airflow] alexakra commented on issue #19901: No scheduling when max_active_runs is 1

2021-12-08 Thread GitBox
alexakra commented on issue #19901: URL: https://github.com/apache/airflow/issues/19901#issuecomment-989589446 > Just out of curiosity, does the scheduler create another run if you modify the file? yes, just another single run -- This is an automated message from the Apache Git

[GitHub] [airflow] Bowrna edited a comment on pull request #20066: Rewrite Breeze setup autocomplete

2021-12-08 Thread GitBox
Bowrna edited a comment on pull request #20066: URL: https://github.com/apache/airflow/pull/20066#issuecomment-989552843 > Hmm. good question. I think we might provide a command in ./Breeze2 to do it for the user. Similarly like we had `setup-autocomplete` in the original `./breeze`. So

[GitHub] [airflow] Bowrna edited a comment on pull request #20066: Rewrite Breeze setup autocomplete

2021-12-08 Thread GitBox
Bowrna edited a comment on pull request #20066: URL: https://github.com/apache/airflow/pull/20066#issuecomment-989552843 > Hmm. good question. I think we might provide a command in ./Breeze2 to do it for the user. Similarly like we had `setup-autocomplete` in the original `./breeze`. So

[GitHub] [airflow] sharad-vm closed pull request #20154: Add example dag showing usage of impersonation_chain argument of Google operators

2021-12-08 Thread GitBox
sharad-vm closed pull request #20154: URL: https://github.com/apache/airflow/pull/20154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] sharad-vm commented on pull request #20154: Add example dag showing usage of impersonation_chain argument of Google operators

2021-12-08 Thread GitBox
sharad-vm commented on pull request #20154: URL: https://github.com/apache/airflow/pull/20154#issuecomment-989565504 Not required right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] david30907d commented on issue #19507: Make BigQueryHook compatible with sqlalchemy

2021-12-08 Thread GitBox
david30907d commented on issue #19507: URL: https://github.com/apache/airflow/issues/19507#issuecomment-989564695 not sure I guess we still need to overwrite the `get_uri()` function like these 2 examples ?

[GitHub] [airflow] david30907d commented on issue #19507: Make BigQueryHook compatible with sqlalchemy

2021-12-08 Thread GitBox
david30907d commented on issue #19507: URL: https://github.com/apache/airflow/issues/19507#issuecomment-989563954 @kazanzhy I could be wrong but it still fails on my local (2.2.2) seems to me that [conn_type](https://github.com/apache/airflow/blob/main/airflow/hooks/dbapi.py#L107) here

[GitHub] [airflow] KennyRich edited a comment on issue #20139: Restructure Amazon provider operators files

2021-12-08 Thread GitBox
KennyRich edited a comment on issue #20139: URL: https://github.com/apache/airflow/issues/20139#issuecomment-989549995 Can I work on one of the classes? I can work on S3. @eladkal and @o-nikolas This would be my first contribution to airflow -- This is an automated message from the

[GitHub] [airflow] Acehaidrey commented on pull request #20112: Add td_format function and apply to Views duration column for better human readability

2021-12-08 Thread GitBox
Acehaidrey commented on pull request #20112: URL: https://github.com/apache/airflow/pull/20112#issuecomment-989561127 @uranusjr sorry I didn't realize it created PR already. Working on it now! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] sharad-vm opened a new pull request #20154: Add example dag showing usage of impersonation_chain argument of Google operators

2021-12-08 Thread GitBox
sharad-vm opened a new pull request #20154: URL: https://github.com/apache/airflow/pull/20154 This PR adds an example DAG showing usage of impersonation chain argument for Google BigQuery service. Close: #12061 --- **^ Add meaningful description above** Read the

[GitHub] [airflow] david30907d opened a new issue #19507: Make BigQueryHook compatible with sqlalchemy

2021-12-08 Thread GitBox
david30907d opened a new issue #19507: URL: https://github.com/apache/airflow/issues/19507 ### Description ```python hook = BigQueryHook('google_cloud_default', use_legacy_sql=False) hook.get_sqlalchemy_engine() ``` this one would raise this exception  ```bash

[GitHub] [airflow] Bowrna commented on pull request #20066: Rewrite Breeze setup autocomplete

2021-12-08 Thread GitBox
Bowrna commented on pull request #20066: URL: https://github.com/apache/airflow/pull/20066#issuecomment-989552843 > Hmm. good question. I think we might provide a command in ./Breeze2 to do it for the user. Similarly like we had `setup-autocomplete` in the original `./breeze`. So

[GitHub] [airflow] KennyRich edited a comment on issue #20139: Restructure Amazon provider operators files

2021-12-08 Thread GitBox
KennyRich edited a comment on issue #20139: URL: https://github.com/apache/airflow/issues/20139#issuecomment-989549995 Can I work on one of the classes? I can work on sagemaker. @eladkal and @o-nikolas This would be my first contribution to airflow -- This is an automated message

[GitHub] [airflow] KennyRich commented on issue #20139: Restructure Amazon provider operators files

2021-12-08 Thread GitBox
KennyRich commented on issue #20139: URL: https://github.com/apache/airflow/issues/20139#issuecomment-989549995 Can I work on one of the classes? I can work on sagemaker. @eladkal and @o-nikolas -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] josh-fell commented on issue #19891: Re-enable MyPy

2021-12-08 Thread GitBox
josh-fell commented on issue #19891: URL: https://github.com/apache/airflow/issues/19891#issuecomment-989536477 I started looking into `dev`. Let me know if someone else has already though. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] ephraimbuddy commented on pull request #20151: Deprecate smart sensors

2021-12-08 Thread GitBox
ephraimbuddy commented on pull request #20151: URL: https://github.com/apache/airflow/pull/20151#issuecomment-989533980 What do you think about using [deprecated](https://github.com/tantale/deprecated) on the Sensor Class? It gives a very nice message when a deprecated function/class is

[GitHub] [airflow] dstandish commented on a change in pull request #19665: Add two operators in AWS Providers: RedshiftResumeClusterOperator and RedshiftPauseClusterOperator

2021-12-08 Thread GitBox
dstandish commented on a change in pull request #19665: URL: https://github.com/apache/airflow/pull/19665#discussion_r765422377 ## File path: tests/providers/amazon/aws/operators/test_redshift.py ## @@ -42,3 +47,69 @@ def test_redshift_operator(self, test_autocommit,

[GitHub] [airflow] david30907d closed issue #19507: Make BigQueryHook compatible with sqlalchemy

2021-12-08 Thread GitBox
david30907d closed issue #19507: URL: https://github.com/apache/airflow/issues/19507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] david30907d commented on issue #19507: Make BigQueryHook compatible with sqlalchemy

2021-12-08 Thread GitBox
david30907d commented on issue #19507: URL: https://github.com/apache/airflow/issues/19507#issuecomment-989497534 @kazanzhy sorry for the late reply good to know this new conn_type! I'm still using 2.1.2 so didn't realize it  going to close this issue, thx~ -- This is an

[GitHub] [airflow] harishkrao commented on issue #20032: Snowflake Provider - Hook's support for not providing a region is broken when using SQLAlchemy

2021-12-08 Thread GitBox
harishkrao commented on issue #20032: URL: https://github.com/apache/airflow/issues/20032#issuecomment-989486844 Thank you @mik-laj. I will write the test cases based on the new tests you pushed yesterday. Also thank you for the SQL Alchemy URL build link. I will use it to construct

[GitHub] [airflow] github-actions[bot] commented on pull request #19912: Fix mypy for cli package

2021-12-08 Thread GitBox
github-actions[bot] commented on pull request #19912: URL: https://github.com/apache/airflow/pull/19912#issuecomment-989472520 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] uranusjr edited a comment on issue #20063: Forward slash in `dag_run_id` gives rise to trouble accessing things through the REST API

2021-12-08 Thread GitBox
uranusjr edited a comment on issue #20063: URL: https://github.com/apache/airflow/issues/20063#issuecomment-989402511 I tracked this down to pallets/flask#900, and as Armin mentioned when he closed the ticket, the problem is in WSGI—`%2f` is treated exactly as `/` and there’s no way to

[GitHub] [airflow] uranusjr edited a comment on issue #20063: Forward slash in `dag_run_id` gives rise to trouble accessing things through the REST API

2021-12-08 Thread GitBox
uranusjr edited a comment on issue #20063: URL: https://github.com/apache/airflow/issues/20063#issuecomment-989402511 I tracked this down to pallets/flask#900, and as Armin mentioned when he closed the ticket, the problem is in WSGI—`%2f` is treated exactly as `/` and there’s no way to

[GitHub] [airflow] github-actions[bot] commented on pull request #19911: Fix mypy checks for api_connexion

2021-12-08 Thread GitBox
github-actions[bot] commented on pull request #19911: URL: https://github.com/apache/airflow/pull/19911#issuecomment-989434949 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] plockaby edited a comment on issue #19376: Logs suppressed when impersonation is enabled

2021-12-08 Thread GitBox
plockaby edited a comment on issue #19376: URL: https://github.com/apache/airflow/issues/19376#issuecomment-989430540 I think that I know the issue but I'm not confident in my solution. Roughly, the problem is that normally tasks are called using using `os.fork` and the task is

[GitHub] [airflow] plockaby edited a comment on issue #19376: Logs suppressed when impersonation is enabled

2021-12-08 Thread GitBox
plockaby edited a comment on issue #19376: URL: https://github.com/apache/airflow/issues/19376#issuecomment-989430540 I think that I know the issue but I'm not confident in my solution. Roughly, the problem is that normally tasks are called using using `os.fork` and the task is

[GitHub] [airflow] plockaby commented on issue #19376: Logs suppressed when impersonation is enabled

2021-12-08 Thread GitBox
plockaby commented on issue #19376: URL: https://github.com/apache/airflow/issues/19376#issuecomment-989430540 I think that I know the issue but I'm not confident in my solution. Roughly, the problem is that normally tasks are called using using `os.fork` and the task is called from

[GitHub] [airflow] uranusjr edited a comment on issue #20063: Forward slash in `dag_run_id` gives rise to trouble accessing things through the REST API

2021-12-08 Thread GitBox
uranusjr edited a comment on issue #20063: URL: https://github.com/apache/airflow/issues/20063#issuecomment-989402511 I tracked this down to pallets/flask#900, and as Armin mentioned when he closed the ticket, the problem is in WSGI—`%2f` is treated exactly as `/` and there’s no way to

[GitHub] [airflow] uranusjr edited a comment on issue #20063: Forward slash in `dag_run_id` gives rise to trouble accessing things through the REST API

2021-12-08 Thread GitBox
uranusjr edited a comment on issue #20063: URL: https://github.com/apache/airflow/issues/20063#issuecomment-989402511 I tracked this down to pallets/flask#900, and as Armin mentioned when he closed the ticket, the problem is in WSGI—`%2f` is treated exactly as `/` and there’s no way to

[GitHub] [airflow] uranusjr commented on issue #20063: Forward slash in `dag_run_id` gives rise to trouble accessing things through the REST API

2021-12-08 Thread GitBox
uranusjr commented on issue #20063: URL: https://github.com/apache/airflow/issues/20063#issuecomment-989402511 I tracked this down to pallets/flask#900, and as Armin mentioned when he closed the ticket, the problem is in WSGI—`%2f` is treated exactly as `/` and there’s no way to work

[GitHub] [airflow] dbarrundiag commented on a change in pull request #19665: Add two operators in AWS Providers: RedshiftResumeClusterOperator and RedshiftPauseClusterOperator

2021-12-08 Thread GitBox
dbarrundiag commented on a change in pull request #19665: URL: https://github.com/apache/airflow/pull/19665#discussion_r765369339 ## File path: tests/providers/amazon/aws/operators/test_redshift.py ## @@ -42,3 +47,69 @@ def test_redshift_operator(self, test_autocommit,

[GitHub] [airflow] burakovsky edited a comment on issue #17447: Option to exclude default / hard-coded helm annotations for jobs and other relevant templates

2021-12-08 Thread GitBox
burakovsky edited a comment on issue #17447: URL: https://github.com/apache/airflow/issues/17447#issuecomment-989374372 Is it possible to add a similar configuration for other resources with hardcoded helm annotations (extra-configmaps, redis-secrets.yaml) ? Are these annotations really

[GitHub] [airflow] burakovsky edited a comment on issue #17447: Option to exclude default / hard-coded helm annotations for jobs and other relevant templates

2021-12-08 Thread GitBox
burakovsky edited a comment on issue #17447: URL: https://github.com/apache/airflow/issues/17447#issuecomment-989374372 Is it possible to add a similar configuration for other resources with hardcoded helm annotations (extra-configmaps, redis-secrets.yaml) ? Are these annotations really

[GitHub] [airflow] burakovsky commented on issue #17447: Option to exclude default / hard-coded helm annotations for jobs and other relevant templates

2021-12-08 Thread GitBox
burakovsky commented on issue #17447: URL: https://github.com/apache/airflow/issues/17447#issuecomment-989374372 Is it possible to add a similar configuration for other resources with hardcoded helm annotations (extra-configmaps, redis-secrets.yaml) ? -- This is an automated message

[airflow] branch main updated (9a92a56 -> f99d0e7)

2021-12-08 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9a92a56 Deferrable operators doc clarification (#20150) add f99d0e7 Bump minimum required ``alembic``

[GitHub] [airflow] potiuk commented on issue #20134: Negsignal.SIGABRT when trying to create matplotlib plots in DAG

2021-12-08 Thread GitBox
potiuk commented on issue #20134: URL: https://github.com/apache/airflow/issues/20134#issuecomment-989357811 There is not much information but from your description it looks like this (or similar):

[airflow] branch main updated (112114e -> 9a92a56)

2021-12-08 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 112114e Update CODEOWNERS (#20152) add 9a92a56 Deferrable operators doc clarification (#20150) No new

[GitHub] [airflow] kaxil merged pull request #20153: Bump minimum required ``alembic`` version

2021-12-08 Thread GitBox
kaxil merged pull request #20153: URL: https://github.com/apache/airflow/pull/20153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil merged pull request #20150: Deferrable operators doc clarification

2021-12-08 Thread GitBox
kaxil merged pull request #20150: URL: https://github.com/apache/airflow/pull/20150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] SamWheating commented on a change in pull request #19950: Add clear logging to tasks killed due to a Dagrun timeout

2021-12-08 Thread GitBox
SamWheating commented on a change in pull request #19950: URL: https://github.com/apache/airflow/pull/19950#discussion_r765356556 ## File path: airflow/jobs/local_task_job.py ## @@ -208,6 +208,13 @@ def heartbeat_callback(self, session=None): )

[GitHub] [airflow] uranusjr commented on a change in pull request #18724: Use `DagRun.run_id` instead of `execution_date` when updating state of TIs(UI & REST API)

2021-12-08 Thread GitBox
uranusjr commented on a change in pull request #18724: URL: https://github.com/apache/airflow/pull/18724#discussion_r765347284 ## File path: airflow/models/dag.py ## @@ -179,6 +179,20 @@ def get_last_dagrun(dag_id, session, include_externally_triggered=False): return

[GitHub] [airflow] SamWheating commented on a change in pull request #18557: Warning of public exposure of deployment in UI with on/off config

2021-12-08 Thread GitBox
SamWheating commented on a change in pull request #18557: URL: https://github.com/apache/airflow/pull/18557#discussion_r765349989 ## File path: airflow/config_templates/config.yml ## @@ -1300,6 +1300,13 @@ type: integer example: ~ default: "3" +- name:

[GitHub] [airflow] potiuk commented on issue #20144: SFTPHook requires param 'ftp_conn_id' to be passed even for ssh connections

2021-12-08 Thread GitBox
potiuk commented on issue #20144: URL: https://github.com/apache/airflow/issues/20144#issuecomment-989341737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] dstandish commented on a change in pull request #18724: Use `DagRun.run_id` instead of `execution_date` when updating state of TIs(UI & REST API)

2021-12-08 Thread GitBox
dstandish commented on a change in pull request #18724: URL: https://github.com/apache/airflow/pull/18724#discussion_r765345335 ## File path: airflow/api_connexion/endpoints/task_instance_endpoint.py ## @@ -297,15 +296,34 @@ def post_set_task_instances_state(dag_id, session):

[GitHub] [airflow] dstandish commented on a change in pull request #18724: Use `DagRun.run_id` instead of `execution_date` when updating state of TIs(UI & REST API)

2021-12-08 Thread GitBox
dstandish commented on a change in pull request #18724: URL: https://github.com/apache/airflow/pull/18724#discussion_r765345335 ## File path: airflow/api_connexion/endpoints/task_instance_endpoint.py ## @@ -297,15 +296,34 @@ def post_set_task_instances_state(dag_id, session):

[GitHub] [airflow] SamWheating commented on a change in pull request #19950: Add clear logging to tasks killed due to a Dagrun timeout

2021-12-08 Thread GitBox
SamWheating commented on a change in pull request #19950: URL: https://github.com/apache/airflow/pull/19950#discussion_r765344407 ## File path: airflow/jobs/local_task_job.py ## @@ -208,6 +208,14 @@ def heartbeat_callback(self, session=None): )

[GitHub] [airflow] hwooson12 commented on a change in pull request #20002: Add hour and minute to time format on x-axis of all charts using nvd3.lineChart

2021-12-08 Thread GitBox
hwooson12 commented on a change in pull request #20002: URL: https://github.com/apache/airflow/pull/20002#discussion_r765344252 ## File path: airflow/www/views.py ## @@ -136,6 +136,11 @@ PAGE_SIZE = conf.getint('webserver', 'page_size') FILTER_TAGS_COOKIE = 'tags_filter'

[GitHub] [airflow] mik-laj commented on a change in pull request #18557: Warning of public exposure of deployment in UI with on/off config

2021-12-08 Thread GitBox
mik-laj commented on a change in pull request #18557: URL: https://github.com/apache/airflow/pull/18557#discussion_r765342946 ## File path: airflow/www/views.py ## @@ -702,6 +703,29 @@ def _iter_parsed_moved_data_table_names(): # Second segment is a version

[GitHub] [airflow] kaxil commented on issue #20144: SFTPHook requires param 'ftp_conn_id' to be passed even for ssh connections

2021-12-08 Thread GitBox
kaxil commented on issue #20144: URL: https://github.com/apache/airflow/issues/20144#issuecomment-989335523 Oh yes this is regarding the Hook, I am fine with that. The SftpOperator uses the SSHHook anyway so all food  -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] kaxil commented on issue #20139: Restructure Amazon provider operators files

2021-12-08 Thread GitBox
kaxil commented on issue #20139: URL: https://github.com/apache/airflow/issues/20139#issuecomment-989334325 Agree with the proposed changes @eladkal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] potiuk commented on issue #20144: SFTPHook requires param 'ftp_conn_id' to be passed even for ssh connections

2021-12-08 Thread GitBox
potiuk commented on issue #20144: URL: https://github.com/apache/airflow/issues/20144#issuecomment-989334148 And there is disconnect which one is used between the Operator and Hook. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk commented on issue #20144: SFTPHook requires param 'ftp_conn_id' to be passed even for ssh connections

2021-12-08 Thread GitBox
potiuk commented on issue #20144: URL: https://github.com/apache/airflow/issues/20144#issuecomment-989333959 It's really about the "__iniit__" parameter name of Hook, so I am not sure if we should have two variants :). One should be blesssed. -- This is an automated message from the

[GitHub] [airflow] github-actions[bot] closed pull request #19053: Referencing Connections in tutorial doc

2021-12-08 Thread GitBox
github-actions[bot] closed pull request #19053: URL: https://github.com/apache/airflow/pull/19053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on issue #13916: ECONNRESET error in scheduler using KubernetesExecutor on AKS

2021-12-08 Thread GitBox
github-actions[bot] commented on issue #13916: URL: https://github.com/apache/airflow/issues/13916#issuecomment-989328161 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] github-actions[bot] closed pull request #14640: Allow ExternalTaskSensor to wait for taskgroup

2021-12-08 Thread GitBox
github-actions[bot] closed pull request #14640: URL: https://github.com/apache/airflow/pull/14640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on issue #14175: ERROR - Unknown error in KubernetesJobWatcher. Failing

2021-12-08 Thread GitBox
github-actions[bot] commented on issue #14175: URL: https://github.com/apache/airflow/issues/14175#issuecomment-989328149 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] kaxil commented on issue #12338: Add docs on Release process w.r.t test and stable branches

2021-12-08 Thread GitBox
kaxil commented on issue #12338: URL: https://github.com/apache/airflow/issues/12338#issuecomment-989319767 > I tink we can close that one. We are really not in 1.10 any more and I think the cherry-picking process for v2* branches is much more strightforward now WDYT @kaxil . Agree

[GitHub] [airflow] kaxil closed issue #12338: Add docs on Release process w.r.t test and stable branches

2021-12-08 Thread GitBox
kaxil closed issue #12338: URL: https://github.com/apache/airflow/issues/12338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil commented on pull request #18557: Warning of public exposure of deployment in UI with on/off config

2021-12-08 Thread GitBox
kaxil commented on pull request #18557: URL: https://github.com/apache/airflow/pull/18557#issuecomment-989318574 Can you review this again @SamWheating to see if your comments are addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] github-actions[bot] commented on pull request #18557: Warning of public exposure of deployment in UI with on/off config

2021-12-08 Thread GitBox
github-actions[bot] commented on pull request #18557: URL: https://github.com/apache/airflow/pull/18557#issuecomment-989318550 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] github-actions[bot] commented on pull request #20153: Bump minimum required ``alembic`` version

2021-12-08 Thread GitBox
github-actions[bot] commented on pull request #20153: URL: https://github.com/apache/airflow/pull/20153#issuecomment-989318260 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] kaxil opened a new pull request #20153: Bump minimum required ``alembic`` version

2021-12-08 Thread GitBox
kaxil opened a new pull request #20153: URL: https://github.com/apache/airflow/pull/20153 Related to https://github.com/apache/airflow/pull/18453#issuecomment-989314399 `1.5.0` was yanked so `>=1.5.1` is safe and we already have `1.7.5` in constraints-main --- **^

[GitHub] [airflow] kaxil edited a comment on pull request #18453: Remove redundant ``session.commit()`` in migration

2021-12-08 Thread GitBox
kaxil edited a comment on pull request #18453: URL: https://github.com/apache/airflow/pull/18453#issuecomment-989314399 OK I can confirm that `alembic==1.4.2` is the issue you have, upgrade the version to at least `1.7.4` (specified by constraints). Even `1.5.1` should work -- This is

[GitHub] [airflow] kaxil edited a comment on pull request #18453: Remove redundant ``session.commit()`` in migration

2021-12-08 Thread GitBox
kaxil edited a comment on pull request #18453: URL: https://github.com/apache/airflow/pull/18453#issuecomment-989314399 OK I can confirm that `alembic==1.4.2` is the issue you have, upgrade the version to at least `1.7.4` (specified by constraints). Even `1.5` should work -- This is an

[GitHub] [airflow] kaxil edited a comment on pull request #18453: Remove redundant ``session.commit()`` in migration

2021-12-08 Thread GitBox
kaxil edited a comment on pull request #18453: URL: https://github.com/apache/airflow/pull/18453#issuecomment-989314399 OK I can confirm that `alembic==1.4.2` is the issue you have, upgrade the version to at least `1.7.4` (specified by constraints). Even 1.6 should work -- This is an

[GitHub] [airflow] kaxil commented on pull request #18453: Remove redundant ``session.commit()`` in migration

2021-12-08 Thread GitBox
kaxil commented on pull request #18453: URL: https://github.com/apache/airflow/pull/18453#issuecomment-989314399 OK I can confirm that `alembic==1.4.2` is the issue you have, upgrade the version to at least `1.7.4` (specified by constraints) -- This is an automated message from the

[GitHub] [airflow] kaxil edited a comment on pull request #18453: Remove redundant ``session.commit()`` in migration

2021-12-08 Thread GitBox
kaxil edited a comment on pull request #18453: URL: https://github.com/apache/airflow/pull/18453#issuecomment-989313618 @yuqian90 Some of your requirements are different than the one in [constraints file ](https://github.com/apache/airflow/blob/constraints-2.2.2/constraints-3.7.txt) that

[GitHub] [airflow] kaxil commented on pull request #18453: Remove redundant ``session.commit()`` in migration

2021-12-08 Thread GitBox
kaxil commented on pull request #18453: URL: https://github.com/apache/airflow/pull/18453#issuecomment-989313618 @yuqian90 Some of your requirements are different than the one in [constraints file ](https://github.com/apache/airflow/blob/constraints-2.2.2/constraints-3.7.txt)

[GitHub] [airflow] potiuk commented on a change in pull request #19914: Fix mypy errors in airflow utils

2021-12-08 Thread GitBox
potiuk commented on a change in pull request #19914: URL: https://github.com/apache/airflow/pull/19914#discussion_r765323415 ## File path: airflow/utils/timezone.py ## @@ -179,8 +179,7 @@ def coerce_datetime(v: Union[None, dt.datetime, DateTime]) -> Optional[DateTime]

[GitHub] [airflow] kaxil commented on pull request #17349: #16037 Add support for passing templated requirements.txt in PythonVirtualenvOperator

2021-12-08 Thread GitBox
kaxil commented on pull request #17349: URL: https://github.com/apache/airflow/pull/17349#issuecomment-989311500 Merge Conflicts :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[airflow] branch main updated (abe842c -> 112114e)

2021-12-08 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from abe842c Extend config window on UI (#20052) add 112114e Update CODEOWNERS (#20152) No new revisions were

[GitHub] [airflow] kaxil merged pull request #20152: Update CODEOWNERS

2021-12-08 Thread GitBox
kaxil merged pull request #20152: URL: https://github.com/apache/airflow/pull/20152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #20152: Update CODEOWNERS

2021-12-08 Thread GitBox
github-actions[bot] commented on pull request #20152: URL: https://github.com/apache/airflow/pull/20152#issuecomment-989307767 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] kaxil opened a new pull request #20152: Update CODEOWNERS

2021-12-08 Thread GitBox
kaxil opened a new pull request #20152: URL: https://github.com/apache/airflow/pull/20152 The Changes are self-explanatory in the diff :) --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] potiuk commented on a change in pull request #19914: Fix mypy errors in airflow utils

2021-12-08 Thread GitBox
potiuk commented on a change in pull request #19914: URL: https://github.com/apache/airflow/pull/19914#discussion_r765317510 ## File path: airflow/utils/log/logging_mixin.py ## @@ -134,6 +136,56 @@ def isatty(self): """ return False +def fileno(self) ->

[GitHub] [airflow] kaxil commented on pull request #19949: Only update label when adopting to prevent new pods

2021-12-08 Thread GitBox
kaxil commented on pull request #19949: URL: https://github.com/apache/airflow/pull/19949#issuecomment-989299026 I am not sure if this is the correct change, wdyt @jedcunningham @dstandish -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] kaxil commented on issue #20143: task_instance_mutation_hook not applied every time

2021-12-08 Thread GitBox
kaxil commented on issue #20143: URL: https://github.com/apache/airflow/issues/20143#issuecomment-989294384 cc @dstandish Can you try and replicate this one please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] kaxil commented on issue #20144: SFTPHook requires param 'ftp_conn_id' to be passed even for ssh connections

2021-12-08 Thread GitBox
kaxil commented on issue #20144: URL: https://github.com/apache/airflow/issues/20144#issuecomment-989293726 I would say rather than deprecating, allow both as it is quite common to use SSH for get and send files -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] kaxil commented on a change in pull request #19950: Add clear logging to tasks killed due to a Dagrun timeout

2021-12-08 Thread GitBox
kaxil commented on a change in pull request #19950: URL: https://github.com/apache/airflow/pull/19950#discussion_r765304211 ## File path: airflow/jobs/local_task_job.py ## @@ -208,6 +208,14 @@ def heartbeat_callback(self, session=None): )

[GitHub] [airflow] mdcsaenz commented on issue #13573: Airflow Google oAuth failing with Invalid response from google on 1.10.12-python3.6

2021-12-08 Thread GitBox
mdcsaenz commented on issue #13573: URL: https://github.com/apache/airflow/issues/13573#issuecomment-989284864 Closing b/c it led to me putting this issue https://github.com/apache/airflow/issues/16783 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mdcsaenz closed issue #13573: Airflow Google oAuth failing with Invalid response from google on 1.10.12-python3.6

2021-12-08 Thread GitBox
mdcsaenz closed issue #13573: URL: https://github.com/apache/airflow/issues/13573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #20151: Deprecate smart sensors

2021-12-08 Thread GitBox
github-actions[bot] commented on pull request #20151: URL: https://github.com/apache/airflow/pull/20151#issuecomment-989280012 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on issue #20144: SFTPHook requires param 'ftp_conn_id' to be passed even for ssh connections

2021-12-08 Thread GitBox
potiuk commented on issue #20144: URL: https://github.com/apache/airflow/issues/20144#issuecomment-989279011 OK. Works for me. Sftp is really ssh under-the-hood indeed. But you should make sure to keep deprecated previous option working too. Assigning you :D -- This is an automated

[GitHub] [airflow] jedcunningham opened a new pull request #20151: Deprecate smart sensors

2021-12-08 Thread GitBox
jedcunningham opened a new pull request #20151: URL: https://github.com/apache/airflow/pull/20151 Smart sensors are being replaced with Deferrable Operators. As they were marked as an early-access feature, we can remove them before Airflow 3. (Don't merge before December 15th)

[GitHub] [airflow] kaxil commented on a change in pull request #19572: Simplify ``KubernetesPodOperator``

2021-12-08 Thread GitBox
kaxil commented on a change in pull request #19572: URL: https://github.com/apache/airflow/pull/19572#discussion_r765293105 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -328,101 +340,130 @@ def create_labels_for_pod(context) -> dict:

[GitHub] [airflow] kaxil commented on a change in pull request #19572: Simplify ``KubernetesPodOperator``

2021-12-08 Thread GitBox
kaxil commented on a change in pull request #19572: URL: https://github.com/apache/airflow/pull/19572#discussion_r765292706 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -328,101 +340,130 @@ def create_labels_for_pod(context) -> dict:

[GitHub] [airflow] potiuk commented on a change in pull request #19911: Fix mypy checks for api_connexion

2021-12-08 Thread GitBox
potiuk commented on a change in pull request #19911: URL: https://github.com/apache/airflow/pull/19911#discussion_r765292461 ## File path: airflow/api_connexion/endpoints/dag_endpoint.py ## @@ -111,15 +110,15 @@ def patch_dag(session, dag_id, update_mask=None):

[GitHub] [airflow] kaxil commented on a change in pull request #19572: Simplify ``KubernetesPodOperator``

2021-12-08 Thread GitBox
kaxil commented on a change in pull request #19572: URL: https://github.com/apache/airflow/pull/19572#discussion_r765292182 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -328,101 +340,130 @@ def create_labels_for_pod(context) -> dict:

[GitHub] [airflow] saveriogzz commented on issue #20144: SFTPHook requires param 'ftp_conn_id' to be passed even for ssh connections

2021-12-08 Thread GitBox
saveriogzz commented on issue #20144: URL: https://github.com/apache/airflow/issues/20144#issuecomment-989276707 To be consistent with the SFTPOperator and not to mislead the type of connection to be used since there are both FTP and SFTP connections! -- This is an automated message

[GitHub] [airflow] mik-laj commented on issue #20142: DAG_run_id not include Task Instance object for REST API

2021-12-08 Thread GitBox
mik-laj commented on issue #20142: URL: https://github.com/apache/airflow/issues/20142#issuecomment-989276094 Done: https://github.com/apache/airflow/pull/19105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

  1   2   3   4   5   >