[GitHub] [airflow] eladkal commented on a diff in pull request #24836: Move all SQL classes to common-sql provider

2022-07-04 Thread GitBox
eladkal commented on code in PR #24836: URL: https://github.com/apache/airflow/pull/24836#discussion_r913396000 ## airflow/providers/common/sql/provider.yaml: ## @@ -16,26 +16,35 @@ # under the License. --- -package-name: apache-airflow-providers-core-sql -name: Core SQL

[airflow] branch main updated (34b2ed4066 -> b6a2759417)

2022-07-04 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 34b2ed4066 Add configurable scheme for webserver probes (#22815) add b6a2759417 Add support for Salesforce bulk

[GitHub] [airflow] eladkal merged pull request #24473: Add support for Salesforce bulk api

2022-07-04 Thread GitBox
eladkal merged PR #24473: URL: https://github.com/apache/airflow/pull/24473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] eladkal closed issue #16921: Add support for Salesforce Bulk API

2022-07-04 Thread GitBox
eladkal closed issue #16921: Add support for Salesforce Bulk API URL: https://github.com/apache/airflow/issues/16921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] pasalkarsachin1 commented on pull request #24726: `DockerOperator` fix cli.logs giving character array instead of string

2022-07-04 Thread GitBox
pasalkarsachin1 commented on PR #24726: URL: https://github.com/apache/airflow/pull/24726#issuecomment-1174609512 > > > I do wonder if there was some reason that we called got the logs again instead of using tht lines we already had. I expect not, but I wonder who might know. > > >

[GitHub] [airflow] potiuk commented on pull request #24836: Move all SQL classes to common-sql provider

2022-07-04 Thread GitBox
potiuk commented on PR #24836: URL: https://github.com/apache/airflow/pull/24836#issuecomment-1174507829 cc: @denimalpaca - this one implements more complete version of #24790 (some tests were failiing) - it also moves the `DBApi` and `SQLSensor` to rhe new provider. -- This is an

[GitHub] [airflow] o-nikolas commented on pull request #24643: Convert Step Functions Example DAG to System Test (AIP-47)

2022-07-04 Thread GitBox
o-nikolas commented on PR #24643: URL: https://github.com/apache/airflow/pull/24643#issuecomment-1174506896 > Looks nice! So the TaskFlow is used to manage system test configuration. What will happen if TaskFlow itself fails, will it be clear to users that it failed in _setup_ phase rather

[GitHub] [airflow] o-nikolas commented on a diff in pull request #24643: Convert Step Functions Example DAG to System Test (AIP-47)

2022-07-04 Thread GitBox
o-nikolas commented on code in PR #24643: URL: https://github.com/apache/airflow/pull/24643#discussion_r913321709 ## tests/system/providers/amazon/aws/utils/__init__.py: ## @@ -102,7 +105,54 @@ def _fetch_from_ssm(key: str) -> str: return value -def fetch_variable(key:

[GitHub] [airflow] potiuk opened a new pull request, #24836: Move all SQL classes to common-sql provider

2022-07-04 Thread GitBox
potiuk opened a new pull request, #24836: URL: https://github.com/apache/airflow/pull/24836 The DBApiHook, SQLSensor are now part of the common.sql provider. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] potiuk closed issue #24788: Make task_instance priority_weight dag_run/execution_date dependent

2022-07-04 Thread GitBox
potiuk closed issue #24788: Make task_instance priority_weight dag_run/execution_date dependent URL: https://github.com/apache/airflow/issues/24788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on issue #24788: Make task_instance priority_weight dag_run/execution_date dependent

2022-07-04 Thread GitBox
potiuk commented on issue #24788: URL: https://github.com/apache/airflow/issues/24788#issuecomment-1174466564 This would be a major change in the architectuer of scheduler and executor. I think it is not enough to make it a feature. If someone would like to implement such prioritisation

[airflow] branch main updated: Add configurable scheme for webserver probes (#22815)

2022-07-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 34b2ed4066 Add configurable scheme for webserver

[GitHub] [airflow] potiuk merged pull request #22815: Add configurable scheme for webserver probes

2022-07-04 Thread GitBox
potiuk merged PR #22815: URL: https://github.com/apache/airflow/pull/22815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #23870: DAG regex flag in backfill command

2022-07-04 Thread GitBox
potiuk commented on PR #23870: URL: https://github.com/apache/airflow/pull/23870#issuecomment-1174465021 LGTM. WDYT @uranusjr ? I think "Explicit is better than implicit" so even if we could detect it automatically, I think we should not. -- This is an automated message from the Apache

[GitHub] [airflow] potiuk closed issue #24779: Return objects from PythonVirtualenvOperator

2022-07-04 Thread GitBox
potiuk closed issue #24779: Return objects from PythonVirtualenvOperator URL: https://github.com/apache/airflow/issues/24779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on issue #24779: Return objects from PythonVirtualenvOperator

2022-07-04 Thread GitBox
potiuk commented on issue #24779: URL: https://github.com/apache/airflow/issues/24779#issuecomment-1174462432 If you know how unpickling works, what you want to achieve is impossible. This is how Python works, nothing specificy to Airlfow. There is no way to have an object of a type that

[GitHub] [airflow] potiuk commented on pull request #24716: KubernetesPodOperator can get namespace from hook

2022-07-04 Thread GitBox
potiuk commented on PR #24716: URL: https://github.com/apache/airflow/pull/24716#issuecomment-1174460623 Tests are failing (and it seems related). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on issue #24739: DAG specific permissions cannot be split between 2 roles

2022-07-04 Thread GitBox
potiuk commented on issue #24739: URL: https://github.com/apache/airflow/issues/24739#issuecomment-1174453939 This is unlikely to be handled before we get mutlitenancy implemented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk commented on issue #24731: Celery Executor : After killing Redis or Airflow Worker Pod, queued Tasks not getting executed even after pod is up.

2022-07-04 Thread GitBox
potiuk commented on issue #24731: URL: https://github.com/apache/airflow/issues/24731#issuecomment-1174453268 Assigned you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] potiuk commented on issue #10893: Add new operator for ClickHouse

2022-07-04 Thread GitBox
potiuk commented on issue #10893: URL: https://github.com/apache/airflow/issues/10893#issuecomment-1174453070 It's merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] potiuk commented on issue #19767: dag callbacks are missed sometimes

2022-07-04 Thread GitBox
potiuk commented on issue #19767: URL: https://github.com/apache/airflow/issues/19767#issuecomment-1174452996 @liuning89757 - can you please provide more evidences? Logs, circumstances, etc. Your problem might be different and the more evidences you provide, the bigger chance there is it

[airflow] branch main updated: Update AWS Connection docs and deprecate some extras (#24670)

2022-07-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c61f86dde5 Update AWS Connection docs and

[GitHub] [airflow] potiuk merged pull request #24670: Update AWS Connection docs and deprecate some extras

2022-07-04 Thread GitBox
potiuk merged PR #24670: URL: https://github.com/apache/airflow/pull/24670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #24825: Dockerfile centos

2022-07-04 Thread GitBox
potiuk commented on PR #24825: URL: https://github.com/apache/airflow/pull/24825#issuecomment-1174437799 I converted it to Draft then. Maybe indeed there will be time to implement it at some poin in time. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk closed issue #24833: Github SSO OAuth in Airflow 2.3.2 Issue

2022-07-04 Thread GitBox
potiuk closed issue #24833: Github SSO OAuth in Airflow 2.3.2 Issue URL: https://github.com/apache/airflow/issues/24833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] mik-laj commented on pull request #24825: Dockerfile centos

2022-07-04 Thread GitBox
mik-laj commented on PR #24825: URL: https://github.com/apache/airflow/pull/24825#issuecomment-1174423386 Honestly, it wasn't our intention to merge this change, and it certainly wasn't as it was. We created this PR because you were interested to see what our image looked like and we

[GitHub] [airflow] boring-cyborg[bot] commented on issue #24833: Github SSO OAuth in Airflow 2.3.2 Issue

2022-07-04 Thread GitBox
boring-cyborg[bot] commented on issue #24833: URL: https://github.com/apache/airflow/issues/24833#issuecomment-1174420133 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] NicolasAndresCalvo opened a new issue, #24833: Github SSO OAuth in Airflow 2.3.2 Issue

2022-07-04 Thread GitBox
NicolasAndresCalvo opened a new issue, #24833: URL: https://github.com/apache/airflow/issues/24833 ### Apache Airflow version 2.3.2 (latest released) ### What happened Hi team, i was trying to enable Github SSO auth in my Airflow but i got 404 page as a result. I follow

[GitHub] [airflow] ferruzzi commented on pull request #24726: `DockerOperator` fix cli.logs giving character array instead of string

2022-07-04 Thread GitBox
ferruzzi commented on PR #24726: URL: https://github.com/apache/airflow/pull/24726#issuecomment-1174417109 >> I do wonder if there was some reason that we called got the logs again instead of using tht lines we already had. I expect not, but I wonder who might know. >As per

[GitHub] [airflow] potiuk commented on pull request #22976: Make sure jobs triggered by airflow web are not identified as orphaned.

2022-07-04 Thread GitBox
potiuk commented on PR #22976: URL: https://github.com/apache/airflow/pull/22976#issuecomment-1174415526 can you please rebase @nclaeys ? there is a conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk commented on pull request #22692: Add support for Delta Sharing protocol

2022-07-04 Thread GitBox
potiuk commented on PR #22692: URL: https://github.com/apache/airflow/pull/22692#issuecomment-1174415061 Feel Free. It's merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk commented on pull request #24726: `DockerOperator` fix cli.logs giving character array instead of string

2022-07-04 Thread GitBox
potiuk commented on PR #24726: URL: https://github.com/apache/airflow/pull/24726#issuecomment-1174414872 @ferruzzi - any comments ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk commented on issue #12562: Airflow requires to-be-deprecated flag when using MySQL

2022-07-04 Thread GitBox
potiuk commented on issue #12562: URL: https://github.com/apache/airflow/issues/12562#issuecomment-1174411720 It really needs some investigation why it was needed. I am not sure if anyone ever remembers why. -- This is an automated message from the Apache Git Service. To respond to the

[airflow] branch main updated: Datacatalog assets & system tests migration (AIP-47) (#24600)

2022-07-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9227d56e68 Datacatalog assets & system tests

[GitHub] [airflow] potiuk merged pull request #24600: Datacatalog assets & system tests migration (AIP-47)

2022-07-04 Thread GitBox
potiuk merged PR #24600: URL: https://github.com/apache/airflow/pull/24600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #20603: Airflow 2.2.3 : AirflowContextDeprecationWarning executing a DAG with PythonOperator that accesses the context

2022-07-04 Thread GitBox
potiuk commented on issue #20603: URL: https://github.com/apache/airflow/issues/20603#issuecomment-1174408416 @BernhardNiksch - please open a new issue and provide evidences - logs, details circumstances, etc. Adding a comment "I have the same issue" on a closed issue brings exactly 0

[GitHub] [airflow] potiuk commented on pull request #24666: Add more selective provider tests

2022-07-04 Thread GitBox
potiuk commented on PR #24666: URL: https://github.com/apache/airflow/pull/24666#issuecomment-1174402678 Anyone ? This should speed up the tests in most cases and adds a way how to run tests per provider (will be useful in the future when we split providers). -- This is an automated

[GitHub] [airflow] potiuk commented on issue #24674: AirflowSecurityManager inconsistent with Flask-appbuilder when using @protect API in custom plugins

2022-07-04 Thread GitBox
potiuk commented on issue #24674: URL: https://github.com/apache/airflow/issues/24674#issuecomment-1174390402 Correct. SecurityManager is a trimmed-down version of FAB Security Manager that only implements subset needed to implement the UI and it does not implement all features. But You

[GitHub] [airflow] potiuk closed issue #24674: AirflowSecurityManager inconsistent with Flask-appbuilder when using @protect API in custom plugins

2022-07-04 Thread GitBox
potiuk closed issue #24674: AirflowSecurityManager inconsistent with Flask-appbuilder when using @protect API in custom plugins URL: https://github.com/apache/airflow/issues/24674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] ephraimbuddy commented on issue #19785: Applying labels to task groups shows a cycle in the graph view for the dag

2022-07-04 Thread GitBox
ephraimbuddy commented on issue #19785: URL: https://github.com/apache/airflow/issues/19785#issuecomment-1174387487 > Is there a stack trace in the webserver logs? (It looks like the API call failed with a 500) Yes. Here's the stacktrace: ```log [2022-07-04 21:18:55+ 929ms]

[GitHub] [airflow] ephraimbuddy commented on issue #19785: Applying labels to task groups shows a cycle in the graph view for the dag

2022-07-04 Thread GitBox
ephraimbuddy commented on issue #19785: URL: https://github.com/apache/airflow/issues/19785#issuecomment-1174381917 For the above dag, writing the chain as below works: ```python chain([Label("branch three")], [taskgroup1], t4) ``` or ```python chain(Label("branch three"),

[GitHub] [airflow] potiuk commented on pull request #24668: added component specific labels

2022-07-04 Thread GitBox
potiuk commented on PR #24668: URL: https://github.com/apache/airflow/pull/24668#issuecomment-1174374724 This one has static chceks and docs failing. You need to fix it before we review it @mayankbatra123 -- This is an automated message from the Apache Git Service. To respond to the

[airflow] branch main updated: Add test_connection method to AWS hook (#24662)

2022-07-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 210549c658 Add test_connection method to AWS hook

[GitHub] [airflow] potiuk merged pull request #24662: Add test_connection method to AWS hook

2022-07-04 Thread GitBox
potiuk merged PR #24662: URL: https://github.com/apache/airflow/pull/24662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] 1101110111100000110100011 commented on issue #22657: Wrong apiVersion Detected During Ingress Creation

2022-07-04 Thread GitBox
11011100110100011 commented on issue #22657: URL: https://github.com/apache/airflow/issues/22657#issuecomment-1174364816 Hi, I faced the same problem (with same config, aka microk8s). Using Helm template and then kubectl helped me bypass the problem. Hope it would be the same

[GitHub] [airflow] potiuk commented on pull request #24499: Add cache_ok flag to sqlalchemy TypeDecorators.

2022-07-04 Thread GitBox
potiuk commented on PR #24499: URL: https://github.com/apache/airflow/pull/24499#issuecomment-1174343072 Just in case - we should rebase this one after #24819 gets merged to test its behaviour anyway. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] potiuk commented on pull request #24499: Add cache_ok flag to sqlalchemy TypeDecorators.

2022-07-04 Thread GitBox
potiuk commented on PR #24499: URL: https://github.com/apache/airflow/pull/24499#issuecomment-1174340740 Makes sense . I rebased to see if it will be fine. also it might be necesary after #24819 is merged as we will be upgrading to sqlalchemy > 1.4.39 that will start emit this warning.

[airflow] branch main updated: Add parameter to turn off SQL query logging (#24570)

2022-07-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 53284cf272 Add parameter to turn off SQL query

[GitHub] [airflow] potiuk merged pull request #24570: Add parameter to turn off SQL query logging

2022-07-04 Thread GitBox
potiuk merged PR #24570: URL: https://github.com/apache/airflow/pull/24570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed issue #11618: Support to turn off the sql echo at logging in dbapi_hook

2022-07-04 Thread GitBox
potiuk closed issue #11618: Support to turn off the sql echo at logging in dbapi_hook URL: https://github.com/apache/airflow/issues/11618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] branch main updated: Serialize pod_override to JSON before pickling executor_config (#24356)

2022-07-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c1d621c7ce Serialize pod_override to JSON before

[GitHub] [airflow] potiuk merged pull request #24356: Serialize pod_override to JSON before pickling executor_config

2022-07-04 Thread GitBox
potiuk merged PR #24356: URL: https://github.com/apache/airflow/pull/24356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #24356: Serialize pod_override to JSON before pickling executor_config

2022-07-04 Thread GitBox
potiuk commented on PR #24356: URL: https://github.com/apache/airflow/pull/24356#issuecomment-1174318773 Random failure. Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[airflow] branch main updated: perf(BigQuery): pass table_id as str type (#23141)

2022-07-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fe13eae3bf perf(BigQuery): pass table_id as str

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23141: perf(BigQuery): pass table_id as str type

2022-07-04 Thread GitBox
boring-cyborg[bot] commented on PR #23141: URL: https://github.com/apache/airflow/pull/23141#issuecomment-1174315170 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk merged pull request #23141: perf(BigQuery): pass table_id as str type

2022-07-04 Thread GitBox
potiuk merged PR #23141: URL: https://github.com/apache/airflow/pull/23141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ashb commented on issue #19785: Applying labels to task groups shows a cycle in the graph view for the dag

2022-07-04 Thread GitBox
ashb commented on issue #19785: URL: https://github.com/apache/airflow/issues/19785#issuecomment-1174293741 Is there a stack trace in the webserver logs? (It looks like the API call failed with a 500) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] potiuk closed issue #24642: Erroneous comment about need to address AIRFLOW-1455 in airflow_local_settings.py

2022-07-04 Thread GitBox
potiuk closed issue #24642: Erroneous comment about need to address AIRFLOW-1455 in airflow_local_settings.py URL: https://github.com/apache/airflow/issues/24642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk commented on issue #24642: Erroneous comment about need to address AIRFLOW-1455 in airflow_local_settings.py

2022-07-04 Thread GitBox
potiuk commented on issue #24642: URL: https://github.com/apache/airflow/issues/24642#issuecomment-1174285053 Airlfow is created by > 2100 contributors. It's far easier to remve the comment in a PR than open an issue about it. -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] potiuk commented on issue #24642: Erroneous comment about need to address AIRFLOW-1455 in airflow_local_settings.py

2022-07-04 Thread GitBox
potiuk commented on issue #24642: URL: https://github.com/apache/airflow/issues/24642#issuecomment-1174283162 Can you please remove it? It should be easy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[airflow] branch main updated: Migrate Google example DAG mssql_to_gcs to new design AIP-47 (#24541)

2022-07-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 37ea530cb7 Migrate Google example DAG mssql_to_gcs

[GitHub] [airflow] potiuk merged pull request #24541: Migrate Google example DAG mssql_to_gcs to new design AIP-47

2022-07-04 Thread GitBox
potiuk merged PR #24541: URL: https://github.com/apache/airflow/pull/24541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #24819: Remove upper-binding for SQLAlchemy

2022-07-04 Thread GitBox
potiuk commented on PR #24819: URL: https://github.com/apache/airflow/pull/24819#issuecomment-1174234844 All Green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] mik-laj commented on issue #10742: Enable More PyDocStyle Checks

2022-07-04 Thread GitBox
mik-laj commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1174217080 @edithturn SGTM. The smaller the changes are, the easier it will be to review and merge. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] asosnovsky-sumologic commented on issue #22318: KubernetesPodOperator xcom sidecar stuck in running

2022-07-04 Thread GitBox
asosnovsky-sumologic commented on issue #22318: URL: https://github.com/apache/airflow/issues/22318#issuecomment-1174144626 @tnyz so I just encountered this issue myself. It seems that if the base container finishes without writing to the xcom file (`/airflow/xcom/return.json`) or if the

[GitHub] [airflow] Taragolis commented on pull request #23560: Add advanced secrets backend configurations

2022-07-04 Thread GitBox
Taragolis commented on PR #23560: URL: https://github.com/apache/airflow/pull/23560#issuecomment-1174010308 @potiuk @dstandish tl;dr: After tried to change something in secrets backends I found that might be better to try make this mechanism more transparent first at least for developers

[GitHub] [airflow] alexkruc commented on issue #24728: DAGs View: make Owner column hyperlink for a predefined URL

2022-07-04 Thread GitBox
alexkruc commented on issue #24728: URL: https://github.com/apache/airflow/issues/24728#issuecomment-1174002070 Hey guys! :) With your permission please, I might have some suggestions for relatively small and maybe "easy" implementations of this feature, that does not involve config

[GitHub] [airflow] ishiis commented on a diff in pull request #24473: Add support for Salesforce bulk api

2022-07-04 Thread GitBox
ishiis commented on code in PR #24473: URL: https://github.com/apache/airflow/pull/24473#discussion_r913148471 ## airflow/providers/salesforce/operators/bulk.py: ## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [airflow] eitanme commented on issue #23361: Scheduler crashes with psycopg2.errors.DeadlockDetected exception

2022-07-04 Thread GitBox
eitanme commented on issue #23361: URL: https://github.com/apache/airflow/issues/23361#issuecomment-1173989183 Just to follow up here on the deadlock issue I saw which, I think, is unrelated to the load issues associated with the new GridView though I'm happy to hear those will be fixed in

[GitHub] [airflow] dstandish commented on a diff in pull request #24743: Get dataset-driven scheduling working

2022-07-04 Thread GitBox
dstandish commented on code in PR #24743: URL: https://github.com/apache/airflow/pull/24743#discussion_r913140198 ## airflow/models/dataset_dag_ref.py: ## @@ -0,0 +1,60 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [airflow] ashb commented on pull request #24743: Get dataset-driven scheduling working

2022-07-04 Thread GitBox
ashb commented on PR #24743: URL: https://github.com/apache/airflow/pull/24743#issuecomment-1173987183 If the docstring in the example dag is still accurate: > Note that even though dag4 depends on the dataset in dag1, it will not be triggered until dag2 runs (and dag2 is Then

[GitHub] [airflow] chenglongyan opened a new pull request, #24830: Migrate Google firestore example to new design AIP-47

2022-07-04 Thread GitBox
chenglongyan opened a new pull request, #24830: URL: https://github.com/apache/airflow/pull/24830 related: #22447, #22430 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] ashb commented on a diff in pull request #24743: Get dataset-driven scheduling working

2022-07-04 Thread GitBox
ashb commented on code in PR #24743: URL: https://github.com/apache/airflow/pull/24743#discussion_r913137378 ## airflow/models/dag.py: ## @@ -2509,6 +2524,67 @@ def bulk_write_to_db(cls, dags: Collection["DAG"], session=NEW_SESSION):

[GitHub] [airflow] ashb commented on a diff in pull request #24743: Get dataset-driven scheduling working

2022-07-04 Thread GitBox
ashb commented on code in PR #24743: URL: https://github.com/apache/airflow/pull/24743#discussion_r913135616 ## airflow/models/dataset_dag_ref.py: ## @@ -0,0 +1,60 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [airflow] ashb commented on a diff in pull request #24743: Get dataset-driven scheduling working

2022-07-04 Thread GitBox
ashb commented on code in PR #24743: URL: https://github.com/apache/airflow/pull/24743#discussion_r913135616 ## airflow/models/dataset_dag_ref.py: ## @@ -0,0 +1,60 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [airflow] ishiis commented on a diff in pull request #24473: Add support for Salesforce bulk api

2022-07-04 Thread GitBox
ishiis commented on code in PR #24473: URL: https://github.com/apache/airflow/pull/24473#discussion_r913132147 ## airflow/providers/salesforce/operators/bulk.py: ## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [airflow] dstandish commented on pull request #23560: Add advanced secrets backend configurations

2022-07-04 Thread GitBox
dstandish commented on PR #23560: URL: https://github.com/apache/airflow/pull/23560#issuecomment-1173975828 yeah @potiuk I suggested that if we add this new way of configuring, we have to deprecate the old way. @Taragolis has indicated that doing so is difficult / problematic /

[GitHub] [airflow] abin-tiger commented on issue #19627: Providing a metadata secret conflicts with the use of pgbouncer

2022-07-04 Thread GitBox
abin-tiger commented on issue #19627: URL: https://github.com/apache/airflow/issues/19627#issuecomment-1173971929 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] Taragolis commented on a diff in pull request #23560: Add advanced secrets backend configurations

2022-07-04 Thread GitBox
Taragolis commented on code in PR #23560: URL: https://github.com/apache/airflow/pull/23560#discussion_r913123196 ## airflow/config_templates/default_airflow.cfg: ## @@ -422,6 +422,13 @@ backend = # ``{{"connections_prefix": "/airflow/connections", "profile_name":

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #24156: Create new databases from the ORM

2022-07-04 Thread GitBox
ephraimbuddy commented on code in PR #24156: URL: https://github.com/apache/airflow/pull/24156#discussion_r913114437 ## tests/conftest.py: ## @@ -194,9 +194,11 @@ def pytest_addoption(parser): def initial_db_init(): from airflow.utils import db +from airflow.www.app

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #24156: Create new databases from the ORM

2022-07-04 Thread GitBox
ephraimbuddy commented on code in PR #24156: URL: https://github.com/apache/airflow/pull/24156#discussion_r913113969 ## airflow/utils/db.py: ## @@ -655,16 +655,34 @@ def create_default_connections(session: Session = NEW_SESSION): @provide_session def initdb(session: Session

[GitHub] [airflow] Taragolis commented on a diff in pull request #23560: Add advanced secrets backend configurations

2022-07-04 Thread GitBox
Taragolis commented on code in PR #23560: URL: https://github.com/apache/airflow/pull/23560#discussion_r913113058 ## airflow/configuration.py: ## @@ -1487,47 +1500,118 @@ def set(*args, **kwargs) -> None: conf.set(*args, **kwargs) -def ensure_secrets_loaded() ->

[GitHub] [airflow] potiuk commented on a diff in pull request #23560: Add advanced secrets backend configurations

2022-07-04 Thread GitBox
potiuk commented on code in PR #23560: URL: https://github.com/apache/airflow/pull/23560#discussion_r913110782 ## airflow/config_templates/default_airflow.cfg: ## @@ -422,6 +422,13 @@ backend = # ``{{"connections_prefix": "/airflow/connections", "profile_name": "default"}}``

[GitHub] [airflow] eladkal commented on issue #19785: Applying labels to task groups shows a cycle in the graph view for the dag

2022-07-04 Thread GitBox
eladkal commented on issue #19785: URL: https://github.com/apache/airflow/issues/19785#issuecomment-1173948974 @bbovenzi I tried to reproduce this issue and It seems like now this DAG is breaking the Grid view: ![Screen Shot 2022-07-04 at 18 35

[GitHub] [airflow] dstandish commented on pull request #24743: Get dataset-driven scheduling working

2022-07-04 Thread GitBox
dstandish commented on PR #24743: URL: https://github.com/apache/airflow/pull/24743#issuecomment-1173948817 OK addressed the comments > We still need to address the HA/lock issue As presently constructed we shouldn't get conflicts because I think each dagrun should get a

[GitHub] [airflow] potiuk commented on a diff in pull request #23560: Add advanced secrets backend configurations

2022-07-04 Thread GitBox
potiuk commented on code in PR #23560: URL: https://github.com/apache/airflow/pull/23560#discussion_r913110114 ## airflow/config_templates/default_airflow.cfg: ## @@ -422,6 +422,13 @@ backend = # ``{{"connections_prefix": "/airflow/connections", "profile_name": "default"}}``

[GitHub] [airflow] edithturn commented on pull request #23660: Add templates and constructor parameters to list-integrations

2022-07-04 Thread GitBox
edithturn commented on PR #23660: URL: https://github.com/apache/airflow/pull/23660#issuecomment-1173947195 @josh-fell yes that is pretty similar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on a diff in pull request #23560: Add advanced secrets backend configurations

2022-07-04 Thread GitBox
potiuk commented on code in PR #23560: URL: https://github.com/apache/airflow/pull/23560#discussion_r913107498 ## airflow/config_templates/default_airflow.cfg: ## @@ -422,6 +422,13 @@ backend = # ``{{"connections_prefix": "/airflow/connections", "profile_name": "default"}}``

[GitHub] [airflow] Taragolis commented on a diff in pull request #23560: Add advanced secrets backend configurations

2022-07-04 Thread GitBox
Taragolis commented on code in PR #23560: URL: https://github.com/apache/airflow/pull/23560#discussion_r913105349 ## airflow/config_templates/default_airflow.cfg: ## @@ -422,6 +422,13 @@ backend = # ``{{"connections_prefix": "/airflow/connections", "profile_name":

[GitHub] [airflow] Taragolis commented on a diff in pull request #23560: Add advanced secrets backend configurations

2022-07-04 Thread GitBox
Taragolis commented on code in PR #23560: URL: https://github.com/apache/airflow/pull/23560#discussion_r913105349 ## airflow/config_templates/default_airflow.cfg: ## @@ -422,6 +422,13 @@ backend = # ``{{"connections_prefix": "/airflow/connections", "profile_name":

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #24156: Create new databases from the ORM

2022-07-04 Thread GitBox
ephraimbuddy commented on code in PR #24156: URL: https://github.com/apache/airflow/pull/24156#discussion_r913104704 ## tests/conftest.py: ## @@ -194,9 +194,11 @@ def pytest_addoption(parser): def initial_db_init(): from airflow.utils import db +from airflow.www.app

[GitHub] [airflow] potiuk commented on pull request #23560: Add advanced secrets backend configurations

2022-07-04 Thread GitBox
potiuk commented on PR #23560: URL: https://github.com/apache/airflow/pull/23560#issuecomment-1173940941 Sorry @dstandish @Taragolis I know I promised to take a look before :( . Just one comment and question - I amnot sure if the extra class is needed at all? I think maybe because

[GitHub] [airflow] edithturn opened a new pull request, #24829: Improve documentation to add path of Breeze in a Mac with Python

2022-07-04 Thread GitBox
edithturn opened a new pull request, #24829: URL: https://github.com/apache/airflow/pull/24829 I was testing Breeze on a Mac and It will be better to specify how to add the path in Macs too because pix doesn´t work on it. -- This is an automated message from the Apache Git

[GitHub] [airflow] potiuk commented on a diff in pull request #23560: Add advanced secrets backend configurations

2022-07-04 Thread GitBox
potiuk commented on code in PR #23560: URL: https://github.com/apache/airflow/pull/23560#discussion_r913089337 ## airflow/configuration.py: ## @@ -1487,47 +1500,118 @@ def set(*args, **kwargs) -> None: conf.set(*args, **kwargs) -def ensure_secrets_loaded() ->

[GitHub] [airflow] dstandish commented on a diff in pull request #24743: Get dataset-driven scheduling working

2022-07-04 Thread GitBox
dstandish commented on code in PR #24743: URL: https://github.com/apache/airflow/pull/24743#discussion_r913099721 ## airflow/models/taskinstance.py: ## @@ -1521,7 +1524,17 @@ def _run_raw_task( if not test_mode: session.add(Log(self.state, self))

[GitHub] [airflow] dstandish commented on a diff in pull request #24743: Get dataset-driven scheduling working

2022-07-04 Thread GitBox
dstandish commented on code in PR #24743: URL: https://github.com/apache/airflow/pull/24743#discussion_r913097109 ## airflow/models/dataset_dag_run_queue.py: ## @@ -0,0 +1,62 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [airflow] edithturn commented on pull request #24610: Convert selective checks to Breeze Python

2022-07-04 Thread GitBox
edithturn commented on PR #24610: URL: https://github.com/apache/airflow/pull/24610#issuecomment-1173930350 It was merged, well done @potiuk Jarek 拾 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] dstandish commented on a diff in pull request #24743: Get dataset-driven scheduling working

2022-07-04 Thread GitBox
dstandish commented on code in PR #24743: URL: https://github.com/apache/airflow/pull/24743#discussion_r913094044 ## airflow/models/dag.py: ## @@ -2509,6 +2524,67 @@ def bulk_write_to_db(cls, dags: Collection["DAG"], session=NEW_SESSION):

[GitHub] [airflow] ashb commented on a diff in pull request #24156: Create new databases from the ORM

2022-07-04 Thread GitBox
ashb commented on code in PR #24156: URL: https://github.com/apache/airflow/pull/24156#discussion_r913092662 ## tests/conftest.py: ## @@ -194,9 +194,11 @@ def pytest_addoption(parser): def initial_db_init(): from airflow.utils import db +from airflow.www.app import

[GitHub] [airflow] ashb commented on a diff in pull request #24156: Create new databases from the ORM

2022-07-04 Thread GitBox
ashb commented on code in PR #24156: URL: https://github.com/apache/airflow/pull/24156#discussion_r913091357 ## airflow/utils/db.py: ## @@ -655,16 +655,34 @@ def create_default_connections(session: Session = NEW_SESSION): @provide_session def initdb(session: Session =

  1   2   3   >