uranusjr commented on code in PR #27072:
URL: https://github.com/apache/airflow/pull/27072#discussion_r1002895940
##
airflow/models/trigger.py:
##
@@ -196,15 +196,16 @@ def assign_unassigned(cls, triggerer_id, capacity,
session=None):
# Find triggers who do NOT have
uranusjr commented on code in PR #27072:
URL: https://github.com/apache/airflow/pull/27072#discussion_r1002895940
##
airflow/models/trigger.py:
##
@@ -196,15 +196,16 @@ def assign_unassigned(cls, triggerer_id, capacity,
session=None):
# Find triggers who do NOT have
dstandish commented on PR #27206:
URL: https://github.com/apache/airflow/pull/27206#issuecomment-1288431864
bam thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
uranusjr merged PR #27206:
URL: https://github.com/apache/airflow/pull/27206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jens-scheffler-bosch commented on issue #27032:
URL: https://github.com/apache/airflow/issues/27032#issuecomment-1288431435
> > As I see that the new Helm Chart 1.7.0 was released, does somebody know
or expect if the new liveness probe on Celery Worker will fix this problem
implicitly?
uranusjr opened a new pull request, #27224:
URL: https://github.com/apache/airflow/pull/27224
This can only be done when the commits are actually merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
dstandish pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 2a34dc9e84 Enable string normalization in python formatting -
providers (#27205)
add 6b9e76b7b3 Allow and
dstandish merged PR #27047:
URL: https://github.com/apache/airflow/pull/27047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk commented on issue #27089:
URL: https://github.com/apache/airflow/issues/27089#issuecomment-1288350736
Feel free to comment [there](https://github.com/apache/airflow/pull/26027)
@rajeshdhanda if you need this as well.
--
This is an automated message from the Apache Git Service.
To
potiuk commented on issue #27089:
URL: https://github.com/apache/airflow/issues/27089#issuecomment-1288350394
And my be fixed by https://github.com/apache/airflow/pull/26027 - it just
needs fixing/rebasing/answering comments.
--
This is an automated message from the Apache Git Service.
potiuk commented on PR #26949:
URL: https://github.com/apache/airflow/pull/26949#issuecomment-1288349096
I think it needs rebase and fixes (but It's a good one to have).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
potiuk commented on PR #13517:
URL: https://github.com/apache/airflow/pull/13517#issuecomment-1288348242
Feel free to pick it up @tirkarthi and contribute it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
potiuk commented on issue #27082:
URL: https://github.com/apache/airflow/issues/27082#issuecomment-1288346833
Ideally the fix should be to detect if group replication is on and follow
different migration path @tirkarthi.
We should not - for example - disable it for "all mysql".
dstandish commented on code in PR #27047:
URL: https://github.com/apache/airflow/pull/27047#discussion_r1002847963
##
airflow/providers/microsoft/azure/hooks/data_factory.py:
##
@@ -113,6 +116,23 @@ class
AzureDataFactoryPipelineRunException(AirflowException):
"""An
potiuk commented on PR #23560:
URL: https://github.com/apache/airflow/pull/23560#issuecomment-1288325212
Just wondering @Taragolis - should it really be closed? Are you still
working on it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Taragolis opened a new pull request, #23560:
URL: https://github.com/apache/airflow/pull/23560
At that moment Airflow have only predefined order for secrets backend
1. Alternative secrets backend (if defined)
2. Environment Variables Secrets backend
3. Metastore Backend
potiuk commented on PR #27124:
URL: https://github.com/apache/airflow/pull/27124#issuecomment-1288324047
Stupid question. Why do you need gitSync AND dagPersitence @hussein-awala ?
It always bothered me, because it never made any sense to me.
What is the reason you need persistence
potiuk commented on issue #20309:
URL: https://github.com/apache/airflow/issues/20309#issuecomment-1288320601
One thing you can try. Can you set the PYTHONFAULTHANDLER variable before
running airlfow ?
```
export PYTHONFAULTHANDLER="true"
```
Setting this variable before running
potiuk commented on issue #26429:
URL: https://github.com/apache/airflow/issues/26429#issuecomment-1288304466
I assigned you too - so if you want ot help @qcha41 -> talk directly to
@HeshamMeneisi
--
This is an automated message from the Apache Git Service.
To respond to the message,
potiuk commented on PR #26664:
URL: https://github.com/apache/airflow/pull/26664#issuecomment-1288303423
Conflicts need resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
potiuk commented on PR #27072:
URL: https://github.com/apache/airflow/pull/27072#issuecomment-1288296532
I re-based it to account for failed image build. And it looks good in
general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
potiuk commented on issue #27012:
URL: https://github.com/apache/airflow/issues/27012#issuecomment-1288293746
And that should also fix the same case for Python Virtualenv Operator (which
should have the same problem).
--
This is an automated message from the Apache Git Service.
To
potiuk commented on issue #15645:
URL: https://github.com/apache/airflow/issues/15645#issuecomment-1288250805
Yes. I think it should be - for consistentcy - fixed. Not sure if "undoing"
the optimisation is a good approach, more like fixing it so that start_date is
not updated in this
potiuk commented on issue #27069:
URL: https://github.com/apache/airflow/issues/27069#issuecomment-1288244591
BTW. In this particular case, i think the problem is that either test does
not test what it should, or maybe the hearbeat mechanism should be changed to
better match expectations.
potiuk commented on issue #27069:
URL: https://github.com/apache/airflow/issues/27069#issuecomment-1288240448
I think better solution would be to make it independent of the time. This is
an inherent problem of tests that depend on particular timing that they might
and will fail eventually.
potiuk commented on PR #27067:
URL: https://github.com/apache/airflow/pull/27067#issuecomment-1288237635
> The cruelty of SemVer I suppose!
I think this is just the price to pay to make our users confident they can
upgrade without worrying about incompatibilities. This is the main
potiuk commented on issue #27032:
URL: https://github.com/apache/airflow/issues/27032#issuecomment-1288222139
> As I see that the new Helm Chart 1.7.0 was released, does somebody know or
expect if the new liveness probe on Celery Worker will fix this problem
implicitly? (#25561)
I
potiuk commented on issue #27065:
URL: https://github.com/apache/airflow/issues/27065#issuecomment-1288221703
I've addded a PR that should address it in #27223 @zachliu - would it be
possible that you test it in your installation?
--
This is an automated message from the Apache Git
potiuk opened a new pull request, #27223:
URL: https://github.com/apache/airflow/pull/27223
The RotatingFileHandler is used when you enable it via
`CONFIG_PROCESSOR_MANAGER_LOGGER=True` and it exhibits similar behaviour as the
FileHandler had when it comes to caching the file on the Kernel
potiuk commented on PR #27196:
URL: https://github.com/apache/airflow/pull/27196#issuecomment-1288220568
All right - seems I get it alll green - @uranusjr - is it possible you take
a look at the XCom.get_value() changes before I merge this one?
--
This is an automated message from the
bluek1te commented on PR #26680:
URL: https://github.com/apache/airflow/pull/26680#issuecomment-1288219124
Ok - I think I've passed all of the running workflows. Lmk if there's
anything else!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
potiuk commented on PR #27059:
URL: https://github.com/apache/airflow/pull/27059#issuecomment-1288215616
> I'd argue the right way to see it is to look at the webserver logs
instead? If you start the webserver in debug mode, you get it regardless of
this config choice too.
Quite
potiuk commented on PR #26658:
URL: https://github.com/apache/airflow/pull/26658#issuecomment-1288211390
I still think this has a potential to deadlock when you are clearing a
subset of tasks while Scheduler might schedule them. Is it possible to hold a
lock on DagRun before attempting it?
potiuk closed issue #27058: Support the official google cloud sql connector
URL: https://github.com/apache/airflow/issues/27058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
potiuk commented on PR #27060:
URL: https://github.com/apache/airflow/pull/27060#issuecomment-1288206307
I saw quite a few users complaining recently about similar behaviour, so it
would be great to review and merge it before 2.4.3.
Deque should be fine when it comes to performance
potiuk commented on issue #27000:
URL: https://github.com/apache/airflow/issues/27000#issuecomment-1288202745
I will take a look at this shortly (or maybe @ashb or @andrewgodwin might
take a look at it before).
--
This is an automated message from the Apache Git Service.
To respond to
potiuk commented on issue #27000:
URL: https://github.com/apache/airflow/issues/27000#issuecomment-1288201132
I will re-open this one. It has enough information to try to avoid the
deadlock in the first place - the problem is that Triggerer acquires the same
locks as scheduler but in a
potiuk commented on PR #27051:
URL: https://github.com/apache/airflow/pull/27051#issuecomment-1288199796
Nice :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
potiuk commented on issue #26677:
URL: https://github.com/apache/airflow/issues/26677#issuecomment-1288199411
Please @nikhil-koul try to avoid repeating the same question in multiple
places. I provide you guidelines on what you should do im
potiuk commented on PR #27052:
URL: https://github.com/apache/airflow/pull/27052#issuecomment-1288198810
Needs conflict resolving after string normalization in providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
potiuk commented on PR #27047:
URL: https://github.com/apache/airflow/pull/27047#issuecomment-1288198677
Needs conflict resolving :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from e789a2ba9f Fix constraint upgrade (#27221)
add 2a34dc9e84 Enable string normalization in python formatting -
potiuk merged PR #27205:
URL: https://github.com/apache/airflow/pull/27205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new e789a2ba9f Fix constraint upgrade (#27221)
potiuk merged PR #27221:
URL: https://github.com/apache/airflow/pull/27221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk opened a new pull request, #27221:
URL: https://github.com/apache/airflow/pull/27221
It turnded out that #27215 has a problem when runnning when
in-workflow-build is False - additional condition has to be added for it.
Additionally, the constraint generation is run for all
dstandish opened a new pull request, #27220:
URL: https://github.com/apache/airflow/pull/27220
From airflow version 2.3, extra prefixes are not required so we enable them
here.
Hooks updated:
* batch
* container volume
* cosmos
* data lake
* synapse
--
This is
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 8f5ed4b3d1 Add better diagnostics on auto dependencies upgrade (#27215)
add dca47c3f47 Use shutil.move instead of
potiuk merged PR #27016:
URL: https://github.com/apache/airflow/pull/27016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk commented on PR #27196:
URL: https://github.com/apache/airflow/pull/27196#issuecomment-1288175286
This one also should cut the "compatibility" test by more than hour.
Currently just installing latest providers on airflow 2.2 takes > 1 hour
because `pip` tries to resolve dependencies
dstandish opened a new pull request, #27219:
URL: https://github.com/apache/airflow/pull/27219
From airflow version 2.3, extra prefixes are not required so we enable them
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from dd40e60b86 Fix system tests for SnowflakeOperator (#27204)
add 8f5ed4b3d1 Add better diagnostics on auto
potiuk merged PR #27215:
URL: https://github.com/apache/airflow/pull/27215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk opened a new pull request, #27215:
URL: https://github.com/apache/airflow/pull/27215
Whenever upgrade-to-newer-dependencies is set, our CI will attempt to
upgrade all dependencies to latest versions released. However so far it was not
clear which dependencies were upgraded so if CI
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new ecddd78f88 Updating
Taragolis opened a new pull request, #27214:
URL: https://github.com/apache/airflow/pull/27214
We have some issues related to `moto` recently
This PR
- [x] Bump version `moto` with extras to min version 4
- [x] Remove `try ... except ImportError ...` because it wouldn't work
potiuk commented on PR #26951:
URL: https://github.com/apache/airflow/pull/26951#issuecomment-1288160260
I think it would be great to get it rebased if the tests fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
eladkal commented on issue #26854:
URL: https://github.com/apache/airflow/issues/26854#issuecomment-1288151850
It also have some similarities with
https://github.com/apache/airflow/issues/15951
--
This is an automated message from the Apache Git Service.
To respond to the message, please
potiuk commented on PR #27034:
URL: https://github.com/apache/airflow/pull/27034#issuecomment-1288149364
It's cool and it will remove a source of confusion for our users.
First of all - you will need to rebase @RNHTTR - there are some conflicts.
One general comment I have -
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 57bb54d458 set executor.job_id to BackfillJob.id for backfills (#27020)
add dd40e60b86 Fix system tests for
mik-laj merged PR #27204:
URL: https://github.com/apache/airflow/pull/27204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 3a4147618f Enable full static checks also when only dev file change
(#27212)
add 57bb54d458 set executor.job_id
potiuk merged PR #27020:
URL: https://github.com/apache/airflow/pull/27020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk commented on PR #27020:
URL: https://github.com/apache/airflow/pull/27020#issuecomment-1288134918
I think that one is good for 2.4.3 - marked it so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
potiuk commented on PR #22562:
URL: https://github.com/apache/airflow/pull/22562#issuecomment-1288131990
I dismissed Jed's review - can you please rebase it @mingshi-wang - sorry
for long delay - I've been on holidays :).
--
This is an automated message from the Apache Git Service.
To
potiuk commented on PR #27033:
URL: https://github.com/apache/airflow/pull/27033#issuecomment-1288131100
Looks good, but could you please make a Howto example (see
howto_operator_start_template_job as example on how you can do it - look in the
documentation for google providers.
--
potiuk commented on PR #27203:
URL: https://github.com/apache/airflow/pull/27203#issuecomment-1288129795
Rebased it on top of #27196 so we should wait with merging it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
potiuk commented on PR #27198:
URL: https://github.com/apache/airflow/pull/27198#issuecomment-1288128308
Yeah. Thanks for fixing it. My ❤️ for moto grows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
pierrejeambrun closed pull request #26872: Update old style typing
URL: https://github.com/apache/airflow/pull/26872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
aakashnand opened a new pull request, #27213:
URL: https://github.com/apache/airflow/pull/27213
Setting client tags information in trino connection can be helpful for more
advance resource management. This PR allows users to set these client tags
Thanks @eladkal for suggesting this
This is an automated email from the ASF dual-hosted git repository.
pierrejeambrun pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from fd859d138c Fix test get credentials for assume role in amazon provider
(#27198)
add 3a4147618f Enable
pierrejeambrun merged PR #27212:
URL: https://github.com/apache/airflow/pull/27212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eladkal commented on code in PR #27197:
URL: https://github.com/apache/airflow/pull/27197#discussion_r1002646168
##
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##
@@ -287,6 +275,12 @@ def __init__(
self.pod_request_obj: k8s.V1Pod | None = None
eladkal commented on code in PR #27197:
URL: https://github.com/apache/airflow/pull/27197#discussion_r1002646168
##
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##
@@ -287,6 +275,12 @@ def __init__(
self.pod_request_obj: k8s.V1Pod | None = None
dstandish commented on code in PR #27197:
URL: https://github.com/apache/airflow/pull/27197#discussion_r1002643215
##
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##
@@ -287,6 +275,12 @@ def __init__(
self.pod_request_obj: k8s.V1Pod | None = None
75 matches
Mail list logo
