Re: [PR] fix: use offset-naive datetime in _CredentialsToken [airflow]

2024-02-19 Thread via GitHub
m1racoli commented on code in PR #37539: URL: https://github.com/apache/airflow/pull/37539#discussion_r1495376268 ## airflow/providers/google/provider.yaml: ## @@ -89,6 +89,12 @@ dependencies: - apache-airflow>=2.6.0 - apache-airflow-providers-common-sql>=1.7.2 -

Re: [PR] fix: use offset-naive datetime in _CredentialsToken [airflow]

2024-02-19 Thread via GitHub
m1racoli commented on code in PR #37539: URL: https://github.com/apache/airflow/pull/37539#discussion_r1495376268 ## airflow/providers/google/provider.yaml: ## @@ -89,6 +89,12 @@ dependencies: - apache-airflow>=2.6.0 - apache-airflow-providers-common-sql>=1.7.2 -

Re: [PR] Show tasks in grid view based on topological sort. [airflow]

2024-02-19 Thread via GitHub
prithvi-git commented on PR #22741: URL: https://github.com/apache/airflow/pull/22741#issuecomment-1953646652 We're using airflow version 2.6.3 in GCP composer v2.6.0. We're still facing this issue -

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-19 Thread via GitHub
awdavidson commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1495362690 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
uranusjr commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495361597 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment: I don’t like

Re: [I] Statsd metric name components are unsanitized [airflow]

2024-02-19 Thread via GitHub
github-actions[bot] commented on issue #29268: URL: https://github.com/apache/airflow/issues/29268#issuecomment-1953594536 This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last

Re: [PR] Add dataset event dataset dag run queue association [airflow]

2024-02-19 Thread via GitHub
uranusjr commented on PR #37424: URL: https://github.com/apache/airflow/pull/37424#issuecomment-1953591955 Notes from talking to Ankit off-thread: 1. I think adding an association table shouldn’t affect `triggering_dataset_events`. SQLA loads relationships lazily (unless we make it;

Re: [PR] Add secret caching for Airflow CLI [airflow]

2024-02-19 Thread via GitHub
uranusjr commented on code in PR #37551: URL: https://github.com/apache/airflow/pull/37551#discussion_r1495301611 ## airflow/__main__.py: ## @@ -54,6 +55,11 @@ def main(): conf = write_default_airflow_configuration_if_needed() if args.subcommand in

Re: [PR] fix: use offset-naive datetime in _CredentialsToken [airflow]

2024-02-19 Thread via GitHub
eladkal commented on code in PR #37539: URL: https://github.com/apache/airflow/pull/37539#discussion_r1495297475 ## airflow/providers/google/provider.yaml: ## @@ -89,6 +89,12 @@ dependencies: - apache-airflow>=2.6.0 - apache-airflow-providers-common-sql>=1.7.2 -

Re: [PR] Add missing informative logs in KPO trigger until container has not finished [airflow]

2024-02-19 Thread via GitHub
eladkal commented on code in PR #37546: URL: https://github.com/apache/airflow/pull/37546#discussion_r1495296352 ## airflow/providers/cncf/kubernetes/triggers/pod.py: ## @@ -254,6 +254,7 @@ async def _wait_for_container_completion(self) -> TriggerEvent:

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495291662 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment: @uranusjr Thank

Re: [PR] fix: use offset-naive datetime in _CredentialsToken [airflow]

2024-02-19 Thread via GitHub
uranusjr merged PR #37539: URL: https://github.com/apache/airflow/pull/37539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Use offset-naive datetime in _CredentialsToken (#37539)

2024-02-19 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 011cd3debb Use offset-naive datetime in

(airflow) branch main updated: Change margin to padding so first task can be selected (#37527)

2024-02-19 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7b422be7df Change margin to padding so first

Re: [PR] Change margin to padding so first task can be selected [airflow]

2024-02-19 Thread via GitHub
uranusjr merged PR #37527: URL: https://github.com/apache/airflow/pull/37527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
uranusjr commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495259187 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
uranusjr commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495257952 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment: Since we have

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495242470 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment:

Re: [I] Logging handler TaskHandlerWithCustomFormatter adds prefix three times [airflow]

2024-02-19 Thread via GitHub
Aakcht commented on issue #35622: URL: https://github.com/apache/airflow/issues/35622#issuecomment-1953484813 Hi, @Taragolis ! Just retested it on Airflow 2.8.1 version - the issue is still there. Haven't gotten around to trying to figure out what the problem is yet , so no solution for

Re: [PR] Add missing informative logs in KPO trigger until container has not finished [airflow]

2024-02-19 Thread via GitHub
pankajkoti commented on code in PR #37546: URL: https://github.com/apache/airflow/pull/37546#discussion_r1495238810 ## airflow/providers/cncf/kubernetes/triggers/pod.py: ## @@ -254,6 +254,7 @@ async def _wait_for_container_completion(self) -> TriggerEvent:

Re: [PR] Add missing informative logs in KPO trigger until container has not finished [airflow]

2024-02-19 Thread via GitHub
pankajkoti commented on code in PR #37546: URL: https://github.com/apache/airflow/pull/37546#discussion_r1495238810 ## airflow/providers/cncf/kubernetes/triggers/pod.py: ## @@ -254,6 +254,7 @@ async def _wait_for_container_completion(self) -> TriggerEvent:

Re: [PR] Add missing informative logs in KPO trigger until container has not finished [airflow]

2024-02-19 Thread via GitHub
pankajkoti commented on code in PR #37546: URL: https://github.com/apache/airflow/pull/37546#discussion_r1495238025 ## airflow/providers/cncf/kubernetes/triggers/pod.py: ## @@ -254,6 +254,7 @@ async def _wait_for_container_completion(self) -> TriggerEvent:

Re: [PR] Add missing informative logs in KPO trigger until container has not finished [airflow]

2024-02-19 Thread via GitHub
pankajkoti commented on code in PR #37546: URL: https://github.com/apache/airflow/pull/37546#discussion_r1495238025 ## airflow/providers/cncf/kubernetes/triggers/pod.py: ## @@ -254,6 +254,7 @@ async def _wait_for_container_completion(self) -> TriggerEvent:

Re: [PR] Add retries to job heartbeat [airflow]

2024-02-19 Thread via GitHub
dirrao commented on code in PR #37541: URL: https://github.com/apache/airflow/pull/37541#discussion_r1495225123 ## airflow/jobs/job.py: ## @@ -183,30 +184,32 @@ def heartbeat( previous_heartbeat = self.latest_heartbeat try: -# This will cause it

Re: [PR] add "queuedEvent" endpoint to get/delete DatasetDagRunQueue [airflow]

2024-02-19 Thread via GitHub
Lee-W commented on PR #37176: URL: https://github.com/apache/airflow/pull/37176#issuecomment-1953440399 > I think it probably does not matter either way. The provider release only includes provider code, so only the provider changes of this PR will be included anyway. Got it. If

Re: [PR] Add missing informative logs in KPO trigger until container has not finished [airflow]

2024-02-19 Thread via GitHub
dirrao commented on code in PR #37546: URL: https://github.com/apache/airflow/pull/37546#discussion_r1495206126 ## airflow/providers/cncf/kubernetes/triggers/pod.py: ## @@ -254,6 +254,7 @@ async def _wait_for_container_completion(self) -> TriggerEvent:

Re: [PR] Add secret caching for Airflow CLI [airflow]

2024-02-19 Thread via GitHub
dirrao commented on code in PR #37551: URL: https://github.com/apache/airflow/pull/37551#discussion_r1495204356 ## airflow/__main__.py: ## @@ -54,6 +55,11 @@ def main(): conf = write_default_airflow_configuration_if_needed() if args.subcommand in ["webserver",

Re: [PR] add "queuedEvent" endpoint to get/delete DatasetDagRunQueue [airflow]

2024-02-19 Thread via GitHub
uranusjr commented on PR #37176: URL: https://github.com/apache/airflow/pull/37176#issuecomment-1953425020 I think it probably does not matter either way. The provider release only includes provider code, so only the provider changes of this PR will be included anyway. -- This is an

Re: [PR] add "queuedEvent" endpoint to get/delete DatasetDagRunQueue [airflow]

2024-02-19 Thread via GitHub
Lee-W commented on PR #37176: URL: https://github.com/apache/airflow/pull/37176#issuecomment-1953380443 Hi @vincbeck @potiuk , I would like to confirm whether we should move the FAB change (adding a new delete dataset permission) to a separate PR. Or are we good to just keep it in this PR?

(airflow) branch main updated: feat(providers/dbt): add reuse_existing_run for allowing DbtCloudRunJobOperator to reuse existing run (#37474)

2024-02-19 Thread phanikumv
This is an automated email from the ASF dual-hosted git repository. phanikumv pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 26964f8a8e feat(providers/dbt): add

Re: [PR] add reuse_existing_run for allowing DbtCloudRunJobOperator to reuse existing run [airflow]

2024-02-19 Thread via GitHub
phanikumv merged PR #37474: URL: https://github.com/apache/airflow/pull/37474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Scheduler fails to schedule DagRuns due to persistent DAG record lock [airflow]

2024-02-19 Thread via GitHub
rahulnbhandari commented on issue #36920: URL: https://github.com/apache/airflow/issues/36920#issuecomment-1953350633 We are also seeing same issue. We started getting this after switching deployments to official helm chart on 2.7.3 -- This is an automated message from the Apache Git

Re: [I] Does not support this configuration : redis sentinel [airflow]

2024-02-19 Thread via GitHub
Taragolis closed issue #35619: Does not support this configuration : redis sentinel URL: https://github.com/apache/airflow/issues/35619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Attempt to update Connexion library to version 3 [airflow]

2024-02-19 Thread via GitHub
Satoshi-Sh commented on PR #36052: URL: https://github.com/apache/airflow/pull/36052#issuecomment-1953320107 Hi @vincbeck @VladaZakharova , I started working on the bugs Vlada listed above. For the first bug, I just updated codes as Vinc's commented. Can you guide me on how to test

[PR] Fixing Errors (Update Connexion Library to version 3) [airflow]

2024-02-19 Thread via GitHub
Satoshi-Sh opened a new pull request, #37555: URL: https://github.com/apache/airflow/pull/37555 ## Description On this PR, I'm fixing the bugs mentioned in [Attempt to update Connexion library to version 3

Re: [PR] Adding missing --answer to breeze build-docs [airflow]

2024-02-19 Thread via GitHub
vincbeck merged PR #37530: URL: https://github.com/apache/airflow/pull/37530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Adding missing --answer to breeze build-docs (#37530)

2024-02-19 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4f35bdc1a5 Adding missing --answer to breeze

Re: [PR] fix: front dagview - explicit wording - next run [airflow]

2024-02-19 Thread via GitHub
github-actions[bot] commented on PR #32964: URL: https://github.com/apache/airflow/pull/32964#issuecomment-1953299934 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

Re: [PR] Fix docker compose command in "Running Airflow in Docker" [airflow]

2024-02-19 Thread via GitHub
github-actions[bot] commented on PR #36611: URL: https://github.com/apache/airflow/pull/36611#issuecomment-1953299893 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

Re: [I] Scheduler fails to schedule DagRuns due to persistent DAG record lock [airflow]

2024-02-19 Thread via GitHub
github-actions[bot] commented on issue #36920: URL: https://github.com/apache/airflow/issues/36920#issuecomment-1953299882 This issue has been automatically marked as stale because it has been open for 14 days with no response from the author. It will be closed in next 7 days if no further

Re: [PR] add "queuedEvent" endpoint to get/delete DatasetDagRunQueue [airflow]

2024-02-19 Thread via GitHub
vincbeck commented on code in PR #37176: URL: https://github.com/apache/airflow/pull/37176#discussion_r1495087934 ## airflow/providers/fab/auth_manager/security_manager/override.py: ## @@ -276,6 +276,7 @@ class FabAirflowSecurityManagerOverride(AirflowSecurityManagerV2):

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495084373 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment: Window ME was

(airflow) branch main updated: Add swagger path to FAB Auth manager and Internal API (#37525)

2024-02-19 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 79603f9302 Add swagger path to FAB Auth manager

Re: [PR] Add swagger path to FAB Auth manager and Internal API [airflow]

2024-02-19 Thread via GitHub
vincbeck merged PR #37525: URL: https://github.com/apache/airflow/pull/37525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Properly setup bundled swagger-ui in Connexion [airflow]

2024-02-19 Thread via GitHub
vincbeck closed issue #36975: Properly setup bundled swagger-ui in Connexion URL: https://github.com/apache/airflow/issues/36975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Move some` FAB related tests to provider [airflow]

2024-02-19 Thread via GitHub
potiuk commented on PR #37549: URL: https://github.com/apache/airflow/pull/37549#issuecomment-1953269274 :100: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Move some` FAB related tests to provider [airflow]

2024-02-19 Thread via GitHub
vincbeck commented on PR #37549: URL: https://github.com/apache/airflow/pull/37549#issuecomment-1953267375 The FAB auth manager has its own test suite so it should be "okay" covered. The only missing (and big) piece is the FAB security manager override, we definitely need to improve the

Re: [PR] Move some` FAB related tests to provider [airflow]

2024-02-19 Thread via GitHub
vincbeck commented on PR #37549: URL: https://github.com/apache/airflow/pull/37549#issuecomment-1953266625 > > Looks like this was what lead to the false positive earlier. Thanks +1 > > We still have to update our FAB / WWW test suite - to make the needed test purely AuthManager

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
Taragolis commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495076941 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment: I'm pretty

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495072748 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment: Shoudln't that

Re: [PR] Base date for fetching dag grid view must include selected run_id [airflow]

2024-02-19 Thread via GitHub
jscheffl commented on PR #34887: URL: https://github.com/apache/airflow/pull/34887#issuecomment-1953238610 Yeah, would be great - as this fix was pushed multiple times... next release will be cut in ~24h - if rebased and reviewed the chance is likely to get it in... -- This is an

Re: [PR] Add docstring to airflow/configurations.py to avoid D105 [airflow]

2024-02-19 Thread via GitHub
Taragolis commented on code in PR #37540: URL: https://github.com/apache/airflow/pull/37540#discussion_r1495061759 ## airflow/configuration.py: ## @@ -1883,8 +1884,9 @@ def __getstate__(self): ] } -def __setstate__(self, state): -

Re: [PR] Update ObjectStoragePath for universal_pathlib>=v0.2.1 [airflow]

2024-02-19 Thread via GitHub
ap-- commented on code in PR #37524: URL: https://github.com/apache/airflow/pull/37524#discussion_r1495056522 ## tests/io/test_path.py: ## @@ -227,16 +271,13 @@ def test_move_remote(self): _to.unlink() def test_copy_remote_remote(self): -# foo = xxx

Re: [PR] Update ObjectStoragePath for universal_pathlib>=v0.2.1 [airflow]

2024-02-19 Thread via GitHub
ap-- commented on code in PR #37524: URL: https://github.com/apache/airflow/pull/37524#discussion_r1495056345 ## airflow/providers/common/io/xcom/backend.py: ## @@ -152,7 +152,7 @@ def deserialize_value( try: p = ObjectStoragePath(path) /

Re: [I] Logging handler TaskHandlerWithCustomFormatter adds prefix three times [airflow]

2024-02-19 Thread via GitHub
Taragolis commented on issue #35622: URL: https://github.com/apache/airflow/issues/35622#issuecomment-1953223361 @Aakcht Sorry for the late response. Is it still a case now, maybe you found a solution? Asked because that I do not know that we have this task handler, and only one

Re: [PR] Update ObjectStoragePath for universal_pathlib>=v0.2.1 [airflow]

2024-02-19 Thread via GitHub
ap-- commented on code in PR #37524: URL: https://github.com/apache/airflow/pull/37524#discussion_r1495055053 ## tests/io/test_path.py: ## @@ -60,34 +89,39 @@ def get_fs_no_storage_options(_: str): class TestFs: def setup_class(self): self._store_cache =

Re: [PR] Update ObjectStoragePath for universal_pathlib>=v0.2.1 [airflow]

2024-02-19 Thread via GitHub
ap-- commented on code in PR #37524: URL: https://github.com/apache/airflow/pull/37524#discussion_r1495054871 ## tests/providers/common/io/xcom/test_backend.py: ## @@ -181,7 +182,7 @@ def test_value_storage(self, task_instance, session):

Re: [I] Tasks are stuck in running state. "select 1" query stuck in idle in transaction [airflow]

2024-02-19 Thread via GitHub
Taragolis commented on issue #35524: URL: https://github.com/apache/airflow/issues/35524#issuecomment-1953196972 @deepak4babu Sorry for the late response. Is this problem still actual (maybe it resolve into the new version of Airflow). If it still relevant could you provide minimum

Re: [I] Passing a DagRun to a PythonVirtualenvOperator gives NameError: name 'timedelta' is not defined [airflow]

2024-02-19 Thread via GitHub
Taragolis commented on issue #35483: URL: https://github.com/apache/airflow/issues/35483#issuecomment-1953191577 Hey, @Felix-neko a lot of time has passed since last activity on this issue. Any chance that you have check it on [Airflow 2.8.1 with pendulum

Re: [I] Allow jinja templating connection ids for all third party operators [airflow]

2024-02-19 Thread via GitHub
Taragolis commented on issue #35259: URL: https://github.com/apache/airflow/issues/35259#issuecomment-1953182638 I think it might be a good first issue, I also required to collect all connection ID from the existed operators and list them, so everyone could pick up and make the changes.

Re: [PR] Add docstring to airflow/configurations.py to avoid D105 [airflow]

2024-02-19 Thread via GitHub
romsharon98 commented on code in PR #37540: URL: https://github.com/apache/airflow/pull/37540#discussion_r1495026409 ## airflow/configuration.py: ## @@ -1883,8 +1884,9 @@ def __getstate__(self): ] } -def __setstate__(self, state): -

Re: [PR] Add docstring to airflow/configurations.py to avoid D105 [airflow]

2024-02-19 Thread via GitHub
romsharon98 commented on code in PR #37540: URL: https://github.com/apache/airflow/pull/37540#discussion_r1495025369 ## airflow/configuration.py: ## @@ -1883,8 +1889,19 @@ def __getstate__(self): ] } -def __setstate__(self, state): -

Re: [PR] Add docstring to airflow/configurations.py to avoid D105 [airflow]

2024-02-19 Thread via GitHub
romsharon98 commented on code in PR #37540: URL: https://github.com/apache/airflow/pull/37540#discussion_r1495025258 ## airflow/configuration.py: ## @@ -1871,7 +1871,13 @@ def _warn_deprecate( stacklevel=4 + extra_stacklevel, ) -def

Re: [PR] Fix credentials error for S3ToGCSOperator trigger [airflow]

2024-02-19 Thread via GitHub
Taragolis commented on code in PR #37518: URL: https://github.com/apache/airflow/pull/37518#discussion_r1495024515 ## airflow/providers/google/cloud/transfers/s3_to_gcs.py: ## @@ -269,6 +269,7 @@ def transfer_files_async(self, files: list[str], gcs_hook: GCSHook, s3_hook: S3H

Re: [PR] Fix credentials error for S3ToGCSOperator trigger [airflow]

2024-02-19 Thread via GitHub
Taragolis commented on code in PR #37518: URL: https://github.com/apache/airflow/pull/37518#discussion_r1495023390 ## airflow/providers/google/cloud/transfers/s3_to_gcs.py: ## @@ -269,6 +269,7 @@ def transfer_files_async(self, files: list[str], gcs_hook: GCSHook, s3_hook: S3H

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
Taragolis commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495010233 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
Taragolis commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494980560 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494964997 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text +from

[PR] updated logic to allow retries to be effective [airflow]

2024-02-19 Thread via GitHub
evgenyslab opened a new pull request, #37552: URL: https://github.com/apache/airflow/pull/37552 --- Update logic in `Amazon/aws` providers for `batch_client` `hook`'s `parse_job_description` function. This function is ONLY called within the

Re: [I] Status of testing Providers that were prepared on February 19, 2024 [airflow]

2024-02-19 Thread via GitHub
raphaelauv commented on issue #37534: URL: https://github.com/apache/airflow/issues/37534#issuecomment-1953072614 @pankajastro you are correct I mixed the settings between asyn and non async when I checked the RC. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
Taragolis commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494959852 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text

Re: [PR] Add secret caching for Airflow CLI [airflow]

2024-02-19 Thread via GitHub
boring-cyborg[bot] commented on PR #37551: URL: https://github.com/apache/airflow/pull/37551#issuecomment-1953060748 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[PR] Add secret caching for Airflow CLI [airflow]

2024-02-19 Thread via GitHub
Birne94 opened a new pull request, #37551: URL: https://github.com/apache/airflow/pull/37551 This PR adds secret caching for the Airflow CLI. [Secret caching](https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#use-cache) current only works for the DAG-processing

(airflow) branch constraints-main updated: Updating constraints. Github run id:7964006016

2024-02-19 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 7b935eeb0a Updating

Re: [I] Status of testing Providers that were prepared on February 19, 2024 [airflow]

2024-02-19 Thread via GitHub
pankajastro commented on issue #37534: URL: https://github.com/apache/airflow/issues/37534#issuecomment-1953058108 Still not sure, `logging_interval` is a new param in 8.0.0rc and it should not impact the sync version of the operator. here code for the sync kpo

Re: [I] Status of testing Providers that were prepared on February 19, 2024 [airflow]

2024-02-19 Thread via GitHub
pankajkoti commented on issue #37534: URL: https://github.com/apache/airflow/issues/37534#issuecomment-1953057871 > I'm not speaking about the deferrable mode Okay, :). The `logging_interval` param that you pointed at

Re: [I] Status of testing Providers that were prepared on February 19, 2024 [airflow]

2024-02-19 Thread via GitHub
raphaelauv commented on issue #37534: URL: https://github.com/apache/airflow/issues/37534#issuecomment-1953031982 I'm not speaking about the deferrable mode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494895941 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text +from

Re: [I] Status of testing Providers that were prepared on February 19, 2024 [airflow]

2024-02-19 Thread via GitHub
pankajkoti commented on issue #37534: URL: https://github.com/apache/airflow/issues/37534#issuecomment-1953016838 > "Container logs was not available earlier regularly" > > That's wrong, the kpo with get_logs , get the container logs regularly @raphaelauv It was not possible to

(airflow) branch main updated: Move some FAB related tests to provider (#37549)

2024-02-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e6f5d454b2 Move some FAB related tests to provider

Re: [PR] Move some` FAB related tests to provider [airflow]

2024-02-19 Thread via GitHub
potiuk merged PR #37549: URL: https://github.com/apache/airflow/pull/37549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch constraints-2-8 updated: Updating constraints. Github run id:7963561456

2024-02-19 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-2-8 in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2-8 by this push: new 3efd31a4fc Updating

Re: [I] Feature Request - Pool Support for Task Groups in Apache Airflow [airflow]

2024-02-19 Thread via GitHub
potiuk commented on issue #35689: URL: https://github.com/apache/airflow/issues/35689#issuecomment-1952982168 One more comment here (result of discussion in Slack). I think it would be indeed a very nice feature to add in Airflow, but likely you can achieve it by using some external

Re: [I] Status of testing Providers that were prepared on February 19, 2024 [airflow]

2024-02-19 Thread via GitHub
raphaelauv commented on issue #37534: URL: https://github.com/apache/airflow/issues/37534#issuecomment-1952970781 "Container logs was not available earlier regularly" That's wrong, the kpo with get_logs , get the container logs regularly -- This is an automated message

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494895941 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text +from

(airflow) 01/01: Synchronize missing changes in breeze with main and regenerate images

2024-02-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-8-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 53f2a9b1b817bcd3a9e83e3d5e2f5053a0f9b598 Author: Jarek Potiuk AuthorDate: Mon Feb 19 13:33:18 2024 +0100

(airflow) branch v2-8-test updated (c501470ed9 -> 53f2a9b1b8)

2024-02-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch v2-8-test in repository https://gitbox.apache.org/repos/asf/airflow.git discard c501470ed9 Synchronize missing changes in breeze with main and regenerate images new 53f2a9b1b8 Synchronize

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

2024-02-19 Thread via GitHub
Taragolis commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494864956 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text

Re: [I] Status of testing Providers that were prepared on February 19, 2024 [airflow]

2024-02-19 Thread via GitHub
pankajastro commented on issue #37534: URL: https://github.com/apache/airflow/issues/37534#issuecomment-1952900773 @raphaelauv I'm a bit confused now. Sorry!. Do you mean container log is not visible regularly or the log statement something like "container is still running/pending" when

Re: [I] Status of testing Providers that were prepared on February 19, 2024 [airflow]

2024-02-19 Thread via GitHub
pankajkoti commented on issue #37534: URL: https://github.com/apache/airflow/issues/37534#issuecomment-1952897570 Yes, I agree there will be no informative logs in RC3 from the triggerer saying the container is still running. However, the trigger logs are independent of get_logs

(airflow) 01/03: Fix wrong test after fixing audit log permission (#37547)

2024-02-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-8-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 4a8cd4d8a59dd4c86a1910770406c67aa2cd277a Author: Jarek Potiuk AuthorDate: Mon Feb 19 16:31:58 2024 +0100 Fix

(airflow) branch v2-8-test updated (eedf58e4d9 -> c501470ed9)

2024-02-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch v2-8-test in repository https://gitbox.apache.org/repos/asf/airflow.git discard eedf58e4d9 Fix wrong test after fixing audit log permission (#37547) discard 76606e13ad Synchronize missing

(airflow) 03/03: Synchronize missing changes in breeze with main and regenerate images

2024-02-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-8-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit c501470ed99f265c970ef98fb99903d664498b5d Author: Jarek Potiuk AuthorDate: Mon Feb 19 13:33:18 2024 +0100

(airflow) 02/03: Fix failing home view test after changing audit log permissions (#37550)

2024-02-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-8-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit baa35432de1d018640609e6984562528944f6b56 Author: Jarek Potiuk AuthorDate: Mon Feb 19 18:00:20 2024 +0100 Fix

Re: [I] Airflow Dag Callback Executed Multiple times [airflow]

2024-02-19 Thread via GitHub
denisluciano commented on issue #33216: URL: https://github.com/apache/airflow/issues/33216#issuecomment-1952895377 I have the same problem. Can someone help me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Move some` FAB related tests to provider [airflow]

2024-02-19 Thread via GitHub
potiuk commented on PR #37549: URL: https://github.com/apache/airflow/pull/37549#issuecomment-1952891496 > Looks like this was what lead to the false positive earlier. Thanks +1 We still have to update our FAB / WWW test suite - to make the needed test purely AuthManager ones, but

Re: [PR] Add missing informative logs in KPO trigger until container has not finished [airflow]

2024-02-19 Thread via GitHub
pankajastro commented on code in PR #37546: URL: https://github.com/apache/airflow/pull/37546#discussion_r1494846167 ## airflow/providers/cncf/kubernetes/triggers/pod.py: ## @@ -263,6 +264,7 @@ async def _wait_for_container_completion(self) -> TriggerEvent:

Re: [PR] Fix failing home view test after changing audit log permissions [airflow]

2024-02-19 Thread via GitHub
potiuk commented on PR #37550: URL: https://github.com/apache/airflow/pull/37550#issuecomment-1952884931 Should finally fix main :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(airflow) branch main updated: Fix failing home view test after changing audit log permissions (#37550)

2024-02-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 016892b7d6 Fix failing home view test after

Re: [PR] Fix failing home view test after changing audit log permissions [airflow]

2024-02-19 Thread via GitHub
potiuk merged PR #37550: URL: https://github.com/apache/airflow/pull/37550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >