Re: [PR] Scheduler to handle incrementing of try_number [airflow]

2024-05-11 Thread via GitHub
eladkal commented on code in PR #39336: URL: https://github.com/apache/airflow/pull/39336#discussion_r1597486765 ## airflow/providers/dbt/cloud/CHANGELOG.rst: ## @@ -28,6 +28,11 @@ Changelog - +main +. + +In Airflow 2.10.0, we fix the way try_number works, so

Re: [PR] ADD prototype version dark mode for Airflow UI [airflow]

2024-05-11 Thread via GitHub
YounHS commented on PR #39355: URL: https://github.com/apache/airflow/pull/39355#issuecomment-2106116615 @jscheffl sry, I checked this prob! I initially thought that I would only need to modify the airflow/www side, but for "security", "browse", and "admin", modifying views.py

Re: [PR] add deferrable support to `DatabricksNotebookOperator` [airflow]

2024-05-11 Thread via GitHub
rawwar commented on code in PR #39295: URL: https://github.com/apache/airflow/pull/39295#discussion_r1597539214 ## airflow/providers/databricks/operators/databricks.py: ## @@ -1056,13 +1073,24 @@ def monitor_databricks_job(self) -> None: ) if not

Re: [PR] add deferrable support to `DatabricksNotebookOperator` [airflow]

2024-05-11 Thread via GitHub
rawwar commented on code in PR #39295: URL: https://github.com/apache/airflow/pull/39295#discussion_r1597539214 ## airflow/providers/databricks/operators/databricks.py: ## @@ -1056,13 +1073,24 @@ def monitor_databricks_job(self) -> None: ) if not

Re: [PR] use `sqlqlchemy_url` property in `get_uri` for `mssql` provider [airflow]

2024-05-11 Thread via GitHub
rawwar closed pull request #39572: use `sqlqlchemy_url` property in `get_uri` for `mssql` provider URL: https://github.com/apache/airflow/pull/39572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] use `sqlqlchemy_url` property in `get_uri` for `mssql` provider [airflow]

2024-05-11 Thread via GitHub
rawwar opened a new pull request, #39572: URL: https://github.com/apache/airflow/pull/39572 related: #38195 use sqlalchemy's URL object to create a URI in the `get_uri` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Airflow statsd stops sending metrics during maximum dagrun [airflow]

2024-05-11 Thread via GitHub
rawwar commented on issue #39571: URL: https://github.com/apache/airflow/issues/39571#issuecomment-2106074922 Can you confirm if this is happening consistently when you run 200+ tasks in parallel -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] feat: Add DbtCloudRetryJobOperator to retry failed dbt job [airflow]

2024-05-11 Thread via GitHub
github-actions[bot] commented on PR #38001: URL: https://github.com/apache/airflow/pull/38001#issuecomment-2106066273 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

Re: [PR] New generaic SQL transfer operator proposal [airflow]

2024-05-11 Thread via GitHub
github-actions[bot] closed pull request #38281: New generaic SQL transfer operator proposal URL: https://github.com/apache/airflow/pull/38281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Switch AzureDataLakeStorageV2Hook to use ManagedIdentityCredential for managed identity/workload auth [airflow]

2024-05-11 Thread via GitHub
github-actions[bot] commented on PR #38497: URL: https://github.com/apache/airflow/pull/38497#issuecomment-2106066256 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[I] Airflow statsd stops sending metrics during maximum dagrun [airflow]

2024-05-11 Thread via GitHub
paramjeet01 opened a new issue, #39571: URL: https://github.com/apache/airflow/issues/39571 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.8.3 ### What happened? Statsd

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-11 Thread via GitHub
potiuk commented on PR #39513: URL: https://github.com/apache/airflow/pull/39513#issuecomment-2106034576 Yep. All green. So now just waiting for comments / approvals. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-11 Thread via GitHub
potiuk commented on PR #39513: URL: https://github.com/apache/airflow/pull/39513#issuecomment-2106028192 OK. I removed it out of `DRAFT` state. Looks like this one should get `green` - which means that we can run full test suite against Airflow 2.9.1 - but we will need to get some

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-11 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1597505481 ## tests/test_utils/compat.py: ## @@ -0,0 +1,47 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-11 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1597505397 ## tests/providers/google/cloud/operators/test_dataproc.py: ## @@ -1064,11 +1064,10 @@ def test_create_cluster_operator_extra_links(dag_maker,

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-11 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1597505127 ## tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py: ## @@ -367,6 +368,7 @@ def test_stopped_tasks(self): class TestAwsEcsExecutor: """Tests the

[PR] Surface ti dependencies [airflow]

2024-05-11 Thread via GitHub
RNHTTR opened a new pull request, #39570: URL: https://github.com/apache/airflow/pull/39570 Closes: #35935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Prepare docs 2nd wave May 2024 [airflow]

2024-05-11 Thread via GitHub
potiuk commented on PR #39565: URL: https://github.com/apache/airflow/pull/39565#issuecomment-2106007577 Ah . I see :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Redirect to new DAGRun after trigger from Grid view [airflow]

2024-05-11 Thread via GitHub
jscheffl opened a new pull request, #39569: URL: https://github.com/apache/airflow/pull/39569 This PR adds a feature to trigger DAG run handling, if called from Grid view it will redirect to the new DAG Run that was generated. If any task or detail tab was selected, the selection is

Re: [PR] Prepare docs 2nd wave May 2024 [airflow]

2024-05-11 Thread via GitHub
eladkal commented on PR #39565: URL: https://github.com/apache/airflow/pull/39565#issuecomment-2106000758 > Am I right that you skipped all the other providers where only templates were reapplied ? > > I think you should update all other provider changes and mark them as "doc-only"

Re: [PR] Fix validation for BQ label values for BigQueryInsertJobOperator [airflow]

2024-05-11 Thread via GitHub
boring-cyborg[bot] commented on PR #39568: URL: https://github.com/apache/airflow/pull/39568#issuecomment-210531 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[PR] Fix validation for BQ label values for BigQueryInsertJobOperator [airflow]

2024-05-11 Thread via GitHub
kisssam opened a new pull request, #39568: URL: https://github.com/apache/airflow/pull/39568 --- This updates the label value validation logic for BigQuery label values as documented in the [public

Re: [I] Triggering a DAG Run from the DAG Graph View does not redirect to the triggered DAG Run page [airflow]

2024-05-11 Thread via GitHub
pedro-cf commented on issue #37935: URL: https://github.com/apache/airflow/issues/37935#issuecomment-2105999397 > In 2.8.2 the main problem was the new DAG run was "hidden". This is what in 2.9.1 now is fixed. The new DAG run appears after triggering. That's interesting you mention

[I] BigQueryInsertJobOperator fails for task IDs with 64 characters [airflow]

2024-05-11 Thread via GitHub
kisssam opened a new issue, #39567: URL: https://github.com/apache/airflow/issues/39567 ### Apache Airflow Provider(s) google ### Versions of Apache Airflow Providers apache-airflow-providers-google==10.17.0 ### Apache Airflow version airflow-2.7.3

Re: [I] BigQueryInsertJobOperator fails for task IDs with 64 characters [airflow]

2024-05-11 Thread via GitHub
boring-cyborg[bot] commented on issue #39567: URL: https://github.com/apache/airflow/issues/39567#issuecomment-2105998513 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

Re: [I] Triggering a DAG Run from the DAG Graph View does not redirect to the triggered DAG Run page [airflow]

2024-05-11 Thread via GitHub
jscheffl commented on issue #37935: URL: https://github.com/apache/airflow/issues/37935#issuecomment-2105998506 Okay, then I assume I now understand the mis-understanding. Please correct me if I am right: In 2.8.2 the main problem was the new DAG run was "hidden". This is what in

[PR] PoC on a static resource loading plugin [airflow]

2024-05-11 Thread via GitHub
jscheffl opened a new pull request, #39566: URL: https://github.com/apache/airflow/pull/39566 WIP PoC for AIP-68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Prepare docs 2nd wave May 2024 [airflow]

2024-05-11 Thread via GitHub
potiuk commented on PR #39565: URL: https://github.com/apache/airflow/pull/39565#issuecomment-2105981649 Am I right that you skipped all the other providers where only templates were reapplied ? I think you should update all other provider changes and mark them as "doc-only" - the

[PR] Prepare docs 2nd wave May 2024 [airflow]

2024-05-11 Thread via GitHub
eladkal opened a new pull request, #39565: URL: https://github.com/apache/airflow/pull/39565 Ad hoc release for the providers we didn't release in the 1st wave + the new iceberg provider -- This is an automated message from the Apache Git Service. To respond to the message, please log on

(airflow) branch constraints-main updated: Updating constraints. Github run id:9044765785

2024-05-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 1416d3662d Updating

Re: [PR] Scheduler to handle incrementing of try_number [airflow]

2024-05-11 Thread via GitHub
eladkal commented on code in PR #39336: URL: https://github.com/apache/airflow/pull/39336#discussion_r1597486765 ## airflow/providers/dbt/cloud/CHANGELOG.rst: ## @@ -28,6 +28,11 @@ Changelog - +main +. + +In Airflow 2.10.0, we fix the way try_number works, so

Re: [PR] Scheduler to handle incrementing of try_number [airflow]

2024-05-11 Thread via GitHub
eladkal commented on code in PR #39336: URL: https://github.com/apache/airflow/pull/39336#discussion_r1597486765 ## airflow/providers/dbt/cloud/CHANGELOG.rst: ## @@ -28,6 +28,11 @@ Changelog - +main +. + +In Airflow 2.10.0, we fix the way try_number works, so

Re: [I] Triggering a DAG Run from the DAG Graph View does not redirect to the triggered DAG Run page [airflow]

2024-05-11 Thread via GitHub
pedro-cf commented on issue #37935: URL: https://github.com/apache/airflow/issues/37935#issuecomment-2105951470 Updated the issue description. Would be cool if someone could update the label since it affects version 2.9.1 @eladkal -- This is an automated message from the Apache Git

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-11 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1597471910 ## tests/providers/amazon/aws/links/test_base_aws.py: ## @@ -203,7 +204,10 @@ def test_link_serialize(self): """Test: Operator links should exist for

[PR] Implement AND logic checkbox for filtering DAGs [airflow]

2024-05-11 Thread via GitHub
TiDeane opened a new pull request, #39564: URL: https://github.com/apache/airflow/pull/39564 Implements a small checkbox named "Use AND logic" under the "filter DAGs by tag" box, allowing users to toggle between filtering DAGs using AND logic or OR logic. If there are no matching DAGs, it

(airflow) branch main updated: yandex provider: bump version for yq http client package (#39548)

2024-05-11 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new defe4590e9 yandex provider: bump version for yq

Re: [PR] yandex provider: bump version for yq http client package [airflow]

2024-05-11 Thread via GitHub
Taragolis merged PR #39548: URL: https://github.com/apache/airflow/pull/39548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Group id is mandatory configurtion option for confluent_kafka 2.4.0+ [airflow]

2024-05-11 Thread via GitHub
dylanbstorey commented on PR #39559: URL: https://github.com/apache/airflow/pull/39559#issuecomment-2105740417 Yeah that should be all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Proofread the `INSTALL` file [airflow]

2024-05-11 Thread via GitHub
potiuk commented on PR #39563: URL: https://github.com/apache/airflow/pull/39563#issuecomment-2105731291 Nice :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(airflow) branch main updated: Update INSTALL (#39563)

2024-05-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 092153c2e2 Update INSTALL (#39563) 092153c2e2 is

Re: [PR] Proofread the `INSTALL` file [airflow]

2024-05-11 Thread via GitHub
potiuk merged PR #39563: URL: https://github.com/apache/airflow/pull/39563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Proofread the `INSTALL` file [airflow]

2024-05-11 Thread via GitHub
shahar1 commented on PR #39563: URL: https://github.com/apache/airflow/pull/39563#issuecomment-2105727883 cc: @potiuk (changing this file doesn't assign reviewers automatically) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] Update INSTALL [airflow]

2024-05-11 Thread via GitHub
shahar1 opened a new pull request, #39563: URL: https://github.com/apache/airflow/pull/39563 Proofread the `INSTALL` file --- **^ Add meaningful description above** Read the **[Pull Request

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-11 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1597433753 ## tests/providers/amazon/aws/links/test_base_aws.py: ## @@ -203,7 +204,10 @@ def test_link_serialize(self): """Test: Operator links should exist for

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-11 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1597430270 ## tests/providers/amazon/aws/links/test_base_aws.py: ## @@ -203,7 +204,10 @@ def test_link_serialize(self): """Test: Operator links should exist for

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-11 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1597429662 ## tests/providers/amazon/aws/links/test_base_aws.py: ## @@ -203,7 +204,10 @@ def test_link_serialize(self): """Test: Operator links should exist for

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-11 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1597429528 ## tests/providers/amazon/aws/links/test_base_aws.py: ## @@ -203,7 +204,10 @@ def test_link_serialize(self): """Test: Operator links should exist for

[I] Support different plugins_folder setting in helm chart when airflow version > 2.0.0 [airflow]

2024-05-11 Thread via GitHub
tankim opened a new issue, #39562: URL: https://github.com/apache/airflow/issues/39562 ### Description When configuring Airflow using a Helm chart, the `core` section allows you to set the `plugins_folder`. This setting is applied equally across all web servers and schedulers. Many

Re: [I] Support different plugins_folder setting in helm chart when airflow version > 2.0.0 [airflow]

2024-05-11 Thread via GitHub
boring-cyborg[bot] commented on issue #39562: URL: https://github.com/apache/airflow/issues/39562#issuecomment-2105683617 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

Re: [PR] yandex provider: bump version for yq http client package [airflow]

2024-05-11 Thread via GitHub
Taragolis commented on PR #39548: URL: https://github.com/apache/airflow/pull/39548#issuecomment-2105680384 I've add missing changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-11 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1597427202 ## tests/providers/amazon/aws/links/test_base_aws.py: ## @@ -203,7 +204,10 @@ def test_link_serialize(self): """Test: Operator links should exist for

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-11 Thread via GitHub
Taragolis commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1597426660 ## tests/providers/amazon/aws/links/test_base_aws.py: ## @@ -203,7 +204,10 @@ def test_link_serialize(self): """Test: Operator links should exist for

(airflow) branch main updated (86caf84934 -> 5fd1128085)

2024-05-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 86caf84934 Remove Airflow 2.6 back compact code (#39558) add 5fd1128085 Update uv to 0.42 (#39561) No new

Re: [PR] Update uv to 0.1.42 [airflow]

2024-05-11 Thread via GitHub
potiuk merged PR #39561: URL: https://github.com/apache/airflow/pull/39561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Remove Airflow 2.6 back compact code [airflow]

2024-05-11 Thread via GitHub
eladkal merged PR #39558: URL: https://github.com/apache/airflow/pull/39558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Remove Airflow 2.6 back compact code (#39558)

2024-05-11 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 86caf84934 Remove Airflow 2.6 back compact code

[PR] Update uv to 0.42 [airflow]

2024-05-11 Thread via GitHub
potiuk opened a new pull request, #39561: URL: https://github.com/apache/airflow/pull/39561 --- **^ Add meaningful description above** Read the **[Pull Request

(airflow) branch main updated: fix boring-cyborg.yml (#39557)

2024-05-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new a22d042ace fix boring-cyborg.yml (#39557)

Re: [PR] fix boring-cyborg.yml [airflow]

2024-05-11 Thread via GitHub
potiuk merged PR #39557: URL: https://github.com/apache/airflow/pull/39557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Group id is mandatory configurtion option for confluent_kafka 2.4.0+ (#39559)

2024-05-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e637367958 Group id is mandatory configurtion

Re: [PR] Group id is mandatory configurtion option for confluent_kafka 2.4.0+ [airflow]

2024-05-11 Thread via GitHub
potiuk merged PR #39559: URL: https://github.com/apache/airflow/pull/39559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update best-practices.rst: fix Connection.get [airflow]

2024-05-11 Thread via GitHub
boring-cyborg[bot] commented on PR #39560: URL: https://github.com/apache/airflow/pull/39560#issuecomment-2105622673 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[PR] Update best-practices.rst: fix Connection.get [airflow]

2024-05-11 Thread via GitHub
iamtodor opened a new pull request, #39560: URL: https://github.com/apache/airflow/pull/39560 Replace `Connection.get` with `Connection. get_connection_from_secrets` Resolves https://github.com/apache/airflow/issues/39475 --- **^ Add meaningful

Re: [PR] ADD prototype version dark mode for Airflow UI [airflow]

2024-05-11 Thread via GitHub
YounHS commented on code in PR #39355: URL: https://github.com/apache/airflow/pull/39355#discussion_r1597388058 ## airflow/www/templates/appbuilder/navbar.html: ## @@ -50,6 +50,13 @@ {% include 'appbuilder/navbar_menu.html' %} + Review Comment:

Re: [PR] ADD prototype version dark mode for Airflow UI [airflow]

2024-05-11 Thread via GitHub
YounHS commented on code in PR #39355: URL: https://github.com/apache/airflow/pull/39355#discussion_r1597386702 ## airflow/www/views.py: ## @@ -719,8 +719,17 @@ def render_template(self, *args, **kwargs): **kwargs, ) +class

Re: [PR] Group id is mandatory configurtion option for confluent_kafka 2.4.0+ [airflow]

2024-05-11 Thread via GitHub
potiuk commented on PR #39559: URL: https://github.com/apache/airflow/pull/39559#issuecomment-2105612755 cc: @dylanbstorey -> our integration tests started to fail with latest `confluent_kafka` -> and I **think** this PR should fix it, but would love your pair of eyes on it. -- This is

[PR] Group id is mandatory configurtion option for iconfluent_kafka 2.4.0+ [airflow]

2024-05-11 Thread via GitHub
potiuk opened a new pull request, #39559: URL: https://github.com/apache/airflow/pull/39559 The group.id parameter has been optional before 2.4.0 version of confluent_kafka relased on 7th of May. This started to fail our integration tests (cool). This PR adds "group.id" as extra

Re: [I] Bug in Extras in Add Connection , while writing few words are hidden due to margin and padding [airflow]

2024-05-11 Thread via GitHub
eladkal commented on issue #37583: URL: https://github.com/apache/airflow/issues/37583#issuecomment-2105608675 @Ram-tripath please share real example of the issue `" {Ke" " ` i think the real issue you are trying to solve is not about hidden things but more about having Json linter

[PR] Remove Airflow 2.6 back compact code [airflow]

2024-05-11 Thread via GitHub
eladkal opened a new pull request, #39558: URL: https://github.com/apache/airflow/pull/39558 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Fix default behaviour for init function in `AppriseNotifier` [airflow]

2024-05-11 Thread via GitHub
eladkal commented on PR #38593: URL: https://github.com/apache/airflow/pull/38593#issuecomment-2105600969 @rrr2rrr can you please fix the test? `FAILED tests/providers/apprise/notifications/test_apprise.py::TestAppriseNotifier::test_notifier - AssertionError: expected call not found.`

(airflow) branch main updated: enh(amazon_hook): raise not found exception instead of general exception when download file (#39509)

2024-05-11 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ca058a635e enh(amazon_hook): raise not found

Re: [PR] enh(amazon_hook): in file download, change type of raised exception due to 404 [airflow]

2024-05-11 Thread via GitHub
boring-cyborg[bot] commented on PR #39509: URL: https://github.com/apache/airflow/pull/39509#issuecomment-2105600552 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] enh(amazon_hook): in file download, change type of raised exception due to 404 [airflow]

2024-05-11 Thread via GitHub
eladkal merged PR #39509: URL: https://github.com/apache/airflow/pull/39509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix BigQuery jobs Label Regex [airflow]

2024-05-11 Thread via GitHub
eladkal commented on PR #39556: URL: https://github.com/apache/airflow/pull/39556#issuecomment-2105600292 Can you add unit test to avoid regression? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] fix boring-cyborg.yml [airflow]

2024-05-11 Thread via GitHub
eladkal opened a new pull request, #39557: URL: https://github.com/apache/airflow/pull/39557 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Reapply templates for all providers [airflow]

2024-05-11 Thread via GitHub
potiuk commented on code in PR #39554: URL: https://github.com/apache/airflow/pull/39554#discussion_r1597372120 ## airflow/providers/tabular/__init__.py: ## @@ -14,3 +14,26 @@ # KIND, either express or implied. See the License for the # specific language governing

Re: [PR] Fix tabular provider version 1.5.0 removal [airflow]

2024-05-11 Thread via GitHub
potiuk closed pull request #39555: Fix tabular provider version 1.5.0 removal URL: https://github.com/apache/airflow/pull/39555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix tabular provider version 1.5.0 removal [airflow]

2024-05-11 Thread via GitHub
potiuk commented on PR #39555: URL: https://github.com/apache/airflow/pull/39555#issuecomment-2105596604 Superseded by #39554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(airflow) branch main updated: Reapply templates for all providers (#39554)

2024-05-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2b1a2f8d56 Reapply templates for all providers

Re: [PR] Reapply templates for all providers [airflow]

2024-05-11 Thread via GitHub
potiuk merged PR #39554: URL: https://github.com/apache/airflow/pull/39554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [fix] Simplify metrics handling [airflow]

2024-05-11 Thread via GitHub
Jack-R-lantern closed pull request #38818: [fix] Simplify metrics handling URL: https://github.com/apache/airflow/pull/38818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix] Simplify metrics handling [airflow]

2024-05-11 Thread via GitHub
Jack-R-lantern closed pull request #38818: [fix] Simplify metrics handling URL: https://github.com/apache/airflow/pull/38818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Reapply templates for all providers [airflow]

2024-05-11 Thread via GitHub
eladkal commented on code in PR #39554: URL: https://github.com/apache/airflow/pull/39554#discussion_r1597369983 ## airflow/providers/tabular/__init__.py: ## @@ -14,3 +14,26 @@ # KIND, either express or implied. See the License for the # specific language governing

Re: [PR] Add timeout when watching pod events in k8s executor [airflow]

2024-05-11 Thread via GitHub
dstandish commented on code in PR #39551: URL: https://github.com/apache/airflow/pull/39551#discussion_r1597369523 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py: ## @@ -165,6 +163,14 @@ def _run( last_resource_version: str | None = None