[GitHub] [airflow] hussein-awala commented on a diff in pull request #29809: Adding configuration to control retry parameters for k8s api client

2023-04-13 Thread via GitHub
hussein-awala commented on code in PR #29809: URL: https://github.com/apache/airflow/pull/29809#discussion_r1166074222 ## airflow/kubernetes/kube_client.py: ## @@ -125,5 +138,5 @@ def get_kube_client( if ssl_ca_cert: configuration.ssl_ca_cert = ssl_ca_cert -

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29809: Adding configuration to control retry parameters for k8s api client

2023-04-13 Thread via GitHub
hussein-awala commented on code in PR #29809: URL: https://github.com/apache/airflow/pull/29809#discussion_r1166065617 ## tests/kubernetes/test_client.py: ## @@ -81,3 +84,11 @@ def test_disable_verify_ssl(self): else: configuration = Configuration()

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29809: Adding configuration to control retry parameters for k8s api client

2023-03-17 Thread via GitHub
hussein-awala commented on code in PR #29809: URL: https://github.com/apache/airflow/pull/29809#discussion_r1139851471 ## airflow/kubernetes/kube_client.py: ## @@ -107,23 +110,36 @@ def get_kube_client( if conf.getboolean("kubernetes_executor", "enable_tcp_keepalive"):

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29809: Adding configuration to control retry parameters for k8s api client

2023-03-13 Thread via GitHub
hussein-awala commented on code in PR #29809: URL: https://github.com/apache/airflow/pull/29809#discussion_r1134606251 ## airflow/kubernetes/kube_client.py: ## @@ -105,16 +107,26 @@ def get_kube_client( if conf.getboolean("kubernetes_executor", "enable_tcp_keepalive"):

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29809: Adding configuration to control retry parameters for k8s api client

2023-03-05 Thread via GitHub
hussein-awala commented on code in PR #29809: URL: https://github.com/apache/airflow/pull/29809#discussion_r1125696401 ## airflow/kubernetes/kube_client.py: ## @@ -105,16 +107,28 @@ def get_kube_client( if conf.getboolean("kubernetes_executor", "enable_tcp_keepalive"):

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29809: Adding configuration to control retry parameters for k8s api client

2023-03-05 Thread via GitHub
hussein-awala commented on code in PR #29809: URL: https://github.com/apache/airflow/pull/29809#discussion_r1125695860 ## tests/kubernetes/test_client.py: ## @@ -78,3 +80,23 @@ def test_disable_verify_ssl(self): else: configuration = Configuration()

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29809: Adding configuration to control retry parameters for k8s api client

2023-03-04 Thread via GitHub
hussein-awala commented on code in PR #29809: URL: https://github.com/apache/airflow/pull/29809#discussion_r1125584719 ## tests/kubernetes/test_client.py: ## @@ -78,3 +80,23 @@ def test_disable_verify_ssl(self): else: configuration = Configuration()

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29809: Adding configuration to control retry parameters for k8s api client

2023-03-02 Thread via GitHub
hussein-awala commented on code in PR #29809: URL: https://github.com/apache/airflow/pull/29809#discussion_r1123866188 ## airflow/kubernetes/kube_client.py: ## @@ -105,16 +107,24 @@ def get_kube_client( if conf.getboolean("kubernetes_executor", "enable_tcp_keepalive"):

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29809: Adding configuration to control retry parameters for k8s api client

2023-02-28 Thread via GitHub
hussein-awala commented on code in PR #29809: URL: https://github.com/apache/airflow/pull/29809#discussion_r1120948866 ## airflow/config_templates/config.yml: ## @@ -2465,6 +2465,13 @@ kubernetes_executor: previous_name: kubernetes version: 2.5.0 options: +