mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r512183344
##
File path: .pre-commit-config.yaml
##
@@ -277,7 +277,7 @@ repos:
entry: "^\\s*from\\s+\\."
pass_filenames: true
files:
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r512181994
##
File path: .pre-commit-config.yaml
##
@@ -277,7 +277,7 @@ repos:
entry: "^\\s*from\\s+\\."
pass_filenames: true
files:
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r512176444
##
File path: chart/tests/git-sync-scheduler_test.yaml
##
@@ -1,154 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
Review
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r512165649
##
File path: .pre-commit-config.yaml
##
@@ -277,7 +277,7 @@ repos:
entry: "^\\s*from\\s+\\."
pass_filenames: true
files:
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r512156689
##
File path: TESTING.rst
##
@@ -196,6 +196,44 @@ Run all Quarantined tests:
./breeze --test-type Quarantined tests --db-reset
+Helm Unit
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511664620
##
File path: .pre-commit-config.yaml
##
@@ -277,7 +277,7 @@ repos:
entry: "^\\s*from\\s+\\."
pass_filenames: true
files:
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511664620
##
File path: .pre-commit-config.yaml
##
@@ -277,7 +277,7 @@ repos:
entry: "^\\s*from\\s+\\."
pass_filenames: true
files:
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511643293
##
File path: scripts/in_container/entrypoint_ci.sh
##
@@ -170,7 +170,33 @@ set -u
export RESULT_LOG_FILE="/files/test_result.xml"
if [[
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511642916
##
File path: scripts/ci/testing/ci_run_airflow_testing.sh
##
@@ -60,11 +60,12 @@ function run_airflow_testing_in_docker() {
echo "Skip
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511642810
##
File path: chart/tests/helm_template_generator.py
##
@@ -0,0 +1,61 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511642713
##
File path: chart/tests/conftest.py
##
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511642736
##
File path: chart/tests/git-sync-scheduler_test.yaml
##
@@ -1,154 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
Review
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511642303
##
File path: chart/requirements.lock
##
@@ -1,6 +1,6 @@
dependencies:
- name: postgresql
- repository:
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511642251
##
File path: Dockerfile.ci
##
@@ -348,8 +348,19 @@ RUN if command -v airflow; then \
# Install autocomplete for Kubectl
RUN echo "source
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511642215
##
File path: Dockerfile.ci
##
@@ -348,8 +348,19 @@ RUN if command -v airflow; then \
# Install autocomplete for Kubectl
RUN echo "source
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511642166
##
File path: .pre-commit-config.yaml
##
@@ -451,6 +451,12 @@ repos:
language: system
entry:
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511641707
##
File path: .pre-commit-config.yaml
##
@@ -201,7 +201,7 @@ repos:
args:
- --convention=pep257
-
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511641707
##
File path: .pre-commit-config.yaml
##
@@ -201,7 +201,7 @@ repos:
args:
- --convention=pep257
-
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511641661
##
File path: .pre-commit-config.yaml
##
@@ -153,7 +153,7 @@ repos:
rev: 20.8b1
hooks:
- id: black
-files:
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511641661
##
File path: .pre-commit-config.yaml
##
@@ -153,7 +153,7 @@ repos:
rev: 20.8b1
hooks:
- id: black
-files:
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511609078
##
File path: .github/workflows/ci.yml
##
@@ -424,6 +424,52 @@ jobs:
name: airflow-provider-readmes
path:
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511528599
##
File path: .github/workflows/ci.yml
##
@@ -424,6 +428,52 @@ jobs:
name: airflow-provider-readmes
path:
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511223301
##
File path: scripts/ci/kubernetes/ci_run_helm_testing.sh
##
@@ -18,7 +18,28 @@
echo "Running helm tests"
+. "$( dirname "${BASH_SOURCE[0]}"
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511222593
##
File path: scripts/ci/kubernetes/ci_run_helm_testing.sh
##
@@ -18,7 +18,28 @@
echo "Running helm tests"
+. "$( dirname "${BASH_SOURCE[0]}"
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511213269
##
File path: scripts/ci/kubernetes/ci_run_helm_testing.sh
##
@@ -18,7 +18,28 @@
echo "Running helm tests"
+. "$( dirname "${BASH_SOURCE[0]}"
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511198433
##
File path: .github/workflows/ci.yml
##
@@ -138,13 +138,32 @@ jobs:
timeout-minutes: 5
name: "Checks: Helm tests"
runs-on:
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511180388
##
File path: scripts/ci/kubernetes/ci_run_helm_testing.sh
##
@@ -18,7 +18,28 @@
echo "Running helm tests"
+. "$( dirname "${BASH_SOURCE[0]}"
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511163980
##
File path: scripts/ci/kubernetes/ci_run_helm_testing.sh
##
@@ -20,6 +20,8 @@ echo "Running helm tests"
chart_directory="$( cd "$( dirname
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511163187
##
File path: chart/tests/helm_template_generator.py
##
@@ -0,0 +1,61 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511162977
##
File path: chart/tests/helm_template_generator.py
##
@@ -0,0 +1,61 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r55327
##
File path:
chart_tests/test_templates/git_sync_scheduler/git-sync-existing-claim.yaml
##
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r510775901
##
File path: .dockerignore
##
@@ -45,6 +45,7 @@
# Add tests and kubernetes_tests to context.
!tests
!kubernetes_tests
+!chart_tests
Review
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r510464290
##
File path:
chart_tests/test_templates/git_sync_scheduler/git-sync-existing-claim.yaml
##
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r509583891
##
File path: scripts/ci/libraries/_local_mounts.sh
##
@@ -51,6 +51,7 @@ function local_mounts::generate_local_mounts_list {
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r509579685
##
File path: tests/helm/test_git_sync_scheduler.py
##
@@ -0,0 +1,136 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r508852272
##
File path: tests/helm/test_git_sync_scheduler.py
##
@@ -0,0 +1,136 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r508851415
##
File path: tests/helm/test_git_sync_scheduler.py
##
@@ -0,0 +1,136 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r508850541
##
File path: tests/helm/__init__.py
##
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
I think
mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r508845350
##
File path: airflow/utils/helm_template_generator.py
##
@@ -0,0 +1,62 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review
39 matches
Mail list logo
