Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

boring-cyborg[bot] commented on PR #38716: URL: https://github.com/apache/airflow/pull/38716#issuecomment-2066107379 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

potiuk merged PR #38716: URL: https://github.com/apache/airflow/pull/38716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

potiuk commented on PR #38716: URL: https://github.com/apache/airflow/pull/38716#issuecomment-2066107147 Nothing to be sorry about :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

zstrathe commented on PR #38716: URL: https://github.com/apache/airflow/pull/38716#issuecomment-2065462531 @potiuk Static checks should pass now. I sincerely apologize for that, I'll ensure to run pre-commit checks for any future contributions. -- This is an automated message from the

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

potiuk commented on PR #38716: URL: https://github.com/apache/airflow/pull/38716#issuecomment-2065216353 Static checks need fixing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

e-galan commented on PR #38716: URL: https://github.com/apache/airflow/pull/38716#issuecomment-2063660272 The changes look good to me @zstrathe. What do you think @eladkal ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

zstrathe commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1568197801 ## tests/providers/apache/beam/operators/test_beam.py: ## @@ -256,6 +256,59 @@ def test_on_kill_direct_runner(self, _, dataflow_mock, __): op.on_kill()

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

e-galan commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1566949795 ## tests/providers/apache/beam/operators/test_beam.py: ## @@ -256,6 +256,59 @@ def test_on_kill_direct_runner(self, _, dataflow_mock, __): op.on_kill()

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

zstrathe commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1565032713 ## tests/providers/apache/beam/operators/test_beam.py: ## Review Comment: @e-galan @eladkal I added test_execute_gcs_hook_called_only_with_gs_prefix() to

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

zstrathe commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1565032713 ## tests/providers/apache/beam/operators/test_beam.py: ## Review Comment: @e-galan @eladkal I added test_execute_gcs_hook_called_only_with_gs_prefix() to

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

zstrathe commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1565032713 ## tests/providers/apache/beam/operators/test_beam.py: ## Review Comment: I added test_execute_gcs_hook_called_only_with_gs_prefix() to the

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

zstrathe commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1565030327 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

zstrathe commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1555982325 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

zstrathe commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1555982325 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

zstrathe commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1555982325 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

e-galan commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1555830278 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

e-galan commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1555810282 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

zstrathe commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1550311342 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

eladkal commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1550301331 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

zstrathe commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1550297987 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

eladkal commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1550265521 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

eladkal commented on code in PR #38716: URL: https://github.com/apache/airflow/pull/38716#discussion_r1550265521 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -364,11 +364,13 @@ def execute(self, context: Context): def execute_sync(self, context: Context):

Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

boring-cyborg[bot] commented on PR #38716: URL: https://github.com/apache/airflow/pull/38716#issuecomment-2035003228 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our