[GitHub] [airflow] XD-DENG commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook

2019-10-02 Thread GitBox
XD-DENG commented on a change in pull request #6234: [AIRFLOW-5529] support apache drill hook URL: https://github.com/apache/airflow/pull/6234#discussion_r330574362 ## File path: setup.py ## @@ -182,6 +182,11 @@ def write_version(filename: str = os.path.join(*["airflow",

[GitHub] [airflow] kpathak13 commented on a change in pull request #6237: AIRFLOW-5581: Join KubernetesJobWatcher in terminate call

2019-10-02 Thread GitBox
kpathak13 commented on a change in pull request #6237: AIRFLOW-5581: Join KubernetesJobWatcher in terminate call URL: https://github.com/apache/airflow/pull/6237#discussion_r330583452 ## File path: airflow/executors/kubernetes_executor.py ## @@ -576,6 +576,7 @@ def

[jira] [Created] (AIRFLOW-5585) Docker-context file check gives only marginal improvements for build

2019-10-02 Thread Jarek Potiuk (Jira)
Jarek Potiuk created AIRFLOW-5585: - Summary: Docker-context file check gives only marginal improvements for build Key: AIRFLOW-5585 URL: https://issues.apache.org/jira/browse/AIRFLOW-5585 Project:

[jira] [Commented] (AIRFLOW-5362) Imports are not ordered properly

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942911#comment-16942911 ] ASF subversion and git services commented on AIRFLOW-5362: -- Commit

[GitHub] [airflow] kimpers commented on a change in pull request #6241: [AIRFLOW-3014] Increase connection password length to match model

2019-10-02 Thread GitBox
kimpers commented on a change in pull request #6241: [AIRFLOW-3014] Increase connection password length to match model URL: https://github.com/apache/airflow/pull/6241#discussion_r330638118 ## File path: airflow/migrations/versions/37c6b55d15a9_merge_migration_heads.py ##

[GitHub] [airflow] mik-laj commented on a change in pull request #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators

2019-10-02 Thread GitBox
mik-laj commented on a change in pull request #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators URL: https://github.com/apache/airflow/pull/6228#discussion_r330520367 ## File path: airflow/gcp/operators/search_ads.py ## @@ -0,0 +1,200 @@ +# -*- coding: utf-8 -*-

[GitHub] [airflow] mik-laj commented on a change in pull request #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators

2019-10-02 Thread GitBox
mik-laj commented on a change in pull request #6228: [AIRFLOW-5379] Add Google Search Ads 360 operators URL: https://github.com/apache/airflow/pull/6228#discussion_r330552971 ## File path: airflow/gcp/operators/search_ads.py ## @@ -0,0 +1,200 @@ +# -*- coding: utf-8 -*-

[jira] [Updated] (AIRFLOW-5362) Imports are not ordered properly

2019-10-02 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-5362: -- Fix Version/s: (was: 1.10.6) 2.0.0 > Imports are not ordered properly

[jira] [Commented] (AIRFLOW-5529) Support Apache Drill hook

2019-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942864#comment-16942864 ] ASF GitHub Bot commented on AIRFLOW-5529: - blcksrx commented on pull request #6234:

[GitHub] [airflow] ashb commented on a change in pull request #6237: AIRFLOW-5581: Join KubernetesJobWatcher in terminate call

2019-10-02 Thread GitBox
ashb commented on a change in pull request #6237: AIRFLOW-5581: Join KubernetesJobWatcher in terminate call URL: https://github.com/apache/airflow/pull/6237#discussion_r330590036 ## File path: airflow/executors/kubernetes_executor.py ## @@ -576,6 +576,7 @@ def

[GitHub] [airflow] codecov-io commented on issue #6239: [AIRFLOW-5585] Remove docker context from build

2019-10-02 Thread GitBox
codecov-io commented on issue #6239: [AIRFLOW-5585] Remove docker context from build URL: https://github.com/apache/airflow/pull/6239#issuecomment-537570182 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6239?src=pr=h1) Report > :exclamation: No coverage uploaded for pull

[GitHub] [airflow] codecov-io edited a comment on issue #6240: [AIRFLOW-XXX] Make it clear that 1.10.5 wasn't accidentally omitted from UPDATING.md

2019-10-02 Thread GitBox
codecov-io edited a comment on issue #6240: [AIRFLOW-XXX] Make it clear that 1.10.5 wasn't accidentally omitted from UPDATING.md URL: https://github.com/apache/airflow/pull/6240#issuecomment-537578909 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6240?src=pr=h1) Report >

[GitHub] [airflow] codecov-io edited a comment on issue #6240: [AIRFLOW-XXX] Make it clear that 1.10.5 wasn't accidentally omitted from UPDATING.md

2019-10-02 Thread GitBox
codecov-io edited a comment on issue #6240: [AIRFLOW-XXX] Make it clear that 1.10.5 wasn't accidentally omitted from UPDATING.md URL: https://github.com/apache/airflow/pull/6240#issuecomment-537578909 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6240?src=pr=h1) Report >

[GitHub] [airflow] Tagar commented on a change in pull request #6090: [AIRFLOW-5470] Add Apache Livy REST operator

2019-10-02 Thread GitBox
Tagar commented on a change in pull request #6090: [AIRFLOW-5470] Add Apache Livy REST operator URL: https://github.com/apache/airflow/pull/6090#discussion_r330639113 ## File path: airflow/contrib/hooks/livy_hook.py ## @@ -0,0 +1,297 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] [airflow] Tagar commented on a change in pull request #6090: [AIRFLOW-5470] Add Apache Livy REST operator

2019-10-02 Thread GitBox
Tagar commented on a change in pull request #6090: [AIRFLOW-5470] Add Apache Livy REST operator URL: https://github.com/apache/airflow/pull/6090#discussion_r330640096 ## File path: airflow/contrib/hooks/livy_hook.py ## @@ -0,0 +1,297 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] [airflow] Tagar commented on a change in pull request #6090: [AIRFLOW-5470] Add Apache Livy REST operator

2019-10-02 Thread GitBox
Tagar commented on a change in pull request #6090: [AIRFLOW-5470] Add Apache Livy REST operator URL: https://github.com/apache/airflow/pull/6090#discussion_r330642789 ## File path: airflow/utils/db.py ## @@ -200,6 +200,10 @@ def initdb(): Connection(

[GitHub] [airflow] codecov-io commented on issue #6240: [AIRFLOW-XXX] Make it clear that 1.10.5 wasn't accidentally omitted from UPDATING.md

2019-10-02 Thread GitBox
codecov-io commented on issue #6240: [AIRFLOW-XXX] Make it clear that 1.10.5 wasn't accidentally omitted from UPDATING.md URL: https://github.com/apache/airflow/pull/6240#issuecomment-537578909 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6240?src=pr=h1) Report > :exclamation:

[GitHub] [airflow] Tagar commented on a change in pull request #6090: [AIRFLOW-5470] Add Apache Livy REST operator

2019-10-02 Thread GitBox
Tagar commented on a change in pull request #6090: [AIRFLOW-5470] Add Apache Livy REST operator URL: https://github.com/apache/airflow/pull/6090#discussion_r330655060 ## File path: airflow/contrib/hooks/livy_hook.py ## @@ -0,0 +1,297 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] [airflow] feng-tao commented on issue #6238: Updated readme with "Who's using" information

2019-10-02 Thread GitBox
feng-tao commented on issue #6238: Updated readme with "Who's using" information URL: https://github.com/apache/airflow/pull/6238#issuecomment-537584047 need rebase This is an automated message from the Apache Git Service. To

[GitHub] [airflow] codecov-io commented on issue #6233: [AIRFLOW-4939] Simplify Code for Default Task Retries

2019-10-02 Thread GitBox
codecov-io commented on issue #6233: [AIRFLOW-4939] Simplify Code for Default Task Retries URL: https://github.com/apache/airflow/pull/6233#issuecomment-537612331 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6233?src=pr=h1) Report > Merging

[GitHub] [airflow] efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration

2019-10-02 Thread GitBox
efolgar commented on a change in pull request #6170: [AIRFLOW-4971][Don't merge] Add Google Display & Video 360 integration URL: https://github.com/apache/airflow/pull/6170#discussion_r330693110 ## File path: airflow/gcp/operators/display_video.py ## @@ -0,0 +1,301 @@ +#

[GitHub] [airflow] potiuk commented on issue #6229: [AIRFLOW-5580] Add base class for system test

2019-10-02 Thread GitBox
potiuk commented on issue #6229: [AIRFLOW-5580] Add base class for system test URL: https://github.com/apache/airflow/pull/6229#issuecomment-537641809 It should be rebased to the latest master @nuclearpinguin This is an

[GitHub] [airflow] feng-tao commented on a change in pull request #6238: Updated readme with "Who's using" information

2019-10-02 Thread GitBox
feng-tao commented on a change in pull request #6238: Updated readme with "Who's using" information URL: https://github.com/apache/airflow/pull/6238#discussion_r330739959 ## File path: README.md ## @@ -282,6 +282,7 @@ Currently **officially** using Airflow: 1.

[GitHub] [airflow] codecov-io commented on issue #6230: [AIRFLOW-5413] enable K8S pod config from file

2019-10-02 Thread GitBox
codecov-io commented on issue #6230: [AIRFLOW-5413] enable K8S pod config from file URL: https://github.com/apache/airflow/pull/6230#issuecomment-537654940 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6230?src=pr=h1) Report > Merging

[GitHub] [airflow] saianupkumarp commented on a change in pull request #6238: Updated readme with "Who's using" information

2019-10-02 Thread GitBox
saianupkumarp commented on a change in pull request #6238: Updated readme with "Who's using" information URL: https://github.com/apache/airflow/pull/6238#discussion_r330742581 ## File path: README.md ## @@ -282,6 +282,7 @@ Currently **officially** using Airflow: 1.

[GitHub] [airflow] dimberman commented on a change in pull request #6230: [AIRFLOW-5413] enable K8S pod config from file

2019-10-02 Thread GitBox
dimberman commented on a change in pull request #6230: [AIRFLOW-5413] enable K8S pod config from file URL: https://github.com/apache/airflow/pull/6230#discussion_r330743153 ## File path: airflow/kubernetes/kube_config.py ## @@ -0,0 +1,218 @@ +# Licensed to the Apache

[GitHub] [airflow] feng-tao merged pull request #6238: [AIRFLOW-XXX] Updated readme with "Who's using" information

2019-10-02 Thread GitBox
feng-tao merged pull request #6238: [AIRFLOW-XXX] Updated readme with "Who's using" information URL: https://github.com/apache/airflow/pull/6238 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mik-laj opened a new pull request #6243: [AIRFLOW-XXX] Highlight code blocks

2019-10-02 Thread GitBox
mik-laj opened a new pull request #6243: [AIRFLOW-XXX] Highlight code blocks URL: https://github.com/apache/airflow/pull/6243 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] [airflow] dimberman commented on a change in pull request #6230: [AIRFLOW-5413] enable K8S pod config from file

2019-10-02 Thread GitBox
dimberman commented on a change in pull request #6230: [AIRFLOW-5413] enable K8S pod config from file URL: https://github.com/apache/airflow/pull/6230#discussion_r330750756 ## File path: airflow/executors/kubernetes_executor.py ## @@ -373,29 +183,74 @@ def run_next(self,

[jira] [Commented] (AIRFLOW-5490) security.py: Fix incorrect None comparison

2019-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943139#comment-16943139 ] ASF GitHub Bot commented on AIRFLOW-5490: - milton0825 commented on pull request #6222: Revert

[GitHub] [airflow] saianupkumarp commented on issue #6238: Updated readme with "Who's using" information

2019-10-02 Thread GitBox
saianupkumarp commented on issue #6238: Updated readme with "Who's using" information URL: https://github.com/apache/airflow/pull/6238#issuecomment-537652022 > need rebase Thank you @feng-tao. I have done the rebase.

[GitHub] [airflow] dimberman commented on issue #6230: [AIRFLOW-5413] enable K8S pod config from file

2019-10-02 Thread GitBox
dimberman commented on issue #6230: [AIRFLOW-5413] enable K8S pod config from file URL: https://github.com/apache/airflow/pull/6230#issuecomment-537656984 @ashb @kaxil @potiuk @davlum and I had a discussion about this a few weeks ago and I think this is a fantastic idea, but it's

[GitHub] [airflow] mik-laj opened a new pull request #6242: [AIRFLOW-XXX] Improve format in code-block directives

2019-10-02 Thread GitBox
mik-laj opened a new pull request #6242: [AIRFLOW-XXX] Improve format in code-block directives URL: https://github.com/apache/airflow/pull/6242 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] [airflow] mik-laj opened a new pull request #6244: [AIRFLOW-XXX] Improve linking

2019-10-02 Thread GitBox
mik-laj opened a new pull request #6244: [AIRFLOW-XXX] Improve linking URL: https://github.com/apache/airflow/pull/6244 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)

[GitHub] [airflow] mik-laj opened a new pull request #6245: [AIRFLOW-XXX] Format sengrid docs

2019-10-02 Thread GitBox
mik-laj opened a new pull request #6245: [AIRFLOW-XXX] Format sengrid docs URL: https://github.com/apache/airflow/pull/6245 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] [airflow] davlum commented on a change in pull request #6230: [AIRFLOW-5413] enable K8S pod config from file

2019-10-02 Thread GitBox
davlum commented on a change in pull request #6230: [AIRFLOW-5413] enable K8S pod config from file URL: https://github.com/apache/airflow/pull/6230#discussion_r330743809 ## File path: airflow/kubernetes/kube_config.py ## @@ -0,0 +1,218 @@ +# Licensed to the Apache

[GitHub] [airflow] milton0825 merged pull request #6222: Revert "[AIRFLOW-5490] Fix incorrect None comparison"

2019-10-02 Thread GitBox
milton0825 merged pull request #6222: Revert "[AIRFLOW-5490] Fix incorrect None comparison" URL: https://github.com/apache/airflow/pull/6222 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (AIRFLOW-5490) security.py: Fix incorrect None comparison

2019-10-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943140#comment-16943140 ] ASF subversion and git services commented on AIRFLOW-5490: -- Commit

[GitHub] [airflow] milton0825 commented on a change in pull request #6217: [AIRFLOW-5572] Clearing Task Instances with reschedule mode does not clear reschedules during up_for_reschedule

2019-10-02 Thread GitBox
milton0825 commented on a change in pull request #6217: [AIRFLOW-5572] Clearing Task Instances with reschedule mode does not clear reschedules during up_for_reschedule URL: https://github.com/apache/airflow/pull/6217#discussion_r330756079 ## File path:

[GitHub] [airflow] leahecole opened a new pull request #6246: [AIRFLOW-XXX] Improve CLI error messaging

2019-10-02 Thread GitBox
leahecole opened a new pull request #6246: [AIRFLOW-XXX] Improve CLI error messaging URL: https://github.com/apache/airflow/pull/6246 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] [airflow] jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator

2019-10-02 Thread GitBox
jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#issuecomment-537697927 Digging deeper on `DataflowJavaOperator` as an example. This is a poor choice because it requires running a java process on

[GitHub] [airflow] mik-laj commented on a change in pull request #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator

2019-10-02 Thread GitBox
mik-laj commented on a change in pull request #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#discussion_r330793090 ## File path: airflow/models/base_async_operator.py ## @@ -0,0 +1,96 @@ +# -*- coding:

[GitHub] [airflow] mik-laj commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator

2019-10-02 Thread GitBox
mik-laj commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#issuecomment-537704665 Dataproc operators will be rewritten to the goog-cloud library - * in the near future. Will it bother you?

[GitHub] [airflow] davlum commented on a change in pull request #6230: [AIRFLOW-5413] enable K8S pod config from file

2019-10-02 Thread GitBox
davlum commented on a change in pull request #6230: [AIRFLOW-5413] enable K8S pod config from file URL: https://github.com/apache/airflow/pull/6230#discussion_r330773213 ## File path: airflow/executors/kubernetes_executor.py ## @@ -373,29 +183,74 @@ def run_next(self,

[GitHub] [airflow] codecov-io commented on issue #6242: [AIRFLOW-XXX] Improve format in code-block directives

2019-10-02 Thread GitBox
codecov-io commented on issue #6242: [AIRFLOW-XXX] Improve format in code-block directives URL: https://github.com/apache/airflow/pull/6242#issuecomment-537683667 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6242?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #6244: [AIRFLOW-XXX] Improve linking

2019-10-02 Thread GitBox
codecov-io commented on issue #6244: [AIRFLOW-XXX] Improve linking URL: https://github.com/apache/airflow/pull/6244#issuecomment-537693476 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6244?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base

[GitHub] [airflow] mik-laj commented on issue #6246: [AIRFLOW-XXX] Improve CLI error messaging

2019-10-02 Thread GitBox
mik-laj commented on issue #6246: [AIRFLOW-XXX] Improve CLI error messaging URL: https://github.com/apache/airflow/pull/6246#issuecomment-537699582 This is a change in the code. Can you create a Jira ticket? This is an

[GitHub] [airflow] mik-laj commented on a change in pull request #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator

2019-10-02 Thread GitBox
mik-laj commented on a change in pull request #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#discussion_r330792031 ## File path: airflow/models/base_async_operator.py ## @@ -0,0 +1,96 @@ +# -*- coding:

[GitHub] [airflow] chang commented on issue #5044: [AIRFLOW-4240] Require POST for state-changing requests

2019-10-02 Thread GitBox
chang commented on issue #5044: [AIRFLOW-4240] Require POST for state-changing requests URL: https://github.com/apache/airflow/pull/5044#issuecomment-537702765 Thanks for the hint @ashb! I was able to fix this on our end - happy to submit a patch upstream, too.

[GitHub] [airflow] mik-laj commented on a change in pull request #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator

2019-10-02 Thread GitBox
mik-laj commented on a change in pull request #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#discussion_r330794247 ## File path: airflow/models/base_async_operator.py ## @@ -0,0 +1,96 @@ +# -*- coding:

[jira] [Created] (AIRFLOW-5586) Improve error messaging for role creation and updates

2019-10-02 Thread Leah (Jira)
Leah created AIRFLOW-5586: - Summary: Improve error messaging for role creation and updates Key: AIRFLOW-5586 URL: https://issues.apache.org/jira/browse/AIRFLOW-5586 Project: Apache Airflow Issue

[GitHub] [airflow] codecov-io edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-10-02 Thread GitBox
codecov-io edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-529755241 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5743?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-10-02 Thread GitBox
codecov-io edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-529755241 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5743?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-10-02 Thread GitBox
codecov-io edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-529755241 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5743?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability

2019-10-02 Thread GitBox
codecov-io edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-529755241 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5743?src=pr=h1) Report > Merging

[GitHub] [airflow] leahecole edited a comment on issue #6246: [AIRFLOW-5586] Improve CLI error messaging

2019-10-02 Thread GitBox
leahecole edited a comment on issue #6246: [AIRFLOW-5586] Improve CLI error messaging URL: https://github.com/apache/airflow/pull/6246#issuecomment-537728915 I'm trying this in travis on my own fork but am having trouble recreating the failing part of the travis job locally. Any insight

[GitHub] [airflow] leahecole commented on issue #6246: [AIRFLOW-5586] Improve CLI error messaging

2019-10-02 Thread GitBox
leahecole commented on issue #6246: [AIRFLOW-5586] Improve CLI error messaging URL: https://github.com/apache/airflow/pull/6246#issuecomment-537728915 I'm trying this in travis on my own fork but am having trouble recreating this part of the testing locally. Any insight is appreciated!

[GitHub] [airflow] dimberman commented on issue #6230: [AIRFLOW-5413] enable K8S pod config from file

2019-10-02 Thread GitBox
dimberman commented on issue #6230: [AIRFLOW-5413] enable K8S pod config from file URL: https://github.com/apache/airflow/pull/6230#issuecomment-537754239 @davlum can you rebase? This is an automated message from the Apache

[GitHub] [airflow] jaketf commented on a change in pull request #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator

2019-10-02 Thread GitBox
jaketf commented on a change in pull request #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#discussion_r330848344 ## File path: airflow/models/base_async_operator.py ## @@ -0,0 +1,96 @@ +# -*- coding:

[GitHub] [airflow] OmerJog commented on issue #5676: [AIRFLOW-5062] Add support for getting/setting ACL in S3Hook

2019-10-02 Thread GitBox
OmerJog commented on issue #5676: [AIRFLOW-5062] Add support for getting/setting ACL in S3Hook URL: https://github.com/apache/airflow/pull/5676#issuecomment-537793085 @LesterKim Can you please fix the error? ```

[GitHub] [airflow] Fokko commented on a change in pull request #6246: [AIRFLOW-5586] Improve CLI error messaging

2019-10-02 Thread GitBox
Fokko commented on a change in pull request #6246: [AIRFLOW-5586] Improve CLI error messaging URL: https://github.com/apache/airflow/pull/6246#discussion_r330867837 ## File path: airflow/bin/cli.py ## @@ -1376,8 +1376,10 @@ def users_list(args): def users_create(args):

[GitHub] [airflow] Fokko commented on a change in pull request #6246: [AIRFLOW-5586] Improve CLI error messaging

2019-10-02 Thread GitBox
Fokko commented on a change in pull request #6246: [AIRFLOW-5586] Improve CLI error messaging URL: https://github.com/apache/airflow/pull/6246#discussion_r330867874 ## File path: airflow/bin/cli.py ## @@ -1433,8 +1435,9 @@ def users_manage_role(args, remove=False):

[GitHub] [airflow] Fokko commented on a change in pull request #6246: [AIRFLOW-5586] Improve CLI error messaging

2019-10-02 Thread GitBox
Fokko commented on a change in pull request #6246: [AIRFLOW-5586] Improve CLI error messaging URL: https://github.com/apache/airflow/pull/6246#discussion_r330867792 ## File path: airflow/bin/cli.py ## @@ -1376,8 +1376,10 @@ def users_list(args): def users_create(args):

[GitHub] [airflow] jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator

2019-10-02 Thread GitBox
jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#issuecomment-537766761 I have noticed in looking at existing dataflow and dataproc hooks many hooks conflate job submission and `wait_for_done`

[GitHub] [airflow] jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator

2019-10-02 Thread GitBox
jaketf commented on issue #6210: [AIRFLOW-5567] [Do not Merge] prototype BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#issuecomment-537765917 @mik-laj Is there any operator you can think of that might be a better example to refactor as an async operator that might not

[jira] [Commented] (AIRFLOW-5500) Bug in trigger api endpoint

2019-10-02 Thread jack (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943345#comment-16943345 ] jack commented on AIRFLOW-5500: --- Can you PR the fix? > Bug in trigger api endpoint >

[jira] [Commented] (AIRFLOW-3032) _pickle.UnpicklingError with using remote MySQL Server

2019-10-02 Thread jack (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943343#comment-16943343 ] jack commented on AIRFLOW-3032: --- Is this still an issue? > _pickle.UnpicklingError with using remote

[GitHub] [airflow] mik-laj commented on issue #6235: [AIRFLOW-5583] Extend the "DAG Details" page to display the start_date / end_date

2019-10-02 Thread GitBox
mik-laj commented on issue #6235: [AIRFLOW-5583] Extend the "DAG Details" page to display the start_date / end_date URL: https://github.com/apache/airflow/pull/6235#issuecomment-537793697 @visciang This PR have a too much commits. Can you do a rebase?

[GitHub] [airflow] codecov-io commented on issue #6246: [AIRFLOW-5586] Improve CLI error messaging

2019-10-02 Thread GitBox
codecov-io commented on issue #6246: [AIRFLOW-5586] Improve CLI error messaging URL: https://github.com/apache/airflow/pull/6246#issuecomment-537793583 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6246?src=pr=h1) Report > Merging

[GitHub] [airflow] mik-laj commented on issue #6229: [AIRFLOW-5580] Add base class for system test

2019-10-02 Thread GitBox
mik-laj commented on issue #6229: [AIRFLOW-5580] Add base class for system test URL: https://github.com/apache/airflow/pull/6229#issuecomment-537793924 @nuclearpinguin This PR contains too much commits. Can you fix it? This

<    1   2