potiuk commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058628066
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
Taragolis commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058628201
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
potiuk commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058655785
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
potiuk commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058655785
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
blag commented on issue #28280:
URL: https://github.com/apache/airflow/issues/28280#issuecomment-1366839468
TIL. What an odd choice.
While there are many tools that will happily deal with all of the different
forms of newlines, sadly some tools that remain in popular usage still do
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058530854
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058530854
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058561504
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
Taragolis commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058557413
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
Taragolis commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058574945
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
Taragolis commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058578673
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
pgagnon commented on PR #28635:
URL: https://github.com/apache/airflow/pull/28635#issuecomment-1366926674
> I don't think this breaks any backcompat because for most providers this
is no change and, for snowflake , if you try to submit multistatement r.n. with
defaults it will just fail
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058623426
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058629909
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
jedcunningham opened a new pull request, #28632:
URL: https://github.com/apache/airflow/pull/28632
This solves a number of issues with our existing (new) audit logging on
things like variables and connections.
Still a WIP, need to verify and add tests for other ViewModels inheriting
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058531880
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058561504
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
dstandish commented on code in PR #28439:
URL: https://github.com/apache/airflow/pull/28439#discussion_r1058563809
##
airflow/utils/log/colored_log.py:
##
@@ -38,7 +40,7 @@
BOLD_OFF = esc("22")
-class CustomTTYColoredFormatter(TTYColoredFormatter):
+class
dstandish commented on code in PR #28439:
URL: https://github.com/apache/airflow/pull/28439#discussion_r1058564087
##
airflow/utils/log/colored_log.py:
##
@@ -38,7 +40,7 @@
BOLD_OFF = esc("22")
-class CustomTTYColoredFormatter(TTYColoredFormatter):
+class
Taragolis commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058568341
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058574076
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058575510
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058627698
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
dstandish commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058631912
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under
Taragolis commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r105866
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058633670
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
dstandish commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058642484
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under
dstandish commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058642484
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under
potiuk commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058648489
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
bharanidharan14 commented on code in PR #28262:
URL: https://github.com/apache/airflow/pull/28262#discussion_r1058690039
##
airflow/providers/microsoft/azure/hooks/adls_v2.py:
##
@@ -0,0 +1,307 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
bharanidharan14 commented on code in PR #28262:
URL: https://github.com/apache/airflow/pull/28262#discussion_r1058689964
##
tests/providers/microsoft/azure/hooks/test_adls_v2.py:
##
@@ -0,0 +1,108 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
uranusjr commented on PR #27710:
URL: https://github.com/apache/airflow/pull/27710#issuecomment-1367053758
Do we still need to keep the old argument for backward compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kaxil merged PR #28625:
URL: https://github.com/apache/airflow/pull/28625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 761aa59f92 Fix Incorrect Example (#28609)
add 8a23bf47a4 Add note for pymssql requirement (#28625)
No new
blag closed issue #28280: Inconsistent handling of newlines in tasks
URL: https://github.com/apache/airflow/issues/28280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058531880
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
Taragolis commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058554942
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058569528
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
Taragolis commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058572636
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
stamixthereal opened a new pull request, #28634:
URL: https://github.com/apache/airflow/pull/28634
Docstrings were added to email sending util, some type hints changes, and
implements regular expression intro `_get_email_list_from_str` function
--
This is an automated message from the
Taragolis commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058602023
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
Adityamalik123 opened a new pull request, #28636:
URL: https://github.com/apache/airflow/pull/28636
…dpoint
---
**^ Add meaningful description above**
Read the **[Pull Request
Taragolis commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058601195
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
dstandish commented on code in PR #28336:
URL: https://github.com/apache/airflow/pull/28336#discussion_r1058615241
##
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##
@@ -168,6 +168,7 @@ class KubernetesPodOperator(BaseOperator):
:param labels: labels to
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 69df1c5d9e Speed up provider validation pre-commit (#28541)
add e8657ce559 Improve "other" test category
Taragolis commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058626222
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
potiuk merged PR #28630:
URL: https://github.com/apache/airflow/pull/28630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eladkal commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058527580
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058533615
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058569528
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
dstandish opened a new pull request, #28635:
URL: https://github.com/apache/airflow/pull/28635
Some databases, such as snowflake, require you to split statements in order
to submit multi-statement sql. For such databases, splitting is the natural
default, and we should defer to the hook
dstandish commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058624408
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under
dstandish commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058640908
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under
avicol commented on PR #28353:
URL: https://github.com/apache/airflow/pull/28353#issuecomment-1367014562
> @avicol doc spellcheck
The doc error is from a file that I did not contributed to:
../../airflow/providers/cncf/kubernetes/CHANGELOG.rst:377: (didn) and you
didn’t use the
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058530302
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new 6d85c982c7 Updating
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058561504
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058561504
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058574439
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
Taragolis commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058574499
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
dstandish commented on PR #28635:
URL: https://github.com/apache/airflow/pull/28635#issuecomment-1366922185
I don't think this breaks any backcompat because for most providers this is
no change and, for snowflake , if you try to submit multistatement r.n. with
defaults it will just fail
dstandish commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058643196
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new 230be22d16 Updating
potiuk commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058655785
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
potiuk commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058656390
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
github-actions[bot] closed pull request #27481: Add "user_updated_state" column
in taskinstance
URL: https://github.com/apache/airflow/pull/27481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
potiuk commented on issue #28280:
URL: https://github.com/apache/airflow/issues/28280#issuecomment-1366846230
Yep. Let's keep it as the kind of issue that we can send anyone to if they
stumble upon similar case :).
We can even start counting.
Number of people experiencing the
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 8a23bf47a4 Add note for pymssql requirement (#28625)
add 69df1c5d9e Speed up provider validation pre-commit
potiuk merged PR #28541:
URL: https://github.com/apache/airflow/pull/28541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058531880
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058533615
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058531880
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
Taragolis commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058557413
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058571297
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058571297
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058576658
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
dstandish commented on code in PR #28635:
URL: https://github.com/apache/airflow/pull/28635#discussion_r1058602568
##
airflow/providers/common/sql/operators/sql.py:
##
@@ -26,6 +26,7 @@
from airflow.hooks.base import BaseHook
from airflow.models import BaseOperator, SkipMixin
magges commented on issue #23666:
URL: https://github.com/apache/airflow/issues/23666#issuecomment-1366930217
@thinhnd2104 are you working on this topic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
potiuk commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058622999
##
tests/providers/conftest.py:
##
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
potiuk commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058627308
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
potiuk merged PR #28633:
URL: https://github.com/apache/airflow/pull/28633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 94b3b897e2 Variables set in variables.env are
dstandish commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058643196
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under
potiuk commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058656390
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
hussein-awala commented on PR #27710:
URL: https://github.com/apache/airflow/pull/27710#issuecomment-1367003154
@potiuk it's ready, can you check it please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
bharanidharan14 commented on code in PR #28262:
URL: https://github.com/apache/airflow/pull/28262#discussion_r1058689769
##
airflow/providers/microsoft/azure/hooks/adls_v2.py:
##
@@ -0,0 +1,307 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
dstandish commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058722499
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under
stamixthereal commented on PR #28634:
URL: https://github.com/apache/airflow/pull/28634#issuecomment-1367133320
Thanks for your review, @uranusjr; I fixed it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
uranusjr commented on code in PR #28635:
URL: https://github.com/apache/airflow/pull/28635#discussion_r1058741250
##
airflow/providers/common/sql/operators/sql.py:
##
@@ -198,7 +198,7 @@ class SQLExecuteQueryOperator(BaseSQLOperator):
:param autocommit: (optional) if True,
dstandish commented on code in PR #28300:
URL: https://github.com/apache/airflow/pull/28300#discussion_r1058724161
##
docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst:
##
@@ -0,0 +1,87 @@
+ .. Licensed to the Apache Software Foundation (ASF) under
uranusjr commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058731243
##
tests/providers/conftest.py:
##
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
uranusjr commented on code in PR #28631:
URL: https://github.com/apache/airflow/pull/28631#discussion_r1058731243
##
tests/providers/conftest.py:
##
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
uranusjr commented on code in PR #28619:
URL: https://github.com/apache/airflow/pull/28619#discussion_r1058737216
##
airflow/api/client/json_client.py:
##
@@ -24,9 +24,24 @@
class Client(api_client.Client):
-"""Json API client implementation."""
+"""Json API client
uranusjr commented on code in PR #28634:
URL: https://github.com/apache/airflow/pull/28634#discussion_r1058743022
##
airflow/utils/email.py:
##
@@ -267,8 +306,13 @@ def _get_smtp_connection(host: str, port: int, timeout:
int, with_ssl: bool) ->
def
uranusjr commented on code in PR #28634:
URL: https://github.com/apache/airflow/pull/28634#discussion_r1058742159
##
airflow/utils/email.py:
##
@@ -47,8 +48,26 @@ def send_email(
conn_id: str | None = None,
custom_headers: dict[str, Any] | None = None,
**kwargs,
uranusjr commented on code in PR #28634:
URL: https://github.com/apache/airflow/pull/28634#discussion_r1058742360
##
airflow/utils/email.py:
##
@@ -47,8 +48,26 @@ def send_email(
conn_id: str | None = None,
custom_headers: dict[str, Any] | None = None,
**kwargs,
uranusjr commented on code in PR #28627:
URL: https://github.com/apache/airflow/pull/28627#discussion_r1058744792
##
airflow/cli/commands/info_command.py:
##
@@ -155,12 +156,16 @@ class Architecture:
ARM = "arm"
@staticmethod
-def get_current():
+def
stamixthereal commented on code in PR #28619:
URL: https://github.com/apache/airflow/pull/28619#discussion_r1058786146
##
airflow/api/client/json_client.py:
##
@@ -24,9 +24,25 @@
class Client(api_client.Client):
-"""Json API client implementation."""
+"""Json API
uranusjr commented on code in PR #28634:
URL: https://github.com/apache/airflow/pull/28634#discussion_r1058742434
##
airflow/utils/email.py:
##
@@ -47,8 +48,26 @@ def send_email(
conn_id: str | None = None,
custom_headers: dict[str, Any] | None = None,
**kwargs,
uranusjr commented on PR #28020:
URL: https://github.com/apache/airflow/pull/28020#issuecomment-1367091823
I don’t think we want to implement this. DAG arguments and default args are
different things and this introduces complexity that is unnecessary at best.
--
This is an automated
101 - 200 of 200 matches
Mail list logo