[GitHub] [airflow] potiuk commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
potiuk commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058628066 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058628201 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] potiuk commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
potiuk commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058655785 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] potiuk commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
potiuk commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058655785 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] blag commented on issue #28280: Inconsistent handling of newlines in tasks

2022-12-28 Thread GitBox
blag commented on issue #28280: URL: https://github.com/apache/airflow/issues/28280#issuecomment-1366839468 TIL. What an odd choice. While there are many tools that will happily deal with all of the different forms of newlines, sadly some tools that remain in popular usage still do

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058530854 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058530854 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058561504 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058557413 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058574945 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058578673 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] pgagnon commented on pull request #28635: Defer to hook setting for split_statements in SQLExecuteQueryOperator

2022-12-28 Thread GitBox
pgagnon commented on PR #28635: URL: https://github.com/apache/airflow/pull/28635#issuecomment-1366926674 > I don't think this breaks any backcompat because for most providers this is no change and, for snowflake , if you try to submit multistatement r.n. with defaults it will just fail

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058623426 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058629909 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] jedcunningham opened a new pull request, #28632: WIP: Improve audit logging for FAB-controlled models

2022-12-28 Thread GitBox
jedcunningham opened a new pull request, #28632: URL: https://github.com/apache/airflow/pull/28632 This solves a number of issues with our existing (new) audit logging on things like variables and connections. Still a WIP, need to verify and add tests for other ViewModels inheriting

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058531880 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058561504 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] dstandish commented on a diff in pull request #28439: CustomTTYColoredFormatter should inherit TimezoneAware formatter

2022-12-28 Thread GitBox
dstandish commented on code in PR #28439: URL: https://github.com/apache/airflow/pull/28439#discussion_r1058563809 ## airflow/utils/log/colored_log.py: ## @@ -38,7 +40,7 @@ BOLD_OFF = esc("22") -class CustomTTYColoredFormatter(TTYColoredFormatter): +class

[GitHub] [airflow] dstandish commented on a diff in pull request #28439: CustomTTYColoredFormatter should inherit TimezoneAware formatter

2022-12-28 Thread GitBox
dstandish commented on code in PR #28439: URL: https://github.com/apache/airflow/pull/28439#discussion_r1058564087 ## airflow/utils/log/colored_log.py: ## @@ -38,7 +40,7 @@ BOLD_OFF = esc("22") -class CustomTTYColoredFormatter(TTYColoredFormatter): +class

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058568341 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058574076 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058575510 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
potiuk commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058627698 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] dstandish commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
dstandish commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058631912 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r105866 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058633670 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] dstandish commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
dstandish commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058642484 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] dstandish commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
dstandish commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058642484 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] potiuk commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
potiuk commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058648489 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] bharanidharan14 commented on a diff in pull request #28262: Hook for managing directories and files in Azure Data Lake Storage Gen2

2022-12-28 Thread GitBox
bharanidharan14 commented on code in PR #28262: URL: https://github.com/apache/airflow/pull/28262#discussion_r1058690039 ## airflow/providers/microsoft/azure/hooks/adls_v2.py: ## @@ -0,0 +1,307 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] bharanidharan14 commented on a diff in pull request #28262: Hook for managing directories and files in Azure Data Lake Storage Gen2

2022-12-28 Thread GitBox
bharanidharan14 commented on code in PR #28262: URL: https://github.com/apache/airflow/pull/28262#discussion_r1058689964 ## tests/providers/microsoft/azure/hooks/test_adls_v2.py: ## @@ -0,0 +1,108 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment:

[GitHub] [airflow] uranusjr commented on pull request #27710: add a new conf to wait past_deps before skipping a task

2022-12-28 Thread GitBox
uranusjr commented on PR #27710: URL: https://github.com/apache/airflow/pull/27710#issuecomment-1367053758 Do we still need to keep the old argument for backward compatibility? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] kaxil merged pull request #28625: Add note for pymssql requirement

2022-12-28 Thread GitBox
kaxil merged PR #28625: URL: https://github.com/apache/airflow/pull/28625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (761aa59f92 -> 8a23bf47a4)

2022-12-28 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 761aa59f92 Fix Incorrect Example (#28609) add 8a23bf47a4 Add note for pymssql requirement (#28625) No new

[GitHub] [airflow] blag closed issue #28280: Inconsistent handling of newlines in tasks

2022-12-28 Thread GitBox
blag closed issue #28280: Inconsistent handling of newlines in tasks URL: https://github.com/apache/airflow/issues/28280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058531880 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058554942 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058569528 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058572636 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] stamixthereal opened a new pull request, #28634: Add doc-strings and small improvement to email util

2022-12-28 Thread GitBox
stamixthereal opened a new pull request, #28634: URL: https://github.com/apache/airflow/pull/28634 Docstrings were added to email sending util, some type hints changes, and implements regular expression intro `_get_email_list_from_str` function -- This is an automated message from the

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058602023 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] Adityamalik123 opened a new pull request, #28636: Adding base changes for adding updated_at filter for task_instance_en…

2022-12-28 Thread GitBox
Adityamalik123 opened a new pull request, #28636: URL: https://github.com/apache/airflow/pull/28636 …dpoint --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058601195 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] dstandish commented on a diff in pull request #28336: Fixed hanged KubernetesPodOperator

2022-12-28 Thread GitBox
dstandish commented on code in PR #28336: URL: https://github.com/apache/airflow/pull/28336#discussion_r1058615241 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -168,6 +168,7 @@ class KubernetesPodOperator(BaseOperator): :param labels: labels to

[airflow] branch main updated (69df1c5d9e -> e8657ce559)

2022-12-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 69df1c5d9e Speed up provider validation pre-commit (#28541) add e8657ce559 Improve "other" test category

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058626222 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] potiuk merged pull request #28630: Improve "other" test category selection

2022-12-28 Thread GitBox
potiuk merged PR #28630: URL: https://github.com/apache/airflow/pull/28630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] eladkal commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
eladkal commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058527580 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058533615 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058569528 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] dstandish opened a new pull request, #28635: Defer to hook setting for split_statements in SQLExecuteQueryOperator

2022-12-28 Thread GitBox
dstandish opened a new pull request, #28635: URL: https://github.com/apache/airflow/pull/28635 Some databases, such as snowflake, require you to split statements in order to submit multi-statement sql. For such databases, splitting is the natural default, and we should defer to the hook

[GitHub] [airflow] dstandish commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
dstandish commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058624408 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] dstandish commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
dstandish commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058640908 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] avicol commented on pull request #28353: Fix the sql syntax in merge_data

2022-12-28 Thread GitBox
avicol commented on PR #28353: URL: https://github.com/apache/airflow/pull/28353#issuecomment-1367014562 > @avicol doc spellcheck  The doc error is from a file that I did not contributed to: ../../airflow/providers/cncf/kubernetes/CHANGELOG.rst:377: (didn) and you didn’t use the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058530302 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[airflow] branch constraints-main updated: Updating constraints. Build id:

2022-12-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 6d85c982c7 Updating

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058561504 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058561504 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058574439 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058574499 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] dstandish commented on pull request #28635: Defer to hook setting for split_statements in SQLExecuteQueryOperator

2022-12-28 Thread GitBox
dstandish commented on PR #28635: URL: https://github.com/apache/airflow/pull/28635#issuecomment-1366922185 I don't think this breaks any backcompat because for most providers this is no change and, for snowflake , if you try to submit multistatement r.n. with defaults it will just fail

[GitHub] [airflow] dstandish commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
dstandish commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058643196 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under

[airflow] branch constraints-main updated: Updating constraints. Build id:

2022-12-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 230be22d16 Updating

[GitHub] [airflow] potiuk commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
potiuk commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058655785 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] potiuk commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
potiuk commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058656390 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] github-actions[bot] closed pull request #27481: Add "user_updated_state" column in taskinstance

2022-12-28 Thread GitBox
github-actions[bot] closed pull request #27481: Add "user_updated_state" column in taskinstance URL: https://github.com/apache/airflow/pull/27481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on issue #28280: Inconsistent handling of newlines in tasks

2022-12-28 Thread GitBox
potiuk commented on issue #28280: URL: https://github.com/apache/airflow/issues/28280#issuecomment-1366846230 Yep. Let's keep it as the kind of issue that we can send anyone to if they stumble upon similar case :). We can even start counting. Number of people experiencing the

[airflow] branch main updated (8a23bf47a4 -> 69df1c5d9e)

2022-12-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 8a23bf47a4 Add note for pymssql requirement (#28625) add 69df1c5d9e Speed up provider validation pre-commit

[GitHub] [airflow] potiuk merged pull request #28541: Speed up provider validation pre-commit

2022-12-28 Thread GitBox
potiuk merged PR #28541: URL: https://github.com/apache/airflow/pull/28541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058531880 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058533615 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058531880 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058557413 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058571297 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058571297 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058576658 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] dstandish commented on a diff in pull request #28635: Defer to hook setting for split_statements in SQLExecuteQueryOperator

2022-12-28 Thread GitBox
dstandish commented on code in PR #28635: URL: https://github.com/apache/airflow/pull/28635#discussion_r1058602568 ## airflow/providers/common/sql/operators/sql.py: ## @@ -26,6 +26,7 @@ from airflow.hooks.base import BaseHook from airflow.models import BaseOperator, SkipMixin

[GitHub] [airflow] maggesssss commented on issue #23666: Add transfers operator S3 to SQL / SQL to SQL

2022-12-28 Thread GitBox
magges commented on issue #23666: URL: https://github.com/apache/airflow/issues/23666#issuecomment-1366930217 @thinhnd2104 are you working on this topic? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058622999 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
potiuk commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058627308 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] potiuk merged pull request #28633: Variables set in variables.env are automatically exported

2022-12-28 Thread GitBox
potiuk merged PR #28633: URL: https://github.com/apache/airflow/pull/28633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Variables set in variables.env are automatically exported (#28633)

2022-12-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 94b3b897e2 Variables set in variables.env are

[GitHub] [airflow] dstandish commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
dstandish commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058643196 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] potiuk commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
potiuk commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058656390 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] hussein-awala commented on pull request #27710: add a new conf to wait past_deps before skipping a task

2022-12-28 Thread GitBox
hussein-awala commented on PR #27710: URL: https://github.com/apache/airflow/pull/27710#issuecomment-1367003154 @potiuk it's ready, can you check it please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] bharanidharan14 commented on a diff in pull request #28262: Hook for managing directories and files in Azure Data Lake Storage Gen2

2022-12-28 Thread GitBox
bharanidharan14 commented on code in PR #28262: URL: https://github.com/apache/airflow/pull/28262#discussion_r1058689769 ## airflow/providers/microsoft/azure/hooks/adls_v2.py: ## @@ -0,0 +1,307 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] dstandish commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
dstandish commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058722499 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] stamixthereal commented on pull request #28634: Add doc-strings and small improvement to email util

2022-12-28 Thread GitBox
stamixthereal commented on PR #28634: URL: https://github.com/apache/airflow/pull/28634#issuecomment-1367133320 Thanks for your review, @uranusjr; I fixed it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] uranusjr commented on a diff in pull request #28635: Defer to hook setting for split_statements in SQLExecuteQueryOperator

2022-12-28 Thread GitBox
uranusjr commented on code in PR #28635: URL: https://github.com/apache/airflow/pull/28635#discussion_r1058741250 ## airflow/providers/common/sql/operators/sql.py: ## @@ -198,7 +198,7 @@ class SQLExecuteQueryOperator(BaseSQLOperator): :param autocommit: (optional) if True,

[GitHub] [airflow] dstandish commented on a diff in pull request #28300: Add Public Interface description to Airflow documentation

2022-12-28 Thread GitBox
dstandish commented on code in PR #28300: URL: https://github.com/apache/airflow/pull/28300#discussion_r1058724161 ## docs/apache-airflow/administration-and-deployment/public-airflow-interface.rst: ## @@ -0,0 +1,87 @@ + .. Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] uranusjr commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
uranusjr commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058731243 ## tests/providers/conftest.py: ## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] uranusjr commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
uranusjr commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058731243 ## tests/providers/conftest.py: ## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] uranusjr commented on a diff in pull request #28619: Fix code readability, add docstrings to json_client

2022-12-28 Thread GitBox
uranusjr commented on code in PR #28619: URL: https://github.com/apache/airflow/pull/28619#discussion_r1058737216 ## airflow/api/client/json_client.py: ## @@ -24,9 +24,24 @@ class Client(api_client.Client): -"""Json API client implementation.""" +"""Json API client

[GitHub] [airflow] uranusjr commented on a diff in pull request #28634: Add doc-strings and small improvement to email util

2022-12-28 Thread GitBox
uranusjr commented on code in PR #28634: URL: https://github.com/apache/airflow/pull/28634#discussion_r1058743022 ## airflow/utils/email.py: ## @@ -267,8 +306,13 @@ def _get_smtp_connection(host: str, port: int, timeout: int, with_ssl: bool) -> def

[GitHub] [airflow] uranusjr commented on a diff in pull request #28634: Add doc-strings and small improvement to email util

2022-12-28 Thread GitBox
uranusjr commented on code in PR #28634: URL: https://github.com/apache/airflow/pull/28634#discussion_r1058742159 ## airflow/utils/email.py: ## @@ -47,8 +48,26 @@ def send_email( conn_id: str | None = None, custom_headers: dict[str, Any] | None = None, **kwargs,

[GitHub] [airflow] uranusjr commented on a diff in pull request #28634: Add doc-strings and small improvement to email util

2022-12-28 Thread GitBox
uranusjr commented on code in PR #28634: URL: https://github.com/apache/airflow/pull/28634#discussion_r1058742360 ## airflow/utils/email.py: ## @@ -47,8 +48,26 @@ def send_email( conn_id: str | None = None, custom_headers: dict[str, Any] | None = None, **kwargs,

[GitHub] [airflow] uranusjr commented on a diff in pull request #28627: Change Architecture class into Enum

2022-12-28 Thread GitBox
uranusjr commented on code in PR #28627: URL: https://github.com/apache/airflow/pull/28627#discussion_r1058744792 ## airflow/cli/commands/info_command.py: ## @@ -155,12 +156,16 @@ class Architecture: ARM = "arm" @staticmethod -def get_current(): +def

[GitHub] [airflow] stamixthereal commented on a diff in pull request #28619: Fix code readability, add docstrings to json_client

2022-12-28 Thread GitBox
stamixthereal commented on code in PR #28619: URL: https://github.com/apache/airflow/pull/28619#discussion_r1058786146 ## airflow/api/client/json_client.py: ## @@ -24,9 +24,25 @@ class Client(api_client.Client): -"""Json API client implementation.""" +"""Json API

[GitHub] [airflow] uranusjr commented on a diff in pull request #28634: Add doc-strings and small improvement to email util

2022-12-28 Thread GitBox
uranusjr commented on code in PR #28634: URL: https://github.com/apache/airflow/pull/28634#discussion_r1058742434 ## airflow/utils/email.py: ## @@ -47,8 +48,26 @@ def send_email( conn_id: str | None = None, custom_headers: dict[str, Any] | None = None, **kwargs,

[GitHub] [airflow] uranusjr commented on pull request #28020: Feature/#28015 default args

2022-12-28 Thread GitBox
uranusjr commented on PR #28020: URL: https://github.com/apache/airflow/pull/28020#issuecomment-1367091823 I don’t think we want to implement this. DAG arguments and default args are different things and this introduces complexity that is unnecessary at best. -- This is an automated

<    1   2   3   >