[GitHub] [airflow] potiuk merged pull request #29086: Remove upper bound limitation for `pytest`

2023-01-23 Thread via GitHub
potiuk merged PR #29086: URL: https://github.com/apache/airflow/pull/29086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] alicj commented on a diff in pull request #21877: AIP-45 Remove dag parsing in airflow run local

2023-01-23 Thread via GitHub
alicj commented on code in PR #21877: URL: https://github.com/apache/airflow/pull/21877#discussion_r1084263956 ## airflow/task/task_runner/base_task_runner.py: ## @@ -95,24 +89,16 @@ def __init__(self, local_task_job): cfg_path = tmp_configuration_copy(chmod=0o600,

[GitHub] [airflow] potiuk commented on pull request #29087: Unquarantine receive SIGTERM on Task Runner test (second attempt)

2023-01-23 Thread via GitHub
potiuk commented on PR #29087: URL: https://github.com/apache/airflow/pull/29087#issuecomment-1400623052 All was good. Rebased again with "use public runners". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk commented on pull request #27829: Improving the release process

2023-01-23 Thread via GitHub
potiuk commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1400705889 > > Feel free to merge if you think it's GOOD and useful :). > > Been thinking about the useful side of it :) let @jedcunningham decide Comment here - for @jedcunningham as

[GitHub] [airflow] josh-fell commented on issue #29102: Airflow UI not showing mapped tasks

2023-01-23 Thread via GitHub
josh-fell commented on issue #29102: URL: https://github.com/apache/airflow/issues/29102#issuecomment-1400706033 FWIW I cannot reproduce this with Breeze `breeze start-airflow --use-airflow-version 2.5.1 --python 3.8`. A little bit of a toy example since we don't know what's going on

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #29098: Explicit a few steps in the release process

2023-01-23 Thread via GitHub
pierrejeambrun commented on code in PR #29098: URL: https://github.com/apache/airflow/pull/29098#discussion_r1084331524 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -477,8 +496,12 @@ To do this we need to twine upload -r pypitest dist/* ``` -- Verify that the test

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #29098: Explicit a few steps in the release process

2023-01-23 Thread via GitHub
pierrejeambrun commented on code in PR #29098: URL: https://github.com/apache/airflow/pull/29098#discussion_r1084331524 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -477,8 +496,12 @@ To do this we need to twine upload -r pypitest dist/* ``` -- Verify that the test

[GitHub] [airflow] bbovenzi commented on a diff in pull request #27063: AIP-50 Trigger UI based on FAB

2023-01-23 Thread via GitHub
bbovenzi commented on code in PR #27063: URL: https://github.com/apache/airflow/pull/27063#discussion_r1084252178 ## airflow/www/static/js/trigger.js: ## @@ -19,33 +19,190 @@ /* global document, CodeMirror, window */ -const textArea = document.getElementById('json'); +let

[GitHub] [airflow] potiuk commented on pull request #27829: Improving the release process

2023-01-23 Thread via GitHub
potiuk commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1400624961 Nice! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on pull request #27829: Improving the release process

2023-01-23 Thread via GitHub
potiuk commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1400625486 Feel free to merge if you think it's GOOD and useful :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #29098: Explicit a few steps in the release process

2023-01-23 Thread via GitHub
pierrejeambrun commented on code in PR #29098: URL: https://github.com/apache/airflow/pull/29098#discussion_r1084331524 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -477,8 +496,12 @@ To do this we need to twine upload -r pypitest dist/* ``` -- Verify that the test

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #29098: Explicit a few steps in the release process

2023-01-23 Thread via GitHub
pierrejeambrun commented on code in PR #29098: URL: https://github.com/apache/airflow/pull/29098#discussion_r1084331524 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -477,8 +496,12 @@ To do this we need to twine upload -r pypitest dist/* ``` -- Verify that the test

[GitHub] [airflow] bbovenzi commented on issue #29102: Airflow UI not showing mapped tasks

2023-01-23 Thread via GitHub
bbovenzi commented on issue #29102: URL: https://github.com/apache/airflow/issues/29102#issuecomment-1400713276 @anneadb Are there any console or network errors if you open up inspect element? We have a separate API request to populate the mapped instances list. Depending on

[GitHub] [airflow] pierrejeambrun commented on issue #29102: Airflow UI not showing mapped tasks

2023-01-23 Thread via GitHub
pierrejeambrun commented on issue #29102: URL: https://github.com/apache/airflow/issues/29102#issuecomment-1400713568 Same here on my end, couldn't reproduce. I filled functions in a similar way as @josh-fell. Using standalone airflow with ` 2.5.1` package. -- This is an automated

[GitHub] [airflow] Taragolis commented on pull request #29035: Renaming nose compatible methods in flavour of regular pytest naming

2023-01-23 Thread via GitHub
Taragolis commented on PR #29035: URL: https://github.com/apache/airflow/pull/29035#issuecomment-1400499360 > Ah - isn't that the "airflow.jobs.backfill_job.BackfillJob" generated log ? Yeah, it is `distributed.client:client.py` logger create this message ```console ERROR

[GitHub] [airflow] Taragolis commented on issue #29103: Status of testing Providers that were prepared on January 23, 2023

2023-01-23 Thread via GitHub
Taragolis commented on issue #29103: URL: https://github.com/apache/airflow/issues/29103#issuecomment-1400502773 @TPapajCin @marvinfretly @nicnguyen3103 could you also have a look PapermillOperator? ```pip install apache-airflow-providers-papermill==3.1.1rc1``` -- This is an

[GitHub] [airflow] raphaelauv opened a new pull request, #29106: [FIX] README K8S support 2.5.1

2023-01-23 Thread via GitHub
raphaelauv opened a new pull request, #29106: URL: https://github.com/apache/airflow/pull/29106 https://github.com/apache/airflow/pull/29074 did not updated the K8S support in the README -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] potiuk commented on a diff in pull request #29098: Explicit a few steps in the release process

2023-01-23 Thread via GitHub
potiuk commented on code in PR #29098: URL: https://github.com/apache/airflow/pull/29098#discussion_r1084184091 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -477,8 +496,12 @@ To do this we need to twine upload -r pypitest dist/* ``` -- Verify that the test package looks

[GitHub] [airflow] sudohainguyen commented on issue #28399: Dataproc Generator should allow creating spot instances

2023-01-23 Thread via GitHub
sudohainguyen commented on issue #28399: URL: https://github.com/apache/airflow/issues/28399#issuecomment-1400553157 due to the latest change from google (https://github.com/googleapis/python-dataproc/pull/512) I'm resuming the work from now on -- This is an automated message from the

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29109: [Google Cloud] DataprocCreateBatchOperator returns incorrect results and does not reattach

2023-01-23 Thread boring-cyborg
boring-cyborg[bot] commented on issue #29109: URL: https://github.com/apache/airflow/issues/29109#issuecomment-1400596078 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] bbovenzi commented on a diff in pull request #27063: AIP-50 Trigger UI based on FAB

2023-01-23 Thread via GitHub
bbovenzi commented on code in PR #27063: URL: https://github.com/apache/airflow/pull/27063#discussion_r1084258122 ## airflow/www/static/js/trigger.js: ## @@ -19,33 +19,190 @@ /* global document, CodeMirror, window */ -const textArea = document.getElementById('json'); +let

[airflow] branch main updated (90e6277da6 -> c0f6bfa35b)

2023-01-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 90e6277da6 Auto ML assets (#25466) add c0f6bfa35b Remove upper bound limitation for `pytest` (#29086) No new

[GitHub] [airflow] sudohainguyen commented on issue #28399: Dataproc Generator should allow creating spot instances

2023-01-23 Thread via GitHub
sudohainguyen commented on issue #28399: URL: https://github.com/apache/airflow/issues/28399#issuecomment-1400637319 to fulfill the need to create secondary workers as SPOT type, `google-cloud-dataproc` version must be `5.3.0` -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] josh-fell commented on pull request #29048: Allow downloading of dbt Cloud artifacts to non-existent paths

2023-01-23 Thread via GitHub
josh-fell commented on PR #29048: URL: https://github.com/apache/airflow/pull/29048#issuecomment-1400637565 Rebased and resolved conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] jedcunningham commented on a diff in pull request #28808: Allow setting the name for the base container within K8s Pod Operator

2023-01-23 Thread via GitHub
jedcunningham commented on code in PR #28808: URL: https://github.com/apache/airflow/pull/28808#discussion_r1084275635 ## kubernetes_tests/test_kubernetes_pod_operator.py: ## @@ -1153,3 +1153,134 @@ def test_using_resources(self): do_xcom_push=False,

[GitHub] [airflow] ephraimbuddy commented on pull request #27829: Improving the release process

2023-01-23 Thread via GitHub
ephraimbuddy commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1400675244 > Feel free to merge if you think it's GOOD and useful :). Been thinking about the useful side of it :) let @jedcunningham decide -- This is an automated message from the

[GitHub] [airflow] potiuk merged pull request #29077: add retries to stop_pipeline on conflict

2023-01-23 Thread via GitHub
potiuk merged PR #29077: URL: https://github.com/apache/airflow/pull/29077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #29098: Explicit a few steps in the release process

2023-01-23 Thread via GitHub
pierrejeambrun commented on code in PR #29098: URL: https://github.com/apache/airflow/pull/29098#discussion_r1084331524 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -477,8 +496,12 @@ To do this we need to twine upload -r pypitest dist/* ``` -- Verify that the test

[GitHub] [airflow] potiuk commented on pull request #29104: Update set-up-database.rst

2023-01-23 Thread via GitHub
potiuk commented on PR #29104: URL: https://github.com/apache/airflow/pull/29104#issuecomment-1400708221 Thanks! Important one indeed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29078: enhance production guide with a few Argo specific guidelines [#20999][#28637]

2023-01-23 Thread via GitHub
jedcunningham commented on code in PR #29078: URL: https://github.com/apache/airflow/pull/29078#discussion_r1084232512 ## docs/helm-chart/index.rst: ## @@ -140,3 +140,18 @@ will not start as the migrations will not be run: This is so these CI/CD services can perform updates

[GitHub] [airflow] saulbein commented on issue #27657: Zombie tasks detected after service restart sometimes do not retry

2023-01-23 Thread via GitHub
saulbein commented on issue #27657: URL: https://github.com/apache/airflow/issues/27657#issuecomment-1400584723 Updated to 2.5.0 (unfortunately right before 2.5.1). updated the issue description with the current providers that we use and the log itself. Now we don't really get tasks

[GitHub] [airflow] bbovenzi commented on a diff in pull request #27063: AIP-50 Trigger UI based on FAB

2023-01-23 Thread via GitHub
bbovenzi commented on code in PR #27063: URL: https://github.com/apache/airflow/pull/27063#discussion_r1084245521 ## airflow/www/templates/airflow/trigger.html: ## @@ -27,11 +27,93 @@ {% endblock %} +{% macro form_element(form_key, form_details) %} + + + + {%-

[GitHub] [airflow] auvipy commented on pull request #29086: Remove upper bound limitation for `pytest`

2023-01-23 Thread via GitHub
auvipy commented on PR #29086: URL: https://github.com/apache/airflow/pull/29086#issuecomment-1400626127 thank you both -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] kristopherkane opened a new pull request, #29111: Dataproc batches

2023-01-23 Thread via GitHub
kristopherkane opened a new pull request, #29111: URL: https://github.com/apache/airflow/pull/29111 #28399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29111: Dataproc batches

2023-01-23 Thread boring-cyborg
boring-cyborg[bot] commented on PR #29111: URL: https://github.com/apache/airflow/pull/29111#issuecomment-1400644355 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] kristopherkane commented on issue #29109: [Google Cloud] DataprocCreateBatchOperator returns incorrect results and does not reattach

2023-01-23 Thread via GitHub
kristopherkane commented on issue #29109: URL: https://github.com/apache/airflow/issues/29109#issuecomment-1400653822 How I tested this with the Breeze environment and a real GCP project: - Batches DAG run from start to finish successfully - Batches DAG run that is cancelled after

[airflow] branch main updated (c0f6bfa35b -> 6190e34388)

2023-01-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from c0f6bfa35b Remove upper bound limitation for `pytest` (#29086) add 6190e34388 add retries to stop_pipeline on

[GitHub] [airflow] potiuk merged pull request #29104: Update set-up-database.rst

2023-01-23 Thread via GitHub
potiuk merged PR #29104: URL: https://github.com/apache/airflow/pull/29104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29104: Update set-up-database.rst

2023-01-23 Thread boring-cyborg
boring-cyborg[bot] commented on PR #29104: URL: https://github.com/apache/airflow/pull/29104#issuecomment-1400708042 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[airflow] branch main updated (f805b4154a -> c01f9f8c92)

2023-01-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from f805b4154a Allow downloading of dbt Cloud artifacts to non-existent paths (#29048) add c01f9f8c92 Update

[GitHub] [airflow] hussein-awala commented on issue #29103: Status of testing Providers that were prepared on January 23, 2023

2023-01-23 Thread via GitHub
hussein-awala commented on issue #29103: URL: https://github.com/apache/airflow/issues/29103#issuecomment-1400897972 #28996 tested and working as expected ```python import pendulum from airflow.providers.docker.operators.docker import DockerOperator from airflow.models import

[GitHub] [airflow] maggesssss commented on pull request #29085: Add transfer operator S3 to (generic) SQL

2023-01-23 Thread via GitHub
magges commented on PR #29085: URL: https://github.com/apache/airflow/pull/29085#issuecomment-1400933299 > static checks are failing - I recommnd installing pre-commit. Fixed now -- This is an automated message from the Apache Git Service. To respond to the message, please log

[airflow] branch main updated: fix Google provider CHANGELOG.rst (#29114)

2023-01-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7e2493e3c8 fix Google provider CHANGELOG.rst

[GitHub] [airflow] potiuk merged pull request #29114: fix Google provider CHANGELOG.rst

2023-01-23 Thread via GitHub
potiuk merged PR #29114: URL: https://github.com/apache/airflow/pull/29114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] agreenburg commented on issue #16286: SFTPHook cannot download large files

2023-01-23 Thread via GitHub
agreenburg commented on issue #16286: URL: https://github.com/apache/airflow/issues/16286#issuecomment-1400971349 I'm still encountering this issue with the new provider (which uses paramiko). I see some workarounds in this thread but the issue is still open:

[GitHub] [airflow] o-nikolas merged pull request #28934: Remove hard-coded executor-database coupling

2023-01-23 Thread via GitHub
o-nikolas merged PR #28934: URL: https://github.com/apache/airflow/pull/28934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] o-nikolas closed issue #27929: AIP-51 - Single Threaded Executors

2023-01-23 Thread via GitHub
o-nikolas closed issue #27929: AIP-51 - Single Threaded Executors URL: https://github.com/apache/airflow/issues/27929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] utkarsharma2 commented on pull request #28934: Remove hard-coded executor-database coupling

2023-01-23 Thread via GitHub
utkarsharma2 commented on PR #28934: URL: https://github.com/apache/airflow/pull/28934#issuecomment-1400938664 Hey @o-nikolas, can you PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on issue #28789: Add colors in help outputs of Airfow CLI commands

2023-01-23 Thread via GitHub
potiuk commented on issue #28789: URL: https://github.com/apache/airflow/issues/28789#issuecomment-1400963065 Just here and see if you can apply it to all argparse https://github.com/hamdanal/rich-argparse -- This is an automated message from the Apache Git Service. To respond to the

[airflow] branch main updated: Migrate DagFileProcessor.manage_slas to Internal API (#28502)

2023-01-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 0359a42a39 Migrate DagFileProcessor.manage_slas to

[GitHub] [airflow] potiuk merged pull request #28502: Migrate DagFileProcessor.manage_slas to Internal API

2023-01-23 Thread via GitHub
potiuk merged PR #28502: URL: https://github.com/apache/airflow/pull/28502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed issue #28268: AIP-44 Migrate DagFileProcessor.manage_slas to Internal API

2023-01-23 Thread via GitHub
potiuk closed issue #28268: AIP-44 Migrate DagFileProcessor.manage_slas to Internal API URL: https://github.com/apache/airflow/issues/28268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] branch main updated (0359a42a39 -> e5730364b4)

2023-01-23 Thread onikolas
This is an automated email from the ASF dual-hosted git repository. onikolas pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 0359a42a39 Migrate DagFileProcessor.manage_slas to Internal API (#28502) add e5730364b4 Remove hard-coded

[GitHub] [airflow] o-nikolas commented on a diff in pull request #28528: Fixes to how DebugExecutor handles sensors

2023-01-23 Thread via GitHub
o-nikolas commented on code in PR #28528: URL: https://github.com/apache/airflow/pull/28528#discussion_r1084581785 ## airflow/ti_deps/deps/ready_to_reschedule.py: ## @@ -44,7 +45,8 @@ def _get_dep_statuses(self, ti, session, dep_context): from

[GitHub] [airflow] pierrejeambrun commented on pull request #29106: [FIX] README K8S support 2.5.1

2023-01-23 Thread via GitHub
pierrejeambrun commented on PR #29106: URL: https://github.com/apache/airflow/pull/29106#issuecomment-1400735349 Hello @raphaelauv, Thanks for the PR, I am not familiar with our K8S code. https://github.com/apache/airflow/pull/28320 was not part of `2.5.1`, it is marked should make

[GitHub] [airflow] potiuk commented on issue #29103: Status of testing Providers that were prepared on January 23, 2023

2023-01-23 Thread via GitHub
potiuk commented on issue #29103: URL: https://github.com/apache/airflow/issues/29103#issuecomment-1400749422 @eladkal I noticed unsual thing - that we do not have have the "sdist" in PyPI - only .whl ones. I think they are generated (they are present in SVN for verification) but not in

[GitHub] [airflow] josh-fell commented on issue #29105: graph disappears during run time when using branch_task and a dynamic classic operator

2023-01-23 Thread via GitHub
josh-fell commented on issue #29105: URL: https://github.com/apache/airflow/issues/29105#issuecomment-1400749974 Can reproduce with Breeze `breeze start-airflow --use-airflow-version 2.5.1`:

[GitHub] [airflow] NilsJPWerner commented on issue #28931: Hide/Show log timestamp and file source

2023-01-23 Thread via GitHub
NilsJPWerner commented on issue #28931: URL: https://github.com/apache/airflow/issues/28931#issuecomment-1400761972 That's what I thought since you can filter by source. Those are both great ideas! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] vincbeck commented on pull request #28636: Expose updated_at filter for dag run and task instance endpoints

2023-01-23 Thread via GitHub
vincbeck commented on PR #28636: URL: https://github.com/apache/airflow/pull/28636#issuecomment-1400791935 Hey @Adityamalik123. Just following up on this one, any news? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[airflow] branch constraints-main updated: Updating constraints. Build id:

2023-01-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new aca6db7c1f Updating

[GitHub] [airflow] jedcunningham commented on pull request #27829: Improving the release process

2023-01-23 Thread via GitHub
jedcunningham commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1400801480 I'm not too concerned with it being "magic", I think we all can debug and carry on manually if things go sideways. Hopefully it doesn't, but historically we have

[GitHub] [airflow] potiuk commented on a diff in pull request #29098: Explicit a few steps in the release process

2023-01-23 Thread via GitHub
potiuk commented on code in PR #29098: URL: https://github.com/apache/airflow/pull/29098#discussion_r1084421411 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -477,8 +496,12 @@ To do this we need to twine upload -r pypitest dist/* ``` -- Verify that the test package looks

[GitHub] [airflow] potiuk commented on pull request #28406: Add defer mode to GKECreateClusterOperator and GKEDeleteClusterOperator

2023-01-23 Thread via GitHub
potiuk commented on PR #28406: URL: https://github.com/apache/airflow/pull/28406#issuecomment-1400853873 Just checking with @kaxil and @bhirsz - weren't you working on this already in Astronomer/Google ? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] loulsb commented on issue #28789: Add colors in help outputs of Airfow CLI commands

2023-01-23 Thread via GitHub
loulsb commented on issue #28789: URL: https://github.com/apache/airflow/issues/28789#issuecomment-1400882791 @potiuk I would like to work on this. Any advice on where to start? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[airflow] branch main updated: Allow setting the name for the base container within K8s Pod Operator (#28808)

2023-01-23 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 70b84b51a5 Allow setting the name for the

[GitHub] [airflow] jedcunningham merged pull request #28808: Allow setting the name for the base container within K8s Pod Operator

2023-01-23 Thread via GitHub
jedcunningham merged PR #28808: URL: https://github.com/apache/airflow/pull/28808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] aamster opened a new issue, #29113: sqlite conn id unclear

2023-01-23 Thread via GitHub
aamster opened a new issue, #29113: URL: https://github.com/apache/airflow/issues/29113 ### What do you see as an issue? The sqlite conn doc here https://airflow.apache.org/docs/apache-airflow-providers-sqlite/stable/operators.html is unclear. Sqlite does not use username,

[GitHub] [airflow] potiuk commented on issue #29105: graph disappears during run time when using branch_task and a dynamic classic operator

2023-01-23 Thread via GitHub
potiuk commented on issue #29105: URL: https://github.com/apache/airflow/issues/29105#issuecomment-1400743077 I can assign you @talnagar if you would like to take a stab on it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] josh-fell commented on issue #29113: sqlite conn id unclear

2023-01-23 Thread via GitHub
josh-fell commented on issue #29113: URL: https://github.com/apache/airflow/issues/29113#issuecomment-1400751712 @aamster Would you like to update the docs? Seems like you have a solid handle on what needs to be updated. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] Taragolis commented on issue #29112: "Operation not permitted" error when chmod on log folder

2023-01-23 Thread via GitHub
Taragolis commented on issue #29112: URL: https://github.com/apache/airflow/issues/29112#issuecomment-1400768048 I guess it is regression of https://github.com/apache/airflow/pull/28477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29058: Optionally export `airflow db clean` data to CSV files

2023-01-23 Thread via GitHub
jedcunningham commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1084418134 ## airflow/utils/db_cleanup.py: ## @@ -159,6 +170,14 @@ def _do_delete(*, query, orm_model, skip_archive, session): logger.debug("delete statement:\n%s",

[GitHub] [airflow] bbovenzi commented on issue #29105: graph disappears during run time when using branch_task and a dynamic classic operator

2023-01-23 Thread via GitHub
bbovenzi commented on issue #29105: URL: https://github.com/apache/airflow/issues/29105#issuecomment-1400824339 PR to fix is already open. https://github.com/apache/airflow/pull/29042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk closed pull request #29106: [FIX] README K8S support 2.5.1

2023-01-23 Thread via GitHub
potiuk closed pull request #29106: [FIX] README K8S support 2.5.1 URL: https://github.com/apache/airflow/pull/29106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on pull request #29106: [FIX] README K8S support 2.5.1

2023-01-23 Thread via GitHub
potiuk commented on PR #29106: URL: https://github.com/apache/airflow/pull/29106#issuecomment-1400839091 @pierrejeambrun - @raphaelauv - yes, what we have now is correct approach - we do not change the supported versions of Python and Kubernetes versions in the Patchlevel releases (so once

[GitHub] [airflow] potiuk commented on pull request #29107: PR: Introduced fix to run tasks on Windows systems

2023-01-23 Thread via GitHub
potiuk commented on PR #29107: URL: https://github.com/apache/airflow/pull/29107#issuecomment-1400857304 Agree - not a problem to have it in. Marked it as "2.5.2" so when we release it, you won't have to patch it. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] potiuk commented on issue #29112: "Operation not permitted" error when chmod on log folder

2023-01-23 Thread via GitHub
potiuk commented on issue #29112: URL: https://github.com/apache/airflow/issues/29112#issuecomment-1400861929 Should be easy fix but it is likely another candidate to speed up 2.5.2 cc: @pierrejeambrun @ephraimbuddy -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] eladkal opened a new pull request, #29114: fix Google provider CHANGELOG.rst

2023-01-23 Thread via GitHub
eladkal opened a new pull request, #29114: URL: https://github.com/apache/airflow/pull/29114 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29112: "Operation not permitted" error when chmod on log folder

2023-01-23 Thread boring-cyborg
boring-cyborg[bot] commented on issue #29112: URL: https://github.com/apache/airflow/issues/29112#issuecomment-1400736195 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] denskh opened a new issue, #29112: "Operation not permitted" error when chmod on log folder

2023-01-23 Thread via GitHub
denskh opened a new issue, #29112: URL: https://github.com/apache/airflow/issues/29112 ### Official Helm Chart version 1.7.0 (latest released) ### Apache Airflow version 2.5.1 ### Kubernetes Version 1.24.6 ### Helm Chart configuration

[GitHub] [airflow] bbovenzi commented on issue #28931: Hide/Show log timestamp and file source

2023-01-23 Thread via GitHub
bbovenzi commented on issue #28931: URL: https://github.com/apache/airflow/issues/28931#issuecomment-1400760229 We already parse the log text in the UI in order to keep the timestamps with the right timezone or filter logs by file source. Another idea I just had: swap the timestamp

[GitHub] [airflow] potiuk commented on issue #29103: Status of testing Providers that were prepared on January 23, 2023

2023-01-23 Thread via GitHub
potiuk commented on issue #29103: URL: https://github.com/apache/airflow/issues/29103#issuecomment-1400772021 * I just realised that technically speaking cassandra 3.1.1 is the same as 3.1.0 - not sure if we need to remove it. First we added limits to install requires and then we removed

[GitHub] [airflow] potiuk commented on a diff in pull request #29098: Explicit a few steps in the release process

2023-01-23 Thread via GitHub
potiuk commented on code in PR #29098: URL: https://github.com/apache/airflow/pull/29098#discussion_r1084421411 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -477,8 +496,12 @@ To do this we need to twine upload -r pypitest dist/* ``` -- Verify that the test package looks

[GitHub] [airflow] potiuk merged pull request #29107: PR: Introduced fix to run tasks on Windows systems

2023-01-23 Thread via GitHub
potiuk merged PR #29107: URL: https://github.com/apache/airflow/pull/29107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (c01f9f8c92 -> f8e8fc02fe)

2023-01-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from c01f9f8c92 Update set-up-database.rst (#29104) add f8e8fc02fe PR: Introduced fix to run tasks on Windows systems

[GitHub] [airflow] bugraoz93 commented on pull request #29099: Trigger Class migration to internal API

2023-01-23 Thread via GitHub
bugraoz93 commented on PR #29099: URL: https://github.com/apache/airflow/pull/29099#issuecomment-1400856010 Conflict is resolved. It is a good idea. You are right, I am thinking the same as you. This will be painful only for a short term until the migration will be stable and will be

[GitHub] [airflow] mattppal commented on pull request #28592: Guard not-yet-expanded ti in trigger rule dep

2023-01-23 Thread via GitHub
mattppal commented on PR #28592: URL: https://github.com/apache/airflow/pull/28592#issuecomment-1400883922 @Taragolis I think adding a test case like: ``` @task def t(x): return {'x':x} @task_group def tg(a):

[GitHub] [airflow] zachliu commented on pull request #28386: Maintain manual scroll position in task logs

2023-01-23 Thread via GitHub
zachliu commented on PR #28386: URL: https://github.com/apache/airflow/pull/28386#issuecomment-1401021706 is it fixed or am i looking at another (but very similar problem)? https://user-images.githubusercontent.com/14293802/214154892-43154669-2020-4bab-a901-67fb704e2b87.mp4

[GitHub] [airflow] zachliu commented on issue #28143: Logs tab is automatically scrolling to the bottom while user is reading logs

2023-01-23 Thread via GitHub
zachliu commented on issue #28143: URL: https://github.com/apache/airflow/issues/28143#issuecomment-1401023836 is it fixed or am i looking at another (but very similar) problem? https://user-images.githubusercontent.com/14293802/214154892-43154669-2020-4bab-a901-67fb704e2b87.mp4

[GitHub] [airflow] yukijam opened a new issue, #29115: GCSToGCSOperator delimiter bug

2023-01-23 Thread via GitHub
yukijam opened a new issue, #29115: URL: https://github.com/apache/airflow/issues/29115 ### Apache Airflow version 2.5.1 ### What happened Using GCSToGCSOperator with delimiter = '.json' would also consider the incorrect files for example: I got a file named

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29115: GCSToGCSOperator delimiter bug

2023-01-23 Thread boring-cyborg
boring-cyborg[bot] commented on issue #29115: URL: https://github.com/apache/airflow/issues/29115#issuecomment-1401026203 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29058: Optionally export `airflow db clean` data to CSV files

2023-01-23 Thread via GitHub
ephraimbuddy commented on code in PR #29058: URL: https://github.com/apache/airflow/pull/29058#discussion_r1084591088 ## airflow/utils/db_cleanup.py: ## @@ -123,7 +126,15 @@ def _check_for_rows(*, query: Query, print_rows=False): return num_entities -def _do_delete(*,

[GitHub] [airflow] bbovenzi commented on issue #28143: Logs tab is automatically scrolling to the bottom while user is reading logs

2023-01-23 Thread via GitHub
bbovenzi commented on issue #28143: URL: https://github.com/apache/airflow/issues/28143#issuecomment-1401033586 @zachliu What about if you view the logs from the grid view? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] zachliu commented on issue #28143: Logs tab is automatically scrolling to the bottom while user is reading logs

2023-01-23 Thread via GitHub
zachliu commented on issue #28143: URL: https://github.com/apache/airflow/issues/28143#issuecomment-1401042154 grid view logs seems to be fine. this only occurs if i click "See More". after i click "See More" there are actually 2 scenarios: 1. if i scroll down to the bottom i'll start

[GitHub] [airflow] o-nikolas merged pull request #29085: Add transfer operator S3 to (generic) SQL

2023-01-23 Thread via GitHub
o-nikolas merged PR #29085: URL: https://github.com/apache/airflow/pull/29085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] o-nikolas closed issue #23666: Add transfers operator S3 to SQL / SQL to SQL

2023-01-23 Thread via GitHub
o-nikolas closed issue #23666: Add transfers operator S3 to SQL / SQL to SQL URL: https://github.com/apache/airflow/issues/23666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[airflow] branch main updated (e5730364b4 -> efaed34213)

2023-01-23 Thread onikolas
This is an automated email from the ASF dual-hosted git repository. onikolas pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from e5730364b4 Remove hard-coded executor reschedule mode coupling (#28934) add efaed34213 Add transfer operator

[GitHub] [airflow] loulsb opened a new pull request, #29116: Add colors in help outputs of Airfow CLI commands #28789

2023-01-23 Thread via GitHub
loulsb opened a new pull request, #29116: URL: https://github.com/apache/airflow/pull/29116 closes: #28789 @potiuk I started with changing formatter_class as described here https://github.com/hamdanal/rich-argparse#usage. I get the following output: airflow --help

[GitHub] [airflow] potiuk commented on issue #29115: GCSToGCSOperator delimiter bug

2023-01-23 Thread via GitHub
potiuk commented on issue #29115: URL: https://github.com/apache/airflow/issues/29115#issuecomment-1401071704 assigned you @yukijam if you want to fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] potiuk merged pull request #29088: Deprecate `delegate_to` param in GCP operators and update docs

2023-01-23 Thread via GitHub
potiuk merged PR #29088: URL: https://github.com/apache/airflow/pull/29088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed issue #9461: Unclear documentation for the delegate_to parameter

2023-01-23 Thread via GitHub
potiuk closed issue #9461: Unclear documentation for the delegate_to parameter URL: https://github.com/apache/airflow/issues/9461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

<    1   2   3   >