[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28256: Include full path to Python files under zip path while clearing import errors.

2023-02-20 Thread via GitHub
ephraimbuddy commented on code in PR #28256: URL: https://github.com/apache/airflow/pull/28256#discussion_r619848 ## airflow/dag_processing/manager.py: ## @@ -782,7 +782,11 @@ def clear_nonexistent_import_errors(file_paths: list[str] | None, session=NEW_SE """

[GitHub] [airflow] potiuk closed issue #29626: Using ProcessPoolExecutor in my task get an Exception: A process in the process pool was terminated abruptly while the future was running or pending.

2023-02-20 Thread via GitHub
potiuk closed issue #29626: Using ProcessPoolExecutor in my task get an Exception: A process in the process pool was terminated abruptly while the future was running or pending. URL: https://github.com/apache/airflow/issues/29626 -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] V0lantis opened a new issue, #29632: Postgres secret Bug when upgrading helm chart version (1.7.0 -> 1.8.0)

2023-02-20 Thread via GitHub
V0lantis opened a new issue, #29632: URL: https://github.com/apache/airflow/issues/29632 ### Official Helm Chart version 1.8.0 (latest released) ### Apache Airflow version 2.4.3 ### Kubernetes Version v1.21.14-eks ### Helm Chart configuration

[GitHub] [airflow] harishkrao commented on a diff in pull request #28950: Sensor for Databricks partition and table changes

2023-02-20 Thread via GitHub
harishkrao commented on code in PR #28950: URL: https://github.com/apache/airflow/pull/28950#discussion_r603884 ## airflow/providers/databricks/sensors/databricks_sql.py: ## @@ -0,0 +1,136 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] yjijn opened a new issue, #29626: Using ProcessPoolExecutor in my task get an Exception: A process in the process pool was terminated abruptly while the future was running or pendin

2023-02-20 Thread via GitHub
yjijn opened a new issue, #29626: URL: https://github.com/apache/airflow/issues/29626 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened airflow version:2.1.3 python version:3.8.0 I use this function in my task and get

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29626: Using ProcessPoolExecutor in my task get an Exception: A process in the process pool was terminated abruptly while the future was runni

2023-02-20 Thread via GitHub
boring-cyborg[bot] commented on issue #29626: URL: https://github.com/apache/airflow/issues/29626#issuecomment-1436542943 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[airflow] branch main updated: Update issue triage policy (#29554)

2023-02-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new dae7bf0800 Update issue triage policy (#29554)

[GitHub] [airflow] potiuk merged pull request #29554: Update issue triage policy

2023-02-20 Thread via GitHub
potiuk merged PR #29554: URL: https://github.com/apache/airflow/pull/29554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jose-lpa commented on issue #29432: Jinja templating doesn't work with container_resources when using dymanic task mapping with Kubernetes Pod Operator

2023-02-20 Thread via GitHub
jose-lpa commented on issue #29432: URL: https://github.com/apache/airflow/issues/29432#issuecomment-1436658884 @hussein-awala Can I ask what Airflow version is going to include this fix? I'm in the same situation as @vasu2809: using Cloud Composer and not able to just upgrade to the

[GitHub] [airflow] hussein-awala commented on pull request #29498: add missing read for K8S config file from conn in deferred `KubernetesPodOperator`

2023-02-20 Thread via GitHub
hussein-awala commented on PR #29498: URL: https://github.com/apache/airflow/pull/29498#issuecomment-1436659985 > I guess you will be still changing the config access pattern on that one ? Do I understand correctly? Yes, I'm testing loading the config file in the triggerer instead of

[GitHub] [airflow] vilozio commented on issue #26773: Tasks stuck in queued state forever after upgrade from 2.2.0 to 2.3.4

2023-02-20 Thread via GitHub
vilozio commented on issue #26773: URL: https://github.com/apache/airflow/issues/26773#issuecomment-1436722361 Sorry for a late reply. This issue was resolved for me after migrating to 2.4.1. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] harishkrao commented on a diff in pull request #28950: Sensor for Databricks partition and table changes

2023-02-20 Thread via GitHub
harishkrao commented on code in PR #28950: URL: https://github.com/apache/airflow/pull/28950#discussion_r605205 ## airflow/providers/databricks/sensors/databricks_sql.py: ## @@ -0,0 +1,136 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[airflow] branch main updated: Fix Rest API update user output (#29409)

2023-02-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 20206e9a93 Fix Rest API update user output

[GitHub] [airflow] potiuk merged pull request #29409: Fix Rest API update user output

2023-02-20 Thread via GitHub
potiuk merged PR #29409: URL: https://github.com/apache/airflow/pull/29409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk merged pull request #29441: datasets, next_run_datasets, remove unnecessary timestamp filter

2023-02-20 Thread via GitHub
potiuk merged PR #29441: URL: https://github.com/apache/airflow/pull/29441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed issue #26892: Dataset Next Trigger Modal Not Populating Latest Update

2023-02-20 Thread via GitHub
potiuk closed issue #26892: Dataset Next Trigger Modal Not Populating Latest Update URL: https://github.com/apache/airflow/issues/26892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[airflow] branch main updated: datasets, next_run_datasets, remove unnecessary timestamp filter (#29441)

2023-02-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6f9efbd053 datasets, next_run_datasets, remove

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28256: Include full path to Python files under zip path while clearing import errors.

2023-02-20 Thread via GitHub
ephraimbuddy commented on code in PR #28256: URL: https://github.com/apache/airflow/pull/28256#discussion_r674660 ## airflow/dag_processing/manager.py: ## @@ -782,7 +782,11 @@ def clear_nonexistent_import_errors(file_paths: list[str] | None, session=NEW_SE """

[GitHub] [airflow] bolkedebruin commented on a diff in pull request #29433: Add dataset update endpoint

2023-02-20 Thread via GitHub
bolkedebruin commented on code in PR #29433: URL: https://github.com/apache/airflow/pull/29433#discussion_r675033 ## airflow/datasets/manager.py: ## @@ -55,23 +61,33 @@ def register_dataset_change( dataset_model = session.query(DatasetModel).filter(DatasetModel.uri

[GitHub] [airflow] Taragolis commented on pull request #29616: Refactor docker-compose quick start test

2023-02-20 Thread via GitHub
Taragolis commented on PR #29616: URL: https://github.com/apache/airflow/pull/29616#issuecomment-1436664937 The more you look on error the less chance that this error will reproduce  藍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] Sangameshmsopen commented on issue #25060: Airflow scheduler crashes due to 'duplicate key value violates unique constraint "task_instance_pkey"'

2023-02-20 Thread via GitHub
Sangameshmsopen commented on issue #25060: URL: https://github.com/apache/airflow/issues/25060#issuecomment-1436735346 @potiuk Sure i'm providing the details. Same issue has occurred even in one of our testing environment. **Apache airflow version:** 2.4.3 **Deployed in

[GitHub] [airflow] etgcrog commented on issue #14365: docker-compose up airflow-init produces airflow command error

2023-02-20 Thread via GitHub
etgcrog commented on issue #14365: URL: https://github.com/apache/airflow/issues/14365#issuecomment-1436782316 I belive that you run the command : docker compose up airflow-init but, left the follow command: docker compose up if don't work yet, try: ``` echo -e

[GitHub] [airflow] maxnathaniel commented on pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

2023-02-20 Thread via GitHub
maxnathaniel commented on PR #28953: URL: https://github.com/apache/airflow/pull/28953#issuecomment-1436858511 > @maxnathaniel are you OK with this? Sorry for my late reply. Yes, I will update the README and do a final check of the code. -- This is an automated message from the

[GitHub] [airflow] Taragolis opened a new pull request, #29627: Clarify `service_config` in AWS Connection

2023-02-20 Thread via GitHub
Taragolis opened a new pull request, #29627: URL: https://github.com/apache/airflow/pull/29627 We add information about potential future implementation in `service_config` Extra AWS Connection config. The sample include information about S3, STS and EMR however we only implement

[GitHub] [airflow] potiuk closed issue #29561: CeleryKubernetesExecutor @task(queue="kubernetes")  not work

2023-02-20 Thread via GitHub
potiuk closed issue #29561: CeleryKubernetesExecutor @task(queue="kubernetes")  not work URL: https://github.com/apache/airflow/issues/29561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] harishkrao commented on a diff in pull request #28950: Sensor for Databricks partition and table changes

2023-02-20 Thread via GitHub
harishkrao commented on code in PR #28950: URL: https://github.com/apache/airflow/pull/28950#discussion_r636261 ## airflow/providers/databricks/sensors/databricks_sql.py: ## @@ -0,0 +1,136 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29446: Scheduler, make stale DAG deactivation threshold configurable instead of using dag processing timeout

2023-02-20 Thread via GitHub
ephraimbuddy commented on code in PR #29446: URL: https://github.com/apache/airflow/pull/29446#discussion_r634767 ## airflow/dag_processing/manager.py: ## @@ -523,13 +525,17 @@ def deactivate_stale_dags( query = query.filter(DagModel.processor_subdir ==

[GitHub] [airflow] harishkrao commented on pull request #28950: Sensor for Databricks partition and table changes

2023-02-20 Thread via GitHub
harishkrao commented on PR #28950: URL: https://github.com/apache/airflow/pull/28950#issuecomment-1436560053 > See my comment about returning false vs. throwing an exception when there is no results. > > But primary request for changes is for adding missing pieces: > > *

[GitHub] [airflow] tirkarthi commented on a diff in pull request #28256: Include full path to Python files under zip path while clearing import errors.

2023-02-20 Thread via GitHub
tirkarthi commented on code in PR #28256: URL: https://github.com/apache/airflow/pull/28256#discussion_r644805 ## airflow/dag_processing/manager.py: ## @@ -782,7 +782,11 @@ def clear_nonexistent_import_errors(file_paths: list[str] | None, session=NEW_SE """

[GitHub] [airflow] s0neq opened a new pull request, #29635: support setting endpoint in yandex airflow provider

2023-02-20 Thread via GitHub
s0neq opened a new pull request, #29635: URL: https://github.com/apache/airflow/pull/29635 Sometimes people use API endpoints different from "api.cloud.yandex.net". Yandex.Cloud Python SDK already supports setting custom API endpoint, this PR makes it possible to set endpoint in Yandex

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29635: support setting endpoint in yandex airflow provider

2023-02-20 Thread via GitHub
boring-cyborg[bot] commented on PR #29635: URL: https://github.com/apache/airflow/pull/29635#issuecomment-1436775002 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #29409: Fix Rest API update user output

2023-02-20 Thread via GitHub
ephraimbuddy commented on code in PR #29409: URL: https://github.com/apache/airflow/pull/29409#discussion_r622051 ## airflow/api_connexion/openapi/v1.yaml: ## @@ -2288,7 +2288,7 @@ paths: content: application/json: schema: -

[GitHub] [airflow] tirkarthi commented on issue #29561: CeleryKubernetesExecutor @task(queue="kubernetes")  not work

2023-02-20 Thread via GitHub
tirkarthi commented on issue #29561: URL: https://github.com/apache/airflow/issues/29561#issuecomment-1436569555 You're welcome @takersk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on issue #29524: Possible deadlock when max_active_runs maxed + depends_on_past = True

2023-02-20 Thread via GitHub
potiuk commented on issue #29524: URL: https://github.com/apache/airflow/issues/29524#issuecomment-1436621796 Turning that into discussion then./ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk closed issue #29524: Possible deadlock when max_active_runs maxed + depends_on_past = True

2023-02-20 Thread via GitHub
potiuk closed issue #29524: Possible deadlock when max_active_runs maxed + depends_on_past = True URL: https://github.com/apache/airflow/issues/29524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on pull request #26639: Multi-threads support for processing diff queues in Kubernetes Executor

2023-02-20 Thread via GitHub
potiuk commented on PR #26639: URL: https://github.com/apache/airflow/pull/26639#issuecomment-1436643390 @Dinghang :) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] uranusjr opened a new pull request, #29631: Avoid unneeded Connexion constructs

2023-02-20 Thread via GitHub
uranusjr opened a new pull request, #29631: URL: https://github.com/apache/airflow/pull/29631 We only use Connexion's App class to create a Flask Blueprint, so really we can go one level lower and use the FlaskApi interface directly instead. Connexion's spec-loading also supports

[GitHub] [airflow] ashb commented on a diff in pull request #29625: Aggressively cache entry points in process

2023-02-20 Thread via GitHub
ashb commented on code in PR #29625: URL: https://github.com/apache/airflow/pull/29625#discussion_r824731 ## airflow/utils/entry_points.py: ## @@ -28,26 +30,33 @@ log = logging.getLogger(__name__) +EPnD = Tuple[metadata.EntryPoint, metadata.Distribution] -def

[GitHub] [airflow] potiuk commented on issue #29632: Postgres secret Bug when upgrading helm chart version (1.7.0 -> 1.8.0)

2023-02-20 Thread via GitHub
potiuk commented on issue #29632: URL: https://github.com/apache/airflow/issues/29632#issuecomment-1436805177 Yeah. This is expected - see Release Notes: https://airflow.apache.org/docs/helm-chart/stable/release_notes.html#airflow-helm-chart-1-8-0-2023-02-06 where we explain the migration

[GitHub] [airflow] potiuk closed issue #29632: Postgres secret Bug when upgrading helm chart version (1.7.0 -> 1.8.0)

2023-02-20 Thread via GitHub
potiuk closed issue #29632: Postgres secret Bug when upgrading helm chart version (1.7.0 -> 1.8.0) URL: https://github.com/apache/airflow/issues/29632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #29498: add missing read for K8S config file from conn in deferred `KubernetesPodOperator`

2023-02-20 Thread via GitHub
potiuk commented on PR #29498: URL: https://github.com/apache/airflow/pull/29498#issuecomment-1436627597 @hussein-awala I guess you will be still changing the config access pattern on that one ? Do I understand correctly? -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] eladkal opened a new pull request, #29633: `RedshiftDataOperator` replace `await_result` with `wait_for_completion`

2023-02-20 Thread via GitHub
eladkal opened a new pull request, #29633: URL: https://github.com/apache/airflow/pull/29633 Followup of https://github.com/apache/airflow/pull/27947#discussion_r1096353052 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] Taragolis commented on a diff in pull request #29633: `RedshiftDataOperator` replace `await_result` with `wait_for_completion`

2023-02-20 Thread via GitHub
Taragolis commented on code in PR #29633: URL: https://github.com/apache/airflow/pull/29633#discussion_r744729 ## airflow/providers/amazon/aws/operators/redshift_data.py: ## @@ -73,10 +73,11 @@ def __init__( secret_arn: str | None = None, statement_name:

[GitHub] [airflow] VladaZakharova commented on pull request #29498: add missing read for K8S config file from conn in deferred `KubernetesPodOperator`

2023-02-20 Thread via GitHub
VladaZakharova commented on PR #29498: URL: https://github.com/apache/airflow/pull/29498#issuecomment-1436702119 Hi! May i ask in which format you will pass the config file to trigger? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] V0lantis commented on issue #29632: Postgres secret Bug when upgrading helm chart version (1.7.0 -> 1.8.0)

2023-02-20 Thread via GitHub
V0lantis commented on issue #29632: URL: https://github.com/apache/airflow/issues/29632#issuecomment-1436712605 Find the previous version I probably used for my deployment

[GitHub] [airflow] maxnathaniel commented on pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

2023-02-20 Thread via GitHub
maxnathaniel commented on PR #28953: URL: https://github.com/apache/airflow/pull/28953#issuecomment-1436957932 @eladkal I have updated the CHANGELOG. Hope it makes sense and provides enough information about the changes -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] eladkal merged pull request #29633: `RedshiftDataOperator` replace `await_result` with `wait_for_completion`

2023-02-20 Thread via GitHub
eladkal merged PR #29633: URL: https://github.com/apache/airflow/pull/29633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (dae7bf0800 -> 45419e23a9)

2023-02-20 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from dae7bf0800 Update issue triage policy (#29554) add 45419e23a9 `RedshiftDataOperator` replace `await_result` with

[GitHub] [airflow] amoghrajesh commented on pull request #29624: Can't configure Kubernetes and Celery workers in Helm Chart

2023-02-20 Thread via GitHub
amoghrajesh commented on PR #29624: URL: https://github.com/apache/airflow/pull/29624#issuecomment-1437079339 Thanks for explaining that @hussein-awala Made the changes in sync with what was asked in the issue description: #28880. Maybe I understood the issue wrong. Could you go through

[GitHub] [airflow] pgagnon commented on a diff in pull request #29623: Implement file credentials provider for AWS hook AssumeRoleWithWebIdentity

2023-02-20 Thread via GitHub
pgagnon commented on code in PR #29623: URL: https://github.com/apache/airflow/pull/29623#discussion_r1112002541 ## airflow/providers/amazon/aws/hooks/base_aws.py: ## @@ -312,19 +312,35 @@ def _get_web_identity_credential_fetcher( base_session =

[GitHub] [airflow] Taragolis closed issue #29637: EcsRegisterTaskDefinitionOperator params are incorrectly invalidated

2023-02-20 Thread via GitHub
Taragolis closed issue #29637: EcsRegisterTaskDefinitionOperator params are incorrectly invalidated URL: https://github.com/apache/airflow/issues/29637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] Taragolis commented on issue #29637: EcsRegisterTaskDefinitionOperator params are incorrectly invalidated

2023-02-20 Thread via GitHub
Taragolis commented on issue #29637: URL: https://github.com/apache/airflow/issues/29637#issuecomment-1437078616 Not a bug Airflow provider, the validation happen inside [`botocore`](https://github.com/boto/botocore) / [`boto3`](https://github.com/boto/boto3), see available options and

[GitHub] [airflow] potiuk commented on pull request #29639: Migrate breeze unit tests to pytest.

2023-02-20 Thread via GitHub
potiuk commented on PR #29639: URL: https://github.com/apache/airflow/pull/29639#issuecomment-1437295426 Reopened :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28256: Include full path to Python files under zip path while clearing import errors.

2023-02-20 Thread via GitHub
ephraimbuddy commented on code in PR #28256: URL: https://github.com/apache/airflow/pull/28256#discussion_r1112172817 ## airflow/dag_processing/manager.py: ## @@ -782,7 +782,11 @@ def clear_nonexistent_import_errors(file_paths: list[str] | None, session=NEW_SE """

[GitHub] [airflow] janrito opened a new issue, #29637: EcsRegisterTaskDefinitionOperator params are incorrectly invalidated

2023-02-20 Thread via GitHub
janrito opened a new issue, #29637: URL: https://github.com/apache/airflow/issues/29637 ### Apache Airflow Provider(s) amazon ### Versions of Apache Airflow Providers https://raw.githubusercontent.com/apache/airflow/constraints-2.4.3/constraints-3.10.txt ###

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29637: EcsRegisterTaskDefinitionOperator params are incorrectly invalidated

2023-02-20 Thread via GitHub
boring-cyborg[bot] commented on issue #29637: URL: https://github.com/apache/airflow/issues/29637#issuecomment-1436994044 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] antonio-antuan opened a new issue, #29640: NoBoundaryInMultipartDefect raised using S3Hook

2023-02-20 Thread via GitHub
antonio-antuan opened a new issue, #29640: URL: https://github.com/apache/airflow/issues/29640 ### Apache Airflow Provider(s) amazon ### Versions of Apache Airflow Providers apache-airflow-providers-amazon==7.2.0 ### Apache Airflow version 2.4.3 ###

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29640: NoBoundaryInMultipartDefect raised using S3Hook

2023-02-20 Thread via GitHub
boring-cyborg[bot] commented on issue #29640: URL: https://github.com/apache/airflow/issues/29640#issuecomment-1437187553 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk commented on pull request #29624: Can't configure Kubernetes and Celery workers in Helm Chart

2023-02-20 Thread via GitHub
potiuk commented on PR #29624: URL: https://github.com/apache/airflow/pull/29624#issuecomment-1437263567 I think the idea in the #28800 was to be able to specify some parameters in the Helm Chart Values in a similar way for K8S as it si for celery. What it would likely mean - is merging

[GitHub] [airflow] pgagnon commented on a diff in pull request #29623: Implement file credentials provider for AWS hook AssumeRoleWithWebIdentity

2023-02-20 Thread via GitHub
pgagnon commented on code in PR #29623: URL: https://github.com/apache/airflow/pull/29623#discussion_r1112140747 ## airflow/providers/amazon/aws/hooks/base_aws.py: ## @@ -311,20 +311,32 @@ def _get_web_identity_credential_fetcher( ) ->

[GitHub] [airflow] ryw commented on pull request #29638: Add OSSRank badge

2023-02-20 Thread via GitHub
ryw commented on PR #29638: URL: https://github.com/apache/airflow/pull/29638#issuecomment-1437303211 Thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] eladkal commented on a diff in pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

2023-02-20 Thread via GitHub
eladkal commented on code in PR #28953: URL: https://github.com/apache/airflow/pull/28953#discussion_r964786 ## airflow/providers/telegram/CHANGELOG.rst: ## @@ -24,6 +24,23 @@ Changelog - +3.2.0 +. Review Comment: ```suggestion 4.0.0 .

[GitHub] [airflow] amoghrajesh commented on a diff in pull request #29622: Fix adding annotations for dag persistence PVC

2023-02-20 Thread via GitHub
amoghrajesh commented on code in PR #29622: URL: https://github.com/apache/airflow/pull/29622#discussion_r1112000255 ## chart/templates/dags-persistent-volume-claim.yaml: ## @@ -29,10 +29,10 @@ metadata: {{- with .Values.labels }} {{- toYaml . | nindent 4 }} {{-

[GitHub] [airflow] Taragolis commented on issue #29637: EcsRegisterTaskDefinitionOperator params are incorrectly invalidated

2023-02-20 Thread via GitHub
Taragolis commented on issue #29637: URL: https://github.com/apache/airflow/issues/29637#issuecomment-1437093004 Nevermind, I have a look on wrong parameters initially. Did you use specific values such as `render_template_as_native_obj=True` in DAG? -- This is an automated message

[GitHub] [airflow] Taragolis commented on a diff in pull request #29635: YandexCloud provider: support Yandex SDK feature "endpoint"

2023-02-20 Thread via GitHub
Taragolis commented on code in PR #29635: URL: https://github.com/apache/airflow/pull/29635#discussion_r1112016187 ## airflow/providers/yandex/hooks/yandex.py: ## @@ -122,7 +127,8 @@ def __init__( self.connection = self.get_connection(self.connection_id)

[GitHub] [airflow] francescomucio commented on pull request #29171: Added Snowflake provider to the Docker image

2023-02-20 Thread via GitHub
francescomucio commented on PR #29171: URL: https://github.com/apache/airflow/pull/29171#issuecomment-1437125244 Yes, I will try to do it today or tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] tirkarthi commented on a diff in pull request #28256: Include full path to Python files under zip path while clearing import errors.

2023-02-20 Thread via GitHub
tirkarthi commented on code in PR #28256: URL: https://github.com/apache/airflow/pull/28256#discussion_r1112035762 ## airflow/dag_processing/manager.py: ## @@ -782,7 +782,11 @@ def clear_nonexistent_import_errors(file_paths: list[str] | None, session=NEW_SE """

[GitHub] [airflow] potiuk commented on pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

2023-02-20 Thread via GitHub
potiuk commented on PR #28953: URL: https://github.com/apache/airflow/pull/28953#issuecomment-1437252268 Static checks/docs need fixing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk merged pull request #29639: Migrate breeze unit tests to pytest.

2023-02-20 Thread via GitHub
potiuk merged PR #29639: URL: https://github.com/apache/airflow/pull/29639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (497f6feb06 -> d721701e14)

2023-02-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 497f6feb06 Add OSSRank badge (#29638) add d721701e14 Migrate breeze unit tests to pytest. (#29639) No new

[GitHub] [airflow] potiuk closed issue #29305: Migrate remaining tests to `pytest`

2023-02-20 Thread via GitHub
potiuk closed issue #29305: Migrate remaining tests to `pytest` URL: https://github.com/apache/airflow/issues/29305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on pull request #29639: Migrate breeze unit tests to pytest.

2023-02-20 Thread via GitHub
potiuk commented on PR #29639: URL: https://github.com/apache/airflow/pull/29639#issuecomment-1437270397 That's it? Are we done :)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk commented on pull request #29616: Refactor docker-compose quick start test

2023-02-20 Thread via GitHub
potiuk commented on PR #29616: URL: https://github.com/apache/airflow/pull/29616#issuecomment-1437294393 BTW. This one failed. And the problem is that `wait_for_terminal_state" simply exits after 80 tries when the task is "queued" . But why ? Hard to say. I have a feeling we have a race

[GitHub] [airflow] hussein-awala commented on pull request #29624: Can't configure Kubernetes and Celery workers in Helm Chart

2023-02-20 Thread via GitHub
hussein-awala commented on PR #29624: URL: https://github.com/apache/airflow/pull/29624#issuecomment-1437300580 @amoghrajesh or @potiuk can you please update the description and link the PR to the issue? I think we can add a new value `k8s_pod_template` and use it when the executor

[GitHub] [airflow] hussein-awala commented on pull request #29624: Can't configure Kubernetes and Celery workers in Helm Chart

2023-02-20 Thread via GitHub
hussein-awala commented on PR #29624: URL: https://github.com/apache/airflow/pull/29624#issuecomment-1436973598 I think this is not necessary, because the Kubernetes workers are not created by the helm chart, it just creates and configures the celery workers. For the K8S workers,

[GitHub] [airflow] pgagnon commented on a diff in pull request #29623: Implement file credentials provider for AWS hook AssumeRoleWithWebIdentity

2023-02-20 Thread via GitHub
pgagnon commented on code in PR #29623: URL: https://github.com/apache/airflow/pull/29623#discussion_r979656 ## airflow/providers/amazon/aws/hooks/base_aws.py: ## @@ -312,19 +312,35 @@ def _get_web_identity_credential_fetcher( base_session =

[GitHub] [airflow] ryw opened a new pull request, #29638: Add OSSRank badge

2023-02-20 Thread via GitHub
ryw opened a new pull request, #29638: URL: https://github.com/apache/airflow/pull/29638 Airflow is a top 2% project on OSSRank, and this badge shows Airflow's current rank in the world of open source. I hope you accept the PR :) --- **^ Add meaningful description above**

[GitHub] [airflow] janrito commented on issue #29637: EcsRegisterTaskDefinitionOperator params are incorrectly invalidated

2023-02-20 Thread via GitHub
janrito commented on issue #29637: URL: https://github.com/apache/airflow/issues/29637#issuecomment-1437152518 Ah! yes. I did. Why is that clashing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] s0neq commented on a diff in pull request #29635: YandexCloud provider: support Yandex SDK feature "endpoint"

2023-02-20 Thread via GitHub
s0neq commented on code in PR #29635: URL: https://github.com/apache/airflow/pull/29635#discussion_r1112105457 ## airflow/providers/yandex/hooks/yandex.py: ## @@ -122,7 +127,8 @@ def __init__( self.connection = self.get_connection(self.connection_id)

[GitHub] [airflow] ashb commented on a diff in pull request #29623: Implement file credentials provider for AWS hook AssumeRoleWithWebIdentity

2023-02-20 Thread via GitHub
ashb commented on code in PR #29623: URL: https://github.com/apache/airflow/pull/29623#discussion_r1112132611 ## airflow/providers/amazon/aws/hooks/base_aws.py: ## @@ -311,20 +311,32 @@ def _get_web_identity_credential_fetcher( ) ->

[GitHub] [airflow] Taragolis commented on a diff in pull request #29635: YandexCloud provider: support Yandex SDK feature "endpoint"

2023-02-20 Thread via GitHub
Taragolis commented on code in PR #29635: URL: https://github.com/apache/airflow/pull/29635#discussion_r1112150631 ## airflow/providers/yandex/hooks/yandex.py: ## @@ -122,7 +127,8 @@ def __init__( self.connection = self.get_connection(self.connection_id)

[GitHub] [airflow] vedantlodha commented on pull request #29639: Migrate breeze unit tests to pytest.

2023-02-20 Thread via GitHub
vedantlodha commented on PR #29639: URL: https://github.com/apache/airflow/pull/29639#issuecomment-1437272462 @potiuk Sorry! I see the issue was closed, but there are some tests in google providers that still use unittest. Working on a pr for them. -- This is an automated message from

[GitHub] [airflow] uranusjr commented on pull request #29608: Enable passing --xcom-args to tasks test CLI command

2023-02-20 Thread via GitHub
uranusjr commented on PR #29608: URL: https://github.com/apache/airflow/pull/29608#issuecomment-1437292418 Using JSON for this feels cumbersome to me. I don’t have a much better idea though. Also we need to find a way to support custom backends that may not store values as JSON. -- This

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28256: Include full path to Python files under zip path while clearing import errors.

2023-02-20 Thread via GitHub
ephraimbuddy commented on code in PR #28256: URL: https://github.com/apache/airflow/pull/28256#discussion_r1112176062 ## airflow/dag_processing/manager.py: ## @@ -782,7 +782,11 @@ def clear_nonexistent_import_errors(file_paths: list[str] | None, session=NEW_SE """

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29622: Fix adding annotations for dag persistence PVC

2023-02-20 Thread via GitHub
hussein-awala commented on code in PR #29622: URL: https://github.com/apache/airflow/pull/29622#discussion_r892276 ## chart/templates/dags-persistent-volume-claim.yaml: ## @@ -29,10 +29,10 @@ metadata: {{- with .Values.labels }} {{- toYaml . | nindent 4 }}

[GitHub] [airflow] amoghrajesh commented on a diff in pull request #29270: Adding possibility for annotations in logs pvc

2023-02-20 Thread via GitHub
amoghrajesh commented on code in PR #29270: URL: https://github.com/apache/airflow/pull/29270#discussion_r998546 ## chart/templates/logs-persistent-volume-claim.yaml: ## @@ -29,6 +29,10 @@ metadata: {{- with .Values.labels }} {{- toYaml . | nindent 4 }} {{-

[GitHub] [airflow] vedantlodha commented on pull request #29639: Migrate breeze unit tests to pytest.

2023-02-20 Thread via GitHub
vedantlodha commented on PR #29639: URL: https://github.com/apache/airflow/pull/29639#issuecomment-1437157482 @Taragolis Since youre the author of the issue, can you take a look into the pr (which is barey 2 lines of change :)) whenever you have some time? Thanks -- This is an automated

[GitHub] [airflow] jose-lpa commented on issue #29432: Jinja templating doesn't work with container_resources when using dymanic task mapping with Kubernetes Pod Operator

2023-02-20 Thread via GitHub
jose-lpa commented on issue #29432: URL: https://github.com/apache/airflow/issues/29432#issuecomment-1437182956 I actually fixed my situation by simply using the [`Variable` model](https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/variables.html) instead of trying to go

[GitHub] [airflow] eladkal closed issue #29557: Execution Timeout is not working properly on airflow 2.5.0

2023-02-20 Thread via GitHub
eladkal closed issue #29557: Execution Timeout is not working properly on airflow 2.5.0 URL: https://github.com/apache/airflow/issues/29557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] ashb commented on a diff in pull request #29623: Implement file credentials provider for AWS hook AssumeRoleWithWebIdentity

2023-02-20 Thread via GitHub
ashb commented on code in PR #29623: URL: https://github.com/apache/airflow/pull/29623#discussion_r1112131738 ## airflow/providers/amazon/aws/hooks/base_aws.py: ## @@ -312,19 +312,35 @@ def _get_web_identity_credential_fetcher( base_session =

[GitHub] [airflow] Taragolis commented on a diff in pull request #29635: YandexCloud provider: support Yandex SDK feature "endpoint"

2023-02-20 Thread via GitHub
Taragolis commented on code in PR #29635: URL: https://github.com/apache/airflow/pull/29635#discussion_r1112151762 ## airflow/providers/yandex/hooks/yandex.py: ## @@ -122,7 +127,8 @@ def __init__( self.connection = self.get_connection(self.connection_id)

[GitHub] [airflow] vedantlodha opened a new pull request, #29639: Migrate breeze unit tests to pytest.

2023-02-20 Thread via GitHub
vedantlodha opened a new pull request, #29639: URL: https://github.com/apache/airflow/pull/29639 As a part of #29305, this PR removes a unittest.TestCase dependency from breeze package. The only remaining unittest dependency of this unittest.mock which is anyways used by pytest-mock and is

[GitHub] [airflow] v-hunt commented on issue #13311: pendulum.tz.zoneinfo.exceptions.InvalidTimezone

2023-02-20 Thread via GitHub
v-hunt commented on issue #13311: URL: https://github.com/apache/airflow/issues/13311#issuecomment-1437224379 @EKami hi, did you resolve this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk merged pull request #29638: Add OSSRank badge

2023-02-20 Thread via GitHub
potiuk merged PR #29638: URL: https://github.com/apache/airflow/pull/29638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Add OSSRank badge (#29638)

2023-02-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 497f6feb06 Add OSSRank badge (#29638) 497f6feb06

[GitHub] [airflow] potiuk commented on pull request #29616: Refactor docker-compose quick start test

2023-02-20 Thread via GitHub
potiuk commented on PR #29616: URL: https://github.com/apache/airflow/pull/29616#issuecomment-1437277562 > The more you look on error the less chance that this error will reproduce roll_eyes rofl Heisentest -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29270: Adding possibility for annotations in logs pvc

2023-02-20 Thread via GitHub
hussein-awala commented on code in PR #29270: URL: https://github.com/apache/airflow/pull/29270#discussion_r889625 ## chart/templates/logs-persistent-volume-claim.yaml: ## @@ -29,6 +29,10 @@ metadata: {{- with .Values.labels }} {{- toYaml . | nindent 4 }} {{-

[GitHub] [airflow] kaxil commented on pull request #29047: Add Livy Operator with deferrable mode

2023-02-20 Thread via GitHub
kaxil commented on PR #29047: URL: https://github.com/apache/airflow/pull/29047#issuecomment-1437068944 Failing tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on a diff in pull request #28256: Include full path to Python files under zip path while clearing import errors.

2023-02-20 Thread via GitHub
potiuk commented on code in PR #28256: URL: https://github.com/apache/airflow/pull/28256#discussion_r1112190405 ## airflow/dag_processing/manager.py: ## @@ -782,7 +782,11 @@ def clear_nonexistent_import_errors(file_paths: list[str] | None, session=NEW_SE """

[GitHub] [airflow] Taragolis commented on pull request #29616: Refactor docker-compose quick start test

2023-02-20 Thread via GitHub
Taragolis commented on PR #29616: URL: https://github.com/apache/airflow/pull/29616#issuecomment-1437330747 Yeah as soon as just run a go to do my daily routine it finally failed 磊   That is quite a bit interesting thing, some of them mostly could be a "wrong assumptions"

  1   2   3   >