[jira] [Commented] (AIRFLOW-4938) next_execution_date is not a Pendulum object

2019-07-13 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884571#comment-16884571 ] jack commented on AIRFLOW-4938: --- Related/duplicate to/of :

[jira] [Commented] (AIRFLOW-4597) Add DagStateSensor

2019-07-13 Thread jack (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884570#comment-16884570 ] jack commented on AIRFLOW-4597: --- [~ash] and isn't that exactly what 

[GitHub] [airflow] potiuk commented on a change in pull request #5576: [AIRFLOW-4942] Drop six.next

2019-07-13 Thread GitBox
potiuk commented on a change in pull request #5576: [AIRFLOW-4942] Drop six.next URL: https://github.com/apache/airflow/pull/5576#discussion_r303227884 ## File path: tests/jobs/test_scheduler_job.py ## @@ -2087,7 +2087,7 @@ def run_with_error(task): except

[jira] [Commented] (AIRFLOW-4943) Replace six assertion method with native

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884562#comment-16884562 ] ASF GitHub Bot commented on AIRFLOW-4943: - potiuk commented on pull request #5577:

[jira] [Resolved] (AIRFLOW-4943) Replace six assertion method with native

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4943. --- Resolution: Fixed Fix Version/s: 2.0.0 > Replace six assertion method with native >

[jira] [Commented] (AIRFLOW-4943) Replace six assertion method with native

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884563#comment-16884563 ] ASF subversion and git services commented on AIRFLOW-4943: -- Commit

[jira] [Commented] (AIRFLOW-4944) Use new types syntax

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884561#comment-16884561 ] ASF subversion and git services commented on AIRFLOW-4944: -- Commit

[jira] [Resolved] (AIRFLOW-4944) Use new types syntax

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4944. --- Resolution: Fixed Fix Version/s: 2.0.0 > Use new types syntax >

[GitHub] [airflow] potiuk merged pull request #5577: [AIRFLOW-4943] Replace six assertion method with native

2019-07-13 Thread GitBox
potiuk merged pull request #5577: [AIRFLOW-4943] Replace six assertion method with native URL: https://github.com/apache/airflow/pull/5577 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (AIRFLOW-4944) Use new types syntax

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884560#comment-16884560 ] ASF GitHub Bot commented on AIRFLOW-4944: - potiuk commented on pull request #5578:

[GitHub] [airflow] potiuk merged pull request #5578: [AIRFLOW-4944] Use new types syntax

2019-07-13 Thread GitBox
potiuk merged pull request #5578: [AIRFLOW-4944] Use new types syntax URL: https://github.com/apache/airflow/pull/5578 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (AIRFLOW-4947) Remove six types

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884559#comment-16884559 ] ASF subversion and git services commented on AIRFLOW-4947: -- Commit

[jira] [Resolved] (AIRFLOW-4947) Remove six types

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4947. --- Resolution: Fixed Fix Version/s: 2.0.0 > Remove six types > > >

[GitHub] [airflow] potiuk commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
potiuk commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#discussion_r303227674 ## File path: airflow/_vendor/nvd3/NVD3Chart.py ## @@ -36,7 +36,7 @@ def stab(tab=1): return ' ' * 4 * tab

[jira] [Commented] (AIRFLOW-4949) Use OSError exception

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884557#comment-16884557 ] ASF GitHub Bot commented on AIRFLOW-4949: - potiuk commented on pull request #5583:

[jira] [Resolved] (AIRFLOW-4949) Use OSError exception

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4949. --- Resolution: Fixed Fix Version/s: 2.0.0 > Use OSError exception >

[jira] [Commented] (AIRFLOW-4949) Use OSError exception

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884558#comment-16884558 ] ASF subversion and git services commented on AIRFLOW-4949: -- Commit

[GitHub] [airflow] potiuk merged pull request #5583: [AIRFLOW-4949] Use OSError exception

2019-07-13 Thread GitBox
potiuk merged pull request #5583: [AIRFLOW-4949] Use OSError exception URL: https://github.com/apache/airflow/pull/5583 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
potiuk commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#discussion_r303227624 ## File path: airflow/_vendor/nvd3/NVD3Chart.py ## @@ -36,7 +36,7 @@ def stab(tab=1): return ' ' * 4 * tab

[GitHub] [airflow] codecov-io commented on issue #5577: [AIRFLOW-4943] Replace six assertion method with native

2019-07-13 Thread GitBox
codecov-io commented on issue #5577: [AIRFLOW-4943] Replace six assertion method with native URL: https://github.com/apache/airflow/pull/5577#issuecomment-511167476 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5577?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5581: [AIRFLOW-4947] Remove six types

2019-07-13 Thread GitBox
codecov-io edited a comment on issue #5581: [AIRFLOW-4947] Remove six types URL: https://github.com/apache/airflow/pull/5581#issuecomment-511158555 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #5581: [AIRFLOW-4947] Remove six types

2019-07-13 Thread GitBox
codecov-io commented on issue #5581: [AIRFLOW-4947] Remove six types URL: https://github.com/apache/airflow/pull/5581#issuecomment-511158555 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5581?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-4497) KubernetesExecutor fails to launch pods when using run_as_user or fs_group options

2019-07-13 Thread Philippe Gagnon (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884503#comment-16884503 ] Philippe Gagnon commented on AIRFLOW-4497: -- [~ndigati] Is this solved by AIRFLOW-4516? I think

[jira] [Commented] (AIRFLOW-4911) Silence the FORBIDDEN errors from the KubernetesExecutor

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884502#comment-16884502 ] ASF subversion and git services commented on AIRFLOW-4911: -- Commit

[GitHub] [airflow] codecov-io edited a comment on issue #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
codecov-io edited a comment on issue #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#issuecomment-511149460 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
codecov-io edited a comment on issue #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#issuecomment-511149460 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-4911) Silence the FORBIDDEN errors from the KubernetesExecutor

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884501#comment-16884501 ] ASF subversion and git services commented on AIRFLOW-4911: -- Commit

[GitHub] [airflow] ashb commented on a change in pull request #5550: AIRFLOW-4912: Support to update nested keys in emr_defaults conn extras.

2019-07-13 Thread GitBox
ashb commented on a change in pull request #5550: AIRFLOW-4912: Support to update nested keys in emr_defaults conn extras. URL: https://github.com/apache/airflow/pull/5550#discussion_r303220315 ## File path: tests/utils/test_helpers.py ## @@ -52,6 +52,7 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #5550: AIRFLOW-4912: Support to update nested keys in emr_defaults conn extras.

2019-07-13 Thread GitBox
ashb commented on a change in pull request #5550: AIRFLOW-4912: Support to update nested keys in emr_defaults conn extras. URL: https://github.com/apache/airflow/pull/5550#discussion_r303220308 ## File path: tests/contrib/hooks/test_emr_hook.py ## @@ -62,7 +62,7 @@ def

[jira] [Commented] (AIRFLOW-4918) SparkShellHook

2019-07-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884499#comment-16884499 ] Ash Berlin-Taylor commented on AIRFLOW-4918: Isn't spark-shell designed for interactive

[GitHub] [airflow] ashb commented on issue #5325: [AIRFLOW-XXX] Add missing extras package to installation.rst

2019-07-13 Thread GitBox
ashb commented on issue #5325: [AIRFLOW-XXX] Add missing extras package to installation.rst URL: https://github.com/apache/airflow/pull/5325#issuecomment-511156757 @icyfox-bupt We should probably change it, assuming the current ldap module we install isn't used for anything else (I don't

[GitHub] [airflow] codecov-io commented on issue #5576: [AIRFLOW-4942] Drop six.next

2019-07-13 Thread GitBox
codecov-io commented on issue #5576: [AIRFLOW-4942] Drop six.next URL: https://github.com/apache/airflow/pull/5576#issuecomment-511155668 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #5576: [AIRFLOW-4942] Drop six.next

2019-07-13 Thread GitBox
codecov-io edited a comment on issue #5576: [AIRFLOW-4942] Drop six.next URL: https://github.com/apache/airflow/pull/5576#issuecomment-511155668 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5576?src=pr=h1) Report > Merging

[GitHub] [airflow] ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format

2019-07-13 Thread GitBox
ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format URL: https://github.com/apache/airflow/pull/5584#issuecomment-511154921 Thank you, and sorry to be a bit of a pain - I'm coming at this with my "I've just cherry-picked 100s of commits over the last few months" hat on.

[jira] [Commented] (AIRFLOW-4950) Simplify code formation

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884490#comment-16884490 ] ASF GitHub Bot commented on AIRFLOW-4950: - mik-laj commented on pull request #5584:

[GitHub] [airflow] mik-laj closed pull request #5584: [AIRFLOW-4950] Simplify string format

2019-07-13 Thread GitBox
mik-laj closed pull request #5584: [AIRFLOW-4950] Simplify string format URL: https://github.com/apache/airflow/pull/5584 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (AIRFLOW-4921) scheduler stuck with schedule is 2.30am and timezone is daylight saving time

2019-07-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884488#comment-16884488 ] Ash Berlin-Taylor commented on AIRFLOW-4921: Output I get on the RC: {noformat}

[jira] [Commented] (AIRFLOW-4921) scheduler stuck with schedule is 2.30am and timezone is daylight saving time

2019-07-13 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884484#comment-16884484 ] Ash Berlin-Taylor commented on AIRFLOW-4921: Likely already fixed in 1.10.4RC2 by

[GitHub] [airflow] ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format

2019-07-13 Thread GitBox
ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format URL: https://github.com/apache/airflow/pull/5584#issuecomment-511154360 We still need to support Py 3.5 for a while yet, and I'm not in favour of Yet Another Style Checker, and I honestly couldn't care which style of

[GitHub] [airflow] mik-laj commented on issue #5584: [AIRFLOW-4950] Simplify string format

2019-07-13 Thread GitBox
mik-laj commented on issue #5584: [AIRFLOW-4950] Simplify string format URL: https://github.com/apache/airflow/pull/5584#issuecomment-511153798 No, but it seems to me that when the whole code will be uniform, it will be a more readable code. This tool will allow us to automatically unify

[jira] [Commented] (AIRFLOW-4946) Use yield from syntax

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884481#comment-16884481 ] ASF subversion and git services commented on AIRFLOW-4946: -- Commit

[jira] [Commented] (AIRFLOW-4946) Use yield from syntax

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884479#comment-16884479 ] ASF GitHub Bot commented on AIRFLOW-4946: - BasPH commented on pull request #5580:

[GitHub] [airflow] BasPH merged pull request #5580: [AIRFLOW-4946] Use yield from syntax

2019-07-13 Thread GitBox
BasPH merged pull request #5580: [AIRFLOW-4946] Use yield from syntax URL: https://github.com/apache/airflow/pull/5580 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format

2019-07-13 Thread GitBox
ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format URL: https://github.com/apache/airflow/pull/5584#issuecomment-511153526 Is the current syntax deprecated by Python? This is an automated message from the

[jira] [Commented] (AIRFLOW-4884) Roll up import_errors in UI

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884476#comment-16884476 ] ASF subversion and git services commented on AIRFLOW-4884: -- Commit

[jira] [Commented] (AIRFLOW-4884) Roll up import_errors in UI

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884474#comment-16884474 ] ASF subversion and git services commented on AIRFLOW-4884: -- Commit

[GitHub] [airflow] ashb commented on issue #5516: [AIRFLOW-4884] Roll up import_errors in UI

2019-07-13 Thread GitBox
ashb commented on issue #5516: [AIRFLOW-4884] Roll up import_errors in UI URL: https://github.com/apache/airflow/pull/5516#issuecomment-511153011 /AIRFLOW-4748 was the PR for including stack traces in the dag-bag errors, but done the "naive" way

[jira] [Commented] (AIRFLOW-4884) Roll up import_errors in UI

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884473#comment-16884473 ] ASF GitHub Bot commented on AIRFLOW-4884: - ashb commented on pull request #5516: [AIRFLOW-4884]

[GitHub] [airflow] ashb commented on issue #5516: [AIRFLOW-4884] Roll up import_errors in UI

2019-07-13 Thread GitBox
ashb commented on issue #5516: [AIRFLOW-4884] Roll up import_errors in UI URL: https://github.com/apache/airflow/pull/5516#issuecomment-511152927 Nice. I'll cherry-pick this back to 1.10.4 (but only for the RBAC ui) This is

[GitHub] [airflow] codecov-io commented on issue #5580: [AIRFLOW-4946] Use yield from syntax

2019-07-13 Thread GitBox
codecov-io commented on issue #5580: [AIRFLOW-4946] Use yield from syntax URL: https://github.com/apache/airflow/pull/5580#issuecomment-511152896 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5580?src=pr=h1) Report > Merging

[GitHub] [airflow] ashb merged pull request #5516: [AIRFLOW-4884] Roll up import_errors in UI

2019-07-13 Thread GitBox
ashb merged pull request #5516: [AIRFLOW-4884] Roll up import_errors in UI URL: https://github.com/apache/airflow/pull/5516 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] ashb commented on issue #4291: [AIRFLOW-1488] Add the TriggeredDagRunSensor operator

2019-07-13 Thread GitBox
ashb commented on issue #4291: [AIRFLOW-1488] Add the TriggeredDagRunSensor operator URL: https://github.com/apache/airflow/pull/4291#issuecomment-511152626 > I can not start DAT_PUBLISH if there is DAG_UPDATE_PRICES in RUNNING https://airflow.apache.org/concepts.html#pools

[GitHub] [airflow] mik-laj commented on issue #5584: [AIRFLOW-4950] Simplify string format

2019-07-13 Thread GitBox
mik-laj commented on issue #5584: [AIRFLOW-4950] Simplify string format URL: https://github.com/apache/airflow/pull/5584#issuecomment-511152368 This will help maintain good health of the code. When this change is accepted, it will be possible to automatically verify the code.

[GitHub] [airflow] ashb commented on issue #5057: [AIRFLOW-4257] Remove the global session from the core test

2019-07-13 Thread GitBox
ashb commented on issue #5057: [AIRFLOW-4257] Remove the global session from the core test URL: https://github.com/apache/airflow/pull/5057#issuecomment-511151048 Yeah, I've done a bit of experimentation with Pytest, and started https://issues.apache.org/jira/browse/AIRFLOW-4863 as a

[GitHub] [airflow] codecov-io commented on issue #5578: [AIRFLOW-4944] Use new types syntax

2019-07-13 Thread GitBox
codecov-io commented on issue #5578: [AIRFLOW-4944] Use new types syntax URL: https://github.com/apache/airflow/pull/5578#issuecomment-511150952 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5578?src=pr=h1) Report > Merging

[GitHub] [airflow] ashb commented on issue #5543: Fix permission error when creating logs

2019-07-13 Thread GitBox
ashb commented on issue #5543: Fix permission error when creating logs URL: https://github.com/apache/airflow/pull/5543#issuecomment-511150905 This will change the path to point to something other than the RIGHT path. If I set my dag_dir to `/a/b/c/d/../../e` This would write logs to

[GitHub] [airflow] ashb closed pull request #5543: Fix permission error when creating logs

2019-07-13 Thread GitBox
ashb closed pull request #5543: Fix permission error when creating logs URL: https://github.com/apache/airflow/pull/5543 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#discussion_r303217602 ## File path: airflow/_vendor/nvd3/NVD3Chart.py ## @@ -36,7 +36,7 @@ def stab(tab=1): return ' ' * 4 * tab

[GitHub] [airflow] BasPH commented on issue #5057: [AIRFLOW-4257] Remove the global session from the core test

2019-07-13 Thread GitBox
BasPH commented on issue #5057: [AIRFLOW-4257] Remove the global session from the core test URL: https://github.com/apache/airflow/pull/5057#issuecomment-511150879 Unrelated to this issue; but for the concern about boilerplate code I know there's some work being done on getting pytest in

[GitHub] [airflow] ashb commented on issue #5579: [AIRFLOW-4945] Use super() syntax

2019-07-13 Thread GitBox
ashb commented on issue #5579: [AIRFLOW-4945] Use super() syntax URL: https://github.com/apache/airflow/pull/5579#issuecomment-511150796 This should have been AIRFLOW-4204 - there was already a Jira for this issue. This is an

[GitHub] [airflow] ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format

2019-07-13 Thread GitBox
ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format URL: https://github.com/apache/airflow/pull/5584#issuecomment-511150712 I think I'm -0.5 on this -- it is a lot of diff that makes `git blame`/history noisier and what is there is not deprecated or wrong.

[GitHub] [airflow] mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#discussion_r303217518 ## File path: airflow/_vendor/nvd3/NVD3Chart.py ## @@ -36,7 +36,7 @@ def stab(tab=1): return ' ' * 4 * tab

[GitHub] [airflow] mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#discussion_r303217525 ## File path: airflow/_vendor/nvd3/NVD3Chart.py ## @@ -36,7 +36,7 @@ def stab(tab=1): return ' ' * 4 * tab

[GitHub] [airflow] ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511150575 I'd be very careful about deprecating something as "fundamental" as `task.dag = dag` -- even for 2.0.0 that would still

[GitHub] [airflow] ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
ashb commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511150505 @milton0825 How does the context manager handle this case: ``` dag = DAG('dag', default_args={'email_on_failure':

[GitHub] [airflow] ashb commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
ashb commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#discussion_r303217437 ## File path: airflow/_vendor/nvd3/NVD3Chart.py ## @@ -36,7 +36,7 @@ def stab(tab=1): return ' ' * 4 * tab

[GitHub] [airflow] BasPH commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
BasPH commented on a change in pull request #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#discussion_r303217355 ## File path: airflow/_vendor/nvd3/NVD3Chart.py ## @@ -36,7 +36,7 @@ def stab(tab=1): return ' ' * 4 * tab

[jira] [Assigned] (AIRFLOW-4942) Drop six.next

2019-07-13 Thread Kamil (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil reassigned AIRFLOW-4942: -- Assignee: Kamil > Drop six.next > - > > Key: AIRFLOW-4942 >

[jira] [Assigned] (AIRFLOW-4947) Remove six types

2019-07-13 Thread Kamil (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil reassigned AIRFLOW-4947: -- Assignee: Kamil > Remove six types > > > Key: AIRFLOW-4947 >

[jira] [Assigned] (AIRFLOW-4946) Use yield from syntax

2019-07-13 Thread Kamil (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil reassigned AIRFLOW-4946: -- Assignee: Kamil > Use yield from syntax > - > > Key:

[jira] [Assigned] (AIRFLOW-4943) Replace six assertion method with native

2019-07-13 Thread Kamil (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil reassigned AIRFLOW-4943: -- Assignee: Kamil > Replace six assertion method with native >

[jira] [Assigned] (AIRFLOW-4948) Use items, values method instead six package

2019-07-13 Thread Kamil (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil reassigned AIRFLOW-4948: -- Assignee: Kamil > Use items, values method instead six package >

[jira] [Assigned] (AIRFLOW-4945) Use super() syntax

2019-07-13 Thread Kamil (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil reassigned AIRFLOW-4945: -- Assignee: Kamil > Use super() syntax > -- > > Key: AIRFLOW-4945 >

[jira] [Assigned] (AIRFLOW-4944) Use new types syntax

2019-07-13 Thread Kamil (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil reassigned AIRFLOW-4944: -- Assignee: Kamil > Use new types syntax > > > Key: AIRFLOW-4944

[jira] [Assigned] (AIRFLOW-4949) Use OSError exception

2019-07-13 Thread Kamil (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil reassigned AIRFLOW-4949: -- Assignee: Kamil > Use OSError exception > - > > Key:

[jira] [Assigned] (AIRFLOW-4951) Use new style classes

2019-07-13 Thread Kamil (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil reassigned AIRFLOW-4951: -- Assignee: Kamil > Use new style classes > - > > Key:

[jira] [Updated] (AIRFLOW-4942) Drop six.next

2019-07-13 Thread Kamil (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil updated AIRFLOW-4942: --- Issue Type: Sub-task (was: Improvement) Parent: AIRFLOW-4196 > Drop six.next > - > >

[GitHub] [airflow] milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149532 @ashb I thought about applying `default_args` in the setter but I don't see how we can support the following

[GitHub] [airflow] milton0825 commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
milton0825 commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149609 @feluelle I see that it is flooding the CI since there are actually quite some example dags using the setter. I feel

[GitHub] [airflow] milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149532 @ashb I thought about applying `default_args` in the setter but I don't see how we can support the following

[GitHub] [airflow] milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
milton0825 edited a comment on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149532 @ashb I thought about applying `default_args` in the setter but I don't see how we can support the following

[GitHub] [airflow] milton0825 commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter

2019-07-13 Thread GitBox
milton0825 commented on issue #5574: [AIRFLOW-4941] Warn that default_args not applied via setter URL: https://github.com/apache/airflow/pull/5574#issuecomment-511149532 @ashb I thought about applying `default_args` in the setter but I don't see how we can support the following case

[GitHub] [airflow] codecov-io commented on issue #5585: [AIRFLOW-4951] Use new style classes

2019-07-13 Thread GitBox
codecov-io commented on issue #5585: [AIRFLOW-4951] Use new style classes URL: https://github.com/apache/airflow/pull/5585#issuecomment-511149460 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5585?src=pr=h1) Report > Merging

[GitHub] [airflow] ashb commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
ashb commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#issuecomment-511149357 What was the problem with debian buster btw? This is an

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303216882 ## File path: scripts/ci/ci_docs.sh ## @@ -1,43 +1,52 @@ #!/usr/bin/env bash - -# -#

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303216801 ## File path: scripts/ci/_force_python_3.6.sh ## @@ -0,0 +1,34 @@ +#!/usr/bin/env bash

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303216729 ## File path: scripts/ci/_cache_utils.sh ## @@ -0,0 +1,99 @@ +#!/usr/bin/env bash +#

[GitHub] [airflow] ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3]

2019-07-13 Thread GitBox
ashb commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r303216568 ## File path: scripts/ci/docker-compose-local.yml ## @@ -0,0 +1,42 @@ +# +# Licensed to

[GitHub] [airflow] ashb commented on issue #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI

2019-07-13 Thread GitBox
ashb commented on issue #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI URL: https://github.com/apache/airflow/pull/5573#issuecomment-511148508 For running on master branch two things: 1. Run `setup.py compile_assets` 2. Use the `airflow users -c` option (you man need to

[GitHub] [airflow] ashb commented on a change in pull request #5580: [AIRFLOW-4946] Use yield from syntax

2019-07-13 Thread GitBox
ashb commented on a change in pull request #5580: [AIRFLOW-4946] Use yield from syntax URL: https://github.com/apache/airflow/pull/5580#discussion_r303216456 ## File path: airflow/contrib/hooks/grpc_hook.py ## @@ -100,8 +100,7 @@ def run(self, stub_class, call_func,

[jira] [Updated] (AIRFLOW-4942) Drop six.next

2019-07-13 Thread Kamil (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil updated AIRFLOW-4942: --- Summary: Drop six.next (was: Replace six.next with next) > Drop six.next > - > >

[GitHub] [airflow] codecov-io edited a comment on issue #5583: [AIRFLOW-4949] Use OSError exception

2019-07-13 Thread GitBox
codecov-io edited a comment on issue #5583: [AIRFLOW-4949] Use OSError exception URL: https://github.com/apache/airflow/pull/5583#issuecomment-511147742 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io commented on issue #5583: [AIRFLOW-4949] Use OSError exception

2019-07-13 Thread GitBox
codecov-io commented on issue #5583: [AIRFLOW-4949] Use OSError exception URL: https://github.com/apache/airflow/pull/5583#issuecomment-511147742 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5583?src=pr=h1) Report > Merging

[jira] [Updated] (AIRFLOW-4943) Replace six assertion method with native

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-4943: -- Issue Type: Sub-task (was: Improvement) Parent: AIRFLOW-4196 > Replace six

[jira] [Updated] (AIRFLOW-4944) Use new types syntax

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-4944: -- Issue Type: Sub-task (was: Improvement) Parent: AIRFLOW-4196 > Use new types syntax

[jira] [Commented] (AIRFLOW-4945) Use super() syntax

2019-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884455#comment-16884455 ] ASF GitHub Bot commented on AIRFLOW-4945: - potiuk commented on pull request #5579:

[jira] [Resolved] (AIRFLOW-4945) Use super() syntax

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-4945. --- Resolution: Fixed Fix Version/s: 2.0.0 > Use super() syntax > -- >

[jira] [Commented] (AIRFLOW-4945) Use super() syntax

2019-07-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884456#comment-16884456 ] ASF subversion and git services commented on AIRFLOW-4945: -- Commit

[GitHub] [airflow] potiuk merged pull request #5579: [AIRFLOW-4945] Use super() syntax

2019-07-13 Thread GitBox
potiuk merged pull request #5579: [AIRFLOW-4945] Use super() syntax URL: https://github.com/apache/airflow/pull/5579 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (AIRFLOW-4945) Use super() syntax

2019-07-13 Thread Jarek Potiuk (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-4945: -- Issue Type: Sub-task (was: Improvement) Parent: AIRFLOW-4196 > Use super() syntax >

  1   2   >