[GitHub] [airflow] codecov-io edited a comment on issue #6379: [AIRFLOW-5708] Optionally check task pools when parsing dags.

[GitBox]

codecov-io edited a comment on issue #6379: [AIRFLOW-5708] Optionally check 
task pools when parsing dags.
URL: https://github.com/apache/airflow/pull/6379#issuecomment-603646789
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=h1) 
Report
   > Merging 
[#6379](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a15026fa1652bec839a03d3e33eebac1b79545ae=desc)
 will **decrease** coverage by `25.85%`.
   > The diff coverage is `95.23%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6379/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#6379   +/-   ##
   ===
   - Coverage   86.97%   61.12%   -25.86% 
   ===
 Files 927  927   
 Lines   4496344977   +14 
   ===
   - Hits3910827493-11615 
   - Misses   585517484+11629 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/dagbag.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnYmFnLnB5)
 | `90.00% <95.23%> (+0.16%)` | :arrow_up: |
   | 
[airflow/providers/oracle/hooks/oracle.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvb3JhY2xlL2hvb2tzL29yYWNsZS5weQ==)
 | `9.40% <0.00%> (-86.33%)` | :arrow_down: |
   | 
[airflow/providers/apache/sqoop/hooks/sqoop.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3Nxb29wL2hvb2tzL3Nxb29wLnB5)
 | `11.46% <0.00%> (-84.08%)` | :arrow_down: |
   | 
[airflow/providers/apache/spark/hooks/spark\_jdbc.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX2pkYmMucHk=)
 | `10.34% <0.00%> (-81.61%)` | :arrow_down: |
   | 
[airflow/providers/slack/hooks/slack\_webhook.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc2xhY2svaG9va3Mvc2xhY2tfd2ViaG9vay5weQ==)
 | `16.66% <0.00%> (-79.17%)` | :arrow_down: |
   | 
[...flow/providers/apache/hive/operators/hive\_stats.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL2hpdmVfc3RhdHMucHk=)
 | `21.33% <0.00%> (-78.67%)` | :arrow_down: |
   | 
[...iders/google/marketing\_platform/hooks/analytics.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL21hcmtldGluZ19wbGF0Zm9ybS9ob29rcy9hbmFseXRpY3MucHk=)
 | `21.42% <0.00%> (-78.58%)` | :arrow_down: |
   | 
[airflow/providers/apache/pig/hooks/pig.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3BpZy9ob29rcy9waWcucHk=)
 | `17.77% <0.00%> (-77.78%)` | :arrow_down: |
   | 
[airflow/providers/google/cloud/hooks/dlp.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2RscC5weQ==)
 | `20.93% <0.00%> (-77.62%)` | :arrow_down: |
   | 
[airflow/providers/google/suite/hooks/drive.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL3N1aXRlL2hvb2tzL2RyaXZlLnB5)
 | `22.91% <0.00%> (-77.09%)` | :arrow_down: |
   | ... and [302 
more](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=footer). 
Last update 
[a15026f...1584f1b](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #6379: [AIRFLOW-5708] Optionally check task pools when parsing dags.

[GitBox]

codecov-io commented on issue #6379: [AIRFLOW-5708] Optionally check task pools 
when parsing dags.
URL: https://github.com/apache/airflow/pull/6379#issuecomment-603646789
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=h1) 
Report
   > Merging 
[#6379](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a15026fa1652bec839a03d3e33eebac1b79545ae=desc)
 will **decrease** coverage by `25.85%`.
   > The diff coverage is `95.23%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/6379/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#6379   +/-   ##
   ===
   - Coverage   86.97%   61.12%   -25.86% 
   ===
 Files 927  927   
 Lines   4496344977   +14 
   ===
   - Hits3910827493-11615 
   - Misses   585517484+11629 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/models/dagbag.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnYmFnLnB5)
 | `90.00% <95.23%> (+0.16%)` | :arrow_up: |
   | 
[airflow/providers/oracle/hooks/oracle.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvb3JhY2xlL2hvb2tzL29yYWNsZS5weQ==)
 | `9.40% <0.00%> (-86.33%)` | :arrow_down: |
   | 
[airflow/providers/apache/sqoop/hooks/sqoop.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3Nxb29wL2hvb2tzL3Nxb29wLnB5)
 | `11.46% <0.00%> (-84.08%)` | :arrow_down: |
   | 
[airflow/providers/apache/spark/hooks/spark\_jdbc.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX2pkYmMucHk=)
 | `10.34% <0.00%> (-81.61%)` | :arrow_down: |
   | 
[airflow/providers/slack/hooks/slack\_webhook.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc2xhY2svaG9va3Mvc2xhY2tfd2ViaG9vay5weQ==)
 | `16.66% <0.00%> (-79.17%)` | :arrow_down: |
   | 
[...flow/providers/apache/hive/operators/hive\_stats.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL2hpdmVfc3RhdHMucHk=)
 | `21.33% <0.00%> (-78.67%)` | :arrow_down: |
   | 
[...iders/google/marketing\_platform/hooks/analytics.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL21hcmtldGluZ19wbGF0Zm9ybS9ob29rcy9hbmFseXRpY3MucHk=)
 | `21.42% <0.00%> (-78.58%)` | :arrow_down: |
   | 
[airflow/providers/apache/pig/hooks/pig.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3BpZy9ob29rcy9waWcucHk=)
 | `17.77% <0.00%> (-77.78%)` | :arrow_down: |
   | 
[airflow/providers/google/cloud/hooks/dlp.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2RscC5weQ==)
 | `20.93% <0.00%> (-77.62%)` | :arrow_down: |
   | 
[airflow/providers/google/suite/hooks/drive.py](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL3N1aXRlL2hvb2tzL2RyaXZlLnB5)
 | `22.91% <0.00%> (-77.09%)` | :arrow_down: |
   | ... and [302 
more](https://codecov.io/gh/apache/airflow/pull/6379/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=footer). 
Last update 
[a15026f...1584f1b](https://codecov.io/gh/apache/airflow/pull/6379?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

potiuk commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397603531
 
 

 ##
 File path: scripts/ci/docker-compose/base.yml
 ##
 @@ -59,6 +59,8 @@ services:
   - DB_RESET
   - ENABLED_SYSTEMS
   - RUN_SYSTEM_TESTS
+  - DEFAULT_PYTHON_SHORT_VERSION
+  - PYTHON_SHORT_VERSION
 
 Review comment:
   Not any more :). It was only needed to generate requirements.txt file in the 
main repo but I removed it - it was nice for IDE's but very redundant and 
confusing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

potiuk commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397603326
 
 

 ##
 File path: scripts/ci/_utils.sh
 ##
 @@ -530,7 +531,7 @@ function confirm_image_rebuild() {
 # Make sure to use /dev/tty first rather than stdin/stdout when 
available - this way confirm
 # will works also in case of pre-commits (git does not pass 
stdin/stdout to pre-commit hooks)
 # shellcheck disable=SC2094
-"${AIRFLOW_SOURCES}/confirm" "${ACTION} image ${THE_IMAGE_TYPE} (might 
take some time)" \
+"${AIRFLOW_SOURCES}/confirm" "${ACTION} image 
${THE_IMAGE_TYPE}-${PYTHON_SHORT_VERSION}" \
 
 Review comment:
   Yep.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

potiuk commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397603139
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

potiuk commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397603010
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
+requirement versions. Those requirement.txt files can be used as constraints 
file when installing apache
+airflow - either from the sources ``pip install -e . --constraint 
requirements/requirements-python3.7.txt``
+or from the pypi package ``pip install apache-airflow --constraint 
requirements/requirements-python3.7.txt``.
+This work also with extras - ``pip install .[gcp] --constraint 
requirements/requirements-python3.7.txt``.
+It is also possible to use constraints directly from github (note that it only 
works starting from
+airflow 1.10.10 version:
 
-If you do not use pre-commits and the CI builds fails / you need to regenerate 
it, you can do it manually:
-``pre-commit run generate-requirements --all-files`` or via script
-``./scripts/ci/ci_generate_requirements.sh``.
-This will try to regenerate the requirements.txt file with the latest 
requirements matching
-the setup.py constraints.
+.. code-block:: bash
+
+  pip install apache-airflow[gcp]==1.10.10 \
+  --constraint 
https://raw.githubusercontent.com/apache/airflow/1.10.10/requirements/requirements-python3.7.txt
+
+There are different set of fixed requirements for different python major/minor 
versions and you should
+use the right python version file for the right python version.
+
+The ``requirements-python.txt`` file MUST be regenerated 
every time after setup.py
+is updated. This is checked automatically in Travis CI build there are 
separate jobs for each
+python version that checks if the requirements should be updated.
+
+If they are not you should regenerate the requirements locally using one of 
the methods described below.
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

potiuk commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397602871
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
+requirement versions. Those requirement.txt files can be used as constraints 
file when installing apache
+airflow - either from the sources ``pip install -e . --constraint 
requirements/requirements-python3.7.txt``
+or from the pypi package ``pip install apache-airflow --constraint 
requirements/requirements-python3.7.txt``.
+This work also with extras - ``pip install .[gcp] --constraint 
requirements/requirements-python3.7.txt``.
+It is also possible to use constraints directly from github (note that it only 
works starting from
+airflow 1.10.10 version:
 
-If you do not use pre-commits and the CI builds fails / you need to regenerate 
it, you can do it manually:
-``pre-commit run generate-requirements --all-files`` or via script
-``./scripts/ci/ci_generate_requirements.sh``.
-This will try to regenerate the requirements.txt file with the latest 
requirements matching
-the setup.py constraints.
+.. code-block:: bash
+
+  pip install apache-airflow[gcp]==1.10.10 \
+  --constraint 
https://raw.githubusercontent.com/apache/airflow/1.10.10/requirements/requirements-python3.7.txt
+
+There are different set of fixed requirements for different python major/minor 
versions and you should
+use the right python version file for the right python version.
+
+The ``requirements-python.txt`` file MUST be regenerated 
every time after setup.py
+is updated. This is checked automatically in Travis CI build there are 
separate jobs for each
+python version that checks if the requirements should be updated.
+
+If they are not you should regenerate the requirements locally using one of 
the methods described below.
+
+Generating requirement files
+
+
+This shuould be done every time after you modify setup.py file. You can 
generate requirement files
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

potiuk commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397602779
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
+requirement versions. Those requirement.txt files can be used as constraints 
file when installing apache
+airflow - either from the sources ``pip install -e . --constraint 
requirements/requirements-python3.7.txt``
+or from the pypi package ``pip install apache-airflow --constraint 
requirements/requirements-python3.7.txt``.
+This work also with extras - ``pip install .[gcp] --constraint 
requirements/requirements-python3.7.txt``.
+It is also possible to use constraints directly from github (note that it only 
works starting from
+airflow 1.10.10 version:
 
-If you do not use pre-commits and the CI builds fails / you need to regenerate 
it, you can do it manually:
-``pre-commit run generate-requirements --all-files`` or via script
-``./scripts/ci/ci_generate_requirements.sh``.
-This will try to regenerate the requirements.txt file with the latest 
requirements matching
-the setup.py constraints.
+.. code-block:: bash
+
+  pip install apache-airflow[gcp]==1.10.10 \
+  --constraint 
https://raw.githubusercontent.com/apache/airflow/1.10.10/requirements/requirements-python3.7.txt
+
+There are different set of fixed requirements for different python major/minor 
versions and you should
+use the right python version file for the right python version.
+
+The ``requirements-python.txt`` file MUST be regenerated 
every time after setup.py
+is updated. This is checked automatically in Travis CI build there are 
separate jobs for each
 
 Review comment:
   Fixed,


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

potiuk commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397602652
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
+requirement versions. Those requirement.txt files can be used as constraints 
file when installing apache
+airflow - either from the sources ``pip install -e . --constraint 
requirements/requirements-python3.7.txt``
+or from the pypi package ``pip install apache-airflow --constraint 
requirements/requirements-python3.7.txt``.
+This work also with extras - ``pip install .[gcp] --constraint 
requirements/requirements-python3.7.txt``.
+It is also possible to use constraints directly from github (note that it only 
works starting from
+airflow 1.10.10 version:
 
-If you do not use pre-commits and the CI builds fails / you need to regenerate 
it, you can do it manually:
-``pre-commit run generate-requirements --all-files`` or via script
-``./scripts/ci/ci_generate_requirements.sh``.
-This will try to regenerate the requirements.txt file with the latest 
requirements matching
-the setup.py constraints.
+.. code-block:: bash
+
+  pip install apache-airflow[gcp]==1.10.10 \
+  --constraint 
https://raw.githubusercontent.com/apache/airflow/1.10.10/requirements/requirements-python3.7.txt
+
+There are different set of fixed requirements for different python major/minor 
versions and you should
+use the right python version file for the right python version.
+
+The ``requirements-python.txt`` file MUST be regenerated 
every time after setup.py
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

potiuk commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397602189
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
+requirement versions. Those requirement.txt files can be used as constraints 
file when installing apache
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

potiuk commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397602286
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
+requirement versions. Those requirement.txt files can be used as constraints 
file when installing apache
+airflow - either from the sources ``pip install -e . --constraint 
requirements/requirements-python3.7.txt``
+or from the pypi package ``pip install apache-airflow --constraint 
requirements/requirements-python3.7.txt``.
+This work also with extras - ``pip install .[gcp] --constraint 
requirements/requirements-python3.7.txt``.
+It is also possible to use constraints directly from github (note that it only 
works starting from
+airflow 1.10.10 version:
 
 Review comment:
   rephrased


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

potiuk commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397601566
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

potiuk commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397601489
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
 
 Review comment:
   Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

potiuk commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397601320
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
 
 Review comment:
   added


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

potiuk commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397601090
 
 

 ##
 File path: .travis.yml
 ##
 @@ -41,24 +41,24 @@ jobs:
   stage: pre-test
   script: ./scripts/ci/ci_run_all_static_checks.sh
   env: >-
-PYTHON_VERSION=3.6
+PYTHON_SHORT_VERSION=3.6
 
 Review comment:
   PYTHON_MAJOR_MINOR_VERSION is better


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-6912) Airflow unable to run concurrent ssh tasks (up to 27) in a single dag

[Nguyen Lam Phuc (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-6912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066365#comment-17066365
 ] 

Nguyen Lam Phuc commented on AIRFLOW-6912:
--

[~ash] Is there a way for us to share the dag with you securely? via email 
maybe?

> Airflow unable to run concurrent ssh tasks (up to 27) in a single dag
> -
>
> Key: AIRFLOW-6912
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6912
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: executors, scheduler
>Affects Versions: 1.10.9
> Environment: Kubernetes 1.13
>Reporter: Nguyen Lam Phuc
>Priority: Major
> Attachments: version_1_10_7-working.png, version_1_10_9_break.png
>
>
> *Current working Airflow version:* 1.10.7
> *Environment:* Kubernetes 1.13, Helm chart 5.2.4
> *Airflow version that breaks:* 1.10.9
> *Description:*
>  * We have a list of _ssh_operators_ tasks in a dag that need to be executed 
> in parallel (as shown in the screenshot) and everything is working fine at 
> Airflow version _1.10.7_
>  * We tried to update Airflow to version _1.10.9_ and the tasks break in 
> random orders and number. (as shown in the screenshot)
>  * Here are some of the error that we collected:
>  ** (psycopg2.OperationalError) FATAL:  remaining connection slots are 
> reserved for non-replication superuser connections
>  ** Executor reports task instance . 
> 2020-02-20 12:20:00+00:00 [queued]> finished (failed) although the task says 
> its queued. Was the task killed externally?
>  ** . 2020-02-20 08:20:00+00:00 
> [running]> detected as zombie
>  ** (psycopg2.OperationalError) FATAL: remaining connection slots are 
> reserved for non-replication superuser connections
> *Actions taken:*
>  * We suspected that there were not enough database connections so we 
> increased the _AIRFLOW__CORE__SQL_ALCHEMY_POOL_SIZE_ value from 5 to 50 but 
> the problem still persists.
>  * We reverted the version back to _1.10.7_ and everything works as per 
> normal.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

[GitBox]

codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of 
`none_failed` consistent with documentation
URL: https://github.com/apache/airflow/pull/7464#issuecomment-603575203
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=h1) 
Report
   > Merging 
[#7464](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a15026fa1652bec839a03d3e33eebac1b79545ae=desc)
 will **increase** coverage by `21.44%`.
   > The diff coverage is `96.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7464/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7464   +/-   ##
   ===
   + Coverage   65.44%   86.88%   +21.44% 
   ===
 Files 927  928+1 
 Lines   4496344988   +25 
   ===
   + Hits2942539087 +9662 
   + Misses  15538 5901 -9637 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100.00% <ø> (ø)` | |
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `95.68% <ø> (+28.13%)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/trigger\_rule\_dep.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvdHJpZ2dlcl9ydWxlX2RlcC5weQ==)
 | `94.04% <85.71%> (+73.26%)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_nested\_branch\_dag.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9uZXN0ZWRfYnJhbmNoX2RhZy5weQ==)
 | `100.00% <100.00%> (ø)` | |
   | 
[airflow/utils/trigger\_rule.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy90cmlnZ2VyX3J1bGUucHk=)
 | `100.00% <100.00%> (ø)` | |
   | 
[airflow/providers/google/cloud/operators/vision.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy92aXNpb24ucHk=)
 | `99.63% <0.00%> (+0.36%)` | :arrow_up: |
   | 
[...osoft/azure/operators/azure\_container\_instances.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L2F6dXJlL29wZXJhdG9ycy9henVyZV9jb250YWluZXJfaW5zdGFuY2VzLnB5)
 | `78.28% <0.00%> (+0.65%)` | :arrow_up: |
   | 
[airflow/cli/cli\_parser.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY2xpX3BhcnNlci5weQ==)
 | `98.13% <0.00%> (+0.93%)` | :arrow_up: |
   | 
[...rflow/providers/databricks/operators/databricks.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZGF0YWJyaWNrcy9vcGVyYXRvcnMvZGF0YWJyaWNrcy5weQ==)
 | `92.24% <0.00%> (+1.72%)` | :arrow_up: |
   | ... and [492 
more](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=footer). 
Last update 
[a15026f...74f565d](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

[GitBox]

codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of 
`none_failed` consistent with documentation
URL: https://github.com/apache/airflow/pull/7464#issuecomment-603575203
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=h1) 
Report
   > Merging 
[#7464](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a15026fa1652bec839a03d3e33eebac1b79545ae=desc)
 will **increase** coverage by `21.44%`.
   > The diff coverage is `96.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7464/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7464   +/-   ##
   ===
   + Coverage   65.44%   86.88%   +21.44% 
   ===
 Files 927  928+1 
 Lines   4496344988   +25 
   ===
   + Hits2942539087 +9662 
   + Misses  15538 5901 -9637 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100.00% <ø> (ø)` | |
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `95.68% <ø> (+28.13%)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/trigger\_rule\_dep.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvdHJpZ2dlcl9ydWxlX2RlcC5weQ==)
 | `94.04% <85.71%> (+73.26%)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_nested\_branch\_dag.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9uZXN0ZWRfYnJhbmNoX2RhZy5weQ==)
 | `100.00% <100.00%> (ø)` | |
   | 
[airflow/utils/trigger\_rule.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy90cmlnZ2VyX3J1bGUucHk=)
 | `100.00% <100.00%> (ø)` | |
   | 
[airflow/providers/google/cloud/operators/vision.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy92aXNpb24ucHk=)
 | `99.63% <0.00%> (+0.36%)` | :arrow_up: |
   | 
[...osoft/azure/operators/azure\_container\_instances.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L2F6dXJlL29wZXJhdG9ycy9henVyZV9jb250YWluZXJfaW5zdGFuY2VzLnB5)
 | `78.28% <0.00%> (+0.65%)` | :arrow_up: |
   | 
[airflow/cli/cli\_parser.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY2xpX3BhcnNlci5weQ==)
 | `98.13% <0.00%> (+0.93%)` | :arrow_up: |
   | 
[...rflow/providers/databricks/operators/databricks.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZGF0YWJyaWNrcy9vcGVyYXRvcnMvZGF0YWJyaWNrcy5weQ==)
 | `92.24% <0.00%> (+1.72%)` | :arrow_up: |
   | ... and [492 
more](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=footer). 
Last update 
[a15026f...74f565d](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

[GitBox]

codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of 
`none_failed` consistent with documentation
URL: https://github.com/apache/airflow/pull/7464#issuecomment-603575203
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=h1) 
Report
   > Merging 
[#7464](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a15026fa1652bec839a03d3e33eebac1b79545ae=desc)
 will **increase** coverage by `21.44%`.
   > The diff coverage is `96.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7464/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7464   +/-   ##
   ===
   + Coverage   65.44%   86.88%   +21.44% 
   ===
 Files 927  928+1 
 Lines   4496344988   +25 
   ===
   + Hits2942539087 +9662 
   + Misses  15538 5901 -9637 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100.00% <ø> (ø)` | |
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `95.68% <ø> (+28.13%)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/trigger\_rule\_dep.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvdHJpZ2dlcl9ydWxlX2RlcC5weQ==)
 | `94.04% <85.71%> (+73.26%)` | :arrow_up: |
   | 
[airflow/example\_dags/example\_nested\_branch\_dag.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9uZXN0ZWRfYnJhbmNoX2RhZy5weQ==)
 | `100.00% <100.00%> (ø)` | |
   | 
[airflow/utils/trigger\_rule.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy90cmlnZ2VyX3J1bGUucHk=)
 | `100.00% <100.00%> (ø)` | |
   | 
[airflow/providers/google/cloud/operators/vision.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy92aXNpb24ucHk=)
 | `99.63% <0.00%> (+0.36%)` | :arrow_up: |
   | 
[...osoft/azure/operators/azure\_container\_instances.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L2F6dXJlL29wZXJhdG9ycy9henVyZV9jb250YWluZXJfaW5zdGFuY2VzLnB5)
 | `78.28% <0.00%> (+0.65%)` | :arrow_up: |
   | 
[airflow/cli/cli\_parser.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY2xpX3BhcnNlci5weQ==)
 | `98.13% <0.00%> (+0.93%)` | :arrow_up: |
   | 
[...rflow/providers/databricks/operators/databricks.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZGF0YWJyaWNrcy9vcGVyYXRvcnMvZGF0YWJyaWNrcy5weQ==)
 | `92.24% <0.00%> (+1.72%)` | :arrow_up: |
   | ... and [492 
more](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=footer). 
Last update 
[a15026f...74f565d](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj opened a new pull request #7863: Improve authorization in GCP system tests

[GitBox]

mik-laj opened a new pull request #7863: Improve authorization in GCP system 
tests
URL: https://github.com/apache/airflow/pull/7863
 
 
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj opened a new pull request #7862: Improve setUp/tearDown in Cloud Firestore system test

[GitBox]

mik-laj opened a new pull request #7862: Improve setUp/tearDown in Cloud 
Firestore system test
URL: https://github.com/apache/airflow/pull/7862
 
 
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7786: Restore DaskExecutor tests

[GitBox]

kaxil commented on issue #7786: Restore DaskExecutor tests
URL: https://github.com/apache/airflow/pull/7786#issuecomment-603610022
 
 
   
https://github.com/apache/airflow/pull/7786/commits/d652062b19f0820a0ba5636ec2c4ff94f8aef9b3
 should fix another 2 tests.
   
   ```
   
tests/executors/test_dask_executor.py::TestDaskExecutor::test_backfill_integration
 FAILED 

 [ 25%]
   
tests/executors/test_dask_executor.py::TestDaskExecutor::test_dask_executor_functions
 PASSED 

  [ 50%]
   
tests/executors/test_dask_executor.py::TestDaskExecutorTLS::test_gauge_executor_metrics
 PASSED 

[ 75%]
   tests/executors/test_dask_executor.py::TestDaskExecutorTLS::test_tls PASSED  


  [100%]
   ```
   
   I got the following error while running the test related to backfill:
   
   **Error Log:**
   ```
   
---
 Captured stderr call 

   distributed.worker - WARNING -  Compute Failed
   Function:  airflow_run
   args:  ()
   kwargs:{}
   Exception: TypeError('expected str, bytes or os.PathLike object, not int',)
   
   distributed.worker - WARNING -  Compute Failed
   Function:  airflow_run
   args:  ()
   kwargs:{}
   Exception: TypeError('expected str, bytes or os.PathLike object, not int',)
   
   distributed.worker - WARNING -  Compute Failed
   Function:  airflow_run
   args:  ()
   kwargs:{}
   Exception: TypeError('expected str, bytes or os.PathLike object, not int',)
   
   distributed.worker - WARNING -  Compute Failed
   Function:  airflow_run
   args:  ()
   kwargs:{}
   Exception: TypeError('expected str, bytes or os.PathLike object, not int',)
   
   
-
 Captured log call 
--
   INFO airflow.models.dagbag.DagBag:dagbag.py:371 Filling up the DagBag 
from /opt/airflow/tests/dags
   INFO root:test_task_view_type_check.py:48 class_instance type: 
   INFO airflow.models.dagbag.DagBag:dagbag.py:269 File 
/opt/airflow/tests/dags/test_zip.zip assumed to contain no DAGs. Skipping.
   INFO airflow.executors.dask_executor.DaskExecutor:base_executor.py:75 
Adding to queue: ['airflow', 'tasks', 'run', 'example_bash_operator', 
'runme_0', '2017-01-01T00:00:00+00:00', '--pickle', 1, 
'--ignore-depends-on-past', '--local', '--pool', 'default_pool']
   INFO airflow.executors.dask_executor.DaskExecutor:base_executor.py:75 
Adding to queue: ['airflow', 'tasks', 'run', 'example_bash_operator', 
'runme_1', '2017-01-01T00:00:00+00:00', '--pickle', 1, 
'--ignore-depends-on-past', '--local', '--pool', 'default_pool']
   INFO airflow.executors.dask_executor.DaskExecutor:base_executor.py:75 
Adding to queue: ['airflow', 'tasks', 'run', 'example_bash_operator', 
'runme_2', '2017-01-01T00:00:00+00:00', '--pickle', 1, 
'--ignore-depends-on-past', '--local', '--pool', 'default_pool']
   INFO airflow.executors.dask_executor.DaskExecutor:base_executor.py:75 
Adding to queue: ['airflow', 'tasks', 'run', 'example_bash_operator', 
'also_run_this', '2017-01-01T00:00:00+00:00', '--pickle', 1, 
'--ignore-depends-on-past', '--local', '--pool', 'default_pool']
   INFO airflow.jobs.backfill_job.BackfillJob:backfill_job.py:379 [backfill 
progress] | finished run 0 of 1 | tasks waiting: 2 | succeeded: 0 | running: 4 
| failed: 0 | skipped: 0 | deadlocked: 0 | not ready: 2
   ERRORairflow.executors.dask_executor.DaskExecutor:dask_executor.py:86 
Failed to execute task: TypeError('expected str, bytes or os.PathLike object, 
not int',)
   ERRORairflow.executors.dask_executor.DaskExecutor:dask_executor.py:86 
Failed to execute task: TypeError('expected str, bytes or os.PathLike object, 
not int',)
   ERRORairflow.executors.dask_executor.DaskExecutor:dask_executor.py:86 
Failed to execute task: TypeError('expected str, bytes or os.PathLike object, 
not int',)
   ERRORairflow.executors.dask_executor.DaskExecutor:dask_executor.py:86 
Failed to execute task: TypeError('expected str, bytes or os.PathLike object, 

[GitHub] [airflow] kuromt commented on issue #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

[GitBox]

kuromt commented on issue #7365: [AIRFLOW-5221] add host_aliases to 
KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#issuecomment-603606530
 
 
   > @ashb as the config rewrite is down the road I'm good to merge this.
   
   Thanks!
   
   `pod_generator.py` is updated after my PR, so If I needed to rebase and 
commit again to merge this PR, please let me know.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-4453) none_failed trigger rule cascading skipped state to downstream tasks

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066328#comment-17066328
 ] 

ASF GitHub Bot commented on AIRFLOW-4453:
-

yuqian90 commented on pull request #7464: [AIRFLOW-4453] Make behavior of 
`none_failed` consistent with documentation
URL: https://github.com/apache/airflow/pull/7464
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> none_failed trigger rule cascading skipped state to downstream tasks
> 
>
> Key: AIRFLOW-4453
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4453
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: DAG, scheduler
>Affects Versions: 1.10.3, 1.10.4, 1.10.5, 1.10.6, 1.10.7
>Reporter: Dmytro Kulyk
>Assignee: Kaxil Naik
>Priority: Major
>  Labels: skipped
> Fix For: 1.10.5
>
> Attachments: 3_step.png, cube_update.py, 
> image-2019-05-02-18-11-28-307.png, simple_skip.png
>
>
> Task with trigger_rule = 'none_failed' cascading *skipped *status to 
> downstream task
>  * task have multiple upstream tasks
>  * trigger_rule set to 'none_failed'
>  * some of upstream tasks can be skipped due to *latest only*
> Basing on documentation this shouldn't happen
>  !image-2019-05-02-18-11-28-307.png|width=655,height=372! 
>  DAG attached



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-4453) none_failed trigger rule cascading skipped state to downstream tasks

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066329#comment-17066329
 ] 

ASF GitHub Bot commented on AIRFLOW-4453:
-

yuqian90 commented on pull request #7464: [AIRFLOW-4453] Make behavior of 
`none_failed` consistent with documentation
URL: https://github.com/apache/airflow/pull/7464
 
 
   This is to pick up the work started in 
https://github.com/apache/airflow/pull/7098. I discussed with @TV4Fun and 
opened this new PR to continue the work.
   
   - Make behavior of `none_failed` consistent with documentation. Do not skip 
itself when all parents are skipped.
   - Add `none_failed_or_skipped` which behaves like the old `none_failed` 
trigger rule (i.e. all parents are success or skipped and at least one parent 
is success). One use case of `none_failed_or_skipped` is the join task in a 
workflow with nested `BranchPythonOperator`
   ---
   Issue link: 
[AIRFLOW-4453](https://issues.apache.org/jira/browse/AIRFLOW-4453)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> none_failed trigger rule cascading skipped state to downstream tasks
> 
>
> Key: AIRFLOW-4453
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4453
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: DAG, scheduler
>Affects Versions: 1.10.3, 1.10.4, 1.10.5, 1.10.6, 1.10.7
>Reporter: Dmytro Kulyk
>Assignee: Kaxil Naik
>Priority: Major
>  Labels: skipped
> Fix For: 1.10.5
>
> Attachments: 3_step.png, cube_update.py, 
> image-2019-05-02-18-11-28-307.png, simple_skip.png
>
>
> Task with trigger_rule = 'none_failed' cascading *skipped *status to 
> downstream task
>  * task have multiple upstream tasks
>  * trigger_rule set to 'none_failed'
>  * some of upstream tasks can be skipped due to *latest only*
> Basing on documentation this shouldn't happen
>  !image-2019-05-02-18-11-28-307.png|width=655,height=372! 
>  DAG attached



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] yuqian90 opened a new pull request #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

[GitBox]

yuqian90 opened a new pull request #7464: [AIRFLOW-4453] Make behavior of 
`none_failed` consistent with documentation
URL: https://github.com/apache/airflow/pull/7464
 
 
   This is to pick up the work started in 
https://github.com/apache/airflow/pull/7098. I discussed with @TV4Fun and 
opened this new PR to continue the work.
   
   - Make behavior of `none_failed` consistent with documentation. Do not skip 
itself when all parents are skipped.
   - Add `none_failed_or_skipped` which behaves like the old `none_failed` 
trigger rule (i.e. all parents are success or skipped and at least one parent 
is success). One use case of `none_failed_or_skipped` is the join task in a 
workflow with nested `BranchPythonOperator`
   ---
   Issue link: 
[AIRFLOW-4453](https://issues.apache.org/jira/browse/AIRFLOW-4453)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-]`. AIRFLOW- = 
JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   * For document-only changes commit message can start with 
`[AIRFLOW-]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] yuqian90 closed pull request #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

[GitBox]

yuqian90 closed pull request #7464: [AIRFLOW-4453] Make behavior of 
`none_failed` consistent with documentation
URL: https://github.com/apache/airflow/pull/7464
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix

[GitBox]

codecov-io commented on issue #7861: [AIRFLOW-7108] Fix 
CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861#issuecomment-603603258
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7861?src=pr=h1) 
Report
   > Merging 
[#7861](https://codecov.io/gh/apache/airflow/pull/7861?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a15026fa1652bec839a03d3e33eebac1b79545ae=desc)
 will **increase** coverage by `21.15%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7861/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7861?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7861   +/-   ##
   ===
   + Coverage   65.44%   86.60%   +21.15% 
   ===
 Files 927  927   
 Lines   4496344972+9 
   ===
   + Hits2942538946 +9521 
   + Misses  15538 6026 -9512 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7861?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[.../providers/google/cloud/secrets/secrets\_manager.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL3NlY3JldHMvc2VjcmV0c19tYW5hZ2VyLnB5)
 | `100.00% <100.00%> (ø)` | |
   | 
[airflow/secrets/base\_secrets.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr=tree#diff-YWlyZmxvdy9zZWNyZXRzL2Jhc2Vfc2VjcmV0cy5weQ==)
 | `94.11% <100.00%> (ø)` | |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `47.18% <0.00%> (-39.44%)` | :arrow_down: |
   | 
[...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==)
 | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
   | 
[airflow/providers/google/cloud/operators/vision.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy92aXNpb24ucHk=)
 | `99.63% <0.00%> (+0.36%)` | :arrow_up: |
   | 
[...osoft/azure/operators/azure\_container\_instances.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L2F6dXJlL29wZXJhdG9ycy9henVyZV9jb250YWluZXJfaW5zdGFuY2VzLnB5)
 | `78.28% <0.00%> (+0.65%)` | :arrow_up: |
   | 
[airflow/cli/cli\_parser.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr=tree#diff-YWlyZmxvdy9jbGkvY2xpX3BhcnNlci5weQ==)
 | `98.13% <0.00%> (+0.93%)` | :arrow_up: |
   | ... and [492 
more](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7861?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7861?src=pr=footer). 
Last update 
[a15026f...a851519](https://codecov.io/gh/apache/airflow/pull/7861?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie removed a comment on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix

[GitBox]

zhongjiajie removed a comment on issue #7861: [AIRFLOW-7108] Fix 
CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861#issuecomment-603600912
 
 
   Should we add `[WIP]` in PR title avoid incorrect merge?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix

[GitBox]

zhongjiajie commented on issue #7861: [AIRFLOW-7108] Fix 
CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861#issuecomment-603600912
 
 
   Should we add `[WIP]` in PR title avoid incorrect merge?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix

[GitBox]

zhongjiajie commented on issue #7861: [AIRFLOW-7108] Fix 
CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861#issuecomment-603600903
 
 
   Should we add `[WIP]` in PR title avoid incorrect merge?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] xinbinhuang edited a comment on issue #7846: Standardize SecretBackend class names

[GitBox]

xinbinhuang edited a comment on issue #7846: Standardize SecretBackend class 
names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603593164
 
 
   > Options:
   > 
   > 1. `connections_path_prefix`
   > 2. `connections_prefix`
   > 3. `connections_path`
   > 
   > What do others think @potiuk @ashb
   
   Add a comment here to keep a record on what we discussed on Slack:
   
   - @kaxil and I agree on using `connections_prefix` because it is more 
generic than `path` and may apply to different systems better (GCP Secrets 
Manager does not support `/`, so `airflow/connections` is invalid.)  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] xinbinhuang commented on issue #7846: Standardize SecretBackend class names

[GitBox]

xinbinhuang commented on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603593164
 
 
   > Options:
   > 
   > 1. `connections_path_prefix`
   > 2. `connections_prefix`
   > 3. `connections_path`
   > 
   > What do others think @potiuk @ashb
   
   Add a comment here to keep a record on what we discussed on Slack:
   
   - we agree on using `connections_prefix` because it is more generic than 
`path` and may apply to different systems better (GCP Secrets Manager does not 
support `/`, so `airflow/connections` is invalid.)  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] xinbinhuang commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix

[GitBox]

xinbinhuang commented on issue #7861: [AIRFLOW-7108] Fix 
CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861#issuecomment-603591925
 
 
   Need to rebase after https://github.com/apache/airflow/pull/7861 is merged


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (AIRFLOW-7108) Fix CloudSecretsManagerBackend invalid connections_prefix

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066308#comment-17066308
 ] 

ASF GitHub Bot commented on AIRFLOW-7108:
-

xinbinhuang commented on pull request #7861: [AIRFLOW-7108] Fix 
CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861
 
 
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix CloudSecretsManagerBackend invalid connections_prefix
> -
>
> Key: AIRFLOW-7108
> URL: https://issues.apache.org/jira/browse/AIRFLOW-7108
> Project: Apache Airflow
>  Issue Type: Task
>  Components: security
>Affects Versions: 2.0.0, 1.10.10
>Reporter: Xinbin Huang
>Assignee: Xinbin Huang
>Priority: Major
>
> GCP Secrets Manager only accepts [a-zA-Z0-9-_]* as its valid secret id key. 
> This PR fix the implementation and add checks in constructor



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (AIRFLOW-7108) Fix CloudSecretsManagerBackend invalid connections_prefix

[Xinbin Huang (Jira)]

Xinbin Huang created AIRFLOW-7108:
-

 Summary: Fix CloudSecretsManagerBackend invalid connections_prefix
 Key: AIRFLOW-7108
 URL: https://issues.apache.org/jira/browse/AIRFLOW-7108
 Project: Apache Airflow
  Issue Type: Task
  Components: security
Affects Versions: 2.0.0, 1.10.10
Reporter: Xinbin Huang
Assignee: Xinbin Huang


GCP Secrets Manager only accepts [a-zA-Z0-9-_]* as its valid secret id key. 
This PR fix the implementation and add checks in constructor




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [airflow] xinbinhuang opened a new pull request #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix

[GitBox]

xinbinhuang opened a new pull request #7861: [AIRFLOW-7108] Fix 
CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861
 
 
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] j-y-matsubara commented on issue #7854: Add not solved items to pylint_todo.txt

[GitBox]

j-y-matsubara commented on issue #7854: Add not solved items to pylint_todo.txt
URL: https://github.com/apache/airflow/pull/7854#issuecomment-603579735
 
 
   @potiuk 
   OK, I understand. I will try it.
   
The reason I sent this pull request is because when I ran 
scripts/ci/ci_pylint_main.sh, these items  were marked as pylint errors. 
   
   Thank you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip

[GitBox]

codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph 
View tooltip
URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) 
Report
   > Merging 
[#7859](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7859/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7859  +/-   ##
   ==
   - Coverage   86.97%   86.96%   -0.01% 
   ==
 Files 927  927  
 Lines   4496344963  
   ==
   - Hits3910839104   -4 
   - Misses   5855 5859   +4 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=)
 | `93.05% <0.00%> (-1.39%)` | :arrow_down: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `90.44% <0.00%> (-0.44%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=footer). 
Last update 
[1982c3f...e68ed0c](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest

[GitBox]

codecov-io edited a comment on issue #7860: Improve setUp/tearDown in 
PrestoToGCSSystemTest
URL: https://github.com/apache/airflow/pull/7860#issuecomment-603573823
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=h1) 
Report
   > Merging 
[#7860](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `0.41%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7860/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7860  +/-   ##
   ==
   - Coverage   86.97%   86.56%   -0.42% 
   ==
 Files 927  927  
 Lines   4496344963  
   ==
   - Hits3910838922 -186 
   - Misses   5855 6041 +186 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==)
 | `39.28% <0.00%> (-60.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==)
 | `30.43% <0.00%> (-45.66%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | 
[...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==)
 | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `85.25% <0.00%> (-2.65%)` | :arrow_down: |
   | 
[airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5)
 | `83.11% <0.00%> (-2.60%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `90.14% <0.00%> (-1.98%)` | :arrow_down: |
   | ... and [3 
more](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=footer). 
Last update 
[1982c3f...eb206b5](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip

[GitBox]

codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph 
View tooltip
URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) 
Report
   > Merging 
[#7859](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7859/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7859  +/-   ##
   ==
   - Coverage   86.97%   86.82%   -0.15% 
   ==
 Files 927  927  
 Lines   4496344963  
   ==
   - Hits3910839041  -67 
   - Misses   5855 5922  +67 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==)
 | `39.28% <0.00%> (-60.72%)` | :arrow_down: |
   | 
[airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==)
 | `30.43% <0.00%> (-45.66%)` | :arrow_down: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `85.25% <0.00%> (-2.65%)` | :arrow_down: |
   | 
[airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5)
 | `83.11% <0.00%> (-2.60%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `90.14% <0.00%> (-1.98%)` | :arrow_down: |
   | 
[airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=)
 | `93.05% <0.00%> (-1.39%)` | :arrow_down: |
   | 
[airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5)
 | `91.66% <0.00%> (-0.84%)` | :arrow_down: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `90.30% <0.00%> (-0.58%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=footer). 
Last update 
[1982c3f...e68ed0c](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip

[GitBox]

codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph 
View tooltip
URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) 
Report
   > Merging 
[#7859](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7859/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7859  +/-   ##
   ==
   - Coverage   86.97%   86.82%   -0.15% 
   ==
 Files 927  927  
 Lines   4496344963  
   ==
   - Hits3910839041  -67 
   - Misses   5855 5922  +67 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==)
 | `39.28% <0.00%> (-60.72%)` | :arrow_down: |
   | 
[airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==)
 | `30.43% <0.00%> (-45.66%)` | :arrow_down: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `85.25% <0.00%> (-2.65%)` | :arrow_down: |
   | 
[airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5)
 | `83.11% <0.00%> (-2.60%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `90.14% <0.00%> (-1.98%)` | :arrow_down: |
   | 
[airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=)
 | `93.05% <0.00%> (-1.39%)` | :arrow_down: |
   | 
[airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5)
 | `91.66% <0.00%> (-0.84%)` | :arrow_down: |
   | 
[airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=)
 | `90.30% <0.00%> (-0.58%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=footer). 
Last update 
[1982c3f...e68ed0c](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip

[GitBox]

codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph 
View tooltip
URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) 
Report
   > Merging 
[#7859](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `0.41%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7859/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7859  +/-   ##
   ==
   - Coverage   86.97%   86.56%   -0.42% 
   ==
 Files 927  927  
 Lines   4496344963  
   ==
   - Hits3910838922 -186 
   - Misses   5855 6041 +186 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==)
 | `39.28% <0.00%> (-60.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==)
 | `30.43% <0.00%> (-45.66%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | 
[...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==)
 | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
   | 
[airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5)
 | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
   | 
[airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==)
 | `85.25% <0.00%> (-2.65%)` | :arrow_down: |
   | 
[airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5)
 | `83.11% <0.00%> (-2.60%)` | :arrow_down: |
   | 
[airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==)
 | `90.14% <0.00%> (-1.98%)` | :arrow_down: |
   | ... and [3 
more](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=footer). 
Last update 
[1982c3f...e68ed0c](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

[GitBox]

codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of 
`none_failed` consistent with documentation
URL: https://github.com/apache/airflow/pull/7464#issuecomment-603575203
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=h1) 
Report
   > Merging 
[#7464](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a15026fa1652bec839a03d3e33eebac1b79545ae=desc)
 will **decrease** coverage by `0.61%`.
   > The diff coverage is `72.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7464/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7464  +/-   ##
   ==
   - Coverage   65.44%   64.82%   -0.62% 
   ==
 Files 927  928   +1 
 Lines   4496344988  +25 
   ==
   - Hits2942529163 -262 
   - Misses  1553815825 +287 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100.00% <ø> (ø)` | |
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `67.96% <ø> (+0.41%)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/trigger\_rule\_dep.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvdHJpZ2dlcl9ydWxlX2RlcC5weQ==)
 | `19.04% <0.00%> (-1.74%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_nested\_branch\_dag.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9uZXN0ZWRfYnJhbmNoX2RhZy5weQ==)
 | `100.00% <100.00%> (ø)` | |
   | 
[airflow/utils/trigger\_rule.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy90cmlnZ2VyX3J1bGUucHk=)
 | `100.00% <100.00%> (ø)` | |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `28.16% <0.00%> (-58.46%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZC5weQ==)
 | `42.50% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/kubernetes/kube\_client.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL2t1YmVfY2xpZW50LnB5)
 | `37.14% <0.00%> (-40.00%)` | :arrow_down: |
   | ... and [9 
more](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=footer). 
Last update 
[a15026f...74f565d](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

[GitBox]

codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of 
`none_failed` consistent with documentation
URL: https://github.com/apache/airflow/pull/7464#issuecomment-603575203
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=h1) 
Report
   > Merging 
[#7464](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a15026fa1652bec839a03d3e33eebac1b79545ae=desc)
 will **decrease** coverage by `0.72%`.
   > The diff coverage is `72.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7464/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7464  +/-   ##
   ==
   - Coverage   65.44%   64.71%   -0.73% 
   ==
 Files 927  928   +1 
 Lines   4496344988  +25 
   ==
   - Hits2942529113 -312 
   - Misses  1553815875 +337 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100.00% <ø> (ø)` | |
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `67.96% <ø> (+0.41%)` | :arrow_up: |
   | 
[airflow/ti\_deps/deps/trigger\_rule\_dep.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvdHJpZ2dlcl9ydWxlX2RlcC5weQ==)
 | `19.04% <0.00%> (-1.74%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_nested\_branch\_dag.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9uZXN0ZWRfYnJhbmNoX2RhZy5weQ==)
 | `100.00% <100.00%> (ø)` | |
   | 
[airflow/utils/trigger\_rule.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy90cmlnZ2VyX3J1bGUucHk=)
 | `100.00% <100.00%> (ø)` | |
   | 
[...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=)
 | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `28.16% <0.00%> (-58.46%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZC5weQ==)
 | `42.50% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | ... and [13 
more](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=footer). 
Last update 
[a15026f...74f565d](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

[GitBox]

codecov-io edited a comment on issue #7464: [AIRFLOW-4453] Make behavior of 
`none_failed` consistent with documentation
URL: https://github.com/apache/airflow/pull/7464#issuecomment-603575203
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=h1) 
Report
   > Merging 
[#7464](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a15026fa1652bec839a03d3e33eebac1b79545ae=desc)
 will **decrease** coverage by `32.76%`.
   > The diff coverage is `72.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7464/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7464   +/-   ##
   ===
   - Coverage   65.44%   32.68%   -32.77% 
   ===
 Files 927  928+1 
 Lines   4496344988   +25 
   ===
   - Hits2942514703-14722 
   - Misses  1553830285+14747 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100.00% <ø> (ø)` | |
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `57.08% <ø> (-10.48%)` | :arrow_down: |
   | 
[airflow/ti\_deps/deps/trigger\_rule\_dep.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvdHJpZ2dlcl9ydWxlX2RlcC5weQ==)
 | `14.28% <0.00%> (-6.50%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_nested\_branch\_dag.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9uZXN0ZWRfYnJhbmNoX2RhZy5weQ==)
 | `100.00% <100.00%> (ø)` | |
   | 
[airflow/utils/trigger\_rule.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy90cmlnZ2VyX3J1bGUucHk=)
 | `100.00% <100.00%> (ø)` | |
   | 
[airflow/providers/microsoft/winrm/hooks/winrm.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L3dpbnJtL2hvb2tzL3dpbnJtLnB5)
 | `8.60% <0.00%> (-91.40%)` | :arrow_down: |
   | 
[airflow/providers/oracle/hooks/oracle.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvb3JhY2xlL2hvb2tzL29yYWNsZS5weQ==)
 | `9.40% <0.00%> (-86.33%)` | :arrow_down: |
   | 
[airflow/providers/apache/sqoop/hooks/sqoop.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3Nxb29wL2hvb2tzL3Nxb29wLnB5)
 | `11.46% <0.00%> (-84.08%)` | :arrow_down: |
   | 
[airflow/providers/apache/spark/hooks/spark\_jdbc.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX2pkYmMucHk=)
 | `10.34% <0.00%> (-81.61%)` | :arrow_down: |
   | 
[airflow/providers/slack/hooks/slack\_webhook.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc2xhY2svaG9va3Mvc2xhY2tfd2ViaG9vay5weQ==)
 | `16.66% <0.00%> (-79.17%)` | :arrow_down: |
   | ... and [355 
more](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=footer). 
Last update 
[a15026f...74f565d](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest

[GitBox]

codecov-io edited a comment on issue #7860: Improve setUp/tearDown in 
PrestoToGCSSystemTest
URL: https://github.com/apache/airflow/pull/7860#issuecomment-603573823
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=h1) 
Report
   > Merging 
[#7860](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `22.16%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7860/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7860   +/-   ##
   ===
   - Coverage   86.97%   64.81%   -22.17% 
   ===
 Files 927  927   
 Lines   4496344963   
   ===
   - Hits3910829143 -9965 
   - Misses   585515820 +9965 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mysql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9teXNxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/samba\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9zYW1iYV9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [493 
more](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=footer). 
Last update 
[1982c3f...eb206b5](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7464: [AIRFLOW-4453] Make behavior of `none_failed` consistent with documentation

[GitBox]

codecov-io commented on issue #7464: [AIRFLOW-4453] Make behavior of 
`none_failed` consistent with documentation
URL: https://github.com/apache/airflow/pull/7464#issuecomment-603575203
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=h1) 
Report
   > Merging 
[#7464](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/a15026fa1652bec839a03d3e33eebac1b79545ae=desc)
 will **decrease** coverage by `33.10%`.
   > The diff coverage is `72.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7464/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7464   +/-   ##
   ===
   - Coverage   65.44%   32.33%   -33.11% 
   ===
 Files 927  928+1 
 Lines   4496344988   +25 
   ===
   - Hits2942514546-14879 
   - Misses  1553830442+14904 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=)
 | `100.00% <ø> (ø)` | |
   | 
[airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5)
 | `57.08% <ø> (-10.48%)` | :arrow_down: |
   | 
[airflow/ti\_deps/deps/trigger\_rule\_dep.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvdHJpZ2dlcl9ydWxlX2RlcC5weQ==)
 | `14.28% <0.00%> (-6.50%)` | :arrow_down: |
   | 
[airflow/example\_dags/example\_nested\_branch\_dag.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9uZXN0ZWRfYnJhbmNoX2RhZy5weQ==)
 | `100.00% <100.00%> (ø)` | |
   | 
[airflow/utils/trigger\_rule.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy90cmlnZ2VyX3J1bGUucHk=)
 | `100.00% <100.00%> (ø)` | |
   | 
[airflow/providers/microsoft/winrm/hooks/winrm.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L3dpbnJtL2hvb2tzL3dpbnJtLnB5)
 | `8.60% <0.00%> (-91.40%)` | :arrow_down: |
   | 
[airflow/providers/oracle/hooks/oracle.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvb3JhY2xlL2hvb2tzL29yYWNsZS5weQ==)
 | `9.40% <0.00%> (-86.33%)` | :arrow_down: |
   | 
[airflow/providers/apache/sqoop/hooks/sqoop.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3Nxb29wL2hvb2tzL3Nxb29wLnB5)
 | `11.46% <0.00%> (-84.08%)` | :arrow_down: |
   | 
[airflow/providers/apache/spark/hooks/spark\_jdbc.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX2pkYmMucHk=)
 | `10.34% <0.00%> (-81.61%)` | :arrow_down: |
   | 
[airflow/providers/slack/hooks/slack\_webhook.py](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc2xhY2svaG9va3Mvc2xhY2tfd2ViaG9vay5weQ==)
 | `16.66% <0.00%> (-79.17%)` | :arrow_down: |
   | ... and [360 
more](https://codecov.io/gh/apache/airflow/pull/7464/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=footer). 
Last update 
[a15026f...74f565d](https://codecov.io/gh/apache/airflow/pull/7464?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest

[GitBox]

codecov-io edited a comment on issue #7860: Improve setUp/tearDown in 
PrestoToGCSSystemTest
URL: https://github.com/apache/airflow/pull/7860#issuecomment-603573823
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=h1) 
Report
   > Merging 
[#7860](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `22.27%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7860/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7860   +/-   ##
   ===
   - Coverage   86.97%   64.70%   -22.28% 
   ===
 Files 927  927   
 Lines   4496344963   
   ===
   - Hits3910829093-10015 
   - Misses   585515870+10015 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mysql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9teXNxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/samba\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9zYW1iYV9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [496 
more](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=footer). 
Last update 
[1982c3f...eb206b5](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest

[GitBox]

codecov-io edited a comment on issue #7860: Improve setUp/tearDown in 
PrestoToGCSSystemTest
URL: https://github.com/apache/airflow/pull/7860#issuecomment-603573823
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=h1) 
Report
   > Merging 
[#7860](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `54.32%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7860/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7860   +/-   ##
   ===
   - Coverage   86.97%   32.65%   -54.33% 
   ===
 Files 927  927   
 Lines   4496344963   
   ===
   - Hits3910814684-24424 
   - Misses   585530279+24424 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mysql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9teXNxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/samba\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9zYW1iYV9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [792 
more](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=footer). 
Last update 
[1982c3f...eb206b5](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7860: Improve setUp/tearDown in PrestoToGCSSystemTest

[GitBox]

codecov-io commented on issue #7860: Improve setUp/tearDown in 
PrestoToGCSSystemTest
URL: https://github.com/apache/airflow/pull/7860#issuecomment-603573823
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=h1) 
Report
   > Merging 
[#7860](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `54.34%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7860/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7860   +/-   ##
   ===
   - Coverage   86.97%   32.62%   -54.35% 
   ===
 Files 927  927   
 Lines   4496344963   
   ===
   - Hits3910814671-24437 
   - Misses   585530292+24437 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mysql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9teXNxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/samba\_hook.py](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9zYW1iYV9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [793 
more](https://codecov.io/gh/apache/airflow/pull/7860/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=footer). 
Last update 
[1982c3f...eb206b5](https://codecov.io/gh/apache/airflow/pull/7860?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397541486
 
 

 ##
 File path: scripts/ci/docker-compose/base.yml
 ##
 @@ -59,6 +59,8 @@ services:
   - DB_RESET
   - ENABLED_SYSTEMS
   - RUN_SYSTEM_TESTS
+  - DEFAULT_PYTHON_SHORT_VERSION
+  - PYTHON_SHORT_VERSION
 
 Review comment:
   Do we need both? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip

[GitBox]

codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph 
View tooltip
URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) 
Report
   > Merging 
[#7859](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `22.16%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7859/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7859   +/-   ##
   ===
   - Coverage   86.97%   64.81%   -22.17% 
   ===
 Files 927  927   
 Lines   4496344963   
   ===
   - Hits3910829143 -9965 
   - Misses   585515820 +9965 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mysql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9teXNxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/samba\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9zYW1iYV9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [493 
more](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=footer). 
Last update 
[1982c3f...e68ed0c](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip

[GitBox]

codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph 
View tooltip
URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) 
Report
   > Merging 
[#7859](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `22.27%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7859/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7859   +/-   ##
   ===
   - Coverage   86.97%   64.70%   -22.28% 
   ===
 Files 927  927   
 Lines   4496344963   
   ===
   - Hits3910829093-10015 
   - Misses   585515870+10015 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mysql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9teXNxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/samba\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9zYW1iYV9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [496 
more](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=footer). 
Last update 
[1982c3f...e68ed0c](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph View tooltip

[GitBox]

codecov-io edited a comment on issue #7859: BugFix: Show task_id in the Graph 
View tooltip
URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) 
Report
   > Merging 
[#7859](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `54.32%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7859/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7859   +/-   ##
   ===
   - Coverage   86.97%   32.65%   -54.33% 
   ===
 Files 927  927   
 Lines   4496344963   
   ===
   - Hits3910814683-24425 
   - Misses   585530280+24425 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mysql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9teXNxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/samba\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9zYW1iYV9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [792 
more](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=footer). 
Last update 
[1982c3f...e68ed0c](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397540533
 
 

 ##
 File path: scripts/ci/_utils.sh
 ##
 @@ -530,7 +531,7 @@ function confirm_image_rebuild() {
 # Make sure to use /dev/tty first rather than stdin/stdout when 
available - this way confirm
 # will works also in case of pre-commits (git does not pass 
stdin/stdout to pre-commit hooks)
 # shellcheck disable=SC2094
-"${AIRFLOW_SOURCES}/confirm" "${ACTION} image ${THE_IMAGE_TYPE} (might 
take some time)" \
+"${AIRFLOW_SOURCES}/confirm" "${ACTION} image 
${THE_IMAGE_TYPE}-${PYTHON_SHORT_VERSION}" \
 
 Review comment:
   ```suggestion
   "${AIRFLOW_SOURCES}/confirm" "${ACTION} image 
${THE_IMAGE_TYPE}-python ${PYTHON_SHORT_VERSION}" \
   ```
   
   ?? not sure


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

mik-laj commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397540234
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
 Review comment:
   ```suggestion
   as of Airflow 1.10.10.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7859: BugFix: Show task_id in the Graph View tooltip

[GitBox]

codecov-io commented on issue #7859: BugFix: Show task_id in the Graph View 
tooltip
URL: https://github.com/apache/airflow/pull/7859#issuecomment-603572413
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=h1) 
Report
   > Merging 
[#7859](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `54.67%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7859/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7859   +/-   ##
   ===
   - Coverage   86.97%   32.30%   -54.68% 
   ===
 Files 927  927   
 Lines   4496344963   
   ===
   - Hits3910814526-24582 
   - Misses   585530437+24582 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mysql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9teXNxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/samba\_hook.py](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9zYW1iYV9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [794 
more](https://codecov.io/gh/apache/airflow/pull/7859/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=footer). 
Last update 
[1982c3f...e68ed0c](https://codecov.io/gh/apache/airflow/pull/7859?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397539382
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
+requirement versions. Those requirement.txt files can be used as constraints 
file when installing apache
+airflow - either from the sources ``pip install -e . --constraint 
requirements/requirements-python3.7.txt``
+or from the pypi package ``pip install apache-airflow --constraint 
requirements/requirements-python3.7.txt``.
+This work also with extras - ``pip install .[gcp] --constraint 
requirements/requirements-python3.7.txt``.
+It is also possible to use constraints directly from github (note that it only 
works starting from
+airflow 1.10.10 version:
 
-If you do not use pre-commits and the CI builds fails / you need to regenerate 
it, you can do it manually:
-``pre-commit run generate-requirements --all-files`` or via script
-``./scripts/ci/ci_generate_requirements.sh``.
-This will try to regenerate the requirements.txt file with the latest 
requirements matching
-the setup.py constraints.
+.. code-block:: bash
+
+  pip install apache-airflow[gcp]==1.10.10 \
+  --constraint 
https://raw.githubusercontent.com/apache/airflow/1.10.10/requirements/requirements-python3.7.txt
+
+There are different set of fixed requirements for different python major/minor 
versions and you should
+use the right python version file for the right python version.
+
+The ``requirements-python.txt`` file MUST be regenerated 
every time after setup.py
+is updated. This is checked automatically in Travis CI build there are 
separate jobs for each
+python version that checks if the requirements should be updated.
+
+If they are not you should regenerate the requirements locally using one of 
the methods described below.
+
+Generating requirement files
+
+
+This shuould be done every time after you modify setup.py file. You can 
generate requirement files
 
 Review comment:
   ```suggestion
   This should be done every time after you modify setup.py file. You can 
generate requirement files
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache 

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397539036
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
+requirement versions. Those requirement.txt files can be used as constraints 
file when installing apache
+airflow - either from the sources ``pip install -e . --constraint 
requirements/requirements-python3.7.txt``
+or from the pypi package ``pip install apache-airflow --constraint 
requirements/requirements-python3.7.txt``.
+This work also with extras - ``pip install .[gcp] --constraint 
requirements/requirements-python3.7.txt``.
+It is also possible to use constraints directly from github (note that it only 
works starting from
+airflow 1.10.10 version:
 
-If you do not use pre-commits and the CI builds fails / you need to regenerate 
it, you can do it manually:
-``pre-commit run generate-requirements --all-files`` or via script
-``./scripts/ci/ci_generate_requirements.sh``.
-This will try to regenerate the requirements.txt file with the latest 
requirements matching
-the setup.py constraints.
+.. code-block:: bash
+
+  pip install apache-airflow[gcp]==1.10.10 \
+  --constraint 
https://raw.githubusercontent.com/apache/airflow/1.10.10/requirements/requirements-python3.7.txt
+
+There are different set of fixed requirements for different python major/minor 
versions and you should
+use the right python version file for the right python version.
 
 Review comment:
   ```suggestion
   use the right requirements file for the right python version.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397539315
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
+requirement versions. Those requirement.txt files can be used as constraints 
file when installing apache
+airflow - either from the sources ``pip install -e . --constraint 
requirements/requirements-python3.7.txt``
+or from the pypi package ``pip install apache-airflow --constraint 
requirements/requirements-python3.7.txt``.
+This work also with extras - ``pip install .[gcp] --constraint 
requirements/requirements-python3.7.txt``.
+It is also possible to use constraints directly from github (note that it only 
works starting from
+airflow 1.10.10 version:
 
-If you do not use pre-commits and the CI builds fails / you need to regenerate 
it, you can do it manually:
-``pre-commit run generate-requirements --all-files`` or via script
-``./scripts/ci/ci_generate_requirements.sh``.
-This will try to regenerate the requirements.txt file with the latest 
requirements matching
-the setup.py constraints.
+.. code-block:: bash
+
+  pip install apache-airflow[gcp]==1.10.10 \
+  --constraint 
https://raw.githubusercontent.com/apache/airflow/1.10.10/requirements/requirements-python3.7.txt
+
+There are different set of fixed requirements for different python major/minor 
versions and you should
+use the right python version file for the right python version.
+
+The ``requirements-python.txt`` file MUST be regenerated 
every time after setup.py
+is updated. This is checked automatically in Travis CI build there are 
separate jobs for each
+python version that checks if the requirements should be updated.
+
+If they are not you should regenerate the requirements locally using one of 
the methods described below.
 
 Review comment:
   ```suggestion
   If they are not updated, you should regenerate the requirements locally 
using one of the methods described below.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397539204
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
+requirement versions. Those requirement.txt files can be used as constraints 
file when installing apache
+airflow - either from the sources ``pip install -e . --constraint 
requirements/requirements-python3.7.txt``
+or from the pypi package ``pip install apache-airflow --constraint 
requirements/requirements-python3.7.txt``.
+This work also with extras - ``pip install .[gcp] --constraint 
requirements/requirements-python3.7.txt``.
+It is also possible to use constraints directly from github (note that it only 
works starting from
+airflow 1.10.10 version:
 
-If you do not use pre-commits and the CI builds fails / you need to regenerate 
it, you can do it manually:
-``pre-commit run generate-requirements --all-files`` or via script
-``./scripts/ci/ci_generate_requirements.sh``.
-This will try to regenerate the requirements.txt file with the latest 
requirements matching
-the setup.py constraints.
+.. code-block:: bash
+
+  pip install apache-airflow[gcp]==1.10.10 \
+  --constraint 
https://raw.githubusercontent.com/apache/airflow/1.10.10/requirements/requirements-python3.7.txt
+
+There are different set of fixed requirements for different python major/minor 
versions and you should
+use the right python version file for the right python version.
+
+The ``requirements-python.txt`` file MUST be regenerated 
every time after setup.py
+is updated. This is checked automatically in Travis CI build there are 
separate jobs for each
 
 Review comment:
   ```suggestion
   is updated. This is checked automatically in Travis CI build. There are 
separate jobs for each
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397539097
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
+requirement versions. Those requirement.txt files can be used as constraints 
file when installing apache
+airflow - either from the sources ``pip install -e . --constraint 
requirements/requirements-python3.7.txt``
+or from the pypi package ``pip install apache-airflow --constraint 
requirements/requirements-python3.7.txt``.
+This work also with extras - ``pip install .[gcp] --constraint 
requirements/requirements-python3.7.txt``.
+It is also possible to use constraints directly from github (note that it only 
works starting from
+airflow 1.10.10 version:
 
-If you do not use pre-commits and the CI builds fails / you need to regenerate 
it, you can do it manually:
-``pre-commit run generate-requirements --all-files`` or via script
-``./scripts/ci/ci_generate_requirements.sh``.
-This will try to regenerate the requirements.txt file with the latest 
requirements matching
-the setup.py constraints.
+.. code-block:: bash
+
+  pip install apache-airflow[gcp]==1.10.10 \
+  --constraint 
https://raw.githubusercontent.com/apache/airflow/1.10.10/requirements/requirements-python3.7.txt
+
+There are different set of fixed requirements for different python major/minor 
versions and you should
+use the right python version file for the right python version.
+
+The ``requirements-python.txt`` file MUST be regenerated 
every time after setup.py
 
 Review comment:
   ```suggestion
   The ``requirements-python.txt`` file MUST be 
regenerated every time after ``setup.py``
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397538762
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
+requirement versions. Those requirement.txt files can be used as constraints 
file when installing apache
+airflow - either from the sources ``pip install -e . --constraint 
requirements/requirements-python3.7.txt``
+or from the pypi package ``pip install apache-airflow --constraint 
requirements/requirements-python3.7.txt``.
+This work also with extras - ``pip install .[gcp] --constraint 
requirements/requirements-python3.7.txt``.
 
 Review comment:
   ```suggestion
   This also works with extras - ``pip install .[gcp] --constraint 
requirements/requirements-python3.7.txt``.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397538872
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
+requirement versions. Those requirement.txt files can be used as constraints 
file when installing apache
+airflow - either from the sources ``pip install -e . --constraint 
requirements/requirements-python3.7.txt``
+or from the pypi package ``pip install apache-airflow --constraint 
requirements/requirements-python3.7.txt``.
+This work also with extras - ``pip install .[gcp] --constraint 
requirements/requirements-python3.7.txt``.
+It is also possible to use constraints directly from github (note that it only 
works starting from
+airflow 1.10.10 version:
 
 Review comment:
   ```suggestion
   Airflow 1.10.10 version:
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397538375
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
 
 Review comment:
   ```suggestion
   automatically and committed in the requirements folder based on the set of 
all the latest working and tested
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397538596
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
+requirement versions. Those requirement.txt files can be used as constraints 
file when installing apache
 
 Review comment:
   ```suggestion
   requirement versions. Those ``requirements.txt`` files can be used as 
constraints file when installing apache
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397538375
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
+automatically and committd in the requirements folder based on the set of all 
latest working and tested
 
 Review comment:
   ```suggestion
   automatically and committed in the requirements folder based on the set of 
all latest working and tested
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397538278
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
 
 Review comment:
   ```suggestion
   However we now have ``requirements-python.txt`` file 
generated
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397538133
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
 
 Review comment:
   ```suggestion
   still allowing the apache-airflow package to install. This means that 
'apache-airflow' package might fail to
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397538278
 
 

 ##
 File path: CONTRIBUTING.rst
 ##
 @@ -341,31 +341,59 @@ be open to allow several different libraries with the 
same requirements to be in
 The problem is that Apache Airflow is a bit of both - application to install 
and library to be used when
 you are developing your own operators and DAGs.
 
-This - seemingly unsolvable - puzzle is solved as follows:
+This - seemingly unsolvable - puzzle is solved by having pinned requirement 
files. Those are available
+as of airflow 1.10.10.
 
-* by default when you install ``apache-airflow`` package - the dependencies 
are as open as possible while
-  still allowing the apache-airflow to install. This means that 
'apache-airflow' package might fail to
-  install in case a direct or transitive dependency is released that breaks 
the installation. In such case
-  when installing ``apache-airflow``, you might need to provide additional 
constraints (for
-  example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
+Pinned requirement files
+
 
-* we have ``requirements.txt`` file generated automatically based on the set 
of all latest working
-  and tested requirement versions. You can also use that file as a constraints 
file when installing
-  apache airflow - either from the sources ``pip install -e . --constraint 
requirements.txt`` or
-  from the pypi package ``pip install apache-airflow --constraint 
requirements.txt``. Note that
-  this will also work with extras for example ``pip install .[gcp] 
--constraint requirements.txt`` or
-  ``pip install apache-airflow[gcp] --constraint requirements.txt``
+By default when you install ``apache-airflow`` package - the dependencies are 
as open as possible while
+still allowing the apache-airflow to install. This means that 'apache-airflow' 
package might fail to
+install in case a direct or transitive dependency is released that breaks the 
installation. In such case
+when installing ``apache-airflow``, you might need to provide additional 
constraints (for
+example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
-The ``requirements.txt`` file should be updated automatically via pre-commit 
whenever you update dependencies
-It reflects the current set of dependencies installed in the CI image of 
Apache Airflow.
-The same set of requirements will be used to produce the production image.
+However we now havehave ``requirements-python.txt`` file 
generated
 
 Review comment:
   ```suggestion
   However, we now have ``requirements-python.txt`` file 
generated
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

mik-laj commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397538396
 
 

 ##
 File path: .travis.yml
 ##
 @@ -41,24 +41,24 @@ jobs:
   stage: pre-test
   script: ./scripts/ci/ci_run_all_static_checks.sh
   env: >-
-PYTHON_VERSION=3.6
+PYTHON_SHORT_VERSION=3.6
 
 Review comment:
   What do you think about renaming to ``PYTHON_MINOR_VERSION``?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7841: Requirements now depend on python version

[GitBox]

kaxil commented on a change in pull request #7841: Requirements now depend on 
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397537666
 
 

 ##
 File path: .travis.yml
 ##
 @@ -41,24 +41,24 @@ jobs:
   stage: pre-test
   script: ./scripts/ci/ci_run_all_static_checks.sh
   env: >-
-PYTHON_VERSION=3.6
+PYTHON_SHORT_VERSION=3.6
 
 Review comment:
   Sounds good


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj opened a new pull request #7860: Improve setUp/tearDown in PrestoToGCSSystemTest

[GitBox]

mik-laj opened a new pull request #7860: Improve setUp/tearDown in 
PrestoToGCSSystemTest
URL: https://github.com/apache/airflow/pull/7860
 
 
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil opened a new pull request #7859: BugFix: Show task_id in the Graph View tooltip

[GitBox]

kaxil opened a new pull request #7859: BugFix: Show task_id in the Graph View 
tooltip
URL: https://github.com/apache/airflow/pull/7859
 
 
   I am not sure how to add a test for this as the Tooltip is generated using 
jQuery
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names

[GitBox]

kaxil commented on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603557518
 
 
   > For some context, this is a snapshot of the `parameter store` service. So 
I feel like better to still have the `ParameterStore` part
   > 
   > 
![image](https://user-images.githubusercontent.com/27927454/77485455-6e635580-6dea-11ea-8ce8-a58920c62264.png)
   
   Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] xinbinhuang commented on issue #7846: Standardize SecretBackend class names

[GitBox]

xinbinhuang commented on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603553216
 
 
   For some context, this is a snapshot of the `parameter store` service. So I 
feel like better to still have the `ParameterStore` part
   
   
![image](https://user-images.githubusercontent.com/27927454/77485455-6e635580-6dea-11ea-8ce8-a58920c62264.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil edited a comment on issue #7846: Standardize SecretBackend class names

[GitBox]

kaxil edited a comment on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603547473
 
 
   `SystemsManagerParametersBackend` stripping AWS as we don't use GCP or 
Hashicorp in their respective backends too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names

[GitBox]

kaxil commented on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603547473
 
 
   `SystemManagerParametersBackend` stripping AWS as we don't use GCP or 
Hashicorp in their respective backends too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] sharmaTanmay opened a new issue #7858: ShortCircuitOperator Ignoring Trigger Rules for Downstream Task and Skipping all Tasks

[GitBox]

sharmaTanmay opened a new issue #7858: ShortCircuitOperator Ignoring Trigger 
Rules for Downstream Task and Skipping all Tasks
URL: https://github.com/apache/airflow/issues/7858
 
 
   
   
   
   
   **Apache Airflow version**: 1.10.3
   
   **What happened**: I'm trying to use a ShortCircuitOperator with a two 
downstream tasks, one of which has a `trigger_rule` set as `all_done`. But 
despite the trigger_rule, both of these tasks are getting skipped. As per 
documentation,  skipped tasks should not cascade through with a `trigger_rule` 
set as `all_done`. 
https://airflow.apache.org/docs/stable/concepts.html?highlight=trigger
   
   **What you expected to happen**: That the task with `trigger_rule` should 
execute the piece of code inside it.
   
   **How to reproduce it**:
   
   from airflow import DAG
   from airflow.operators.python_operator import PythonOperator, 
ShortCircuitOperator
   
   dag = DAG(
   dag_id='dag_name',
   orientation="LR",
   schedule_interval=None,
   )
   
   def shortcircuit_func(**context):
   return False
   
   
   shortcircuit = ShortCircuitOperator(
   task_id='shortcircuit',
   dag=dag,
   python_callable=shortcircuit_func
   )
   
   
   def task1_func():
   print("hello world")
   
   
   task1 = PythonOperator(
   task_id='task1',
   dag=dag,
   python_callable=task1_func
   )
   
   def task3_func():
   for x in range(10):
   print("ALL DONE", x)
   
   
   task3 = PythonOperator(
   task_id='task3',
   dag=dag,
   python_callable=task3_func,
   trigger_rule='all_done',
   depends_on_past=True
   )
   
   
   def task2_func():
   print("task2_func")
   
   
   task2 = PythonOperator(
   task_id='task2',
   dag=dag,
   python_callable=task2_func,
   )
   
   task1 >> shortcircuit >> task2 >> task3


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #7846: Standardize SecretBackend class names

[GitBox]

ashb commented on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603546886
 
 
   I think the "Store" part is not needed, so AwsSMParametersBackend, 
AwsSystemManagerParametersBackend or soemthing like that, or perhaps 
AwsSSMParametersBackend.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #7846: Standardize SecretBackend class names

[GitBox]

ashb commented on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603546227
 
 
   
https://docs.aws.amazon.com/systems-manager/latest/userguide/what-is-systems-manager.html
   
   > *Systems Manager Service Name History*
   >
   >  AWS Systems Manager (Systems Manager) was formerly known as " Amazon 
Simple Systems Manager (SSM) " and " Amazon EC2 Systems Manager (SSM) ". The 
original abbreviated name of the service, " SSM ", is still reflected in 
various AWS resources, including a few other service consoles. Some examples:
   >
   >Systems Manager Agent: SSM Agent
   >
   >Systems Manager parameters: SSM parameters
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil edited a comment on issue #7846: Standardize SecretBackend class names

[GitBox]

kaxil edited a comment on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603545674
 
 
   `AwsSystemsManagerParameterStoreBackend` wow that name would be huge
   
   `SystemsManagerParameterStoreBackend` ? We can remove `aws` as it is in 
module_path and `providers` path too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names

[GitBox]

kaxil commented on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603545674
 
 
   `AwsSystemsManagerParameterStoreBackend` wow that name would be huge
   
   `AwsSMParameterStoreBackend` ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names

[GitBox]

kaxil commented on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603545387
 
 
   > I think SecretsManager may be something else. Go AWS!
   
   臘‍♂ I am confused. WTH!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #7846: Standardize SecretBackend class names

[GitBox]

ashb commented on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603545231
 
 
   I think SecretsManager may be something else. Go AWS!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #7846: Standardize SecretBackend class names

[GitBox]

ashb commented on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603544999
 
 
   In fact it seems that "SSM" is the "Systems Manager Agent" 
https://docs.aws.amazon.com/systems-manager/latest/userguide/ssm-agent.html.
   
   The full product name of the feature we are using is the AWS Systems Manager 
Parameter Store.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil edited a comment on issue #7846: Standardize SecretBackend class names

[GitBox]

kaxil edited a comment on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603544562
 
 
   > Aws SSM
   
   How about `AwsSecretsManager`? (Based on 
https://docs.aws.amazon.com/secretsmanager/latest/userguide/intro.html)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names

[GitBox]

kaxil commented on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603544562
 
 
   > Aws SSM
   
   How about `AwdSecretsManager`? (Based on 
https://docs.aws.amazon.com/secretsmanager/latest/userguide/intro.html)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #7846: Standardize SecretBackend class names

[GitBox]

ashb commented on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603543950
 
 
   Aws SSM is a suite of tools/products so calling it AwsSSMBackend is too 
generic. AwsSSMParameterStoreBackend (though it's too long a name)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7846: Standardize SecretBackend class names

[GitBox]

kaxil commented on issue #7846: Standardize SecretBackend class names
URL: https://github.com/apache/airflow/pull/7846#issuecomment-603543023
 
 
   Options:
   
   1. `connections_path_prefix`
   2. `connections_prefix`
   3. `connections_path`
   
   What do others think @potiuk @ashb 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil merged pull request #7851: Bump Boto3 to >=1.12

[GitBox]

kaxil merged pull request #7851: Bump Boto3 to >=1.12
URL: https://github.com/apache/airflow/pull/7851
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7405: [AIRFLOW-6780] Add option to use args instead of command in K8s pod spec

[GitBox]

codecov-io edited a comment on issue #7405: [AIRFLOW-6780] Add option to use 
args instead of command in K8s pod spec
URL: https://github.com/apache/airflow/pull/7405#issuecomment-603534537
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=h1) 
Report
   > Merging 
[#7405](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `0.64%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7405/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7405  +/-   ##
   ==
   - Coverage   86.97%   86.33%   -0.65% 
   ==
 Files 927  927  
 Lines   4496344968   +5 
   ==
   - Hits3910838821 -287 
   - Misses   5855 6147 +292 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==)
 | `56.96% <100.00%> (+0.08%)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=)
 | `96.58% <100.00%> (+0.06%)` | :arrow_up: |
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5)
 | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | 
[airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=)
 | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
   | ... and [7 
more](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=footer). 
Last update 
[1982c3f...80ab7a8](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7401: [AIRFLOW-6778] Add a configurable DAGs volume mount path for Kubernetes

[GitBox]

codecov-io edited a comment on issue #7401: [AIRFLOW-6778] Add a configurable 
DAGs volume mount path for Kubernetes
URL: https://github.com/apache/airflow/pull/7401#issuecomment-603533965
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=h1) 
Report
   > Merging 
[#7401](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `0.58%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7401/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7401  +/-   ##
   ==
   - Coverage   86.97%   86.39%   -0.59% 
   ==
 Files 927  927  
 Lines   4496344966   +3 
   ==
   - Hits3910838848 -260 
   - Misses   5855 6118 +263 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==)
 | `56.96% <100.00%> (+0.08%)` | :arrow_up: |
   | 
[airflow/kubernetes/worker\_configuration.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3dvcmtlcl9jb25maWd1cmF0aW9uLnB5)
 | `99.31% <100.00%> (+<0.01%)` | :arrow_up: |
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | 
[airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==)
 | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | 
[airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=)
 | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
   | 
[airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5)
 | `50.67% <0.00%> (-37.84%)` | :arrow_down: |
   | ... and [7 
more](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=footer). 
Last update 
[1982c3f...4fafd52](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7405: [AIRFLOW-6780] Add option to use args instead of command in K8s pod spec

[GitBox]

codecov-io edited a comment on issue #7405: [AIRFLOW-6780] Add option to use 
args instead of command in K8s pod spec
URL: https://github.com/apache/airflow/pull/7405#issuecomment-603534537
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=h1) 
Report
   > Merging 
[#7405](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `0.78%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7405/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7405  +/-   ##
   ==
   - Coverage   86.97%   86.19%   -0.79% 
   ==
 Files 927  927  
 Lines   4496344968   +5 
   ==
   - Hits3910838760 -348 
   - Misses   5855 6208 +353 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==)
 | `56.96% <100.00%> (+0.08%)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=)
 | `96.58% <100.00%> (+0.06%)` | :arrow_up: |
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=)
 | `28.16% <0.00%> (-54.93%)` | :arrow_down: |
   | 
[airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5)
 | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | 
[airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==)
 | `30.43% <0.00%> (-45.66%)` | :arrow_down: |
   | ... and [10 
more](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=footer). 
Last update 
[1982c3f...80ab7a8](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7405: [AIRFLOW-6780] Add option to use args instead of command in K8s pod spec

[GitBox]

codecov-io edited a comment on issue #7405: [AIRFLOW-6780] Add option to use 
args instead of command in K8s pod spec
URL: https://github.com/apache/airflow/pull/7405#issuecomment-603534537
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=h1) 
Report
   > Merging 
[#7405](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `0.89%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7405/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7405  +/-   ##
   ==
   - Coverage   86.97%   86.08%   -0.90% 
   ==
 Files 927  927  
 Lines   4496344968   +5 
   ==
   - Hits3910838712 -396 
   - Misses   5855 6256 +401 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==)
 | `56.96% <100.00%> (+0.08%)` | :arrow_up: |
   | 
[airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=)
 | `96.58% <100.00%> (+0.06%)` | :arrow_up: |
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | 
[airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==)
 | `39.28% <0.00%> (-60.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=)
 | `28.16% <0.00%> (-54.93%)` | :arrow_down: |
   | 
[airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5)
 | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | ... and [15 
more](https://codecov.io/gh/apache/airflow/pull/7405/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=footer). 
Last update 
[1982c3f...80ab7a8](https://codecov.io/gh/apache/airflow/pull/7405?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7401: [AIRFLOW-6778] Add a configurable DAGs volume mount path for Kubernetes

[GitBox]

codecov-io edited a comment on issue #7401: [AIRFLOW-6778] Add a configurable 
DAGs volume mount path for Kubernetes
URL: https://github.com/apache/airflow/pull/7401#issuecomment-603533965
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=h1) 
Report
   > Merging 
[#7401](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `0.80%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7401/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#7401  +/-   ##
   ==
   - Coverage   86.97%   86.16%   -0.81% 
   ==
 Files 927  927  
 Lines   4496344966   +3 
   ==
   - Hits3910838747 -361 
   - Misses   5855 6219 +364 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==)
 | `56.96% <100.00%> (+0.08%)` | :arrow_up: |
   | 
[airflow/kubernetes/worker\_configuration.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3dvcmtlcl9jb25maWd1cmF0aW9uLnB5)
 | `99.31% <100.00%> (+<0.01%)` | :arrow_up: |
   | 
[...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=)
 | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | 
[airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==)
 | `39.28% <0.00%> (-60.72%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==)
 | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | 
[airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=)
 | `28.16% <0.00%> (-54.93%)` | :arrow_down: |
   | 
[airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=)
 | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==)
 | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | 
[airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==)
 | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | 
[airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==)
 | `30.43% <0.00%> (-45.66%)` | :arrow_down: |
   | ... and [13 
more](https://codecov.io/gh/apache/airflow/pull/7401/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=footer). 
Last update 
[1982c3f...4fafd52](https://codecov.io/gh/apache/airflow/pull/7401?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes

[GitBox]

codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to 
specify additional K8s volumes
URL: https://github.com/apache/airflow/pull/7423#issuecomment-586568480
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=h1) 
Report
   > Merging 
[#7423](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `22.22%`.
   > The diff coverage is `4.34%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7423/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7423   +/-   ##
   ===
   - Coverage   86.97%   64.75%   -22.23% 
   ===
 Files 927  927   
 Lines   4496345009   +46 
   ===
   - Hits3910829145 -9963 
   - Misses   585515864+10009 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/kubernetes/worker\_configuration.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3dvcmtlcl9jb25maWd1cmF0aW9uLnB5)
 | `16.88% <0.00%> (-82.43%)` | :arrow_down: |
   | 
[airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==)
 | `16.27% <5.55%> (-40.60%)` | :arrow_down: |
   | 
[airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [495 
more](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=footer). 
Last update 
[1982c3f...2aa2c86](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes

[GitBox]

codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to 
specify additional K8s volumes
URL: https://github.com/apache/airflow/pull/7423#issuecomment-586568480
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=h1) 
Report
   > Merging 
[#7423](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `22.33%`.
   > The diff coverage is `4.34%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7423/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7423   +/-   ##
   ===
   - Coverage   86.97%   64.64%   -22.34% 
   ===
 Files 927  927   
 Lines   4496345009   +46 
   ===
   - Hits3910829095-10013 
   - Misses   585515914+10059 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/kubernetes/worker\_configuration.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3dvcmtlcl9jb25maWd1cmF0aW9uLnB5)
 | `16.88% <0.00%> (-82.43%)` | :arrow_down: |
   | 
[airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==)
 | `16.27% <5.55%> (-40.60%)` | :arrow_down: |
   | 
[airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [498 
more](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=footer). 
Last update 
[1982c3f...2aa2c86](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to specify additional K8s volumes

[GitBox]

codecov-io edited a comment on issue #7423: [AIRFLOW-3126] Add option to 
specify additional K8s volumes
URL: https://github.com/apache/airflow/pull/7423#issuecomment-586568480
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=h1) 
Report
   > Merging 
[#7423](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=desc) into 
[master](https://codecov.io/gh/apache/airflow/commit/1982c3fdca1f04cfc41fc5b5e285d8f01c6b76ab=desc)
 will **decrease** coverage by `54.34%`.
   > The diff coverage is `4.34%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/airflow/pull/7423/graphs/tree.svg?width=650=150=pr=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#7423   +/-   ##
   ===
   - Coverage   86.97%   32.62%   -54.35% 
   ===
 Files 927  927   
 Lines   4496345009   +46 
   ===
   - Hits3910814686-24422 
   - Misses   585530323+24468 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[airflow/kubernetes/worker\_configuration.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3dvcmtlcl9jb25maWd1cmF0aW9uLnB5)
 | `16.88% <0.00%> (-82.43%)` | :arrow_down: |
   | 
[airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==)
 | `16.27% <5.55%> (-40.60%)` | :arrow_down: |
   | 
[airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [794 
more](https://codecov.io/gh/apache/airflow/pull/7423/diff?src=pr=tree-more) 
| |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=footer). 
Last update 
[1982c3f...2aa2c86](https://codecov.io/gh/apache/airflow/pull/7423?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services