[GitHub] [airflow] siddharthvp commented on pull request #14535: Fix: Mysql 5.7 id utf8mb3

2021-08-20 Thread GitBox
siddharthvp commented on pull request #14535: URL: https://github.com/apache/airflow/pull/14535#issuecomment-903063728 Should this have been closed? This does indeed seem to be an issue and the patch would likely help with MariaDB compatibility as well (#16907). -- This is an automated

[GitHub] [airflow] uranusjr commented on a change in pull request #17749: Example xcom update

2021-08-20 Thread GitBox
uranusjr commented on a change in pull request #17749: URL: https://github.com/apache/airflow/pull/17749#discussion_r693308881 ## File path: airflow/example_dags/example_xcom.py ## @@ -81,3 +90,28 @@ def puller(**kwargs): ) pull << [push1, push2] + +bash_push =

[GitHub] [airflow] uranusjr commented on a change in pull request #17749: Example xcom update

2021-08-20 Thread GitBox
uranusjr commented on a change in pull request #17749: URL: https://github.com/apache/airflow/pull/17749#discussion_r693308805 ## File path: airflow/example_dags/example_xcom.py ## @@ -81,3 +90,28 @@ def puller(**kwargs): ) pull << [push1, push2] + +bash_push =

[GitHub] [airflow] siddharthvp commented on a change in pull request #17729: Automatically use utf8mb3_general_ci collation for mysql

2021-08-20 Thread GitBox
siddharthvp commented on a change in pull request #17729: URL: https://github.com/apache/airflow/pull/17729#discussion_r693308710 ## File path: docs/apache-airflow/howto/set-up-database.rst ## @@ -154,14 +154,18 @@ In the example below, a database ``airflow_db`` and user

[GitHub] [airflow] siddharthvp commented on a change in pull request #17729: Automatically use utf8mb3_general_ci collation for mysql

2021-08-20 Thread GitBox
siddharthvp commented on a change in pull request #17729: URL: https://github.com/apache/airflow/pull/17729#discussion_r693308540 ## File path: airflow/models/base.py ## @@ -44,6 +44,19 @@ def get_id_collation_args(): if collation: return {'collation': collation}

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17765: get_pandas_df() fails when it tries to query an empty table

2021-08-20 Thread GitBox
boring-cyborg[bot] commented on issue #17765: URL: https://github.com/apache/airflow/issues/17765#issuecomment-903052686 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] iblaine opened a new issue #17765: get_pandas_df() fails when it tries to query an empty table

2021-08-20 Thread GitBox
iblaine opened a new issue #17765: URL: https://github.com/apache/airflow/issues/17765 **Apache Airflow version**: 2.2.0.dev0 **OS**: Debian GNU/Linux **Apache Airflow Provider versions**: **Deployment**: docker-compose version

[GitHub] [airflow] cccs-seb opened a new pull request #17764: Helm chart: add the number of retention days for log groomer through env vars.

2021-08-20 Thread GitBox
cccs-seb opened a new pull request #17764: URL: https://github.com/apache/airflow/pull/17764 Allow users to specify the number of days they would like the log grooming sidecar to retain logs (both for scheduler/worker templates). Log grooming script's env var:

[GitHub] [airflow] edwardwang888 commented on a change in pull request #17003: WIP Fix `retry_exponential_backoff` divide by zero error when retry delay is zero

2021-08-20 Thread GitBox
edwardwang888 commented on a change in pull request #17003: URL: https://github.com/apache/airflow/pull/17003#discussion_r693297243 ## File path: airflow/models/taskinstance.py ## @@ -939,9 +939,9 @@ def next_retry_datetime(self): delay = self.task.retry_delay

[GitHub] [airflow] edwardwang888 commented on a change in pull request #17003: WIP Fix `retry_exponential_backoff` divide by zero error when retry delay is zero

2021-08-20 Thread GitBox
edwardwang888 commented on a change in pull request #17003: URL: https://github.com/apache/airflow/pull/17003#discussion_r693297243 ## File path: airflow/models/taskinstance.py ## @@ -939,9 +939,9 @@ def next_retry_datetime(self): delay = self.task.retry_delay

[GitHub] [airflow] edwardwang888 commented on a change in pull request #17003: WIP Fix `retry_exponential_backoff` divide by zero error when retry delay is zero

2021-08-20 Thread GitBox
edwardwang888 commented on a change in pull request #17003: URL: https://github.com/apache/airflow/pull/17003#discussion_r693297243 ## File path: airflow/models/taskinstance.py ## @@ -939,9 +939,9 @@ def next_retry_datetime(self): delay = self.task.retry_delay

[GitHub] [airflow] edwardwang888 commented on a change in pull request #17003: WIP Fix `retry_exponential_backoff` divide by zero error when retry delay is zero

2021-08-20 Thread GitBox
edwardwang888 commented on a change in pull request #17003: URL: https://github.com/apache/airflow/pull/17003#discussion_r693297243 ## File path: airflow/models/taskinstance.py ## @@ -939,9 +939,9 @@ def next_retry_datetime(self): delay = self.task.retry_delay

[GitHub] [airflow] repocho commented on pull request #17537: Extend init_containers defined in pod_override

2021-08-20 Thread GitBox
repocho commented on pull request #17537: URL: https://github.com/apache/airflow/pull/17537#issuecomment-903043492 Thank you for all your help !!  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] kaxil edited a comment on pull request #17121: [WIP] Deactivating DAGs which have been removed from files

2021-08-20 Thread GitBox
kaxil edited a comment on pull request #17121: URL: https://github.com/apache/airflow/pull/17121#issuecomment-903026207 Tests are still failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] kaxil commented on pull request #17121: [WIP] Deactivating DAGs which have been removed from files

2021-08-20 Thread GitBox
kaxil commented on pull request #17121: URL: https://github.com/apache/airflow/pull/17121#issuecomment-903026207 Tests are still faining -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] kaxil edited a comment on pull request #17748: Fix ``TimeSensorAsync``

2021-08-20 Thread GitBox
kaxil edited a comment on pull request #17748: URL: https://github.com/apache/airflow/pull/17748#issuecomment-903025741 > What is the need for `TimeTrigger` here? It seems to perform the same function as the other trigger but with the timezone passed in separately, rather than in

[GitHub] [airflow] kaxil commented on pull request #17748: Fix ``TimeSensorAsync``

2021-08-20 Thread GitBox
kaxil commented on pull request #17748: URL: https://github.com/apache/airflow/pull/17748#issuecomment-903025741 > What is the need for `TimeTrigger` here? It seems to perform the same function as the other trigger but with the timezone passed in separately, rather than in `moment`?

[GitHub] [airflow] Jorricks commented on pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-20 Thread GitBox
Jorricks commented on pull request #17207: URL: https://github.com/apache/airflow/pull/17207#issuecomment-903019652 @ephraimbuddy please make sure you are using a form of a Celery Executor, as this ticket is only for celery setups. -- This is an automated message from the Apache Git

[GitHub] [airflow] kaxil opened a new pull request #17763: Chart docs: Format ``loadBalancerSourceRanges`` using code-block

2021-08-20 Thread GitBox
kaxil opened a new pull request #17763: URL: https://github.com/apache/airflow/pull/17763 Since we use rst for docs, and to be consistent with what we have elsewhere --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] kaxil commented on a change in pull request #17743: Add Triggerer to Helm Chart

2021-08-20 Thread GitBox
kaxil commented on a change in pull request #17743: URL: https://github.com/apache/airflow/pull/17743#discussion_r693272978 ## File path: chart/templates/triggerer/triggerer-deployment.yaml ## @@ -0,0 +1,212 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [airflow] kaxil commented on a change in pull request #17743: Add Triggerer to Helm Chart

2021-08-20 Thread GitBox
kaxil commented on a change in pull request #17743: URL: https://github.com/apache/airflow/pull/17743#discussion_r693272681 ## File path: chart/values.yaml ## @@ -715,6 +715,113 @@ webserver: topologyKey: "kubernetes.io/hostname" tolerations: [] +# Airflow

[GitHub] [airflow] github-actions[bot] commented on issue #16483: Potential security leak in logging connection

2021-08-20 Thread GitBox
github-actions[bot] commented on issue #16483: URL: https://github.com/apache/airflow/issues/16483#issuecomment-903015128 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] github-actions[bot] closed pull request #14535: Fix: Mysql 5.7 id utf8mb3

2021-08-20 Thread GitBox
github-actions[bot] closed pull request #14535: URL: https://github.com/apache/airflow/pull/14535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ephraimbuddy commented on issue #16023: Running tasks marked as 'orphaned' and killed by scheduler

2021-08-20 Thread GitBox
ephraimbuddy commented on issue #16023: URL: https://github.com/apache/airflow/issues/16023#issuecomment-902998077 I ran the above provided DAG in LocalExecutor. Before I ran it, I did `airflow db reset`. The first 16 tasks were successful but the next 17 tasks failed. In scheduler

[GitHub] [airflow] kaxil closed pull request #17756: Fix "Invalid JSON configuration, must be a dict"

2021-08-20 Thread GitBox
kaxil closed pull request #17756: URL: https://github.com/apache/airflow/pull/17756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #17759: Show all import_errors from zip files

2021-08-20 Thread GitBox
github-actions[bot] commented on pull request #17759: URL: https://github.com/apache/airflow/pull/17759#issuecomment-902996262 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[airflow] branch main updated (d39ca78 -> c4d043d)

2021-08-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from d39ca78 Add triggerer to `docker-compose.yaml` file (#17745) add c4d043d Fix failing main spellcheck build

[GitHub] [airflow] potiuk merged pull request #17761: Fix failing main spellcheck build

2021-08-20 Thread GitBox
potiuk merged pull request #17761: URL: https://github.com/apache/airflow/pull/17761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (02a33b5 -> d39ca78)

2021-08-20 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 02a33b5 Fetching and logging livy session logs for LivyOperrator (#17393) add d39ca78 Add triggerer to

[GitHub] [airflow] kaxil merged pull request #17745: Add triggerer to `docker-compose.yaml` file

2021-08-20 Thread GitBox
kaxil merged pull request #17745: URL: https://github.com/apache/airflow/pull/17745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #17761: Fix failing main spellcheck build

2021-08-20 Thread GitBox
github-actions[bot] commented on pull request #17761: URL: https://github.com/apache/airflow/pull/17761#issuecomment-902995580 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] potiuk opened a new pull request #17761: Fix failing main spellcheck build

2021-08-20 Thread GitBox
potiuk opened a new pull request #17761: URL: https://github.com/apache/airflow/pull/17761 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] kaxil opened a new pull request #17760: Fix using XCom with ``KubernetesPodOperator``

2021-08-20 Thread GitBox
kaxil opened a new pull request #17760: URL: https://github.com/apache/airflow/pull/17760 This commit effectively revers https://github.com/apache/airflow/pull/15942 because of the issues it is causing. Until we find better solution we should revert this change Error: ```

[airflow] branch constraints-main updated: Updating constraints. Build id:1152168760

2021-08-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 305a2cd Updating

[GitHub] [airflow] jedcunningham opened a new pull request #17759: Show all import_errors from zip files

2021-08-20 Thread GitBox
jedcunningham opened a new pull request #17759: URL: https://github.com/apache/airflow/pull/17759 Instead of showing a single import error from a zip file, show them all. Before: ![Screen Shot 2021-08-20 at 4 21 11

[GitHub] [airflow] potiuk commented on pull request #17745: Add triggerer to `docker-compose.yaml` file

2021-08-20 Thread GitBox
potiuk commented on pull request #17745: URL: https://github.com/apache/airflow/pull/17745#issuecomment-902986694 > Update the file to need a minimum of 2.2.0 to run this version. If there is another solution in mind, we can follow-up with a PR but until then this will help current

[GitHub] [airflow] potiuk edited a comment on pull request #17745: Add triggerer to `docker-compose.yaml` file

2021-08-20 Thread GitBox
potiuk edited a comment on pull request #17745: URL: https://github.com/apache/airflow/pull/17745#issuecomment-902985606 > > The command to get docker-compose is https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html: > > ``` > curl -LfO

[GitHub] [airflow] potiuk commented on pull request #17745: Add triggerer to `docker-compose.yaml` file

2021-08-20 Thread GitBox
potiuk commented on pull request #17745: URL: https://github.com/apache/airflow/pull/17745#issuecomment-902985606 > > The command to get docker-compose is https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html: > > ``` > curl -LfO

[GitHub] [airflow] ephraimbuddy commented on pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-20 Thread GitBox
ephraimbuddy commented on pull request #17207: URL: https://github.com/apache/airflow/pull/17207#issuecomment-902985223 Now, I reproduced this consistently with LocalExecutor in breeze by running the example DAG below. ``` from airflow import DAG import os from datetime import

[GitHub] [airflow] kaxil commented on pull request #17745: Add triggerer to `docker-compose.yaml` file

2021-08-20 Thread GitBox
kaxil commented on pull request #17745: URL: https://github.com/apache/airflow/pull/17745#issuecomment-902984636 Update the file to need a minimum of 2.2.0 to run this version. If there is another solution in mind, we can follow-up with a PR but until then this will help current testers

[GitHub] [airflow] potiuk commented on a change in pull request #17743: Add Triggerer to Helm Chart

2021-08-20 Thread GitBox
potiuk commented on a change in pull request #17743: URL: https://github.com/apache/airflow/pull/17743#discussion_r693239538 ## File path: chart/templates/triggerer/triggerer-deployment.yaml ## @@ -0,0 +1,212 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] jayantsande25 commented on pull request #17758: in-complete example for salesforce

2021-08-20 Thread GitBox
jayantsande25 commented on pull request #17758: URL: https://github.com/apache/airflow/pull/17758#issuecomment-902976822 Please add example DAG in salesforce connectors space. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] jayantsande25 opened a new pull request #17758: in-complete example for salesforce

2021-08-20 Thread GitBox
jayantsande25 opened a new pull request #17758: URL: https://github.com/apache/airflow/pull/17758 Hi Team, can you show a working example of DAG with salesforce? Rightnow there isnt any example in here --- **^ Add meaningful description above** Read the **[Pull

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17758: in-complete example for salesforce

2021-08-20 Thread GitBox
boring-cyborg[bot] commented on pull request #17758: URL: https://github.com/apache/airflow/pull/17758#issuecomment-902976477 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[airflow] branch main updated: Fetching and logging livy session logs for LivyOperrator (#17393)

2021-08-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 02a33b5 Fetching and logging livy session logs

[GitHub] [airflow] potiuk closed issue #17340: Retrieve session logs when using Livy Operator

2021-08-20 Thread GitBox
potiuk closed issue #17340: URL: https://github.com/apache/airflow/issues/17340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk merged pull request #17393: Fetching and logging Livy session logs for LivyOperator

2021-08-20 Thread GitBox
potiuk merged pull request #17393: URL: https://github.com/apache/airflow/pull/17393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #17393: Fetching and logging Livy session logs for LivyOperator

2021-08-20 Thread GitBox
potiuk commented on pull request #17393: URL: https://github.com/apache/airflow/pull/17393#issuecomment-902975193 Transient error. no worres -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk closed issue #11962: [QUARANTINE] test_serve_logs test is failing randomly on MySQL

2021-08-20 Thread GitBox
potiuk closed issue #11962: URL: https://github.com/apache/airflow/issues/11962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #11962: [QUARANTINE] test_serve_logs test is failing randomly on MySQL

2021-08-20 Thread GitBox
potiuk commented on issue #11962: URL: https://github.com/apache/airflow/issues/11962#issuecomment-902974931 Yep -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] kaxil edited a comment on pull request #17745: Add triggerer to `docker-compose.yaml` file

2021-08-20 Thread GitBox
kaxil edited a comment on pull request #17745: URL: https://github.com/apache/airflow/pull/17745#issuecomment-902974705 > I am afraid this is going to fail if someone tries to run it with Airflow < 2.2. We should add some if's here as the docker-compose for quite some time will be

[GitHub] [airflow] kaxil commented on pull request #17745: Add triggerer to `docker-compose.yaml` file

2021-08-20 Thread GitBox
kaxil commented on pull request #17745: URL: https://github.com/apache/airflow/pull/17745#issuecomment-902974705 > I am afraid this is going to fail if someone tries to run it with Airflow < 2.2. We should add some if's here as the docker-compose for quite some time will be used also for

[GitHub] [airflow] jedcunningham commented on a change in pull request #17743: Add Triggerer to Helm Chart

2021-08-20 Thread GitBox
jedcunningham commented on a change in pull request #17743: URL: https://github.com/apache/airflow/pull/17743#discussion_r693234169 ## File path: chart/templates/triggerer/triggerer-deployment.yaml ## @@ -0,0 +1,212 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] potiuk commented on a change in pull request #17743: Add Triggerer to Helm Chart

2021-08-20 Thread GitBox
potiuk commented on a change in pull request #17743: URL: https://github.com/apache/airflow/pull/17743#discussion_r693233524 ## File path: chart/templates/triggerer/triggerer-deployment.yaml ## @@ -0,0 +1,212 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] potiuk commented on a change in pull request #17743: Add Triggerer to Helm Chart

2021-08-20 Thread GitBox
potiuk commented on a change in pull request #17743: URL: https://github.com/apache/airflow/pull/17743#discussion_r693233064 ## File path: chart/templates/triggerer/triggerer-deployment.yaml ## @@ -0,0 +1,212 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [airflow] potiuk commented on pull request #17741: Add Snowflake DQ Operators

2021-08-20 Thread GitBox
potiuk commented on pull request #17741: URL: https://github.com/apache/airflow/pull/17741#issuecomment-902972000 I think you need to rebase to latest main @denimalpaca -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] potiuk commented on pull request #17746: Bump `pip` version to `21.2.4`

2021-08-20 Thread GitBox
potiuk commented on pull request #17746: URL: https://github.com/apache/airflow/pull/17746#issuecomment-902970968 Glad that we can now 'just upgrade PIP` and it works @uranusjr  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk commented on pull request #17746: Bump `pip` version to `21.2.4`

2021-08-20 Thread GitBox
potiuk commented on pull request #17746: URL: https://github.com/apache/airflow/pull/17746#issuecomment-902968615 Building and pushing cache images now, as it is a change quite early in the Docker build process (and with still few flaky tests it is unlikely main succeeds with pushing

[GitHub] [airflow] noelmcloughlin commented on issue #15799: celery worker timed out with rabbitmq

2021-08-20 Thread GitBox
noelmcloughlin commented on issue #15799: URL: https://github.com/apache/airflow/issues/15799#issuecomment-902968308 Link to RMQ consumer_timeout: https://www.rabbitmq.com/consumers.html#acknowledgement-timeout -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] potiuk commented on issue #17641: Import Errors Flapping

2021-08-20 Thread GitBox
potiuk commented on issue #17641: URL: https://github.com/apache/airflow/issues/17641#issuecomment-902961426 Glad it helped :). > “How often have I said to you that when you have eliminated the impossible, whatever remains, however improbable, must be the truth?” Sherlock

[GitHub] [airflow] SamWheating commented on pull request #17121: [WIP] Deactivating DAGs which have been removed from files

2021-08-20 Thread GitBox
SamWheating commented on pull request #17121: URL: https://github.com/apache/airflow/pull/17121#issuecomment-902959117 > One of the tests is failing, can you take a look please: [#17121 (checks)](https://github.com/apache/airflow/pull/17121/checks?check_run_id=3284172968#step:6:10746)

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

2021-08-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17402418#comment-17402418 ] ASF GitHub Bot commented on AIRFLOW-5071: - raviporan commented on issue #10790: URL:

[GitHub] [airflow] raviporan commented on issue #10790: Copy of [AIRFLOW-5071] JIRA: Thousands of Executor reports task instance X finished (success) although the task says its queued. Was the task ki

2021-08-20 Thread GitBox
raviporan commented on issue #10790: URL: https://github.com/apache/airflow/issues/10790#issuecomment-902954329 Hey Guys, Currently we are on the Airflow 1.14 version; We were getting a similar issue with our tasks going under up_for_retry state for hours. I went thru this thread &

[GitHub] [airflow] collinmcnulty commented on pull request #17393: Fetching and logging Livy session logs for LivyOperator

2021-08-20 Thread GitBox
collinmcnulty commented on pull request #17393: URL: https://github.com/apache/airflow/pull/17393#issuecomment-902932947 For whatever it's worth, I ran the provider tests with python 3.6 and postgres 9.6 in breeze both on this commit and this after merging main back in and they pass. --

[GitHub] [airflow] eladkal commented on issue #11962: [QUARANTINE] test_serve_logs test is failing randomly on MySQL

2021-08-20 Thread GitBox
eladkal commented on issue #11962: URL: https://github.com/apache/airflow/issues/11962#issuecomment-902931666 @potiuk the quarantine was removed in https://github.com/apache/airflow/pull/16754 can we close the issue? -- This is an automated message from the Apache Git Service. To

[airflow] branch main updated: [Airflow 13779] use provided parameters in the wait_for_pipeline_state hook (#17137)

2021-08-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d04aa13 [Airflow 13779] use provided parameters

[GitHub] [airflow] potiuk merged pull request #17137: [Airflow 13779] use provided parameters in the wait_for_pipeline_state hook

2021-08-20 Thread GitBox
potiuk merged pull request #17137: URL: https://github.com/apache/airflow/pull/17137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17137: [Airflow 13779] use provided parameters in the wait_for_pipeline_state hook

2021-08-20 Thread GitBox
boring-cyborg[bot] commented on pull request #17137: URL: https://github.com/apache/airflow/pull/17137#issuecomment-902930128 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] potiuk closed issue #17754: Support set logging level in Dag or Task layer

2021-08-20 Thread GitBox
potiuk closed issue #17754: URL: https://github.com/apache/airflow/issues/17754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #17754: Support set logging level in Dag or Task layer

2021-08-20 Thread GitBox
potiuk commented on issue #17754: URL: https://github.com/apache/airflow/issues/17754#issuecomment-902928136 This is standard python logging feature, Just run `self.log.setLevel(logging.DEBUG)` at the moment you want to enable debug. -- This is an automated message from the Apache Git

[GitHub] [airflow] jedcunningham commented on issue #16587: Users with Guest role stuck in redirect loop upon login

2021-08-20 Thread GitBox
jedcunningham commented on issue #16587: URL: https://github.com/apache/airflow/issues/16587#issuecomment-902927455 What "Guest" role? There isn't one by default. Do you mean Public? This is on my list to look at eventually. #17613 won't fix it, and was targeted specifically at

[GitHub] [airflow] potiuk commented on issue #17752: Skip Scheduled Runs

2021-08-20 Thread GitBox
potiuk commented on issue #17752: URL: https://github.com/apache/airflow/issues/17752#issuecomment-902925509 Sounds like a very, very specific request.. Since Airflow is developed by community, I think the only way to get it, is that you implement it. Would you be willing to make a PR

[GitHub] [airflow] cpdean commented on pull request #15599: Mask passwords and sensitive info in task logs and UI

2021-08-20 Thread GitBox
cpdean commented on pull request #15599: URL: https://github.com/apache/airflow/pull/15599#issuecomment-902921785 Spent the day playing around with this some more. I've been able to eventually get passwords to mask, but sometimes they leak through. When a task has been queued, just

[GitHub] [airflow] potiuk closed pull request #17068: Influxdb Hook

2021-08-20 Thread GitBox
potiuk closed pull request #17068: URL: https://github.com/apache/airflow/pull/17068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on issue #16587: Users with Guest role stuck in redirect loop upon login

2021-08-20 Thread GitBox
uranusjr commented on issue #16587: URL: https://github.com/apache/airflow/issues/16587#issuecomment-902914445 If the issue description is accurate, the linked PR would not fix this since it only applies when a user has no roles at all. cc @jedcunningham -- This is an automated

[GitHub] [airflow] potiuk commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

2021-08-20 Thread GitBox
potiuk commented on pull request #17321: URL: https://github.com/apache/airflow/pull/17321#issuecomment-902902372 Great ! thanks @nathadfield - would you make some pr to add some example operators with useful paths so that we can release it in the new batch of providers (I plan to cut

[GitHub] [airflow] potiuk commented on pull request #17749: Example xcom update

2021-08-20 Thread GitBox
potiuk commented on pull request #17749: URL: https://github.com/apache/airflow/pull/17749#issuecomment-902892389 Reopened to rebuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk closed pull request #17749: Example xcom update

2021-08-20 Thread GitBox
potiuk closed pull request #17749: URL: https://github.com/apache/airflow/pull/17749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #17741: Add Snowflake DQ Operators

2021-08-20 Thread GitBox
potiuk commented on pull request #17741: URL: https://github.com/apache/airflow/pull/17741#issuecomment-902891679 Reopened to rebuid! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk closed pull request #17741: Add Snowflake DQ Operators

2021-08-20 Thread GitBox
potiuk closed pull request #17741: URL: https://github.com/apache/airflow/pull/17741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #17741: Add Snowflake DQ Operators

2021-08-20 Thread GitBox
github-actions[bot] commented on pull request #17741: URL: https://github.com/apache/airflow/pull/17741#issuecomment-902891491 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[airflow] branch main updated: Ensure ``DateTimeTrigger`` receives a datetime object (#17747)

2021-08-20 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e21b54a Ensure ``DateTimeTrigger`` receives a

[GitHub] [airflow] kaxil merged pull request #17747: Ensure ``DateTimeTrigger`` receives a datetime object

2021-08-20 Thread GitBox
kaxil merged pull request #17747: URL: https://github.com/apache/airflow/pull/17747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (4fb184b -> ebf3b4a)

2021-08-20 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4fb184b Add links to provider's documentation (#17736) add ebf3b4a Bump `pip` version to `21.2.4` (#17746)

[GitHub] [airflow] kaxil merged pull request #17746: Bump `pip` version to `21.2.4`

2021-08-20 Thread GitBox
kaxil merged pull request #17746: URL: https://github.com/apache/airflow/pull/17746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (00dc3c4 -> 4fb184b)

2021-08-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 00dc3c4 Chart: Add loadBalancerSourceRanges in webserver and flower services (#17666) add 4fb184b Add links

[GitHub] [airflow] potiuk merged pull request #17736: Add links to provider's documentation

2021-08-20 Thread GitBox
potiuk merged pull request #17736: URL: https://github.com/apache/airflow/pull/17736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #17745: Add triggerer to `docker-compose.yaml` file

2021-08-20 Thread GitBox
github-actions[bot] commented on pull request #17745: URL: https://github.com/apache/airflow/pull/17745#issuecomment-902855896 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] potiuk opened a new pull request #17757: Improves documentation about modules management

2021-08-20 Thread GitBox
potiuk opened a new pull request #17757: URL: https://github.com/apache/airflow/pull/17757 This PR is result of responding to a number of questions and issues Airflow users had on Slack, Stack Overflow and GitHub issues. While the document was really helpful it did not address

[GitHub] [airflow] potiuk commented on issue #17744: Problems with how SecurityContext is handled in the helm chart

2021-08-20 Thread GitBox
potiuk commented on issue #17744: URL: https://github.com/apache/airflow/issues/17744#issuecomment-902847149 I'd also classify it as a bug :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on issue #17744: Problems with how SecurityContext is handled in the helm chart

2021-08-20 Thread GitBox
potiuk commented on issue #17744: URL: https://github.com/apache/airflow/issues/17744#issuecomment-902846867 Yeah. Great observation. How about PR fixing it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] timothyclarke commented on issue #16587: Users with Guest role stuck in redirect loop upon login

2021-08-20 Thread GitBox
timothyclarke commented on issue #16587: URL: https://github.com/apache/airflow/issues/16587#issuecomment-902846020 Isn't a user with the "Guest" role still a validated user and not be pushed back to the login page? (Assuming that the guest role still has default permissions) Shouldn't

[GitHub] [airflow] dacort commented on pull request #16766: Add an Amazon EMR on EKS provider package

2021-08-20 Thread GitBox
dacort commented on pull request #16766: URL: https://github.com/apache/airflow/pull/16766#issuecomment-902844207 @ashb Thanks for pinging folks - I just pushed one more update with a little documentation cleanup. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] jedcunningham commented on pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

2021-08-20 Thread GitBox
jedcunningham commented on pull request #17666: URL: https://github.com/apache/airflow/pull/17666#issuecomment-902839986 Thanks @Diogo-Costa for the contribution, and congrats on your first commit! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] jedcunningham merged pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

2021-08-20 Thread GitBox
jedcunningham merged pull request #17666: URL: https://github.com/apache/airflow/pull/17666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (22e87b3 -> 00dc3c4)

2021-08-20 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 22e87b3 Separate infer_data_interval for data interval timetables (#17755) add 00dc3c4 Chart: Add

[GitHub] [airflow] jedcunningham closed issue #17660: Chart - Add option to set loadBalancerSourceRanges in webserver service

2021-08-20 Thread GitBox
jedcunningham closed issue #17660: URL: https://github.com/apache/airflow/issues/17660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17666: [Chart] Add option to set loadBalancerSourceRanges in webserver service

2021-08-20 Thread GitBox
boring-cyborg[bot] commented on pull request #17666: URL: https://github.com/apache/airflow/pull/17666#issuecomment-902839309 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] dacort commented on pull request #17178: Amazon EMR on Amazon EKS

2021-08-20 Thread GitBox
dacort commented on pull request #17178: URL: https://github.com/apache/airflow/pull/17178#issuecomment-902837170 Here's my current thinking on this - I like the addition of the `Start` and `Cancel` operators. I think we should try to get #16766 merged and then you can 1. rebase off that

[GitHub] [airflow] frenchwr closed issue #17641: Import Errors Flapping

2021-08-20 Thread GitBox
frenchwr closed issue #17641: URL: https://github.com/apache/airflow/issues/17641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >