Re: [I] ArgoCD reverting the app to Missing, OutOfSync even when successfully deployed [airflow]

2024-02-15 Thread via GitHub
potiuk closed issue #37460: ArgoCD reverting the app to Missing, OutOfSync even when successfully deployed URL: https://github.com/apache/airflow/issues/37460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] airflow db upgrade: FOREIGN KEY constraint failed [airflow]

2024-02-15 Thread via GitHub
github-actions[bot] commented on issue #23453: URL: https://github.com/apache/airflow/issues/23453#issuecomment-1947855033 This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last

Re: [I] ArgoCD reverting the app to Missing, OutOfSync even when successfully deployed [airflow]

2024-02-15 Thread via GitHub
potiuk commented on issue #37460: URL: https://github.com/apache/airflow/issues/37460#issuecomment-1947846025 Yep I think discussion is better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Kubernetes executor pod reconcilation is slow due to recurssive deep copy [airflow]

2024-02-15 Thread via GitHub
potiuk commented on issue #37131: URL: https://github.com/apache/airflow/issues/37131#issuecomment-1947843819 It's just another way to achieve isolation (heavy handed, so maybe side-edlffects will be too big and it's a bad idea). Basically the reason we are doing deep copy here is

Re: [PR] add endpoint to delete DatasetDagRunQueue [airflow]

2024-02-15 Thread via GitHub
Lee-W commented on code in PR #37176: URL: https://github.com/apache/airflow/pull/37176#discussion_r1492014740 ## airflow/providers/fab/auth_manager/security_manager/override.py: ## @@ -276,6 +276,7 @@ class FabAirflowSecurityManagerOverride(AirflowSecurityManagerV2):

Re: [PR] Check permissions for ImportError [airflow]

2024-02-15 Thread via GitHub
jedcunningham commented on code in PR #37468: URL: https://github.com/apache/airflow/pull/37468#discussion_r1492012822 ## airflow/api_connexion/endpoints/import_error_endpoint.py: ## @@ -16,39 +16,59 @@ # under the License. from __future__ import annotations -from typing

Re: [PR] add endpoint to delete DatasetDagRunQueue [airflow]

2024-02-15 Thread via GitHub
uranusjr commented on code in PR #37176: URL: https://github.com/apache/airflow/pull/37176#discussion_r1492007495 ## airflow/providers/fab/auth_manager/security_manager/override.py: ## @@ -276,6 +276,7 @@ class FabAirflowSecurityManagerOverride(AirflowSecurityManagerV2):

Re: [PR] Partially enable `D100`, `D102`, `D103` and `D104` [airflow]

2024-02-15 Thread via GitHub
rawwar commented on code in PR #37469: URL: https://github.com/apache/airflow/pull/37469#discussion_r1491968585 ## airflow/security/utils.py: ## Review Comment: So, is it safe to remove from the modules? If so, I can check for all the modules where E402 is ignored and

Re: [I] ERROR: could not queue task TaskInstanceKey [airflow]

2024-02-15 Thread via GitHub
harshith-bolar-rapido commented on issue #20047: URL: https://github.com/apache/airflow/issues/20047#issuecomment-1947761572 Seeing this in airflow 2.5.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] ArgoCD reverting the app to Missing, OutOfSync even when successfully deployed [airflow]

2024-02-15 Thread via GitHub
jaruji commented on issue #37460: URL: https://github.com/apache/airflow/issues/37460#issuecomment-1947700115 I'm mainly opening the issue to see whether somebody else encountered something similar and managed to fix it. I do not have any expectations regarding you doing the necessary

Re: [I] Kubernetes executor pod reconcilation is slow due to recurssive deep copy [airflow]

2024-02-15 Thread via GitHub
dirrao commented on issue #37131: URL: https://github.com/apache/airflow/issues/37131#issuecomment-1947695416 Copy on write is intuitive and makes sense. I would look into the options. However, I believe the Kubernetes executor utils calls coming from either the scheduler (pod launch) or

Re: [PR] Core tests fail when run separately [airflow]

2024-02-15 Thread via GitHub
drajguru closed pull request #37467: Core tests fail when run separately URL: https://github.com/apache/airflow/pull/37467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Core tests fail when run separately [airflow]

2024-02-15 Thread via GitHub
drajguru closed issue #37466: Core tests fail when run separately URL: https://github.com/apache/airflow/issues/37466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Core tests fail when run separately [airflow]

2024-02-15 Thread via GitHub
drajguru closed issue #37466: Core tests fail when run separately URL: https://github.com/apache/airflow/issues/37466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Core tests fail when run separately [airflow]

2024-02-15 Thread via GitHub
drajguru commented on issue #37466: URL: https://github.com/apache/airflow/issues/37466#issuecomment-1947691550 Oh I see... I just retested on the latest main and the issue is indeed now fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Partially enable `D100`, `D102`, `D103` and `D104` [airflow]

2024-02-15 Thread via GitHub
Taragolis commented on code in PR #37469: URL: https://github.com/apache/airflow/pull/37469#discussion_r1491874137 ## airflow/security/utils.py: ## Review Comment: And also think it listed in 3rd-party-licenses:

Re: [PR] Partially enable `D100`, `D102`, `D103` and `D104` [airflow]

2024-02-15 Thread via GitHub
Taragolis commented on code in PR #37469: URL: https://github.com/apache/airflow/pull/37469#discussion_r1491867626 ## airflow/api/auth/backend/kerberos_auth.py: ## @@ -14,13 +14,9 @@ # KIND, either express or implied. See the License for the # specific language governing

Re: [I] Filter datasets by dag_id in rest API [airflow]

2024-02-15 Thread via GitHub
Satoshi-Sh commented on issue #37423: URL: https://github.com/apache/airflow/issues/37423#issuecomment-1947589825 I can take on this task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Partially enable `D100`, `D102`, `D103` and `D104` [airflow]

2024-02-15 Thread via GitHub
rawwar commented on code in PR #37469: URL: https://github.com/apache/airflow/pull/37469#discussion_r1491840368 ## airflow/api/auth/backend/kerberos_auth.py: ## @@ -14,13 +14,9 @@ # KIND, either express or implied. See the License for the # specific language governing

Re: [PR] Add Teradata Provider [airflow]

2024-02-15 Thread via GitHub
SatishChGit commented on PR #36953: URL: https://github.com/apache/airflow/pull/36953#issuecomment-1947589696 Thank you every one for your support!. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Partially enable `D100`, `D102`, `D103` and `D104` [airflow]

2024-02-15 Thread via GitHub
rawwar commented on code in PR #37469: URL: https://github.com/apache/airflow/pull/37469#discussion_r1491840368 ## airflow/api/auth/backend/kerberos_auth.py: ## @@ -14,13 +14,9 @@ # KIND, either express or implied. See the License for the # specific language governing

Re: [PR] Partially enable `D100`, `D102`, `D103` and `D104` [airflow]

2024-02-15 Thread via GitHub
Taragolis commented on code in PR #37469: URL: https://github.com/apache/airflow/pull/37469#discussion_r1491844488 ## pyproject.toml: ## @@ -1381,83 +1387,1472 @@ combine-as-imports = true "tests/providers/qdrant/hooks/test_qdrant.py" = ["E402"]

Re: [PR] Partially enable `D100`, `D102`, `D103` and `D104` [airflow]

2024-02-15 Thread via GitHub
rawwar commented on code in PR #37469: URL: https://github.com/apache/airflow/pull/37469#discussion_r1491840368 ## airflow/api/auth/backend/kerberos_auth.py: ## @@ -14,13 +14,9 @@ # KIND, either express or implied. See the License for the # specific language governing

Re: [I] Enable More PyDocStyle Checks [airflow]

2024-02-15 Thread via GitHub
Taragolis commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1947582702 And personally not sure about D107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] Enable More PyDocStyle Checks [airflow]

2024-02-15 Thread via GitHub
rawwar commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1947582616 > I don’t think it is even possible not to combine them if we want to enable all of them. Only problem to create issues with all of them I just raised this PR -

Re: [PR] Partially enable `D100`, `D101`, `D102`, `D103` and `D104` [airflow]

2024-02-15 Thread via GitHub
rawwar commented on code in PR #37469: URL: https://github.com/apache/airflow/pull/37469#discussion_r1491840368 ## airflow/api/auth/backend/kerberos_auth.py: ## @@ -14,13 +14,9 @@ # KIND, either express or implied. See the License for the # specific language governing

Re: [I] Enable More PyDocStyle Checks [airflow]

2024-02-15 Thread via GitHub
Taragolis commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1947578178 > We could combine several `D*`s if we want in one row. I don't think there is a particular reason why we want to keep them in separate sections. @Taragolis ? I don’t

Re: [I] Reduce irrelevant ERROR level logs from KubernertesPodOperator on pod runtime failure [airflow]

2024-02-15 Thread via GitHub
sudiptob2 commented on issue #36077: URL: https://github.com/apache/airflow/issues/36077#issuecomment-1947569963 @ketozhang Thank you so much. There were problem in RBAC, I updated it and now I can get Pod events ``` [2024-02-15, 23:26:26 UTC] {pod.py:980} ERROR - (403)

Re: [PR] Check permissions for ImportError [airflow]

2024-02-15 Thread via GitHub
vincbeck commented on code in PR #37468: URL: https://github.com/apache/airflow/pull/37468#discussion_r1491830495 ## airflow/api_connexion/endpoints/import_error_endpoint.py: ## @@ -65,10 +85,42 @@ def get_import_errors( """Get all import errors.""" to_replace =

Re: [PR] Check permissions for ImportError [airflow]

2024-02-15 Thread via GitHub
vincbeck commented on code in PR #37468: URL: https://github.com/apache/airflow/pull/37468#discussion_r1491829265 ## airflow/api_connexion/endpoints/import_error_endpoint.py: ## @@ -16,39 +16,59 @@ # under the License. from __future__ import annotations -from typing import

Re: [I] Enable More PyDocStyle Checks [airflow]

2024-02-15 Thread via GitHub
potiuk commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1947559270 > Issue is that same module have D*s and also E*s. We could combine `D*`'s and `E*s` together as well. -- This is an automated message from the Apache Git Service. To

Re: [I] Enable More PyDocStyle Checks [airflow]

2024-02-15 Thread via GitHub
rawwar commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1947557987 > We could combine several `D*`s if we want in one row. I don't think there is a particular reason why we want to keep them in separate sections. @Taragolis ? Issue is that

Re: [I] Enable More PyDocStyle Checks [airflow]

2024-02-15 Thread via GitHub
potiuk commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1947556694 We could `D*` if we want. I don't think there is a particular reason why we want to keep them in separate sections. @Taragolis ? -- This is an automated message from the Apache

Re: [I] Enable More PyDocStyle Checks [airflow]

2024-02-15 Thread via GitHub
rawwar commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1947555396 And, list of all issues that we can add to `pyproject.toml`. I did some basic pre-processing. ``` "airflow/__main__.py" = ["D103"] "airflow/api/auth/__init__.py" =

Re: [PR] Make Datasets hashable [airflow]

2024-02-15 Thread via GitHub
potiuk commented on PR #37465: URL: https://github.com/apache/airflow/pull/37465#issuecomment-1947554480 LGTM. But I would prefer Others to also take a look - maybe there is a good reason for not having it hashable :). And thanks for the thorough research on the past ! BTW. Static

Re: [I] Enable More PyDocStyle Checks [airflow]

2024-02-15 Thread via GitHub
rawwar commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1947553871 > Oh absolutley. Moving it out is just theorethically possible, but we do not want to do it (or at least we have not decided about it yet. I personally think there is a value in

Re: [I] Enable More PyDocStyle Checks [airflow]

2024-02-15 Thread via GitHub
potiuk commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1947550688 > Can we just update it in the current pyproject.toml? I would like to contribute and I'll finish them off one by one Oh absolutley. Moving it out is just theorethically

Re: [I] Reduce irrelevant ERROR level logs from KubernertesPodOperator on pod runtime failure [airflow]

2024-02-15 Thread via GitHub
sudiptob2 commented on issue #36077: URL: https://github.com/apache/airflow/issues/36077#issuecomment-1947549730 Thanks for the hint ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Reduce irrelevant ERROR level logs from KubernertesPodOperator on pod runtime failure [airflow]

2024-02-15 Thread via GitHub
ketozhang commented on issue #36077: URL: https://github.com/apache/airflow/issues/36077#issuecomment-1947548134 It looks like you're not getting any event failures because of some Kubernetes permission issue. In your logs, you're getting a 403 error: > HTTP response body:

Re: [I] Core tests fail when run separately [airflow]

2024-02-15 Thread via GitHub
potiuk commented on issue #37466: URL: https://github.com/apache/airflow/issues/37466#issuecomment-1947544510 BTW. You Absolutely should not open issue for such things - just opening PR is more than enough, we hate beauraucracy (even the word is ugly) and in Airlfow, when you plan to open

[PR] Check permissions for ImportError [airflow]

2024-02-15 Thread via GitHub
jedcunningham opened a new pull request, #37468: URL: https://github.com/apache/airflow/pull/37468 --- **^ Add meaningful description above** Read the **[Pull Request

Re: [I] Core tests fail when run separately [airflow]

2024-02-15 Thread via GitHub
potiuk commented on issue #37466: URL: https://github.com/apache/airflow/issues/37466#issuecomment-1947542936 Are you ABSOLUTELY sure you tested in on the latest main ? Becauase I believe I fixed this very problem few days ago here: https://github.com/apache/airflow/pull/37320 -

Re: [I] Continuously logging and Batch logging mode for the aws Glue job's execution logs [airflow]

2024-02-15 Thread via GitHub
github-actions[bot] commented on issue #26203: URL: https://github.com/apache/airflow/issues/26203#issuecomment-1947539465 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Not able to view the DAG page but jump straight to an error page when testing customized timetable [airflow]

2024-02-15 Thread via GitHub
github-actions[bot] closed issue #35630: Not able to view the DAG page but jump straight to an error page when testing customized timetable URL: https://github.com/apache/airflow/issues/35630 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Not able to view the DAG page but jump straight to an error page when testing customized timetable [airflow]

2024-02-15 Thread via GitHub
github-actions[bot] commented on issue #35630: URL: https://github.com/apache/airflow/issues/35630#issuecomment-1947539386 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Continuously logging and Batch logging mode for the aws Glue job's execution logs [airflow]

2024-02-15 Thread via GitHub
github-actions[bot] closed issue #26203: Continuously logging and Batch logging mode for the aws Glue job's execution logs URL: https://github.com/apache/airflow/issues/26203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] `GoogleBaseHook` is ignoring `key_secret_name` in `provide_gcp_credential_file_as_context` method [airflow]

2024-02-15 Thread via GitHub
github-actions[bot] commented on issue #35190: URL: https://github.com/apache/airflow/issues/35190#issuecomment-1947539409 This issue has been automatically marked as stale because it has been open for 14 days with no response from the author. It will be closed in next 7 days if no further

Re: [I] Enable More PyDocStyle Checks [airflow]

2024-02-15 Thread via GitHub
rawwar commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1947534083 > In theory we could enable all rules [#10742 (comment)](https://github.com/apache/airflow/issues/10742#issuecomment-1947242983) but place exclusions into the separate file, e.g.

Re: [I] Enable More PyDocStyle Checks [airflow]

2024-02-15 Thread via GitHub
rawwar commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1947530957 > In theory we could enable all rules [#10742 (comment)](https://github.com/apache/airflow/issues/10742#issuecomment-1947242983) but place exclusions into the separate file, e.g.

Re: [I] ArgoCD reverting the app to Missing, OutOfSync even when successfully deployed [airflow]

2024-02-15 Thread via GitHub
potiuk commented on issue #37460: URL: https://github.com/apache/airflow/issues/37460#issuecomment-1947527524 > Specifically, the run-airflow-migrations and create-user jobs are executing every couple of minutes in this case. If the automated selfHeal is turned off, the app just shifts to

[PR] Core tests fail when run separately #37466 [airflow]

2024-02-15 Thread via GitHub
drajguru opened a new pull request, #37467: URL: https://github.com/apache/airflow/pull/37467 Add orm mocking to settings test Prevent putting the session into a state that prevents subsequent test modules from passing. closes: #37466 -- This is an automated message from the

Re: [I] Reduce irrelevant ERROR level logs from KubernertesPodOperator on pod runtime failure [airflow]

2024-02-15 Thread via GitHub
sudiptob2 commented on issue #36077: URL: https://github.com/apache/airflow/issues/36077#issuecomment-1947510738 Hi @ketozhang I ran 2 dags according to your suggestion. But could not get the Pod Event log. 1.

[I] Core tests fail when run separately [airflow]

2024-02-15 Thread via GitHub
drajguru opened a new issue, #37466: URL: https://github.com/apache/airflow/issues/37466 ### Apache Airflow version main (development) ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? test_sqlite_relative_path() in

Re: [PR] Add environment var example to mssql.rst [airflow]

2024-02-15 Thread via GitHub
boring-cyborg[bot] commented on PR #37418: URL: https://github.com/apache/airflow/pull/37418#issuecomment-1947489220 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

(airflow) branch main updated: Add environment var example to mssql.rst (#37418)

2024-02-15 Thread jscheffl
This is an automated email from the ASF dual-hosted git repository. jscheffl pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9f4f8b3553 Add environment var example to

Re: [PR] Add environment var example to mssql.rst [airflow]

2024-02-15 Thread via GitHub
jscheffl merged PR #37418: URL: https://github.com/apache/airflow/pull/37418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Replace usage of `datetime.utcnow` and `datetime.utcfromtimestamp` in providers (#37138)

2024-02-15 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 42f8d048d2 Replace usage of `datetime.utcnow`

Re: [PR] Replace usage of `datetime.utcnow` and `datetime.utcfromtimestamp` in providers [airflow]

2024-02-15 Thread via GitHub
Taragolis merged PR #37138: URL: https://github.com/apache/airflow/pull/37138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Make Datasets hashable [airflow]

2024-02-15 Thread via GitHub
mpeteuil opened a new pull request, #37465: URL: https://github.com/apache/airflow/pull/37465 Currently DAGs accept a [`Collection["Dataset"]`](https://github.com/apache/airflow/blob/0c02ead4d8a527cbf0a916b6344f255c520e637f/airflow/models/dag.py#L171) as an option for the `schedule`, but

Re: [I] Reduce irrelevant ERROR level logs from KubernertesPodOperator on pod runtime failure [airflow]

2024-02-15 Thread via GitHub
sudiptob2 commented on issue #36077: URL: https://github.com/apache/airflow/issues/36077#issuecomment-1947442082 Yes sure, Just to mention, I already did try [this](https://github.com/sudiptob2/airflow-kpo-test/blob/main/dev/dags/test_fail_dag_2.py) Dag which is similar to the one you

Re: [I] ArgoCD reverting the app to Missing, OutOfSync even when successfully deployed [airflow]

2024-02-15 Thread via GitHub
jaruji commented on issue #37460: URL: https://github.com/apache/airflow/issues/37460#issuecomment-1947441852 I can open an issue there tomorrow. I did some more research, and enabled automated prune and selfHeal in the argoCD app like so: ``` syncPolicy: automated:

Re: [I] Reduce irrelevant ERROR level logs from KubernertesPodOperator on pod runtime failure [airflow]

2024-02-15 Thread via GitHub
ketozhang commented on issue #36077: URL: https://github.com/apache/airflow/issues/36077#issuecomment-1947438237 If you wouldn't mind. Can you do one run with and another without `container_resources` set? I forgot the original issue I outlined here was we are getting Pod Event

Re: [I] Inlets not handled properly with @task functions [airflow]

2024-02-15 Thread via GitHub
ninowalker commented on issue #37463: URL: https://github.com/apache/airflow/issues/37463#issuecomment-1947437366 For additional context, with the python debugger inside `execute_callable` of the PythonOperator (which wraps the function in question): 1. It's calling

Re: [I] Reduce irrelevant ERROR level logs from KubernertesPodOperator on pod runtime failure [airflow]

2024-02-15 Thread via GitHub
sudiptob2 commented on issue #36077: URL: https://github.com/apache/airflow/issues/36077#issuecomment-1947433926 @ketozhang Thanks! will try this shortly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Reduce irrelevant ERROR level logs from KubernertesPodOperator on pod runtime failure [airflow]

2024-02-15 Thread via GitHub
ketozhang commented on issue #36077: URL: https://github.com/apache/airflow/issues/36077#issuecomment-1947432083 You seem to be getting a different error more so about Kubernetes API permission issue which isn't related to the Pod. Let's try to use reduce your DAG file into minimal

[PR] Filter datasets graph by dag_id [airflow]

2024-02-15 Thread via GitHub
bbovenzi opened a new pull request, #37464: URL: https://github.com/apache/airflow/pull/37464 Read in all the dag_ids from the dataset dependencies endpoint and allow filtering the datasets graph by dag_id A use rcan filter via the multi-select or from a tooltip when clicking on a Dag

Re: [I] ArgoCD reverting the app to Missing, OutOfSync even when successfully deployed [airflow]

2024-02-15 Thread via GitHub
potiuk commented on issue #37460: URL: https://github.com/apache/airflow/issues/37460#issuecomment-1947407531 Have you opened the issue to ArgoCD? What do they say ? It could be caused by some issues that we already know and plan to fix https://github.com/apache/airflow/issues/37399 or

Re: [I] smtp_default connection host/port is ignored when sending email [airflow]

2024-02-15 Thread via GitHub
Taragolis commented on issue #37442: URL: https://github.com/apache/airflow/issues/37442#issuecomment-1947401299 Maybe you rights, attached link to core modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] smtp_default connection host/port is ignored when sending email [airflow]

2024-02-15 Thread via GitHub
potiuk commented on issue #37442: URL: https://github.com/apache/airflow/issues/37442#issuecomment-1947393912 Ah. Maybe I misunderstood :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] smtp_default connection host/port is ignored when sending email [airflow]

2024-02-15 Thread via GitHub
Taragolis commented on issue #37442: URL: https://github.com/apache/airflow/issues/37442#issuecomment-1947391262 Just wondering is it issue about EmailOperator from core or from [SFTP Provider](https://airflow.apache.org/docs/apache-airflow-providers-smtp/stable/index.html)? -- This is

[I] Inlets not handled properly with @task functions [airflow]

2024-02-15 Thread via GitHub
ninowalker opened a new issue, #37463: URL: https://github.com/apache/airflow/issues/37463 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.8.0 ### What happened? A task with

Re: [I] Inlets not handled properly with @task functions [airflow]

2024-02-15 Thread via GitHub
boring-cyborg[bot] commented on issue #37463: URL: https://github.com/apache/airflow/issues/37463#issuecomment-1947378746 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

(airflow) branch constraints-main updated: Updating constraints. Github run id:7921989999

2024-02-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 2ad99b909f Updating

Re: [PR] [POC] Validate is it possible to build wheel from sdist distribution [airflow]

2024-02-15 Thread via GitHub
Taragolis commented on code in PR #37444: URL: https://github.com/apache/airflow/pull/37444#discussion_r1491687286 ## dev/breeze/src/airflow_breeze/commands/release_management_commands.py: ## @@ -711,8 +804,8 @@ def prepare_provider_packages( sys.exit(0)

Re: [I] Azure blob remote logging - The specified container does not exist. [airflow]

2024-02-15 Thread via GitHub
jaruji commented on issue #37459: URL: https://github.com/apache/airflow/issues/37459#issuecomment-1947350151 Okay that fixed it. The docs for this should get updated, as the information written there regarding the azure blob remote logging setup is not up to date. It took me a fair bit of

Re: [PR] [POC] Validate is it possible to build wheel from sdist distribution [airflow]

2024-02-15 Thread via GitHub
potiuk commented on code in PR #37444: URL: https://github.com/apache/airflow/pull/37444#discussion_r1491675071 ## dev/breeze/src/airflow_breeze/commands/release_management_commands.py: ## @@ -711,8 +804,8 @@ def prepare_provider_packages( sys.exit(0)

Re: [I] Add colour to logs [airflow]

2024-02-15 Thread via GitHub
potiuk commented on issue #37443: URL: https://github.com/apache/airflow/issues/37443#issuecomment-1947343754 > Sorry, I don't mean to say that its not possible. I think, the current log tab is just a window showing text and I was talking about it. Well it's a javascript-controlled

Re: [I] smtp_default connection host/port is ignored when sending email [airflow]

2024-02-15 Thread via GitHub
potiuk commented on issue #37442: URL: https://github.com/apache/airflow/issues/37442#issuecomment-1947335380 So far that has been deliberate choice - see https://airflow.apache.org/docs/apache-airflow/stable/howto/email-config.html. SMTP for the emails that are sent by Airflow have -

Re: [I] Azure blob remote logging - The specified container does not exist. [airflow]

2024-02-15 Thread via GitHub
Taragolis commented on issue #37459: URL: https://github.com/apache/airflow/issues/37459#issuecomment-1947316985 It is separate section, something like that. ```yaml config: logging: remote_logging: 'True' remote_base_log_folder: wasb-airflow/logs

Re: [PR] Partially enable D105 rule [airflow]

2024-02-15 Thread via GitHub
Taragolis commented on PR #37462: URL: https://github.com/apache/airflow/pull/37462#issuecomment-1947310104 Anyway, I will create appropriate task tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Partially enable D105 rule [airflow]

2024-02-15 Thread via GitHub
potiuk commented on PR #37462: URL: https://github.com/apache/airflow/pull/37462#issuecomment-1947309064 like it we have in pyproject.toml (and have mechanism to see the "important" changes there :). -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Partially enable D105 rule [airflow]

2024-02-15 Thread via GitHub
potiuk commented on PR #37462: URL: https://github.com/apache/airflow/pull/37462#issuecomment-1947305106 https://github.com/apache/airflow/assets/595491/e6255807-312b-45a3-a783-2889bdf8e5b7;> -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Partially enable D105 rule [airflow]

2024-02-15 Thread via GitHub
Taragolis commented on PR #37462: URL: https://github.com/apache/airflow/pull/37462#issuecomment-1947304958 We could move this changes in the separate file https://github.com/apache/airflow/issues/10742#issuecomment-1947303063 but it just an idea, because if we enable all rules we have to

Re: [I] Enable More PyDocStyle Checks [airflow]

2024-02-15 Thread via GitHub
Taragolis commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1947303063 In theory we could enable all rules https://github.com/apache/airflow/issues/10742#issuecomment-1947242983 but place exclusions into the separate file, e.g. in ruff.toml

Re: [PR] Partially enable D105 rule [airflow]

2024-02-15 Thread via GitHub
potiuk commented on PR #37462: URL: https://github.com/apache/airflow/pull/37462#issuecomment-1947302356 I really like how those kinds of pyproject.toml changes now do not generate full build :D . YAY... Achievement unlocked. -- This is an automated message from the Apache Git Service.

(airflow) branch main updated: Partially enable D105 rule (#37462)

2024-02-15 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 3c1d05140e Partially enable D105 rule (#37462)

Re: [PR] Partially enable D105 rule [airflow]

2024-02-15 Thread via GitHub
potiuk merged PR #37462: URL: https://github.com/apache/airflow/pull/37462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Partially enable D105 rule [airflow]

2024-02-15 Thread via GitHub
Taragolis opened a new pull request, #37462: URL: https://github.com/apache/airflow/pull/37462 related: https://github.com/apache/airflow/issues/10742 --- **^ Add meaningful description above** Read the **[Pull Request

Re: [I] Enable More PyDocStyle Checks [airflow]

2024-02-15 Thread via GitHub
Taragolis commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-1947242983 Just finish calculation other violations of D100-D107 | **Rule** | **Total Errors** | **Uniq Core Modules** | **Uniq Providers Modules** | **Uniq Other Modules** |

Re: [PR] Adding ability to automatically set DAG to off after X times it failed sequentially [airflow]

2024-02-15 Thread via GitHub
potiuk commented on PR #36935: URL: https://github.com/apache/airflow/pull/36935#issuecomment-1947220665 This time I rebased it, but you can usually do it yourself without calling maintainers -> generally I recommend to rebase eaarly, often, and especially when you see you are behind and

Re: [PR] Adding ability to automatically set DAG to off after X times it failed sequentially [airflow]

2024-02-15 Thread via GitHub
potiuk commented on PR #36935: URL: https://github.com/apache/airflow/pull/36935#issuecomment-1947217035 > The Test failures look like are coming from other changes cc. @eladkal @potiuk Yes. Usually rebasing helps. Those errors were found and fixed earlier today -- This is an

Re: [PR] add override option for app with the same name [airflow]

2024-02-15 Thread via GitHub
romsharon98 closed pull request #37447: add override option for app with the same name URL: https://github.com/apache/airflow/pull/37447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] add override option for app with the same name [airflow]

2024-02-15 Thread via GitHub
hussein-awala commented on code in PR #37447: URL: https://github.com/apache/airflow/pull/37447#discussion_r1491561796 ## airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py: ## @@ -255,6 +258,8 @@ def custom_obj_api(self) -> CustomObjectsApi: def

(airflow) branch main updated: Support type checking for third-party pytest's fixtures (#37457)

2024-02-15 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ef0ab856e4 Support type checking for

Re: [PR] Support type checking for third-party pytest's fixtures [airflow]

2024-02-15 Thread via GitHub
hussein-awala merged PR #37457: URL: https://github.com/apache/airflow/pull/37457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add Yandex Query support from Yandex.Cloud [airflow]

2024-02-15 Thread via GitHub
Taragolis commented on PR #37458: URL: https://github.com/apache/airflow/pull/37458#issuecomment-1947076850 And static checks and mypy should be fixed: - https://github.com/apache/airflow/actions/runs/7919541474/job/21623012828?pr=37458 -

Re: [PR] Revert "KPO Maintain backward compatibility for execute_complete and … [airflow]

2024-02-15 Thread via GitHub
potiuk commented on PR #37446: URL: https://github.com/apache/airflow/pull/37446#issuecomment-1946977154 Thanks for super-quick diagnosis and fix @pankajastro BTW ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Revert "KPO Maintain backward compatibility for execute_complete and … [airflow]

2024-02-15 Thread via GitHub
potiuk commented on PR #37446: URL: https://github.com/apache/airflow/pull/37446#issuecomment-1946967719 Merged! That explains it indeed, It did not fail in your PR, because it would **generally** work without mocking (and worked for me as well locally) if run in isolation / on not

(airflow) branch main updated: KPO Maintain backward compatibility for execute_complete and trigger run method (#37454)

2024-02-15 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c84efe77a5 KPO Maintain backward compatibility for

Re: [PR] KPO Maintain backward compatibility for execute_complete and trigger run method [airflow]

2024-02-15 Thread via GitHub
potiuk merged PR #37454: URL: https://github.com/apache/airflow/pull/37454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >