Re: [PR] Add metrics_allow_list and metrics_block_list to statsd deployments env [airflow]

2024-05-09 Thread via GitHub
Xiroo commented on code in PR #38697: URL: https://github.com/apache/airflow/pull/38697#discussion_r1595036924 ## chart/templates/statsd/statsd-deployment.yaml: ## @@ -104,8 +104,17 @@ spec: - "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"

Re: [PR] Add metrics_allow_list and metrics_block_list to statsd deployments env [airflow]

2024-05-08 Thread via GitHub
jedcunningham commented on code in PR #38697: URL: https://github.com/apache/airflow/pull/38697#discussion_r1594326160 ## chart/templates/statsd/statsd-deployment.yaml: ## @@ -104,8 +104,17 @@ spec: - "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"

Re: [PR] Add metrics_allow_list and metrics_block_list to statsd deployments env [airflow]

2024-04-21 Thread via GitHub
romsharon98 commented on PR #38697: URL: https://github.com/apache/airflow/pull/38697#issuecomment-2067948902 @eladkal looks good, can we merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add metrics_allow_list and metrics_block_list to statsd deployments env [airflow]

2024-04-06 Thread via GitHub
Xiroo commented on code in PR #38697: URL: https://github.com/apache/airflow/pull/38697#discussion_r1554627220 ## chart/templates/statsd/statsd-deployment.yaml: ## @@ -104,8 +104,17 @@ spec: - "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"

Re: [PR] Add metrics_allow_list and metrics_block_list to statsd deployments env [airflow]

2024-04-06 Thread via GitHub
romsharon98 commented on code in PR #38697: URL: https://github.com/apache/airflow/pull/38697#discussion_r1554628445 ## chart/templates/statsd/statsd-deployment.yaml: ## @@ -104,8 +104,17 @@ spec: - "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"

Re: [PR] Add metrics_allow_list and metrics_block_list to statsd deployments env [airflow]

2024-04-06 Thread via GitHub
Xiroo commented on code in PR #38697: URL: https://github.com/apache/airflow/pull/38697#discussion_r1554627220 ## chart/templates/statsd/statsd-deployment.yaml: ## @@ -104,8 +104,17 @@ spec: - "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"

Re: [PR] Add metrics_allow_list and metrics_block_list to statsd deployments env [airflow]

2024-04-06 Thread via GitHub
Xiroo commented on code in PR #38697: URL: https://github.com/apache/airflow/pull/38697#discussion_r1554627220 ## chart/templates/statsd/statsd-deployment.yaml: ## @@ -104,8 +104,17 @@ spec: - "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"

Re: [PR] Add metrics_allow_list and metrics_block_list to statsd deployments env [airflow]

2024-04-06 Thread via GitHub
Xiroo commented on code in PR #38697: URL: https://github.com/apache/airflow/pull/38697#discussion_r1554627220 ## chart/templates/statsd/statsd-deployment.yaml: ## @@ -104,8 +104,17 @@ spec: - "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"

Re: [PR] Add metrics_allow_list and metrics_block_list to statsd deployments env [airflow]

2024-04-06 Thread via GitHub
romsharon98 commented on PR #38697: URL: https://github.com/apache/airflow/pull/38697#issuecomment-2041092273 Except this looks good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add metrics_allow_list and metrics_block_list to statsd deployments env [airflow]

2024-04-06 Thread via GitHub
romsharon98 commented on code in PR #38697: URL: https://github.com/apache/airflow/pull/38697#discussion_r1554584784 ## chart/templates/statsd/statsd-deployment.yaml: ## @@ -104,8 +104,17 @@ spec: - "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"

[PR] Add metrics_allow_list and metrics_block_list to statsd deployments env [airflow]

2024-04-03 Thread via GitHub
Xiroo opened a new pull request, #38697: URL: https://github.com/apache/airflow/pull/38697 We need to ensure that the metrics_allow_list and metrics_block_list are added to the StatsD pod's environment variables. This update is crucial for refreshing the pod configuration effectively.