Re: [PR] fix: update `get_uri` to return URI in sqlAlchemy URI format [airflow]

2024-04-09 Thread via GitHub
rawwar commented on PR #38831: URL: https://github.com/apache/airflow/pull/38831#issuecomment-2045402639 > I would rather do not mix-in introduce changes into DBApiHook and other hook in the same PR unless absolutely necessary. So I would rather create a new propery (via separate PR),

Re: [PR] fix: update `get_uri` to return URI in sqlAlchemy URI format [airflow]

2024-04-09 Thread via GitHub
Taragolis commented on code in PR #38831: URL: https://github.com/apache/airflow/pull/38831#discussion_r1557473352 ## airflow/providers/common/sql/hooks/sql.py: ## @@ -178,6 +179,10 @@ def __init__(self, *args, schema: str | None = None, log_sql: bool = True, **kwa

Re: [PR] fix: update `get_uri` to return URI in sqlAlchemy URI format [airflow]

2024-04-08 Thread via GitHub
rawwar commented on PR #38831: URL: https://github.com/apache/airflow/pull/38831#issuecomment-2043040070 @Taragolis , based on your comment [here](https://github.com/apache/airflow/issues/38195#issuecomment-2042644747) > As far as i remember, we recently discuss this case in slack. I