[jira] [Reopened] (AIRFLOW-3392) Add index on dag_id in sla_miss table

2018-12-15 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor reopened AIRFLOW-3392: Changing fix version > Add index on dag_id in sla_miss table >

[jira] [Updated] (AIRFLOW-3001) Accumulative tis slow allocation of new schedule

2018-12-15 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-3001: --- Fix Version/s: (was: 2.0.0) 1.10.2 > Accumulative tis slow

[GitHub] seelmann commented on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors

2018-12-15 Thread GitBox
seelmann commented on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors URL: https://github.com/apache/incubator-airflow/pull/3596#issuecomment-447601182 Screenshots are attached at the Jira. The Gantt view should show a white bar when it's rescheduled in thus in "None"

[GitHub] codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323#issuecomment-447584517 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4323?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323#issuecomment-447584517 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4323?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323#issuecomment-447584517 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4323?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323#issuecomment-447584517 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4323?src=pr=h1) Report > Merging

[jira] [Updated] (AIRFLOW-3500) Make task duration display user friendly

2018-12-15 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik updated AIRFLOW-3500: Fix Version/s: (was: 1.10.2) 2.0.0 > Make task duration display user

[GitHub] dmvieira closed pull request #2748: Fixing temp path

2018-12-15 Thread GitBox
dmvieira closed pull request #2748: Fixing temp path URL: https://github.com/apache/incubator-airflow/pull/2748 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] dmvieira edited a comment on issue #2748: Fixing temp path

2018-12-15 Thread GitBox
dmvieira edited a comment on issue #2748: Fixing temp path URL: https://github.com/apache/incubator-airflow/pull/2748#issuecomment-447598599 We can live without it This is an automated message from the Apache Git Service. To

[GitHub] dmvieira commented on issue #2748: Fixing temp path

2018-12-15 Thread GitBox
dmvieira commented on issue #2748: Fixing temp path URL: https://github.com/apache/incubator-airflow/pull/2748#issuecomment-447598599 We can live with it This is an automated message from the Apache Git Service. To respond

[jira] [Resolved] (AIRFLOW-3392) Add index on dag_id in sla_miss table

2018-12-15 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-3392. Resolution: Fixed Fix Version/s: (was: 2.0.0)

[jira] [Updated] (AIRFLOW-2747) Explicit re-schedule of sensors

2018-12-15 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-2747: --- Fix Version/s: (was: 2.0.0) 1.10.2 > Explicit re-schedule

[jira] [Commented] (AIRFLOW-3447) Intended usage of ts_nodash macro broken with migration to new time system.

2018-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722319#comment-16722319 ] ASF GitHub Bot commented on AIRFLOW-3447: - kaxil closed pull request #4323: [AIRFLOW-3447] Add

[GitHub] kaxil closed pull request #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
kaxil closed pull request #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[jira] [Resolved] (AIRFLOW-3447) Intended usage of ts_nodash macro broken with migration to new time system.

2018-12-15 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-3447. - Resolution: Fixed Resolved by https://github.com/apache/incubator-airflow/pull/4323 >

[jira] [Commented] (AIRFLOW-3500) Make task duration display user friendly

2018-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722371#comment-16722371 ] ASF GitHub Bot commented on AIRFLOW-3500: - kaxil closed pull request #4304: [AIRFLOW-3500] Make

[GitHub] kaxil closed pull request #4304: [AIRFLOW-3500] Make task duration display user friendly

2018-12-15 Thread GitBox
kaxil closed pull request #4304: [AIRFLOW-3500] Make task duration display user friendly URL: https://github.com/apache/incubator-airflow/pull/4304 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] Fokko commented on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors

2018-12-15 Thread GitBox
Fokko commented on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors URL: https://github.com/apache/incubator-airflow/pull/3596#issuecomment-447619213 @ashb @seelmann To simplify things, I'm all in for setting the re-schedule method as the default scheduling method for sensors,

[jira] [Created] (AIRFLOW-3522) Support Slack Attachments for SlackWebhookHook

2018-12-15 Thread Michael Holtzscher (JIRA)
Michael Holtzscher created AIRFLOW-3522: --- Summary: Support Slack Attachments for SlackWebhookHook Key: AIRFLOW-3522 URL: https://issues.apache.org/jira/browse/AIRFLOW-3522 Project: Apache

[GitHub] seelmann edited a comment on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors

2018-12-15 Thread GitBox
seelmann edited a comment on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors URL: https://github.com/apache/incubator-airflow/pull/3596#issuecomment-447601423 Another thing that should be improved: The start date, end date, and duration in the tooltip when hovering over the

[GitHub] seelmann commented on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors

2018-12-15 Thread GitBox
seelmann commented on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors URL: https://github.com/apache/incubator-airflow/pull/3596#issuecomment-447601423 Another thing that should be improved: The start date, end date, and duration in the tooltip when hovering over that task

[jira] [Assigned] (AIRFLOW-3522) Support Slack Attachments for SlackWebhookHook

2018-12-15 Thread Michael Holtzscher (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Holtzscher reassigned AIRFLOW-3522: --- Assignee: Michael Holtzscher > Support Slack Attachments for

[GitHub] seelmann commented on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors

2018-12-15 Thread GitBox
seelmann commented on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors URL: https://github.com/apache/incubator-airflow/pull/3596#issuecomment-447596460 @ashb I can work on those during the holidays. Regarding 1 (the "None" state): I agree it's not optimal that there is

[GitHub] kaxil commented on a change in pull request #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
kaxil commented on a change in pull request #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323#discussion_r241962520 ## File path: UPDATING.md ## @@ -24,6 +24,13 @@ assists users migrating to a new version.

[jira] [Updated] (AIRFLOW-3523) Try number displays incorrect values in failure alert

2018-12-15 Thread Murali Sathenapalli (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murali Sathenapalli updated AIRFLOW-3523: - Summary: Try number displays incorrect values in failure alert (was: Try

[jira] [Created] (AIRFLOW-3523) Try number displays incorrect values in the web UI

2018-12-15 Thread Murali Sathenapalli (JIRA)
Murali Sathenapalli created AIRFLOW-3523: Summary: Try number displays incorrect values in the web UI Key: AIRFLOW-3523 URL: https://issues.apache.org/jira/browse/AIRFLOW-3523 Project: Apache

[GitHub] ashb commented on a change in pull request #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
ashb commented on a change in pull request #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323#discussion_r241958823 ## File path: UPDATING.md ## @@ -24,6 +24,13 @@ assists users migrating to a new version.

[GitHub] ashb commented on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors

2018-12-15 Thread GitBox
ashb commented on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors URL: https://github.com/apache/incubator-airflow/pull/3596#issuecomment-447599864 @seelmann Thanks, that would be ace! This feature is very nice. I'm mostly concerned with the visualisation on the Graph,

[GitHub] oferze commented on issue #4304: [AIRFLOW-3500] Make task duration display user friendly

2018-12-15 Thread GitBox
oferze commented on issue #4304: [AIRFLOW-3500] Make task duration display user friendly URL: https://github.com/apache/incubator-airflow/pull/4304#issuecomment-447608798 @kaxil I originally ticked the box in the PR template: "My PR does not need testing for this extremely good reason:

[GitHub] codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323#issuecomment-447584517 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4323?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-3327) BiqQuery job checking doesn't include location, which api requires outside US/EU

2018-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722366#comment-16722366 ] ASF GitHub Bot commented on AIRFLOW-3327: - kaxil opened a new pull request #4324:

[GitHub] kaxil opened a new pull request #4324: [AIRFLOW-3327] Add location in BigQueryHook

2018-12-15 Thread GitBox
kaxil opened a new pull request #4324: [AIRFLOW-3327] Add location in BigQueryHook URL: https://github.com/apache/incubator-airflow/pull/4324 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[GitHub] kaxil commented on issue #4324: [AIRFLOW-3327] Add location in BigQueryHook

2018-12-15 Thread GitBox
kaxil commented on issue #4324: [AIRFLOW-3327] Add location in BigQueryHook URL: https://github.com/apache/incubator-airflow/pull/4324#issuecomment-447614094 cc @fenglu-g This is an automated message from the Apache Git

[GitHub] eladkal commented on issue #4317: [AIRFLOW-2629] Change reference of hive_hooks to hive_hook everywhere

2018-12-15 Thread GitBox
eladkal commented on issue #4317: [AIRFLOW-2629] Change reference of hive_hooks to hive_hook everywhere URL: https://github.com/apache/incubator-airflow/pull/4317#issuecomment-447622291 Hi guys, I picked it up because it was an open ticket. I see now that this task wan't actually

[jira] [Commented] (AIRFLOW-2143) Try number displays incorrect values in the web UI

2018-12-15 Thread Murali Sathenapalli (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722385#comment-16722385 ] Murali Sathenapalli commented on AIRFLOW-2143: -- we are getting this too in airflow 1.10.0

[GitHub] NielsZeilemaker commented on issue #4322: [AIRFLOW-3518] Performance fixes for topological_sort

2018-12-15 Thread GitBox
NielsZeilemaker commented on issue #4322: [AIRFLOW-3518] Performance fixes for topological_sort URL: https://github.com/apache/incubator-airflow/pull/4322#issuecomment-447553072 @feng-tao that's correct, i've modified the condition to check for `task_id` and in the other equality check

[GitHub] kaxil commented on a change in pull request #3880: [AIRFLOW-461] Support autodetected schemas in BigQuery run_load

2018-12-15 Thread GitBox
kaxil commented on a change in pull request #3880: [AIRFLOW-461] Support autodetected schemas in BigQuery run_load URL: https://github.com/apache/incubator-airflow/pull/3880#discussion_r241946183 ## File path: airflow/contrib/operators/gcs_to_bq.py ## @@ -190,20 +191,24

[GitHub] kaxil commented on a change in pull request #3880: [AIRFLOW-461] Support autodetected schemas in BigQuery run_load

2018-12-15 Thread GitBox
kaxil commented on a change in pull request #3880: [AIRFLOW-461] Support autodetected schemas in BigQuery run_load URL: https://github.com/apache/incubator-airflow/pull/3880#discussion_r241946183 ## File path: airflow/contrib/operators/gcs_to_bq.py ## @@ -190,20 +191,24

[GitHub] kaxil commented on issue #4276: [AIRFLOW-1552] Airflow Filter_by_owner not working with password_auth

2018-12-15 Thread GitBox
kaxil commented on issue #4276: [AIRFLOW-1552] Airflow Filter_by_owner not working with password_auth URL: https://github.com/apache/incubator-airflow/pull/4276#issuecomment-447561172 @ashb Any more comments? This is an

[jira] [Reopened] (AIRFLOW-1919) Add option to query for DAG runs given a DAG ID

2018-12-15 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik reopened AIRFLOW-1919: - > Add option to query for DAG runs given a DAG ID >

[jira] [Commented] (AIRFLOW-1919) Add option to query for DAG runs given a DAG ID

2018-12-15 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722114#comment-16722114 ] Kaxil Naik commented on AIRFLOW-1919: - This feature will be available in 1.10.2. Currently it is

[GitHub] kaxil commented on issue #4317: [AIRFLOW-2629] Change reference of hive_hooks to hive_hook everywhere

2018-12-15 Thread GitBox
kaxil commented on issue #4317: [AIRFLOW-2629] Change reference of hive_hooks to hive_hook everywhere URL: https://github.com/apache/incubator-airflow/pull/4317#issuecomment-447561722 We can keep it as it is. Most of the other hook file in that directory has 1 hook, whereas hive as 3

[jira] [Created] (AIRFLOW-3521) Airflow Jira Compare script is limited to 50 items

2018-12-15 Thread Kaxil Naik (JIRA)
Kaxil Naik created AIRFLOW-3521: --- Summary: Airflow Jira Compare script is limited to 50 items Key: AIRFLOW-3521 URL: https://issues.apache.org/jira/browse/AIRFLOW-3521 Project: Apache Airflow

[jira] [Commented] (AIRFLOW-3521) Airflow Jira Compare script is limited to 50 items

2018-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722126#comment-16722126 ] ASF GitHub Bot commented on AIRFLOW-3521: - kaxil closed pull request #4300: [AIRFLOW-3521]

[GitHub] kaxil closed pull request #4300: [AIRFLOW-3521] Fetch more than 50 items in `airflow-jira compare` script

2018-12-15 Thread GitBox
kaxil closed pull request #4300: [AIRFLOW-3521] Fetch more than 50 items in `airflow-jira compare` script URL: https://github.com/apache/incubator-airflow/pull/4300 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[jira] [Resolved] (AIRFLOW-3521) Airflow Jira Compare script is limited to 50 items

2018-12-15 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-3521. - Resolution: Fixed Fix Version/s: 1.10.2 > Airflow Jira Compare script is limited to 50

[GitHub] kaxil commented on a change in pull request #3880: [AIRFLOW-461] Support autodetected schemas in BigQuery run_load

2018-12-15 Thread GitBox
kaxil commented on a change in pull request #3880: [AIRFLOW-461] Support autodetected schemas in BigQuery run_load URL: https://github.com/apache/incubator-airflow/pull/3880#discussion_r241946183 ## File path: airflow/contrib/operators/gcs_to_bq.py ## @@ -190,20 +191,24

[GitHub] kaxil commented on a change in pull request #4320: [AIRFLOW-3515] Remove the run_duration option

2018-12-15 Thread GitBox
kaxil commented on a change in pull request #4320: [AIRFLOW-3515] Remove the run_duration option URL: https://github.com/apache/incubator-airflow/pull/4320#discussion_r241946571 ## File path: airflow/bin/cli.py ## @@ -971,7 +971,6 @@ def scheduler(args): job =

[GitHub] kaxil commented on a change in pull request #4320: [AIRFLOW-3515] Remove the run_duration option

2018-12-15 Thread GitBox
kaxil commented on a change in pull request #4320: [AIRFLOW-3515] Remove the run_duration option URL: https://github.com/apache/incubator-airflow/pull/4320#discussion_r241946571 ## File path: airflow/bin/cli.py ## @@ -971,7 +971,6 @@ def scheduler(args): job =

[jira] [Resolved] (AIRFLOW-1919) Add option to query for DAG runs given a DAG ID

2018-12-15 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-1919. - Resolution: Fixed Fix Version/s: (was: 2.0.0) 1.10.2 > Add

[GitHub] kaxil commented on a change in pull request #4299: [AIRFLOW-3490] BigQueryHook's Ability to Patch Table/View

2018-12-15 Thread GitBox
kaxil commented on a change in pull request #4299: [AIRFLOW-3490] BigQueryHook's Ability to Patch Table/View URL: https://github.com/apache/incubator-airflow/pull/4299#discussion_r241947032 ## File path: airflow/contrib/hooks/bigquery_hook.py ## @@ -495,6 +495,78 @@ def

[jira] [Commented] (AIRFLOW-1919) Add option to query for DAG runs given a DAG ID

2018-12-15 Thread Kaxil Naik (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722113#comment-16722113 ] Kaxil Naik commented on AIRFLOW-1919: - [~villasv]: This is already available in the documentation

[GitHub] codecov-io commented on issue #4314: [AIRFLOW-3398] Google Cloud Spanner instance database query operator

2018-12-15 Thread GitBox
codecov-io commented on issue #4314: [AIRFLOW-3398] Google Cloud Spanner instance database query operator URL: https://github.com/apache/incubator-airflow/pull/4314#issuecomment-447562637 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4314?src=pr=h1) Report > Merging

[GitHub] kaxil commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed

2018-12-15 Thread GitBox
kaxil commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed URL: https://github.com/apache/incubator-airflow/pull/4298#discussion_r241947339 ## File path: UPDATING.md ## @@ -24,6 +24,10 @@ assists users migrating to a new

[GitHub] kaxil commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed

2018-12-15 Thread GitBox
kaxil commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed URL: https://github.com/apache/incubator-airflow/pull/4298#discussion_r241947334 ## File path: airflow/jobs.py ## @@ -562,8 +561,6 @@ def __init__( :param

[GitHub] kaxil commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed

2018-12-15 Thread GitBox
kaxil commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed URL: https://github.com/apache/incubator-airflow/pull/4298#discussion_r241947328 ## File path: airflow/jobs.py ## @@ -544,7 +544,6 @@ def __init__(

[GitHub] ashb commented on a change in pull request #4322: [AIRFLOW-3518] Performance fixes for topological_sort

2018-12-15 Thread GitBox
ashb commented on a change in pull request #4322: [AIRFLOW-3518] Performance fixes for topological_sort URL: https://github.com/apache/incubator-airflow/pull/4322#discussion_r241952239 ## File path: airflow/models.py ## @@ -2662,10 +2662,15 @@ def __init__( }

[jira] [Commented] (AIRFLOW-3518) Toposort is very slow

2018-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722184#comment-16722184 ] ASF GitHub Bot commented on AIRFLOW-3518: - ashb closed pull request #4322: [AIRFLOW-3518]

[GitHub] ashb closed pull request #4322: [AIRFLOW-3518] Performance fixes for topological_sort

2018-12-15 Thread GitBox
ashb closed pull request #4322: [AIRFLOW-3518] Performance fixes for topological_sort URL: https://github.com/apache/incubator-airflow/pull/4322 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] ashb commented on issue #4322: [AIRFLOW-3518] Performance fixes for topological_sort

2018-12-15 Thread GitBox
ashb commented on issue #4322: [AIRFLOW-3518] Performance fixes for topological_sort URL: https://github.com/apache/incubator-airflow/pull/4322#issuecomment-447575229 Maybe I should offer bad code reviews as a service? ;)

[jira] [Resolved] (AIRFLOW-3518) Toposort is very slow

2018-12-15 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-3518. Resolution: Fixed Fix Version/s: 1.10.2 > Toposort is very slow >

[jira] [Commented] (AIRFLOW-3520) RBAC UI seems to have bug in master branch

2018-12-15 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722193#comment-16722193 ] Ash Berlin-Taylor commented on AIRFLOW-3520: This seems to bite a few people on master. I

[GitHub] ashb commented on issue #4276: [AIRFLOW-1552] Airflow Filter_by_owner not working with password_auth

2018-12-15 Thread GitBox
ashb commented on issue #4276: [AIRFLOW-1552] Airflow Filter_by_owner not working with password_auth URL: https://github.com/apache/incubator-airflow/pull/4276#issuecomment-447576172 LGTM This is an automated message from

[jira] [Resolved] (AIRFLOW-1552) Airflow Filter_by_owner not working with password_auth

2018-12-15 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-1552. Resolution: Fixed > Airflow Filter_by_owner not working with password_auth >

[GitHub] ashb commented on issue #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo

2018-12-15 Thread GitBox
ashb commented on issue #4050: [AIRFLOW-3178] Don't bake ENV and _cmd into tmp config for non-sudo URL: https://github.com/apache/incubator-airflow/pull/4050#issuecomment-447577199 @Fokko updated (and rebased). PTAL. This

[GitHub] ashb commented on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
ashb commented on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323#issuecomment-447584724 Actually - what does this do to the filename that logs are written to?

[GitHub] ashb closed pull request #4276: [AIRFLOW-1552] Airflow Filter_by_owner not working with password_auth

2018-12-15 Thread GitBox
ashb closed pull request #4276: [AIRFLOW-1552] Airflow Filter_by_owner not working with password_auth URL: https://github.com/apache/incubator-airflow/pull/4276 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Commented] (AIRFLOW-1552) Airflow Filter_by_owner not working with password_auth

2018-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722194#comment-16722194 ] ASF GitHub Bot commented on AIRFLOW-1552: - ashb closed pull request #4276: [AIRFLOW-1552]

[GitHub] ashb commented on issue #4317: [AIRFLOW-2629] Change reference of hive_hooks to hive_hook everywhere

2018-12-15 Thread GitBox
ashb commented on issue #4317: [AIRFLOW-2629] Change reference of hive_hooks to hive_hook everywhere URL: https://github.com/apache/incubator-airflow/pull/4317#issuecomment-447577053 I don't feel strongly either way about this PR. It would be possible to rename (if we decide that's what

[GitHub] kaxil commented on issue #4304: [AIRFLOW-3500] Make task duration display user friendly

2018-12-15 Thread GitBox
kaxil commented on issue #4304: [AIRFLOW-3500] Make task duration display user friendly URL: https://github.com/apache/incubator-airflow/pull/4304#issuecomment-447578458 @oferze Can you add tests to check this functions, please?

[GitHub] kaxil commented on issue #4317: [AIRFLOW-2629] Change reference of hive_hooks to hive_hook everywhere

2018-12-15 Thread GitBox
kaxil commented on issue #4317: [AIRFLOW-2629] Change reference of hive_hooks to hive_hook everywhere URL: https://github.com/apache/incubator-airflow/pull/4317#issuecomment-447579180 Definitely, agree with most of the points. I had raised a PR a year back :D regarding a similar thing

[GitHub] kaxil opened a new pull request #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
kaxil opened a new pull request #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-3447) Intended usage of ts_nodash macro broken with migration to new time system.

2018-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722218#comment-16722218 ] ASF GitHub Bot commented on AIRFLOW-3447: - kaxil opened a new pull request #4323:

[GitHub] codecov-io commented on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
codecov-io commented on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323#issuecomment-447584517 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4323?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323#issuecomment-447584517 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4323?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323#issuecomment-447584517 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4323?src=pr=h1) Report > Merging

[GitHub] stale[bot] commented on issue #2367: [AIRFLOW-1077] Warn about subdag deadlock case

2018-12-15 Thread GitBox
stale[bot] commented on issue #2367: [AIRFLOW-1077] Warn about subdag deadlock case URL: https://github.com/apache/incubator-airflow/pull/2367#issuecomment-447585342 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further

[GitHub] codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323#issuecomment-447584517 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4323?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
codecov-io edited a comment on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323#issuecomment-447584517 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4323?src=pr=h1) Report > Merging

[GitHub] ashb commented on issue #4276: [AIRFLOW-1552] Airflow Filter_by_owner not working with password_auth

2018-12-15 Thread GitBox
ashb commented on issue #4276: [AIRFLOW-1552] Airflow Filter_by_owner not working with password_auth URL: https://github.com/apache/incubator-airflow/pull/4276#issuecomment-447587937 I tried cherry-picking this in to v1-10-test but it failed due to the down rev specified there not being

[GitHub] kaxil commented on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro

2018-12-15 Thread GitBox
kaxil commented on issue #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323#issuecomment-447590637 I don't think it affects the log filename as the log filename uses `ts`. I will add details to UPDATING.md ``` # Log

[GitHub] ashb commented on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors

2018-12-15 Thread GitBox
ashb commented on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors URL: https://github.com/apache/incubator-airflow/pull/3596#issuecomment-447590657 I think this feature needs some work 1. the tasks that are in "reschedule" just show up as "None" in the tree view:

[jira] [Reopened] (AIRFLOW-2747) Explicit re-schedule of sensors

2018-12-15 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor reopened AIRFLOW-2747: Some more work needed on this issue - the logs are wrong and the visibility in the

[GitHub] ashb edited a comment on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors

2018-12-15 Thread GitBox
ashb edited a comment on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors URL: https://github.com/apache/incubator-airflow/pull/3596#issuecomment-447590657 I think this feature needs some work 1. the tasks that are in "reschedule" just show up as "None" in the tree