[jira] [Commented] (BEAM-2747) accept CombineFn as UDAF

2017-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122616#comment-16122616 ] ASF GitHub Bot commented on BEAM-2747: -- GitHub user XuMingmin opened a pull request:

[jira] [Commented] (BEAM-2747) accept CombineFn as UDAF

2017-08-10 Thread Xu Mingmin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121906#comment-16121906 ] Xu Mingmin commented on BEAM-2747: -- You're right [~xumingming], it's doable to copy

[jira] [Commented] (BEAM-2747) accept CombineFn as UDAF

2017-08-10 Thread James Xu (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121681#comment-16121681 ] James Xu commented on BEAM-2747: To be more clear, since the signature to add a function is: ``` void

[jira] [Commented] (BEAM-2747) accept CombineFn as UDAF

2017-08-10 Thread James Xu (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121112#comment-16121112 ] James Xu commented on BEAM-2747: [~mingmxu] I think the Adapter strategy should work. Although

[jira] [Commented] (BEAM-2747) accept CombineFn as UDAF

2017-08-09 Thread Xu Mingmin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120886#comment-16120886 ] Xu Mingmin commented on BEAM-2747: -- [~takidau] [~xumingming] I was swamped by a technical question to