[jira] [Commented] (BEAM-742) Move trigger state machines to runners-core, convert triggers to AST

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624228#comment-15624228
 ] 

ASF GitHub Bot commented on BEAM-742:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/1187


> Move trigger state machines to runners-core, convert triggers to AST
> 
>
> Key: BEAM-742
> URL: https://issues.apache.org/jira/browse/BEAM-742
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-core, sdk-java-core
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-742) Move trigger state machines to runners-core, convert triggers to AST

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606440#comment-15606440
 ] 

ASF GitHub Bot commented on BEAM-742:
-

GitHub user kennknowles opened a pull request:

https://github.com/apache/incubator-beam/pull/1187

[BEAM-742] Delete the obsolete ExecutableTrigger

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [x] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

R: @aljoscha 

Here is the follow-up. Since it makes a trivial but very incompatible 
change my goal is to get LGTM on this pull request then (before merging) fix 
the integration tests from the Dataflow side.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kennknowles/incubator-beam 
ExecutableTrigger-delete

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1187


commit 16551a8c2913add21ee4587a9acae4f0598bd5be
Author: Kenneth Knowles 
Date:   2016-10-25T20:42:53Z

Delete the obsolete ExecutableTrigger




> Move trigger state machines to runners-core, convert triggers to AST
> 
>
> Key: BEAM-742
> URL: https://issues.apache.org/jira/browse/BEAM-742
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-core, sdk-java-core
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-742) Move trigger state machines to runners-core, convert triggers to AST

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605891#comment-15605891
 ] 

ASF GitHub Bot commented on BEAM-742:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/1172


> Move trigger state machines to runners-core, convert triggers to AST
> 
>
> Key: BEAM-742
> URL: https://issues.apache.org/jira/browse/BEAM-742
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-core, sdk-java-core
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-742) Move trigger state machines to runners-core, convert triggers to AST

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603036#comment-15603036
 ] 

ASF GitHub Bot commented on BEAM-742:
-

GitHub user kennknowles opened a pull request:

https://github.com/apache/incubator-beam/pull/1172

[BEAM-742] Remove pieces of Trigger now owned by TriggerStateMachine

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [x] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

No reviewer yet; currently posting for self-review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kennknowles/incubator-beam Trigger-delete

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1172


commit 2612ccfea450f9a99589fd8e549c8148a3faad36
Author: Kenneth Knowles 
Date:   2016-10-24T19:57:37Z

Remove pieces of Trigger now owned by TriggerStateMachine




> Move trigger state machines to runners-core, convert triggers to AST
> 
>
> Key: BEAM-742
> URL: https://issues.apache.org/jira/browse/BEAM-742
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-core, sdk-java-core
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-742) Move trigger state machines to runners-core, convert triggers to AST

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592798#comment-15592798
 ] 

ASF GitHub Bot commented on BEAM-742:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/1138


> Move trigger state machines to runners-core, convert triggers to AST
> 
>
> Key: BEAM-742
> URL: https://issues.apache.org/jira/browse/BEAM-742
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-core, sdk-java-core
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-742) Move trigger state machines to runners-core, convert triggers to AST

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15590376#comment-15590376
 ] 

ASF GitHub Bot commented on BEAM-742:
-

GitHub user kennknowles opened a pull request:

https://github.com/apache/incubator-beam/pull/1138

[BEAM-742] Port ReduceFnRunner to TriggerStateMachine

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [x] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kennknowles/incubator-beam 
ReduceFnRunner-TriggerStateMachine

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1138


commit 4fa52a3192aeee6fa8e297a83b2dc884968d05f6
Author: Kenneth Knowles 
Date:   2016-10-19T23:48:58Z

Port ReduceFnRunner to TriggerStateMachine

commit 377be5f3899b4d641abc62ee5326e5eef9a1bb96
Author: Kenneth Knowles 
Date:   2016-10-20T00:41:39Z

Delete TriggerRunner




> Move trigger state machines to runners-core, convert triggers to AST
> 
>
> Key: BEAM-742
> URL: https://issues.apache.org/jira/browse/BEAM-742
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-core, sdk-java-core
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-742) Move trigger state machines to runners-core, convert triggers to AST

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584321#comment-15584321
 ] 

ASF GitHub Bot commented on BEAM-742:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/1101


> Move trigger state machines to runners-core, convert triggers to AST
> 
>
> Key: BEAM-742
> URL: https://issues.apache.org/jira/browse/BEAM-742
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-core, sdk-java-core
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-742) Move trigger state machines to runners-core, convert triggers to AST

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574355#comment-15574355
 ] 

ASF GitHub Bot commented on BEAM-742:
-

GitHub user kennknowles opened a pull request:

https://github.com/apache/incubator-beam/pull/1101

[BEAM-742] Translation from Trigger to TriggerStateMachine

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [x] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

This add a `TriggerStateMachines` utility class to `runners-core` with one 
key piece of functionality: converting a `Trigger` (where we pretend it is just 
a piece of syntax) to a `TriggerStateMachine` (which is just a copy of what 
triggers currently are).

In doing so, a fairly large number of trivial accessors and private/public 
alteration were necessary to the existing trigger codebase, but no 
functionality changes.

It is worth noting briefly the options for disjoint unions in Java, to 
explain why I chose the one I did:

1. A binder/evaluator a la `StateBinder` (this is the super-type-safe way 
of doing data in Java) but that adds a non-user-facing method to the interface. 
It can be useful sometimes, such as the way that `StateTag` has a phantom type 
that gets propagated to the return type of the visitor.
2. A visitor a la `PipelineVisitor` that just mutates some internal state. 
This is roughly the same as the prior, but returning `void` and mutating makes 
it easier to return complex data but forces an ordering.
3. Using reflection to treat the Java class as the disjoint union tag. This 
is the approach taken by Scala, and the approach I take here. I tried to 
minimize the reflective boilerplate this induced. No type safety is really 
lost, since in the technical vision, this trigger will be an AST sent over the 
wire (aka no type safety is available).

R: @bjchambers 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kennknowles/incubator-beam 
TriggerReactor-conversion

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1101


commit a931626554f48197d733a8793e42dd18abcdb36f
Author: Kenneth Knowles 
Date:   2016-10-14T03:08:53Z

Make Trigger#subTriggers public and non-null

commit 409e6b77abc59ac9dff19d155d4485d70e1cfc60
Author: Kenneth Knowles 
Date:   2016-10-14T03:42:38Z

Construct AfterAllStateMachine with a list of subtriggers

commit 12ab0cee39004877ee2d20778d8768966399919e
Author: Kenneth Knowles 
Date:   2016-10-14T03:43:08Z

Construct AfterFirstStateMachine with a list of subtriggers

commit 6c0b307719cdf8a6a45a3b6f1e82cff88d1d10bb
Author: Kenneth Knowles 
Date:   2016-10-14T03:43:33Z

Make AfterSynchronizedProcessingTime public

We need to be able to access this class to reason about it when
converting a trigger to a state machine.

commit 3cdd843b6498b2c5ac227ea3dc8be09d64b1c8b0
Author: Kenneth Knowles 
Date:   2016-10-14T03:44:35Z

Add direct accessors for the components of OrFinallyTrigger

commit 22527bb34708059327f63dccdac3ad4a69bda6ed
Author: Kenneth Knowles 
Date:   2016-10-14T03:56:54Z

Construct AfterEachStateMachine from list of subtriggers

commit 1ad53cb68c76452db1ccbc64d55b92fe14db0e48
Author: Kenneth Knowles 
Date:   2016-10-14T03:57:48Z

Add accessors to Repeatedly trigger

commit ebb8e63b650d2dc9e43ac23d11ef1b3be1d6ac6c
Author: Kenneth Knowles 
Date:   2016-10-14T03:58:12Z

Make OrFinallyTrigger public so it can be examined

commit 40277691f64861a622fbd9bddf0ad1d8963d64ca
Author: Kenneth Knowles 
Date:   2016-10-14T04:13:27Z

Add accessors to AfterWatermark trigger

commit a5bac7bea8f8d82d14f7c341b4757c6a9a40bddf
Author: Kenneth Knowles 
Date:   2016-10-14T05:13:43Z

Add access to values from AfterDelay triggers

commit e95f5945d2469a44218dd3ad6f40afb5dce094e4
Author: Kenneth Knowles 
Date:   2016-10-14T05:14:32Z

Add accessors for AfterPane(StateMachine) parameters

commit 

[jira] [Commented] (BEAM-742) Move trigger state machines to runners-core, convert triggers to AST

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573390#comment-15573390
 ] 

ASF GitHub Bot commented on BEAM-742:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/1083


> Move trigger state machines to runners-core, convert triggers to AST
> 
>
> Key: BEAM-742
> URL: https://issues.apache.org/jira/browse/BEAM-742
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-core, sdk-java-core
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-742) Move trigger state machines to runners-core, convert triggers to AST

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572593#comment-15572593
 ] 

ASF GitHub Bot commented on BEAM-742:
-

Github user kennknowles closed the pull request at:

https://github.com/apache/incubator-beam/pull/1089


> Move trigger state machines to runners-core, convert triggers to AST
> 
>
> Key: BEAM-742
> URL: https://issues.apache.org/jira/browse/BEAM-742
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-core, sdk-java-core
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-742) Move trigger state machines to runners-core, convert triggers to AST

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570036#comment-15570036
 ] 

ASF GitHub Bot commented on BEAM-742:
-

GitHub user kennknowles opened a pull request:

https://github.com/apache/incubator-beam/pull/1089

[BEAM-742] Replicate triggers to runners-core, favoring commit history over 
blame

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [x] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

R: @bjchambers 

This is identical to #1083 but with the first and third commit squashed 
together. Based on my readings on the subject, I would have expected git to 
actually track the content, at least when using blame, but it does not seem to.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kennknowles/incubator-beam 
TriggerReactor-squashed

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1089.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1089


commit f63f81e2d8fad16d668809c8b291256ae5477ab1
Author: Kenneth Knowles 
Date:   2016-06-24T03:05:27Z

Copy triggers to runners-core

This commit is effectively a "git hint" that all the files
in runners-core are moved from prior files. The moved files
will be replaced.

commit f0913147af072cda06a2da4ef6933e311b94dd90
Author: Kenneth Knowles 
Date:   2016-06-24T03:31:10Z

Rename trigger reactors




> Move trigger state machines to runners-core, convert triggers to AST
> 
>
> Key: BEAM-742
> URL: https://issues.apache.org/jira/browse/BEAM-742
> Project: Beam
>  Issue Type: Sub-task
>  Components: runner-core, sdk-java-core
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)