jiazhai commented on code in PR #4334:
URL: https://github.com/apache/bookkeeper/pull/4334#discussion_r1590612461
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java:
##
@@ -40,10 +40,10 @@
public class LedgerDescriptorImpl extends
shoothzj opened a new pull request, #4341:
URL: https://github.com/apache/bookkeeper/pull/4341
See https://lists.apache.org/thread/kz8vc04qysjcc3prgbtr3n1s2f74c1ds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
shoothzj commented on code in PR #4340:
URL: https://github.com/apache/bookkeeper/pull/4340#discussion_r1590553534
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java:
##
@@ -299,6 +298,8 @@ int read(ByteBuffer dst)
public void close()
eolivelli commented on code in PR #4340:
URL: https://github.com/apache/bookkeeper/pull/4340#discussion_r1590655146
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java:
##
@@ -192,7 +192,6 @@ private JournalChannel(File journalDirectory, long
shoothzj merged PR #4338:
URL: https://github.com/apache/bookkeeper/pull/4338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shoothzj commented on issue #358:
URL: https://github.com/apache/bookkeeper/issues/358#issuecomment-2095463578
it was merged during 4.5.0-SNAPSHOT. Since 4.5.1 can be use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 5daf4a470b doc: update PR template to
shoothzj merged PR #4335:
URL: https://github.com/apache/bookkeeper/pull/4335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shoothzj commented on code in PR #4340:
URL: https://github.com/apache/bookkeeper/pull/4340#discussion_r1590554009
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java:
##
@@ -192,7 +192,6 @@ private JournalChannel(File journalDirectory, long
This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new b4ffa20a1f build: remove unused cpp
shoothzj commented on code in PR #4340:
URL: https://github.com/apache/bookkeeper/pull/4340#discussion_r1590666985
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java:
##
@@ -192,7 +192,6 @@ private JournalChannel(File journalDirectory, long
This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a change to branch shoothzj-patch-1
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
at 3021c5383b doc: add the missing release news
This branch includes the following new commits:
This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a commit to branch shoothzj-patch-1
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
commit 3021c5383bee0f983befecd8a052f36ba8a49612
Author: ZhangJian He
AuthorDate: Mon May 6 16:00:28 2024 +0800
jiazhai commented on code in PR #4333:
URL: https://github.com/apache/bookkeeper/pull/4333#discussion_r1590614411
##
docker/Dockerfile:
##
@@ -61,13 +62,15 @@ RUN set -x \
&& tar -xzf "$DISTRO_NAME.tar.gz" \
&& mv bookkeeper-server-${BK_VERSION}/ /opt/bookkeeper/ \
shoothzj commented on issue #2974:
URL: https://github.com/apache/bookkeeper/issues/2974#issuecomment-2095703007
@dlg99 Can we close this issue or need other works? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
shoothzj commented on PR #4321:
URL: https://github.com/apache/bookkeeper/pull/4321#issuecomment-2096059909
@lhotari Thanks. It seems MavenClassLoader will load different versions of
bk and unify it to `slf4j-simple`, but why we need this? Let me check if
integrate-tests bookkeeper outputs
shoothzj opened a new pull request, #4345:
URL: https://github.com/apache/bookkeeper/pull/4345
CVE-2023-5072(7.5), CVE-2022-45688(7.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
shoothzj commented on code in PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1590949030
##
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/DriverMetadataServiceAvailableTest.java:
##
@@ -0,0 +1,54 @@
+/*
+ *
+ * Licensed to the Apache
shoothzj commented on code in PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1590948279
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java:
##
@@ -247,6 +256,19 @@ protected void initialize(AbstractConfiguration
shoothzj commented on code in PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1590948516
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java:
##
@@ -64,6 +66,8 @@
public class ZKMetadataDriverBase implements
lhotari commented on PR #4321:
URL: https://github.com/apache/bookkeeper/pull/4321#issuecomment-2096078122
Actually this PR seems to be fine. The simpleLogger config previously in
`tests/integration-tests-base-groovy/pom.xml` was only used for
`tests/integration-tests-base-groovy`. I think
eolivelli commented on code in PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1590802840
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java:
##
@@ -212,6 +217,10 @@ protected void
shoothzj merged PR #4333:
URL: https://github.com/apache/bookkeeper/pull/4333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new de5a4f21fb build: fix JAVA_HOME not
lhotari commented on PR #4321:
URL: https://github.com/apache/bookkeeper/pull/4321#issuecomment-2096037282
@shoothzj @nicoloboschi There's a need to do some revisits. slf4j-simple is
used in integration tests. This is where this happens:
shoothzj commented on code in PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1590947324
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/BookKeeper.java:
##
@@ -81,6 +81,12 @@ static BookKeeperBuilder newBuilder(final
lhotari commented on PR #4321:
URL: https://github.com/apache/bookkeeper/pull/4321#issuecomment-2096071895
> @lhotari Thanks. It seems MavenClassLoader will load different versions of
bk and unify it to `slf4j-simple`, but why we need this? Let me check if
integrate-tests bookkeeper
shoothzj commented on code in PR #4333:
URL: https://github.com/apache/bookkeeper/pull/4333#discussion_r1590826089
##
docker/Dockerfile:
##
@@ -61,13 +62,15 @@ RUN set -x \
&& tar -xzf "$DISTRO_NAME.tar.gz" \
&& mv bookkeeper-server-${BK_VERSION}/ /opt/bookkeeper/ \
shoothzj opened a new pull request, #4344:
URL: https://github.com/apache/bookkeeper/pull/4344
CVE-2023-44487(7.5), CVE-2023-4785(7.5), CVE-2023-33953(7.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
shoothzj commented on PR #4340:
URL: https://github.com/apache/bookkeeper/pull/4340#issuecomment-2097197427
@dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @StevenLuMT
@wenbingshen @zhaijack PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message,
shoothzj commented on PR #4343:
URL: https://github.com/apache/bookkeeper/pull/4343#issuecomment-2097197726
@dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @StevenLuMT
@wenbingshen @zhaijack PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message,
shoothzj commented on PR #4344:
URL: https://github.com/apache/bookkeeper/pull/4344#issuecomment-2097197941
@dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @StevenLuMT
@wenbingshen @zhaijack PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message,
athanatos commented on issue #869:
URL: https://github.com/apache/bookkeeper/issues/869#issuecomment-2096841552
I'm not working on bk these days -- feel free to close/reassign.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
shoothzj closed issue #3511: circe-checksum, cpu-affinity and native-io contain
invalid maven metadata in pom.xml for packaging
URL: https://github.com/apache/bookkeeper/issues/3511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
shoothzj commented on issue #3511:
URL: https://github.com/apache/bookkeeper/issues/3511#issuecomment-2097150022
Now we have switched to maven, I think we can close this issue now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
shoothzj closed issue #2960: Pulsar is producing and consuming messages, the
bookie_READ_BYTES indicator does not change
URL: https://github.com/apache/bookkeeper/issues/2960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
shoothzj closed issue #4036: NoSuchElementException occured during ledger
replication
URL: https://github.com/apache/bookkeeper/issues/4036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
shoothzj opened a new pull request, #4347:
URL: https://github.com/apache/bookkeeper/pull/4347
### Motivation
- JDK 17 and later throw `UnsupportedOperationException` for the `suspend`
and `resume` methods, causing the `testConstructionZkDelay` and
shoothzj closed issue #2302: Autorecovery may hang indefinitely when zookeeper
connection blips
URL: https://github.com/apache/bookkeeper/issues/2302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
shoothzj commented on issue #2302:
URL: https://github.com/apache/bookkeeper/issues/2302#issuecomment-2097147084
closed by #2471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
shoothzj merged PR #4346:
URL: https://github.com/apache/bookkeeper/pull/4346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 1ae4be04e2 Use slf4j-bom and log4j-bom in
shoothzj commented on PR #4345:
URL: https://github.com/apache/bookkeeper/pull/4345#issuecomment-2097181795
we might need to switch to jdk17 for build. I will open a discuss latter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
shoothzj commented on PR #4347:
URL: https://github.com/apache/bookkeeper/pull/4347#issuecomment-2097198028
@dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @StevenLuMT
@wenbingshen @zhaijack PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message,
shoothzj commented on issue #2950:
URL: https://github.com/apache/bookkeeper/issues/2950#issuecomment-2097241149
See #4328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
shoothzj closed issue #2950: Change `org.apache.bookkeeper.server.Main`
classname，for better recognition.
URL: https://github.com/apache/bookkeeper/issues/2950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
shoothzj closed pull request #4328: Rename Main to BookkeeperStarter for
Improved Clarity and Context
URL: https://github.com/apache/bookkeeper/pull/4328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
shoothzj commented on PR #4328:
URL: https://github.com/apache/bookkeeper/pull/4328#issuecomment-2097240725
@eolivelli @merlimat Ok, I will close this PR and releated issue. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
zymap commented on code in PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1591761669
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/BookKeeper.java:
##
@@ -81,6 +81,13 @@ static BookKeeperBuilder newBuilder(final
shoothzj commented on issue #3511:
URL: https://github.com/apache/bookkeeper/issues/3511#issuecomment-2097497384
@lhotari What can we do with dealing this issue? In `nar-maven-plugin`'s
documentation, `nar` is required. Adding some docs to
gradle user?
--
This is an automated message
lhotari opened a new issue, #3511:
URL: https://github.com/apache/bookkeeper/issues/3511
**BUG REPORT**
***Describe the bug***
circe-checksum, cpu-affinity and native-io contain invalid maven metadata in
pom.xml for packaging.
This has an impact on Gradle builds. For
shoothzj commented on issue #3511:
URL: https://github.com/apache/bookkeeper/issues/3511#issuecomment-2097490110
@lhotari Sorry for I wrong read this, I have reopned this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
shoothzj commented on code in PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1591777510
##
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/DriverMetadataServiceAvailableTest.java:
##
@@ -0,0 +1,53 @@
+/*
+ *
+ * Licensed to the Apache
shoothzj commented on code in PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r159148
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/BookKeeper.java:
##
@@ -81,6 +81,13 @@ static BookKeeperBuilder newBuilder(final
shoothzj commented on code in PR #4334:
URL: https://github.com/apache/bookkeeper/pull/4334#discussion_r1591810241
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java:
##
@@ -40,10 +40,10 @@
public class LedgerDescriptorImpl extends
dlg99 commented on PR #4256:
URL: https://github.com/apache/bookkeeper/pull/4256#issuecomment-2097451781
@shoothzj @thetumbled
> @dlg99 Shall we put this configuration in `Replication Worker settings`
section?
yeah, RW settings seem more relevant
--
This is an
hangc0276 commented on code in PR #4324:
URL: https://github.com/apache/bookkeeper/pull/4324#discussion_r1591771218
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##
@@ -792,9 +792,6 @@ protected List
lhotari commented on issue #3511:
URL: https://github.com/apache/bookkeeper/issues/3511#issuecomment-2097484915
> Now we have switched to maven, I think we can close this issue now.
This isn't about using maven or gradle in bookkeeper.
--
This is an automated message from the
lhotari commented on issue #3511:
URL: https://github.com/apache/bookkeeper/issues/3511#issuecomment-2097485377
@shoothzj please reopen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
59 matches
Mail list logo
