[GitHub] [calcite] chunweilei commented on a change in pull request #1186: [CALCITE-3003] AssertionError when GROUP BY nested field

2019-04-27 Thread GitBox
chunweilei commented on a change in pull request #1186: [CALCITE-3003] AssertionError when GROUP BY nested field URL: https://github.com/apache/calcite/pull/1186#discussion_r279174752 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java

[GitHub] [calcite] my7ym opened a new pull request #1186: [CALCITE-3003] AssertionError when GROUP BY nested field

2019-04-27 Thread GitBox
my7ym opened a new pull request #1186: [CALCITE-3003] AssertionError when GROUP BY nested field URL: https://github.com/apache/calcite/pull/1186 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] vineetgarg02 opened a new pull request #1185: [CALCITE-3012] areColumnsUnique for FULL OUTER JOIN could return wrong answer when ignoreNulls is false

2019-04-27 Thread GitBox
vineetgarg02 opened a new pull request #1185: [CALCITE-3012] areColumnsUnique for FULL OUTER JOIN could return wrong answer when ignoreNulls is false URL: https://github.com/apache/calcite/pull/1185 This is an automated

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279158905 ## File path:

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279158703 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@ -230,6

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279157499 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@ -230,6

[calcite] branch master updated: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei, Alexander Shilov)

2019-04-27 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new a3f81bb [CALCITE-2998] RexCopier should

[GitHub] [calcite] zabetak closed pull request #969: [CALCITE-2738] Add support for copying of RexDynamicParam and RexRangeRef to RexCopier

2019-04-27 Thread GitBox
zabetak closed pull request #969: [CALCITE-2738] Add support for copying of RexDynamicParam and RexRangeRef to RexCopier URL: https://github.com/apache/calcite/pull/969 This is an automated message from the Apache Git

[GitHub] [calcite] zabetak closed pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-27 Thread GitBox
zabetak closed pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164 This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-27 Thread GitBox
chunweilei commented on issue #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#issuecomment-487284735 Update the PR to remove the `visitWindow` method in `RexCopier`. Thanks for your review, @zabetak

[GitHub] [calcite] zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-27 Thread GitBox
zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r279153574 ## File path: core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java ##

[GitHub] [calcite] zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279153158 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ##

[GitHub] [calcite] zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279153072 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@

[GitHub] [calcite] xpleaf opened a new pull request #1184: [CALCITE-3027] Support like query in Elasticsearch

2019-04-27 Thread GitBox
xpleaf opened a new pull request #1184: [CALCITE-3027] Support like query in Elasticsearch URL: https://github.com/apache/calcite/pull/1184 In Elasticsearch, fuzzy matching is implemented by wildcard query: ``` GET /company/_search { "query": { "constant_score": {

[GitHub] [calcite] chunweilei commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-27 Thread GitBox
chunweilei commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r279152055 ## File path: core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java ##

[GitHub] [calcite] chunweilei commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-27 Thread GitBox
chunweilei commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r279152055 ## File path: core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java ##

[GitHub] [calcite] chunweilei commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-27 Thread GitBox
chunweilei commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r279151435 ## File path: core/src/main/java/org/apache/calcite/rex/RexCopier.java ## @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279149970 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ##

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279149934 ## File path: core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279149741 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279149741 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279149384 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279149207 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279149109 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279148975 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-27 Thread GitBox
zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r279147130 ## File path: core/src/main/java/org/apache/calcite/rex/RexCopier.java ## @@

[GitHub] [calcite] julianhyde commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
julianhyde commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279147198 ## File path: core/src/main/java/org/apache/calcite/rel/core/Join.java ## @@

[GitHub] [calcite] zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei)

2019-04-27 Thread GitBox
zabetak commented on a change in pull request #1164: [CALCITE-2998] RexCopier should support all rex types (Chunwei Lei) URL: https://github.com/apache/calcite/pull/1164#discussion_r279147199 ## File path: core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java ##

[GitHub] [calcite] zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

2019-04-27 Thread GitBox
zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r279146938 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ##