[GitHub] [calcite] danny0405 commented on issue #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration

2020-04-08 Thread GitBox
danny0405 commented on issue #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration URL: https://github.com/apache/calcite/pull/1901#issuecomment-611344466 > > > This forces the client to register all rel node types before calling the metadata service > >

[GitHub] [calcite] my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto

2020-04-08 Thread GitBox
my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto URL: https://github.com/apache/calcite/pull/1811#discussion_r404533016 ## File path:

[GitHub] [calcite] my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto

2020-04-08 Thread GitBox
my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto URL: https://github.com/apache/calcite/pull/1811#discussion_r404537134 ## File path:

[GitHub] [calcite] my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto

2020-04-08 Thread GitBox
my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto URL: https://github.com/apache/calcite/pull/1811#discussion_r404537725 ## File path:

[GitHub] [calcite] my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto

2020-04-08 Thread GitBox
my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto URL: https://github.com/apache/calcite/pull/1811#discussion_r404537059 ## File path:

[GitHub] [calcite] my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto

2020-04-08 Thread GitBox
my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto URL: https://github.com/apache/calcite/pull/1811#discussion_r404536366 ## File path:

[GitHub] [calcite] my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto

2020-04-08 Thread GitBox
my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto URL: https://github.com/apache/calcite/pull/1811#discussion_r404533701 ## File path:

[GitHub] [calcite] my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto

2020-04-08 Thread GitBox
my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto URL: https://github.com/apache/calcite/pull/1811#discussion_r404533683 ## File path:

[GitHub] [calcite] my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto

2020-04-08 Thread GitBox
my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto URL: https://github.com/apache/calcite/pull/1811#discussion_r404539706 ## File path:

[GitHub] [calcite] my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto

2020-04-08 Thread GitBox
my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto URL: https://github.com/apache/calcite/pull/1811#discussion_r405954347 ## File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java

[GitHub] [calcite] my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto

2020-04-08 Thread GitBox
my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto URL: https://github.com/apache/calcite/pull/1811#discussion_r404532978 ## File path: core/src/main/java/org/apache/calcite/rel/core/Uncollect.java

[GitHub] [calcite] my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto

2020-04-08 Thread GitBox
my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto URL: https://github.com/apache/calcite/pull/1811#discussion_r404536253 ## File path:

[GitHub] [calcite] my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto

2020-04-08 Thread GitBox
my7ym commented on a change in pull request #1811: [CALCITE-3789] Support validation of UNNEST multiple array columns like Presto URL: https://github.com/apache/calcite/pull/1811#discussion_r404546322 ## File path:

[GitHub] [calcite] wangxlong commented on issue #1878: [CALCITE-3782]Bitwise agg operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type

2020-04-08 Thread GitBox
wangxlong commented on issue #1878: [CALCITE-3782]Bitwise agg operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type URL: https://github.com/apache/calcite/pull/1878#issuecomment-611333982 @chunweilei Thanks for your advice. I have updated.

[GitHub] [calcite] wangxlong commented on a change in pull request #1878: [CALCITE-3782]Bitwise agg operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type

2020-04-08 Thread GitBox
wangxlong commented on a change in pull request #1878: [CALCITE-3782]Bitwise agg operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type URL: https://github.com/apache/calcite/pull/1878#discussion_r405959068 ## File path:

[GitHub] [calcite] liyafan82 commented on issue #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration

2020-04-08 Thread GitBox
liyafan82 commented on issue #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration URL: https://github.com/apache/calcite/pull/1901#issuecomment-611323671 > > This forces the client to register all rel node types before calling the metadata service > >

[GitHub] [calcite] danny0405 edited a comment on issue #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration

2020-04-08 Thread GitBox
danny0405 edited a comment on issue #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration URL: https://github.com/apache/calcite/pull/1901#issuecomment-611309771 > This forces the client to register all rel node types before calling the metadata service

[GitHub] [calcite] danny0405 commented on issue #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration

2020-04-08 Thread GitBox
danny0405 commented on issue #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration URL: https://github.com/apache/calcite/pull/1901#issuecomment-611309771 > This forces the client to register all rel node types before calling the metadata service How ?

[GitHub] [calcite] danny0405 commented on a change in pull request #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration

2020-04-08 Thread GitBox
danny0405 commented on a change in pull request #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration URL: https://github.com/apache/calcite/pull/1901#discussion_r405936361 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #618: [CALCITE-2157] ClickHouse dialect implementation.

2020-04-08 Thread GitBox
danny0405 commented on a change in pull request #618: [CALCITE-2157] ClickHouse dialect implementation. URL: https://github.com/apache/calcite/pull/618#discussion_r405935795 ## File path: core/src/main/java/org/apache/calcite/sql/dialect/ClickHouseSqlDialect.java ## @@

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-04-08 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r405929414 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-04-08 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r405928980 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java

[GitHub] [calcite] danny0405 opened a new pull request #1903: [CALCITE-3900] Add Config for SqlValidator

2020-04-08 Thread GitBox
danny0405 opened a new pull request #1903: [CALCITE-3900] Add Config for SqlValidator URL: https://github.com/apache/calcite/pull/1903 The SqlValidator now has 7 setXXX methods for all kinds of control flags, which is hard for code evolving. There is also no way to config these

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-04-08 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r405928280 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java

[GitHub] [calcite] xndai commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-04-08 Thread GitBox
xndai commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r405927959 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1902: Add github pull request link in git commit messages in IDEA

2020-04-08 Thread GitBox
hsyuan commented on a change in pull request #1902: Add github pull request link in git commit messages in IDEA URL: https://github.com/apache/calcite/pull/1902#discussion_r405924370 ## File path: .idea/vcs.xml ## @@ -7,6 +7,10 @@

[GitHub] [calcite] chunweilei commented on a change in pull request #1902: Add github pull request link in git commit messages in IDEA

2020-04-08 Thread GitBox
chunweilei commented on a change in pull request #1902: Add github pull request link in git commit messages in IDEA URL: https://github.com/apache/calcite/pull/1902#discussion_r405921324 ## File path: .idea/vcs.xml ## @@ -7,6 +7,10 @@

[GitHub] [calcite] hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-04-08 Thread GitBox
hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r405912405 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java

[GitHub] [calcite] xndai commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset

2020-04-08 Thread GitBox
xndai commented on a change in pull request #1860: [CALCITE-2970] Add abstractConverter only between derived and required traitset URL: https://github.com/apache/calcite/pull/1860#discussion_r405899756 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java

[GitHub] [calcite] hsyuan opened a new pull request #1902: Add github pull request link in git commit messages in IDEA

2020-04-08 Thread GitBox
hsyuan opened a new pull request #1902: Add github pull request link in git commit messages in IDEA URL: https://github.com/apache/calcite/pull/1902 In light of https://github.com/apache/calcite/pull/1898,

[calcite-avatica-go] 03/05: [CALCITE-3904] Upgrade Github actions dependencies

2020-04-08 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit dad52f9c17cfb709f49a5cf80ef78ae8d20fb85a Author: Francis Chuang AuthorDate: Thu Apr 9 09:30:15 2020

[calcite-avatica-go] 04/05: [CALCITE-3905] Upgrade gokrb5 to v8

2020-04-08 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit 8cec1eaf7f75cd93a1f617cb8b34bf52898b02da Author: Francis Chuang AuthorDate: Thu Apr 9 09:47:39 2020

[calcite-avatica-go] branch master updated (e2f87a3 -> a5b8252)

2020-04-08 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. from e2f87a3 [CALCITE-3320] Use transitional x/xerrors package when working with errors new

[calcite-avatica-go] 02/05: [CALCITE-3903] Upgrade protobuf generation dependencies and regenerate avatica protobufs

2020-04-08 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit 127418a0cd0d28c706b9484e2d6cff49df299234 Author: Francis Chuang AuthorDate: Thu Apr 9 09:20:23 2020

[calcite-avatica-go] 05/05: [CALCITE-3906] Pin witch in tools.go file

2020-04-08 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit a5b82529db9ac6007ced41a65277e0d59f90f402 Author: Francis Chuang AuthorDate: Thu Apr 9 09:48:33 2020

[calcite-avatica-go] 01/05: [CALCITE-3902] Upgrade Go to 1.13 and 1.14

2020-04-08 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit c028c418dc76aab66e8f4ee659c99a4509e0a51c Author: Francis Chuang AuthorDate: Thu Apr 9 09:13:42 2020

[calcite-avatica] branch master updated: Fix invalid link

2020-04-08 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git The following commit(s) were added to refs/heads/master by this push: new bf6f8f7 Fix invalid link

[GitHub] [calcite-avatica] F21 merged pull request #122: Fix invalid link

2020-04-08 Thread GitBox
F21 merged pull request #122: Fix invalid link URL: https://github.com/apache/calcite-avatica/pull/122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [calcite] vineetgarg02 commented on issue #1900: [CALCITE-3733] MySQL JDBC rewrite should rewrite CAST as TIMESTAMP to CAST as DATETIME (Vineet Garg)

2020-04-08 Thread GitBox
vineetgarg02 commented on issue #1900: [CALCITE-3733] MySQL JDBC rewrite should rewrite CAST as TIMESTAMP to CAST as DATETIME (Vineet Garg) URL: https://github.com/apache/calcite/pull/1900#issuecomment-611148690 > Thanks for the fix @vineetgarg02 , let's give this patch a better commit

[GitHub] [calcite] neoremind commented on a change in pull request #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration

2020-04-08 Thread GitBox
neoremind commented on a change in pull request #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration URL: https://github.com/apache/calcite/pull/1901#discussion_r405654235 ## File path:

[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-08 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-611042597 @vlsi Thank you for your quick response. I have added new benchmark test case for baseline to

[GitHub] [calcite] neoremind commented on a change in pull request #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration

2020-04-08 Thread GitBox
neoremind commented on a change in pull request #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration URL: https://github.com/apache/calcite/pull/1901#discussion_r405654235 ## File path:

[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-08 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-611042597 @vlsi Thank you for your quick response. I have added new benchmark test case for baseline to

[GitHub] [calcite] neoremind commented on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-08 Thread GitBox
neoremind commented on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-611042597 @vlsi Thank you for your quick response. I have added new benchmark test case for baseline to disable

[GitHub] [calcite] eolivelli commented on issue #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration

2020-04-08 Thread GitBox
eolivelli commented on issue #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration URL: https://github.com/apache/calcite/pull/1901#issuecomment-611016923 Thank you @liyafan82 This implementation will unblock this issue on HerdDB !

[GitHub] [calcite] eolivelli commented on a change in pull request #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration

2020-04-08 Thread GitBox
eolivelli commented on a change in pull request #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration URL: https://github.com/apache/calcite/pull/1901#discussion_r40550 ## File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java

[GitHub] [calcite] liyafan82 opened a new pull request #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration

2020-04-08 Thread GitBox
liyafan82 opened a new pull request #1901: [CALCITE-3901] Introduce an option to disable metadata handler regeneration URL: https://github.com/apache/calcite/pull/1901 According to our investigation, Calcite can produce large performance overhead due to meta data handler regeneration.

[GitHub] [calcite] wenhuitang commented on issue #1881: [CALCITE-3216] ClassCastException when running aggregate function and window function over Union

2020-04-08 Thread GitBox
wenhuitang commented on issue #1881: [CALCITE-3216] ClassCastException when running aggregate function and window function over Union URL: https://github.com/apache/calcite/pull/1881#issuecomment-610904642 > 1. Legal type pairs that is assignable in validation but illegal in runtime.

[GitHub] [calcite-avatica] docete commented on a change in pull request #121: [CALCITE-3881][avatica] DateTimeUtils#addMonths yields incorrect resu…

2020-04-08 Thread GitBox
docete commented on a change in pull request #121: [CALCITE-3881][avatica] DateTimeUtils#addMonths yields incorrect resu… URL: https://github.com/apache/calcite-avatica/pull/121#discussion_r405400865 ## File path:

[calcite] branch site updated: Site: Add Feng Zhu as committer

2020-04-08 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new f7d7079 Site: Add Feng Zhu as committer f7d7079

[calcite] branch master updated (c3147f4 -> 5f7c51d)

2020-04-08 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from c3147f4 [CALCITE-3898] RelOptPredicateList may generate incorrect map of constant values add 5f7c51d Site:

[GitHub] [calcite] vlsi commented on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-08 Thread GitBox
vlsi commented on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-610846372 > it describes "Weak values will be garbage collected once they are weakly reachable. This makes them a

[GitHub] [calcite] vlsi edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-08 Thread GitBox
vlsi edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-610846372 > it describes "Weak values will be garbage collected once they are weakly reachable. This makes

[GitHub] [calcite] vlsi commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-08 Thread GitBox
vlsi commented on a change in pull request #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#discussion_r405375307 ## File path:

[GitHub] [calcite] chris-baynes commented on a change in pull request #618: [CALCITE-2157] ClickHouse dialect implementation.

2020-04-08 Thread GitBox
chris-baynes commented on a change in pull request #618: [CALCITE-2157] ClickHouse dialect implementation. URL: https://github.com/apache/calcite/pull/618#discussion_r405369431 ## File path: core/src/main/java/org/apache/calcite/sql/dialect/ClickHouseSqlDialect.java ##

[GitHub] [calcite] neoremind commented on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-08 Thread GitBox
neoremind commented on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-610838697 @vlsi sorry to bother you, would you take a look of my update again? I'd like to move forward this PR,

[GitHub] [calcite] chris-baynes commented on a change in pull request #618: [CALCITE-2157] ClickHouse dialect implementation.

2020-04-08 Thread GitBox
chris-baynes commented on a change in pull request #618: [CALCITE-2157] ClickHouse dialect implementation. URL: https://github.com/apache/calcite/pull/618#discussion_r405316536 ## File path: core/src/main/java/org/apache/calcite/sql/dialect/ClickHouseSqlDialect.java ##