[GitHub] [calcite] LakeShen commented on a diff in pull request #3316: [CALCITE-5837] Make RexUtil#pullFactors method RexNode condition ordered when input RexNode's kind is OR

LakeShen commented on code in PR #3316: URL: https://github.com/apache/calcite/pull/3316#discussion_r1279386104 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -801,6 +804,17 @@ private void checkExponentialCnf(int n) { and(eRef,

[GitHub] [calcite] LakeShen commented on a diff in pull request #3316: [CALCITE-5837] Make RexUtil#pullFactors method RexNode condition ordered when input RexNode's kind is OR

LakeShen commented on code in PR #3316: URL: https://github.com/apache/calcite/pull/3316#discussion_r1279128197 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -801,6 +804,17 @@ private void checkExponentialCnf(int n) { and(eRef,

[GitHub] [calcite] LakeShen commented on a diff in pull request #3316: [CALCITE-5837] Make RexUtil#pullFactors method RexNode condition ordered when input RexNode's kind is OR

LakeShen commented on code in PR #3316: URL: https://github.com/apache/calcite/pull/3316#discussion_r1279061699 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -801,6 +808,40 @@ private void checkExponentialCnf(int n) { and(eRef,

[GitHub] [calcite] LakeShen commented on a diff in pull request #3316: [CALCITE-5837] Make RexUtil#pullFactors method RexNode condition ordered when input RexNode's kind is OR

LakeShen commented on code in PR #3316: URL: https://github.com/apache/calcite/pull/3316#discussion_r1279061424 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -801,6 +808,40 @@ private void checkExponentialCnf(int n) { and(eRef,

[GitHub] [calcite] LakeShen commented on a diff in pull request #3316: [CALCITE-5837] Make RexUtil#pullFactors method RexNode condition ordered when input RexNode's kind is OR

LakeShen commented on code in PR #3316: URL: https://github.com/apache/calcite/pull/3316#discussion_r1278577508 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -801,6 +808,40 @@ private void checkExponentialCnf(int n) { and(eRef,

[GitHub] [calcite] LakeShen commented on a diff in pull request #3316: [CALCITE-5837] Make RexUtil#pullFactors method RexNode condition ordered when input RexNode's kind is OR

LakeShen commented on code in PR #3316: URL: https://github.com/apache/calcite/pull/3316#discussion_r1266972865 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -801,6 +804,17 @@ private void checkExponentialCnf(int n) { and(eRef,

[GitHub] [calcite] LakeShen commented on a diff in pull request #3316: [CALCITE-5837] Make RexUtil#pullFactors method RexNode condition ordered when input RexNode's kind is OR

LakeShen commented on code in PR #3316: URL: https://github.com/apache/calcite/pull/3316#discussion_r1265353606 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -801,6 +804,17 @@ private void checkExponentialCnf(int n) { and(eRef,