amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-578236241
@34venu
Could you send an email to d...@calcite.apache.
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-576808959
@34venu
my understanding is it should just work by calc
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-572188306
@danny0405 I tried to send an email to @julianhyde to remind th
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-569856183
A friendly ping~
-
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-569327858
All green now.
---
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-569157424
The failed tests seems not relevant to this PR:
```
o
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-569130563
Comments addressed.
--
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-568951886
@danny0405
Thanks Danny! I added two more tests in both
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-568940553
Ok. I added CALCITE-3629 as a separate commit in this PR, in wh
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-56875
@danny0405
I understand your concerns. Current implementati
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-568686794
@danny0405 thanks for your awesome work! I merged your change i
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-568416284
just Remove the unnecessary changes in OperandTypes and ReturnT
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-568384386
Gotcha. So you think the better way is to use `SqlKind.OTHER_FU
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-568213301
A friendly ping~ comments were addressed.
@danny0405 I r
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-566676370
@danny0405
Ok, until this moment I have tried addressed
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-566424141
Checks are failing because of
[CALCITE-3604](https://issues.ap
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-564167785
@danny0405 Thank you!
conflict solved and indentation fi
amaliujia commented on issue #1587: [CALCITE-3272] Support TUMBLE as Table
Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#issuecomment-558374075
@julianhyde thanks for reviewing. Have tried to address your co
18 matches
Mail list logo
