[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-09-02 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r482251924 ## File path: core/src/main/java/org/apache/calcite/rex/RexUtil.java ## @@ -2833,4 +2898,77 @@ public boolean anyContain(Iterable nodes) { }

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-09-02 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r481867589 ## File path: core/src/main/java/org/apache/calcite/rex/RexUtil.java ## @@ -2833,4 +2898,77 @@ public boolean anyContain(Iterable nodes) { }

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-09-01 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r481301691 ## File path: core/src/main/java/org/apache/calcite/rex/RexUtil.java ## @@ -2833,4 +2898,77 @@ public boolean anyContain(Iterable nodes) { }

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-09-01 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r480872672 ## File path: core/src/main/java/org/apache/calcite/rex/RexUtil.java ## @@ -2833,4 +2898,77 @@ public boolean anyContain(Iterable nodes) { }

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-08-31 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r480787362 ## File path: core/src/main/java/org/apache/calcite/rex/RexUtil.java ## @@ -2833,4 +2898,77 @@ public boolean anyContain(Iterable nodes) { }

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-08-31 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r480775930 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlInOperator.java ## @@ -60,7 +60,8 @@ */ SqlInOperator(SqlKind kind) {

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-08-31 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r480772730 ## File path: core/src/main/java/org/apache/calcite/util/RangeSets.java ## @@ -43,4 +49,384 @@ private RangeSets() {} public static > RangeSet

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-08-31 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r480290137 ## File path: core/src/test/java/org/apache/calcite/rel/rules/DateRangeRulesTest.java ## @@ -88,8 +88,7 @@ "UTC",

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-08-31 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r480288513 ## File path: core/src/test/java/org/apache/calcite/rel/rules/DateRangeRulesTest.java ## @@ -88,8 +88,7 @@ "UTC",

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-08-31 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r480278359 ## File path: core/src/test/java/org/apache/calcite/rel/rules/DateRangeRulesTest.java ## @@ -88,8 +88,7 @@ "UTC",

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-08-31 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r480261582 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -2515,4 +2510,214 @@ public RexNode simplifyFilterPredicates(Iterable

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-08-31 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r480258535 ## File path: core/src/test/java/org/apache/calcite/rel/rules/DateRangeRulesTest.java ## @@ -88,8 +88,7 @@ "UTC",

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-08-31 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r480257480 ## File path: core/src/main/java/org/apache/calcite/rex/RexLiteral.java ## @@ -568,133 +592,149 @@ public void printAsJava(PrintWriter pw) { *

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-08-28 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r479603946 ## File path: core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml ## @@ -6976,7 +6976,7 @@ GROUP by deptno, job]]>

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-08-28 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r479603916 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -653,15 +657,19 @@ private RexNode simplifyUnaryPlus(RexCall call,

[GitHub] [calcite] julianhyde commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

2020-08-28 Thread GitBox
julianhyde commented on a change in pull request #2124: URL: https://github.com/apache/calcite/pull/2124#discussion_r479603588 ## File path: core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java ## @@ -640,10 +640,10 @@ public Result visit(Values e) {