julianhyde commented on a change in pull request #2124:
URL: https://github.com/apache/calcite/pull/2124#discussion_r480775930
##########
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlInOperator.java
##########
@@ -60,7 +60,8 @@
*/
SqlInOperator(SqlKind kind) {
this(kind.sql, kind);
- assert kind == SqlKind.IN || kind == SqlKind.NOT_IN;
+ assert kind == SqlKind.IN || kind == SqlKind.NOT_IN
+ || kind == SqlKind.DRUID_IN || kind == SqlKind.DRUID_NOT_IN;
Review comment:
It's better than the alternative. Which is to remove IN from all Druid
code (I tried - it's near impossible) or to continue to allow people to use IN
inside RexCall with two completely different meanings (IN-list and
IN-sub-query).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
