julianhyde commented on a change in pull request #2124:
URL: https://github.com/apache/calcite/pull/2124#discussion_r480288513
##########
File path:
core/src/test/java/org/apache/calcite/rel/rules/DateRangeRulesTest.java
##########
@@ -88,8 +88,7 @@
"UTC",
is("AND(AND(>=($8, 2014-01-01), <($8, 2015-01-01)),"
+ " AND(>=($8, 2014-06-01), <($8, 2014-07-01)))"),
- is("AND(>=($8, 2014-01-01), <($8, 2015-01-01),"
- + " >=($8, 2014-06-01), <($8, 2014-07-01))"));
+ is("SEARCH($8, Sarg[[2014-06-01\u20252014-07-01)])"));
}
Review comment:
I don't care about how many characters (or bytes) the line takes. I care
about how many positions it takes in my text editor. I think checkstyle is
checking the wrong thing, so it's a checkstyle bug.
The simplest thing is to revert to ascii and use \u escapes. Which is what I
have done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
