[GitHub] [calcite] julianhyde commented on a diff in pull request #3245: [CALCITE-5747] Conflicting FLOOR return type between Calcite and BigQ…

julianhyde commented on code in PR #3245: URL: https://github.com/apache/calcite/pull/3245#discussion_r1237732224 ## site/_docs/reference.md: ## @@ -2661,6 +2661,7 @@ BigQuery's type system uses confusingly different names for types and functions: | s | ARRAY_SIZE(array)

[GitHub] [calcite] julianhyde commented on a diff in pull request #3245: [CALCITE-5747] Conflicting FLOOR return type between Calcite and BigQ…

julianhyde commented on code in PR #3245: URL: https://github.com/apache/calcite/pull/3245#discussion_r1224881785 ## core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java: ## @@ -1853,12 +1853,14 @@ public class SqlStdOperatorTable extends

[GitHub] [calcite] julianhyde commented on a diff in pull request #3245: [CALCITE-5747] Conflicting FLOOR return type between Calcite and BigQ…

julianhyde commented on code in PR #3245: URL: https://github.com/apache/calcite/pull/3245#discussion_r1224877404 ## core/src/main/java/org/apache/calcite/sql/fun/SqlFloorFunction.java: ## @@ -41,22 +45,23 @@ public class SqlFloorFunction extends SqlMonotonicUnaryFunction {