[GitHub] [calcite] liyafan82 commented on a change in pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

liyafan82 commented on a change in pull request #2243: URL: https://github.com/apache/calcite/pull/2243#discussion_r517083852 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -768,22 +772,22 @@ private boolean

[GitHub] [calcite] liyafan82 commented on a change in pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

liyafan82 commented on a change in pull request #2243: URL: https://github.com/apache/calcite/pull/2243#discussion_r517083461 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -601,7 +604,7 @@ private boolean checkLowerBound(RelNode

[GitHub] [calcite] liyafan82 commented on a change in pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

liyafan82 commented on a change in pull request #2243: URL: https://github.com/apache/calcite/pull/2243#discussion_r517083286 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -590,7 +593,7 @@ private RelNode convert(RelNode rel,

[GitHub] [calcite] liyafan82 commented on a change in pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

liyafan82 commented on a change in pull request #2243: URL: https://github.com/apache/calcite/pull/2243#discussion_r517082361 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -311,31 +311,31 @@ default boolean onProduce(RelNode

[GitHub] [calcite] liyafan82 commented on a change in pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

liyafan82 commented on a change in pull request #2243: URL: https://github.com/apache/calcite/pull/2243#discussion_r517081499 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -170,27 +170,27 @@ private void clearProcessed(RelSet

[GitHub] [calcite] liyafan82 commented on a change in pull request #2243: Fix grammatical errors in TopDownRuleDriver/TopDownRuleQueue/RuleDriver/VolcanoPlanner

liyafan82 commented on a change in pull request #2243: URL: https://github.com/apache/calcite/pull/2243#discussion_r517080225 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java ## @@ -69,8 +69,8 @@ private GeneratorTask applying = null;