chucheng92 commented on PR #3459:
URL: https://github.com/apache/calcite/pull/3459#issuecomment-1785227201
> LGTM, sorry for the delay! Congrats on becoming a committer!
thanks tanner. you helped me to a lot. :)
--
This is an automated message from the Apache Git Service.
To
tanclary merged PR #3459:
URL: https://github.com/apache/calcite/pull/3459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3459:
URL: https://github.com/apache/calcite/pull/3459#issuecomment-1781758539
Kudos, SonarCloud Quality Gate passed! [ {
public RelNode
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372573530
##
core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java:
##
@@ -1221,6 +1225,53 @@ private static class MapFromEntriesOperandTypeChecker
}
}
+
JiajunBernoulli commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372495642
##
core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java:
##
@@ -1221,6 +1225,53 @@ private static class MapFromEntriesOperandTypeChecker
}
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372215059
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372215059
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372215059
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372215059
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372215059
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372215059
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1372215059
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
tanclary commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1371982252
##
core/src/main/java/org/apache/calcite/prepare/LixToRelTranslator.java:
##
@@ -97,7 +97,7 @@ public RelNode translate(Queryable queryable) {
public RelNode
chucheng92 commented on PR #3459:
URL: https://github.com/apache/calcite/pull/3459#issuecomment-1779211043
hi, @tanclary Sorry to pin you, I have solved the comments. could you help
to re-check it?
--
This is an automated message from the Apache Git Service.
To respond to the message,
sonarcloud[bot] commented on PR #3459:
URL: https://github.com/apache/calcite/pull/3459#issuecomment-1766408159
Kudos, SonarCloud Quality Gate passed! [, it supports
the form like 'cast(null as map)'
--
This is an automated message
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358161626
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6703,11 +6704,53 @@ private static void checkIf(SqlOperatorFixture f) {
// test
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358161626
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6703,11 +6704,53 @@ private static void checkIf(SqlOperatorFixture f) {
// test
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358158316
##
core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java:
##
@@ -1221,6 +1225,53 @@ private static class MapFromEntriesOperandTypeChecker
}
}
+
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358246934
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1082,6 +1084,38 @@ private static RelDataType
arrayReturnType(SqlOperatorBinding
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358161626
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6703,11 +6704,53 @@ private static void checkIf(SqlOperatorFixture f) {
// test
sonarcloud[bot] commented on PR #3459:
URL: https://github.com/apache/calcite/pull/3459#issuecomment-1761405658
Kudos, SonarCloud Quality Gate passed! [ would it be better to add an enum to the Bug class?`
this one.
I have rebased the main
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358166406
##
core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java:
##
@@ -568,6 +569,9 @@ public static SqlOperandTypeChecker variadic(
public static final
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358166726
##
core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java:
##
@@ -1221,6 +1225,53 @@ private static class MapFromEntriesOperandTypeChecker
}
}
+
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358164236
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -873,6 +874,7 @@ Builder populate2() {
map.put(MAP_VALUE_CONSTRUCTOR,
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358164736
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -5251,6 +5251,17 @@ public static Map mapFromArrays(List keysArray, List
valuesArray) {
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358164236
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -873,6 +874,7 @@ Builder populate2() {
map.put(MAP_VALUE_CONSTRUCTOR,
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358162190
##
site/_docs/reference.md:
##
@@ -2769,6 +2769,7 @@ BigQuery's type system uses confusingly different names
for types and functions:
| b | TO_HEX(binary)
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358161626
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6703,11 +6704,53 @@ private static void checkIf(SqlOperatorFixture f) {
// test
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358157015
##
core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java:
##
@@ -1221,6 +1225,53 @@ private static class MapFromEntriesOperandTypeChecker
}
}
+
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358157015
##
core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java:
##
@@ -1221,6 +1225,53 @@ private static class MapFromEntriesOperandTypeChecker
}
}
+
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1358155535
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -5251,6 +5251,17 @@ public static Map mapFromArrays(List keysArray, List
valuesArray) {
tanclary commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1357038522
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -5251,6 +5251,17 @@ public static Map mapFromArrays(List keysArray, List
valuesArray) {
sonarcloud[bot] commented on PR #3459:
URL: https://github.com/apache/calcite/pull/3459#issuecomment-1757045249
Kudos, SonarCloud Quality Gate passed! [ {
// test
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1349646120
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -4886,14 +4886,21 @@ SqlNode MapConstructor() :
{
{ s = span(); }
(
-LOOKAHEAD(1)
-
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1349646120
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -4886,14 +4886,21 @@ SqlNode MapConstructor() :
{
{ s = span(); }
(
-LOOKAHEAD(1)
-
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1349685796
##
site/_docs/reference.md:
##
@@ -2769,6 +2769,7 @@ BigQuery's type system uses confusingly different names
for types and functions:
| b | TO_HEX(binary)
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1349646490
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1077,6 +1079,38 @@ private static RelDataType
arrayReturnType(SqlOperatorBinding
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1349646490
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1077,6 +1079,38 @@ private static RelDataType
arrayReturnType(SqlOperatorBinding
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1349646120
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -4886,14 +4886,21 @@ SqlNode MapConstructor() :
{
{ s = span(); }
(
-LOOKAHEAD(1)
-
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1349646490
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1077,6 +1079,38 @@ private static RelDataType
arrayReturnType(SqlOperatorBinding
chucheng92 commented on PR #3459:
URL: https://github.com/apache/calcite/pull/3459#issuecomment-1751953719
@macroguo-ghy hi, thanks for reviewing.
Because we have implemented Spark's ARRAY function, their processing logic
on parser and empty array/map is similar, if compare with 2 PRs
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1349646490
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1077,6 +1079,38 @@ private static RelDataType
arrayReturnType(SqlOperatorBinding
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1349646220
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6604,11 +6605,44 @@ private static void checkIf(SqlOperatorFixture f) {
// test
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1349646120
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -4886,14 +4886,21 @@ SqlNode MapConstructor() :
{
{ s = span(); }
(
-LOOKAHEAD(1)
-
chucheng92 commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1349645838
##
site/_docs/reference.md:
##
@@ -2769,6 +2769,7 @@ BigQuery's type system uses confusingly different names
for types and functions:
| b | TO_HEX(binary)
macroguo-ghy commented on code in PR #3459:
URL: https://github.com/apache/calcite/pull/3459#discussion_r1349635823
##
site/_docs/reference.md:
##
@@ -2769,6 +2769,7 @@ BigQuery's type system uses confusingly different names
for types and functions:
| b | TO_HEX(binary)
sonarcloud[bot] commented on PR #3459:
URL: https://github.com/apache/calcite/pull/3459#issuecomment-1751917666
Kudos, SonarCloud Quality Gate passed! [