YiwenWu commented on PR #3684:
URL: https://github.com/apache/calcite/pull/3684#issuecomment-2044211803
> What is the status of this PR? @YiwenWu can you please rebase to eliminate
the conflicts? Thank you,
This PR is out of date and will be split into multiple PRs. I closed it.
--
YiwenWu closed pull request #3684: [CALCITE-6260] Add already implemented
functions in Spark library
URL: https://github.com/apache/calcite/pull/3684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mihaibudiu commented on PR #3684:
URL: https://github.com/apache/calcite/pull/3684#issuecomment-2043741104
What is the status of this PR?
@YiwenWu can you please rebase to eliminate the conflicts?
Thank you,
--
This is an automated message from the Apache Git Service.
To respond to
YiwenWu commented on PR #3684:
URL: https://github.com/apache/calcite/pull/3684#issuecomment-1958460920
Thanks for the review, I will split this PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
tanclary commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1498154787
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -231,13 +233,15 @@
import static
mihaibudiu commented on PR #3684:
URL: https://github.com/apache/calcite/pull/3684#issuecomment-1957681165
This is turning into a very large PR. It probably should have been broken
into 4 different PRs, one for each function to make it easier to review.
--
This is an automated message
sonarcloud[bot] commented on PR #3684:
URL: https://github.com/apache/calcite/pull/3684#issuecomment-1957212889
## [ | Returns the bit (0 or
1) value at the
YiwenWu commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1497519634
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -2259,6 +2272,27 @@ private static void
YiwenWu commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1497514526
##
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java:
##
@@ -468,6 +468,8 @@ public enum BuiltInMethod {
String[].class),
YiwenWu commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1497482552
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -1491,6 +1491,19 @@ public static String concatMultiWithNull(String... args)
{
public
YiwenWu commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1497481966
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -231,13 +233,15 @@
import static
YiwenWu commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1497477187
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -152,6 +152,7 @@
import static
tanclary commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1488379478
##
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java:
##
@@ -468,6 +468,8 @@ public enum BuiltInMethod {
String[].class),
YiwenWu commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1495812154
##
babel/src/test/java/org/apache/calcite/test/BabelQuidemTest.java:
##
@@ -131,6 +131,16 @@ public static void main(String[] args) throws Exception {
mihaibudiu commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1495018416
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -2259,6 +2272,27 @@ private static void
caicancai commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1494627130
##
site/_docs/reference.md:
##
@@ -2700,12 +2700,14 @@ In the following:
| s | BIT_GET(value, position) | Returns the bit (0 or
1) value at
sonarcloud[bot] commented on PR #3684:
URL: https://github.com/apache/calcite/pull/3684#issuecomment-1951227759
## [ | Returns the bit (0 or
1) value at the
YiwenWu commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1493743574
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -2259,6 +2272,27 @@ private static void
YiwenWu commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1493743503
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -2259,6 +2272,27 @@ private static void
YiwenWu commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1493740036
##
site/_docs/reference.md:
##
@@ -2700,12 +2700,14 @@ In the following:
| s | BIT_GET(value, position) | Returns the bit (0 or
1) value at the
sonarcloud[bot] commented on PR #3684:
URL: https://github.com/apache/calcite/pull/3684#issuecomment-1951145412
## [ throws Exception {
sonarcloud[bot] commented on PR #3684:
URL: https://github.com/apache/calcite/pull/3684#issuecomment-1939122808
## [