chucheng92 commented on code in PR #3366:
URL: https://github.com/apache/calcite/pull/3366#discussion_r1302342558
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -7462,6 +7462,8 @@ SqlIdentifier ReservedFunctionName() :
|
|
|
+|
+|
chucheng92 commented on code in PR #3366:
URL: https://github.com/apache/calcite/pull/3366#discussion_r1302342558
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -7462,6 +7462,8 @@ SqlIdentifier ReservedFunctionName() :
|
|
|
+|
+|
zoudan commented on PR #3378:
URL: https://github.com/apache/calcite/pull/3378#issuecomment-1689158766
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
chucheng92 commented on code in PR #3366:
URL: https://github.com/apache/calcite/pull/3366#discussion_r1301143768
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -7462,6 +7462,8 @@ SqlIdentifier ReservedFunctionName() :
|
|
|
+|
+|
chucheng92 commented on code in PR #3366:
URL: https://github.com/apache/calcite/pull/3366#discussion_r1301143768
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -7462,6 +7462,8 @@ SqlIdentifier ReservedFunctionName() :
|
|
|
+|
+|
chucheng92 commented on code in PR #3366:
URL: https://github.com/apache/calcite/pull/3366#discussion_r1301143768
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -7462,6 +7462,8 @@ SqlIdentifier ReservedFunctionName() :
|
|
|
+|
+|
chucheng92 commented on code in PR #3366:
URL: https://github.com/apache/calcite/pull/3366#discussion_r1301143768
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -7462,6 +7462,8 @@ SqlIdentifier ReservedFunctionName() :
|
|
|
+|
+|
chucheng92 commented on PR #3366:
URL: https://github.com/apache/calcite/pull/3366#issuecomment-1687681608
Hi, bencao, thanks for reviewing. this PR is related with
[CALCITE-5564](https://issues.apache.org/jira/browse/CALCITE-5564)
(https://github.com/apache/calcite/pull/3210), this PR
sonarcloud[bot] commented on PR #3375:
URL: https://github.com/apache/calcite/pull/3375#issuecomment-1687710730
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sonarcloud[bot] commented on PR #3368:
URL: https://github.com/apache/calcite/pull/3368#issuecomment-1687709840
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sonarcloud[bot] commented on PR #3389:
URL: https://github.com/apache/calcite/pull/3389#issuecomment-1687927255
Kudos, SonarCloud Quality Gate passed! [ in this
PR, so I have opened a new PR
libenchao commented on code in PR #3366:
URL: https://github.com/apache/calcite/pull/3366#discussion_r1301478057
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -7462,6 +7462,8 @@ SqlIdentifier ReservedFunctionName() :
|
|
|
+|
+|
libenchao commented on PR #3366:
URL: https://github.com/apache/calcite/pull/3366#issuecomment-1687979383
> Hi, @libenchao , thanks for reviewing. this PR is related with
[CALCITE-5564](https://issues.apache.org/jira/browse/CALCITE-5564) (#3210),
this PR reset the change of keywords in
hujianhong commented on code in PR #3292:
URL: https://github.com/apache/calcite/pull/3292#discussion_r1301658300
##
site/_docs/reference.md:
##
@@ -2764,6 +2764,7 @@ BigQuery's type system uses confusingly different names
for types and functions:
| s |
hujianhong commented on code in PR #3292:
URL: https://github.com/apache/calcite/pull/3292#discussion_r1301664621
##
site/_docs/reference.md:
##
@@ -2764,6 +2764,7 @@ BigQuery's type system uses confusingly different names
for types and functions:
| s |
sonarcloud[bot] commented on PR #3390:
URL: https://github.com/apache/calcite/pull/3390#issuecomment-1688296195
Kudos, SonarCloud Quality Gate passed! [ :
|
|
|
+|
+|
tanclary commented on code in PR #3389:
URL: https://github.com/apache/calcite/pull/3389#discussion_r1301810987
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -929,6 +929,29 @@ public static String charFromUtf8(int n) {
return
tanclary commented on code in PR #3389:
URL: https://github.com/apache/calcite/pull/3389#discussion_r1301811407
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -929,6 +929,29 @@ public static String charFromUtf8(int n) {
return
tanclary commented on code in PR #3378:
URL: https://github.com/apache/calcite/pull/3378#discussion_r1301886422
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -7401,6 +7470,87 @@ private static void checkIf(SqlOperatorFixture f) {
tanclary commented on PR #3378:
URL: https://github.com/apache/calcite/pull/3378#issuecomment-1688522551
@JiajunBernoulli @zoudan Thank you both for your comments, I have dropped
the SAFE_DIVIDE commit from this PR to make it more clear. The expression
parameters tests will be added in the
sonarcloud[bot] commented on PR #3378:
URL: https://github.com/apache/calcite/pull/3378#issuecomment-1688547347
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sonarcloud[bot] commented on PR #3391:
URL: https://github.com/apache/calcite/pull/3391#issuecomment-1688626618
Kudos, SonarCloud Quality Gate passed! [