[PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior. [calcite]

2024-03-01 Thread via GitHub
caicancai opened a new pull request, #3710: URL: https://github.com/apache/calcite/pull/3710 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior. [calcite]

2024-03-01 Thread via GitHub
caicancai closed pull request #3710: [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior. URL: https://github.com/apache/calcite/pull/3710 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [CALCITE-5976] Use explicit CAST if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

2024-03-01 Thread via GitHub
caicancai commented on PR #3705: URL: https://github.com/apache/calcite/pull/3705#issuecomment-1973145979 > @caicancai I have created a commit based on your PR. you can pick and take a look. https://github.com/chucheng92/calcite/tree/CALCITE-5976 Thank you, very much appreciated --

Re: [PR] [CALCITE-5976] Use explicit CAST if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

2024-03-01 Thread via GitHub
chucheng92 commented on PR #3705: URL: https://github.com/apache/calcite/pull/3705#issuecomment-1972932906 @caicancai I have created a commit based on your PR. you can pick and take a look. https://github.com/chucheng92/calcite/tree/CALCITE-5976 -- This is an automated message from

Re: [PR] [CALCITE-5976] Use explicit CAST if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

2024-03-01 Thread via GitHub
sonarcloud[bot] commented on PR #3705: URL: https://github.com/apache/calcite/pull/3705#issuecomment-1973169933 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-5893] Wrong NULL operand behavior of ARRAY_CONTAINS/ARRAY_EXCEPT/ARRAY_INTERSECT In Spark Library [calcite]

2024-03-01 Thread via GitHub
mihaibudiu commented on code in PR #3355: URL: https://github.com/apache/calcite/pull/3355#discussion_r1509387190 ## core/src/main/java/org/apache/calcite/sql/type/ArrayElementOperandTypeChecker.java: ## @@ -31,11 +32,41 @@ * Parameter type-checking strategy where types must

[PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
caicancai opened a new pull request, #3711: URL: https://github.com/apache/calcite/pull/3711 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
caicancai commented on code in PR #3711: URL: https://github.com/apache/calcite/pull/3711#discussion_r1509091687 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -2157,6 +2165,23 @@ private static RelDataType

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
caicancai commented on code in PR #3711: URL: https://github.com/apache/calcite/pull/3711#discussion_r1509097927 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -2157,6 +2165,23 @@ private static RelDataType

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
caicancai commented on code in PR #3711: URL: https://github.com/apache/calcite/pull/3711#discussion_r1509096477 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -2157,6 +2165,23 @@ private static RelDataType

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
sonarcloud[bot] commented on PR #3711: URL: https://github.com/apache/calcite/pull/3711#issuecomment-1973338826 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
caicancai commented on code in PR #3711: URL: https://github.com/apache/calcite/pull/3711#discussion_r1509097927 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -2157,6 +2165,23 @@ private static RelDataType

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
caicancai commented on code in PR #3711: URL: https://github.com/apache/calcite/pull/3711#discussion_r1509098703 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6280,6 +6280,94 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
caicancai commented on code in PR #3711: URL: https://github.com/apache/calcite/pull/3711#discussion_r1509098703 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6280,6 +6280,94 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
caicancai commented on code in PR #3711: URL: https://github.com/apache/calcite/pull/3711#discussion_r1509098703 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6280,6 +6280,94 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

Re: [PR] [CALCITE-5893] Wrong NULL operand behavior of ARRAY_CONTAINS/ARRAY_EXCEPT/ARRAY_INTERSECT In Spark Library [calcite]

2024-03-01 Thread via GitHub
chucheng92 commented on code in PR #3355: URL: https://github.com/apache/calcite/pull/3355#discussion_r1509890311 ## core/src/main/java/org/apache/calcite/sql/type/ArrayElementOperandTypeChecker.java: ## @@ -31,11 +32,41 @@ * Parameter type-checking strategy where types must

Re: [PR] chore: fix doc for strong predicates [calcite]

2024-03-01 Thread via GitHub
YiwenWu commented on code in PR #3709: URL: https://github.com/apache/calcite/pull/3709#discussion_r1509905708 ## core/src/main/java/org/apache/calcite/plan/Strong.java: ## @@ -53,8 +53,6 @@ * {@code p1 AND p2} is strong in [p1, p2] (definitely null if either p1 * is

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
caicancai commented on code in PR #3711: URL: https://github.com/apache/calcite/pull/3711#discussion_r1509907242 ## site/_docs/reference.md: ## @@ -2783,7 +2783,10 @@ In the following: | b f s | LENGTH(string) | Equivalent to `CHAR_LENGTH(string)`

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
caicancai commented on code in PR #3711: URL: https://github.com/apache/calcite/pull/3711#discussion_r1509907088 ## core/src/main/java/org/apache/calcite/util/BuiltInMethod.java: ## @@ -510,7 +510,7 @@ public enum BuiltInMethod { SAFE_MULTIPLY(SqlFunctions.class,

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
caicancai commented on code in PR #3711: URL: https://github.com/apache/calcite/pull/3711#discussion_r1509907088 ## core/src/main/java/org/apache/calcite/util/BuiltInMethod.java: ## @@ -510,7 +510,7 @@ public enum BuiltInMethod { SAFE_MULTIPLY(SqlFunctions.class,

Re: [PR] [CALCITE-5893] Wrong NULL operand behavior of ARRAY_CONTAINS/ARRAY_EXCEPT/ARRAY_INTERSECT In Spark Library [calcite]

2024-03-01 Thread via GitHub
chucheng92 commented on code in PR #3355: URL: https://github.com/apache/calcite/pull/3355#discussion_r1509890311 ## core/src/main/java/org/apache/calcite/sql/type/ArrayElementOperandTypeChecker.java: ## @@ -31,11 +32,41 @@ * Parameter type-checking strategy where types must

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
caicancai commented on code in PR #3711: URL: https://github.com/apache/calcite/pull/3711#discussion_r1509906770 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -2157,6 +2165,23 @@ private static RelDataType

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
YiwenWu commented on code in PR #3711: URL: https://github.com/apache/calcite/pull/3711#discussion_r1509897618 ## core/src/main/java/org/apache/calcite/util/BuiltInMethod.java: ## @@ -510,7 +510,7 @@ public enum BuiltInMethod { SAFE_MULTIPLY(SqlFunctions.class,

Re: [PR] [CALCITE-6248] Illegal dates are accepted by casts [calcite]

2024-03-01 Thread via GitHub
YiwenWu commented on code in PR #3708: URL: https://github.com/apache/calcite/pull/3708#discussion_r1509906302 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -1329,8 +1329,14 @@ void testCastStringToDateTime(CastType castType, SqlOperatorFixture

Re: [PR] chore: fix doc for strong predicates [calcite]

2024-03-01 Thread via GitHub
YiwenWu commented on code in PR #3709: URL: https://github.com/apache/calcite/pull/3709#discussion_r1509905708 ## core/src/main/java/org/apache/calcite/plan/Strong.java: ## @@ -53,8 +53,6 @@ * {@code p1 AND p2} is strong in [p1, p2] (definitely null if either p1 * is

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-01 Thread via GitHub
caicancai commented on code in PR #3711: URL: https://github.com/apache/calcite/pull/3711#discussion_r1509906580 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -2157,6 +2165,23 @@ private static RelDataType

Re: [PR] chore: fix doc for strong predicates [calcite]

2024-03-01 Thread via GitHub
chenzl25 commented on code in PR #3709: URL: https://github.com/apache/calcite/pull/3709#discussion_r1509909245 ## core/src/main/java/org/apache/calcite/plan/Strong.java: ## @@ -53,8 +53,6 @@ * {@code p1 AND p2} is strong in [p1, p2] (definitely null if either p1 * is