[GitHub] [calcite] NobiGo commented on a change in pull request #2620: [CALCITE-4907] JdbcJoin does not convert Join with always true/false …

NobiGo commented on a change in pull request #2620: URL: https://github.com/apache/calcite/pull/2620#discussion_r771795344 ## File path: core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java ## @@ -50,23 +50,25 @@ * same time. */ private static final

[GitHub] [calcite] ILuffZhe commented on a change in pull request #2650: [CALCITE-4949] Evaluate if using org.codelibs is appropriate for an Elasticsearch painless dependency

ILuffZhe commented on a change in pull request #2650: URL: https://github.com/apache/calcite/pull/2650#discussion_r771794448 ## File path: elasticsearch/build.gradle.kts ## @@ -37,6 +37,9 @@ dependencies { testImplementation("org.apache.logging.log4j:log4j-api")

[GitHub] [calcite] vlsi commented on a change in pull request #2650: [CALCITE-4949] Evaluate if using org.codelibs is appropriate for an Elasticsearch painless dependency

vlsi commented on a change in pull request #2650: URL: https://github.com/apache/calcite/pull/2650#discussion_r771792181 ## File path: elasticsearch/build.gradle.kts ## @@ -37,6 +37,9 @@ dependencies { testImplementation("org.apache.logging.log4j:log4j-api")

[GitHub] [calcite] amaliujia commented on a change in pull request #2620: [CALCITE-4907] JdbcJoin does not convert Join with always true/false …

amaliujia commented on a change in pull request #2620: URL: https://github.com/apache/calcite/pull/2620#discussion_r771789797 ## File path: core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java ## @@ -50,23 +50,25 @@ * same time. */ private static final

[GitHub] [calcite] amaliujia commented on a change in pull request #2620: [CALCITE-4907] JdbcJoin does not convert Join with always true/false …

amaliujia commented on a change in pull request #2620: URL: https://github.com/apache/calcite/pull/2620#discussion_r771789797 ## File path: core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java ## @@ -50,23 +50,25 @@ * same time. */ private static final

[calcite] 02/02: Finishing up [CALCITE-4937], remove workarounds for [CALCITE-4877]

This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 6208196d1239d77e2f30329e58b9ac13b4b199be Author: Julian Hyde AuthorDate: Fri Dec 17 01:10:21 2021 -0800 Finishing

[calcite] branch master updated (e4cdcee -> 6208196)

This is an automated email from the ASF dual-hosted git repository. jhyde pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from e4cdcee [CALCITE-4948] Revert Elasticsearch to 7.10.2 new 607c45b [CALCITE-4946] Add method RelBuilder.size()

[calcite] 01/02: [CALCITE-4946] Add method RelBuilder.size()

This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 607c45b7a57b66e50f0a4826b5a80df043199f79 Author: Julian Hyde AuthorDate: Thu Jul 22 13:32:48 2021 -0500

[GitHub] [calcite] ILuffZhe opened a new pull request #2650: [CALCITE-4949] Evaluate if using org.codelibs is appropriate for an Elasticsearch painless dependency

ILuffZhe opened a new pull request #2650: URL: https://github.com/apache/calcite/pull/2650 This PR adds some old comments and removes "scripting-painless-spi" dependency, which is included in "lang-painless". -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] ILuffZhe commented on pull request #2599: [CALCITE-4868] Elasticsearch adapter fails if GROUP BY is followed by ORDER BY

ILuffZhe commented on pull request #2599: URL: https://github.com/apache/calcite/pull/2599#issuecomment-997128577 Hi, @NobiGo . I've add some description for this fix, please take a look when you are free. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] jacques-n edited a comment on pull request #2624: [CALCITE-4914] Introduce HandlerBasedRelMetdataQuery as an extension point

jacques-n edited a comment on pull request #2624: URL: https://github.com/apache/calcite/pull/2624#issuecomment-997120386 Due to discussions on jira, abandoning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [calcite] jacques-n closed pull request #2624: [CALCITE-4914] Introduce HandlerBasedRelMetdataQuery as an extension point

jacques-n closed pull request #2624: URL: https://github.com/apache/calcite/pull/2624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] jacques-n commented on pull request #2624: [CALCITE-4914] Introduce HandlerBasedRelMetdataQuery as an extension point

jacques-n commented on pull request #2624: URL: https://github.com/apache/calcite/pull/2624#issuecomment-997120386 Due to discussionsing on jira, abandoning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] francesco-gini88 commented on a change in pull request #2620: [CALCITE-4907] JdbcJoin does not convert Join with always true/false …

francesco-gini88 commented on a change in pull request #2620: URL: https://github.com/apache/calcite/pull/2620#discussion_r771716821 ## File path: core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java ## @@ -50,23 +50,25 @@ * same time. */ private static final

[GitHub] [calcite] jacques-n merged pull request #2649: [CALCITE-4948] Revert Elasticsearch to 7.10.2

jacques-n merged pull request #2649: URL: https://github.com/apache/calcite/pull/2649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch master updated (ce25311 -> e4cdcee)

This is an automated email from the ASF dual-hosted git repository. jacques pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from ce25311 [CALCITE-4737] Add RelOptPlanner visualizer for debugging (Zuozhi Wang, Thomas Rebele) add e4cdcee

[calcite] branch apache created (now e4cdcee)

This is an automated email from the ASF dual-hosted git repository. jacques pushed a change to branch apache in repository https://gitbox.apache.org/repos/asf/calcite.git. at e4cdcee [CALCITE-4948] Revert Elasticsearch to 7.10.2 No new revisions were added by this update.

[GitHub] [calcite] jacques-n commented on a change in pull request #2649: [CALCITE-4948] Revert Elasticsearch to 7.10.2

jacques-n commented on a change in pull request #2649: URL: https://github.com/apache/calcite/pull/2649#discussion_r771680894 ## File path: elasticsearch/build.gradle.kts ## @@ -44,7 +38,6 @@ dependencies { testImplementation("org.apache.logging.log4j:log4j-api")

[GitHub] [calcite] jacques-n commented on a change in pull request #2649: [CALCITE-4948] Revert Elasticsearch to 7.10.2

jacques-n commented on a change in pull request #2649: URL: https://github.com/apache/calcite/pull/2649#discussion_r771680894 ## File path: elasticsearch/build.gradle.kts ## @@ -44,7 +38,6 @@ dependencies { testImplementation("org.apache.logging.log4j:log4j-api")

[GitHub] [calcite] vlsi commented on a change in pull request #2649: [CALCITE-4948] Revert Elasticsearch to 7.10.2

vlsi commented on a change in pull request #2649: URL: https://github.com/apache/calcite/pull/2649#discussion_r771673340 ## File path: elasticsearch/build.gradle.kts ## @@ -44,7 +38,6 @@ dependencies { testImplementation("org.apache.logging.log4j:log4j-api")

[GitHub] [calcite] jacques-n opened a new pull request #2649: [CALCITE-4948] Revert Elasticsearch to 7.10.2

jacques-n opened a new pull request #2649: URL: https://github.com/apache/calcite/pull/2649 Remove extra maven repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [calcite] jacques-n commented on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

jacques-n commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996997756 > I don't think it's worth the pain and fragility of adding a new repository, even for one release, and even with gradle guard rails that limit the impact to just this

[calcite] branch master updated: [CALCITE-4737] Add RelOptPlanner visualizer for debugging (Zuozhi Wang, Thomas Rebele)

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new ce25311 [CALCITE-4737] Add RelOptPlanner

[GitHub] [calcite] rubenada merged pull request #2552: [CALCITE-4737] Add RelOptPlanner visualizer for debugging

rubenada merged pull request #2552: URL: https://github.com/apache/calcite/pull/2552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] julianhyde commented on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

julianhyde commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996981403 Regarding category X. I accept that we can use category X licensed components in testing. However, they are radioactive, and I think they should be labeled as

[GitHub] [calcite] jacques-n commented on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

jacques-n commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996974297 > java.sql.Connection is licensed under GPL + Classpath_Exception You're mixing api with implementation. There are implementations of java.sql.Connection that are

[GitHub] [calcite] vlsi edited a comment on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

vlsi edited a comment on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996928484 > Honest question: where is this explicitly allowed? I do not want to spend hours on licensing stuff, so let me try with an example. `java.sql.Connection` is

[GitHub] [calcite] vlsi edited a comment on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

vlsi edited a comment on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996928484 > Honest question: where is this explicitly allowed? I do not want to spend hours on licensing stuff, so let me try with an example. `java.sql.Connection` is

[GitHub] [calcite] vlsi commented on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

vlsi commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996928484 > Honest question: where is this explicitly allowed? I do not want to spend hours on licensing stuff, so let me try with an example. `java.sql.Connection` is licensed

[GitHub] [calcite] jacques-n commented on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

jacques-n commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996910475 > JMH is GPL with classpath exception, and that is explicitly allowed Honest question: where is this explicitly allowed? It's been a while since I've done ASF license

[GitHub] [calcite] vlsi edited a comment on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

vlsi edited a comment on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996869051 > We already depend on category X licenses for build/test (JMH is an example, I believe) JMH is GPL with classpath exception, and that is explicitly allowed. There's

[GitHub] [calcite] vlsi commented on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

vlsi commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996869051 > We already depend on category X licenses for build/test (JMH is an example, I believe) JMH is GPL with classpath exception, and that is explicitly allowed. There's no X

[GitHub] [calcite] jacques-n commented on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

jacques-n commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996854742 > This change adds new a package repository. Are we OK with that? I did identify the addition and was okay with it given the following: - it was constrained to test

[GitHub] [calcite] rubenada commented on pull request #2552: [CALCITE-4737] Add RelOptPlanner visualizer for debugging

rubenada commented on pull request #2552: URL: https://github.com/apache/calcite/pull/2552#issuecomment-996759395 Thanks @thomasrebele for pushing this forward, and everyone else involved in the review. I think the PR is in a good shape. If nobody objects, I will merge it at the end of

[GitHub] [calcite] thomasrebele commented on a change in pull request #2552: [CALCITE-4737] Add RelOptPlanner visualizer for debugging

thomasrebele commented on a change in pull request #2552: URL: https://github.com/apache/calcite/pull/2552#discussion_r771311468 ## File path: core/src/main/resources/org/apache/calcite/plan/visualizer/viz-template.html ## @@ -0,0 +1,421 @@ + + + + +Calcite Rule Match

[GitHub] [calcite] thomasrebele commented on a change in pull request #2552: [CALCITE-4737] Add RelOptPlanner visualizer for debugging

thomasrebele commented on a change in pull request #2552: URL: https://github.com/apache/calcite/pull/2552#discussion_r771311468 ## File path: core/src/main/resources/org/apache/calcite/plan/visualizer/viz-template.html ## @@ -0,0 +1,421 @@ + + + + +Calcite Rule Match

[GitHub] [calcite] vlsi commented on a change in pull request #2552: [CALCITE-4737] Add RelOptPlanner visualizer for debugging

vlsi commented on a change in pull request #2552: URL: https://github.com/apache/calcite/pull/2552#discussion_r771300952 ## File path: core/src/main/resources/org/apache/calcite/plan/visualizer/viz-template.html ## @@ -0,0 +1,421 @@ + + + + +Calcite Rule Match Visualization +

[GitHub] [calcite] thomasrebele commented on pull request #2552: [CALCITE-4737] Add RelOptPlanner visualizer for debugging

thomasrebele commented on pull request #2552: URL: https://github.com/apache/calcite/pull/2552#issuecomment-996619367 All remarks have been addressed. Additionally I've replaced the remaining references to the "Volcano" visualizer with a more general wording. All commits have been

[GitHub] [calcite] laurentgo edited a comment on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

laurentgo edited a comment on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996554216 What about the licensing change which happens post 7.10.x? As covered in https://www.elastic.co/pricing/faq/licensing, the main elasticsearch jars are now under the

[GitHub] [calcite] ILuffZhe commented on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

ILuffZhe commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996575133 @laurentgo Thanks for the clarification and gradle tips by @vlsi . @julianhyde I can understand your concern, if a new repo is unacceptable, we may consider upgrading ES to

[GitHub] [calcite] laurentgo commented on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

laurentgo commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996554216 What about the licensing change which happens post 7.10.x? As covered in https://www.elastic.co/pricing/faq/licensing,tThe main elasticsearch jars are now under the Elastic

[GitHub] [calcite] vlsi commented on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

vlsi commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996536697 +100500 @julianhyde , thanks for noticing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] julianhyde commented on pull request #2622: [CALCITE-4898] Upgrading Elasticsearch version from 7.0.1 to 7.15.2

julianhyde commented on pull request #2622: URL: https://github.com/apache/calcite/pull/2622#issuecomment-996535757 I really hope we don't use a new repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the