[GitHub] [calcite] snuyanzin commented on a diff in pull request #3105: [CALCITE-5570] Support nested map type for SqlDataTypeSpec

snuyanzin commented on code in PR #3105: URL: https://github.com/apache/calcite/pull/3105#discussion_r1133203768 ## core/src/main/java/org/apache/calcite/sql/SqlMapTypeNameSpec.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [calcite] snuyanzin commented on pull request #3104: [CALCITE-4698] Respect input timestamp datatype, and timestamp precision for SqlTimestampAddFunction

snuyanzin commented on PR #3104: URL: https://github.com/apache/calcite/pull/3104#issuecomment-1465112792 > Can you revert the changes in formatting? yeah, looks like i missed it, thanks done -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3104: [CALCITE-4698] Respect input timestamp datatype, and timestamp precision for SqlTimestampAddFunction

sonarcloud[bot] commented on PR #3104: URL: https://github.com/apache/calcite/pull/3104#issuecomment-1465111993 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3105: [CALCITE-5570] Support nested map type for SqlDataTypeSpec

sonarcloud[bot] commented on PR #3105: URL: https://github.com/apache/calcite/pull/3105#issuecomment-1465109693 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] julianhyde commented on pull request #3104: [CALCITE-4698] Respect input timestamp datatype, and timestamp precision for SqlTimestampAddFunction

julianhyde commented on PR #3104: URL: https://github.com/apache/calcite/pull/3104#issuecomment-1465098540 Can you revert the changes in formatting? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] libenchao commented on a diff in pull request #3092: [CALCITE-5553] noFlatteningForInput handles single field structs

libenchao commented on code in PR #3092: URL: https://github.com/apache/calcite/pull/3092#discussion_r1133181564 ## testkit/src/main/java/org/apache/calcite/test/catalog/MockCatalogReaderSimple.java: ## @@ -291,13 +297,10 @@ protected MockCatalogReaderSimple(RelDataTypeFactory

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3104: [CALCITE-4698] Respect input timestamp datatype, and timestamp precision for SqlTimestampAddFunction

sonarcloud[bot] commented on PR #3104: URL: https://github.com/apache/calcite/pull/3104#issuecomment-1465030107 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] snuyanzin opened a new pull request, #3104: [CALCITE-4698] Respect input timestamp datatype, and timestamp precision for SqlTimestampAddFunction

snuyanzin opened a new pull request, #3104: URL: https://github.com/apache/calcite/pull/3104 The PR makes TimestampAddFunction respecting incoming type e.g. `timestamp with local time zone` and precision. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] julianhyde commented on pull request #3093: SAFE_CAST (enabled for BigQuery)

julianhyde commented on PR #3093: URL: https://github.com/apache/calcite/pull/3093#issuecomment-1465004226 I think `Expressions.lambda(BlockStatement, Iterable)` will work. If there are zero parameters `deduceType` will return `Function0.class`, which is equivalent to `java.lang.Supplier`.

[GitHub] [calcite] julianhyde commented on pull request #3093: SAFE_CAST (enabled for BigQuery)

julianhyde commented on PR #3093: URL: https://github.com/apache/calcite/pull/3093#issuecomment-1465002746 In future, please use the jira case number in the first commit message and in the title of the PR. (Yes, that requires that you log a jira case before starting work on the bug. That

[GitHub] [calcite] julianhyde commented on pull request #3093: SAFE_CAST (enabled for BigQuery)

julianhyde commented on PR #3093: URL: https://github.com/apache/calcite/pull/3093#issuecomment-1465001747 In future, please use the jira case number in the first commit message and in the title of the PR. (Yes, that requires that you log a jira case before starting work on the bug. That

[GitHub] [calcite] julianhyde commented on a diff in pull request #3093: SAFE_CAST (enabled for BigQuery)

julianhyde commented on code in PR #3093: URL: https://github.com/apache/calcite/pull/3093#discussion_r1133140735 ## core/src/main/java/org/apache/calcite/rex/RexExecutable.java: ## @@ -102,6 +102,38 @@ public void reduce(RexBuilder rexBuilder, List constExps,