DonnyZone commented on PR #3203:
URL: https://github.com/apache/calcite/pull/3203#issuecomment-1560421437
> @DonnyZone thanks for review, but i still not hear any contradictions
against this PR can be merged. If it so - is it possible to merge it ?
Sorry for the late reply. I make
sonarcloud[bot] commented on PR #3214:
URL: https://github.com/apache/calcite/pull/3214#issuecomment-1560389123
Kudos, SonarCloud Quality Gate passed! [ {
return Math.acos(b0);
}
+
JiajunBernoulli commented on code in PR #3215:
URL: https://github.com/apache/calcite/pull/3215#discussion_r1203278546
##
babel/src/main/codegen/config.fmpp:
##
@@ -578,9 +578,14 @@ data: {
]
# Custom identifier token.
-# Example: "< IDENTIFIER: (|)+ >".
-
JiajunBernoulli commented on PR #3215:
URL: https://github.com/apache/calcite/pull/3215#issuecomment-1560333859
LGTM
Remember to squash the third commit to the second commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sonarcloud[bot] commented on PR #3054:
URL: https://github.com/apache/calcite/pull/3054#issuecomment-1560284192
Kudos, SonarCloud Quality Gate passed! [
URL: https://github.com/apache/calcite/pull/3168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
asfgit closed pull request #3197: [CALCITE-5699] Posix regex expressions are
partially incorrectly processed
URL: https://github.com/apache/calcite/pull/3197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
jhyde pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
from d08b5cf73f [CALCITE-5691] IN sub-query inside FILTER clause throws
IndexOutOfBoundsException
new f7ad9093f4
This is an automated email from the ASF dual-hosted git repository.
jhyde pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
commit b0420947ddeb2c9e18afe896dbf7adaf49a715a2
Author: Oliver Lee
AuthorDate: Wed Apr 19 22:23:15 2023 +
sonarcloud[bot] commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1560061072
Kudos, SonarCloud Quality Gate passed! [ under one
mihaibudiu commented on code in PR #3145:
URL: https://github.com/apache/calcite/pull/3145#discussion_r1202905661
##
plus/src/test/java/org/apache/calcite/slt/TestCalcite.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
rubenada commented on code in PR #3193:
URL: https://github.com/apache/calcite/pull/3193#discussion_r1202430114
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -6823,6 +6824,65 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule
rule) {
rubenada commented on code in PR #3193:
URL: https://github.com/apache/calcite/pull/3193#discussion_r1202549064
##
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##
@@ -3549,7 +3549,17 @@ protected final void createAggImpl(
// implement HAVING (we
rubenada commented on code in PR #3193:
URL: https://github.com/apache/calcite/pull/3193#discussion_r1202547773
##
core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java:
##
@@ -866,6 +866,8 @@ private static void matchFilter(SubQueryRemoveRule rule,
sonarcloud[bot] commented on PR #3214:
URL: https://github.com/apache/calcite/pull/3214#issuecomment-1559654228
Kudos, SonarCloud Quality Gate passed! [ {
return Math.acos(b0);
}
HanumathRao commented on code in PR #3193:
URL: https://github.com/apache/calcite/pull/3193#discussion_r1202515386
##
core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java:
##
@@ -866,6 +866,8 @@ private static void matchFilter(SubQueryRemoveRule rule,
rubenada commented on code in PR #3214:
URL: https://github.com/apache/calcite/pull/3214#discussion_r1202508174
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1263,6 +1263,32 @@ private static RelDataType
arrayReturnType(SqlOperatorBinding
zoudan commented on code in PR #3214:
URL: https://github.com/apache/calcite/pull/3214#discussion_r1202480641
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -1854,6 +1854,21 @@ public static double acos(double b0) {
return Math.acos(b0);
}
+
rubenada commented on code in PR #3193:
URL: https://github.com/apache/calcite/pull/3193#discussion_r1202473255
##
core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java:
##
@@ -866,6 +866,8 @@ private static void matchFilter(SubQueryRemoveRule rule,
rubenada commented on code in PR #3193:
URL: https://github.com/apache/calcite/pull/3193#discussion_r1202430114
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -6823,6 +6824,65 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule
rule) {
This is an automated email from the ASF dual-hosted git repository.
rubenql pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new d08b5cf73f [CALCITE-5691] IN sub-query inside
rubenada merged PR #3196:
URL: https://github.com/apache/calcite/pull/3196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rubenada commented on code in PR #3193:
URL: https://github.com/apache/calcite/pull/3193#discussion_r1202430114
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -6823,6 +6824,65 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule
rule) {
rubenada commented on code in PR #3193:
URL: https://github.com/apache/calcite/pull/3193#discussion_r1202428792
##
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##
@@ -3549,7 +3549,17 @@ protected final void createAggImpl(
// implement HAVING (we
rubenada commented on code in PR #3214:
URL: https://github.com/apache/calcite/pull/3214#discussion_r1202422359
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -1854,6 +1854,21 @@ public static double acos(double b0) {
return Math.acos(b0);
}
rubenada commented on code in PR #3214:
URL: https://github.com/apache/calcite/pull/3214#discussion_r1202422359
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -1854,6 +1854,21 @@ public static double acos(double b0) {
return Math.acos(b0);
}
HanumathRao commented on code in PR #3193:
URL: https://github.com/apache/calcite/pull/3193#discussion_r1202371411
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -6823,6 +6824,65 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule
rule) {
sonarcloud[bot] commented on PR #3193:
URL: https://github.com/apache/calcite/pull/3193#issuecomment-1559145137
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
dssysolyatin commented on code in PR #3215:
URL: https://github.com/apache/calcite/pull/3215#discussion_r1202088072
##
babel/src/main/codegen/config.fmpp:
##
@@ -578,9 +578,14 @@ data: {
]
# Custom identifier token.
-# Example: "< IDENTIFIER: (|)+ >".
-
zabetak commented on code in PR #3145:
URL: https://github.com/apache/calcite/pull/3145#discussion_r1201939308
##
plus/build.gradle.kts:
##
@@ -25,9 +25,11 @@ dependencies {
implementation("com.teradata.tpcds:tpcds")
implementation("io.prestosql.tpch:tpch")
tanclary commented on PR #3210:
URL: https://github.com/apache/calcite/pull/3210#issuecomment-1558709335
> looks good. a few cosmetic changes required.
>
> did you add tests to big-query.iq? If you can't execute the queries, at
least you could validate them using `!type`.
>
>
36 matches
Mail list logo
